Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/20/2011 07:51 PM, Alex Williamson wrote: We need to address both the description and enforcement of device groups. Groups are formed any time the iommu does not have resolution between a set of devices. On x86, this typically happens when a PCI-to-PCI bridge exists between the set of

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-08-22 Thread Avi Kivity
On 08/20/2011 04:16 PM, Brad Campbell wrote: Author: Alexander Duyck alexander.h.du...@intel.com Date: Thu Jul 1 13:28:27 2010 + x86: Drop CONFIG_MCORE2 check around setting of NET_IP_ALIGN This patch removes the CONFIG_MCORE2 check from around NET_IP_ALIGN. It is based on

Re: KVM induced panic on 2.6.38[2367] 2.6.39

2011-08-22 Thread Eric Dumazet
Le lundi 22 août 2011 à 09:36 +0300, Avi Kivity a écrit : On 08/20/2011 04:16 PM, Brad Campbell wrote: Author: Alexander Duyck alexander.h.du...@intel.com Date: Thu Jul 1 13:28:27 2010 + x86: Drop CONFIG_MCORE2 check around setting of NET_IP_ALIGN This patch removes the

Re: [RFC PATCH v4 2/5] ramlist mutex

2011-08-22 Thread Paolo Bonzini
On 08/19/2011 08:20 AM, Umesh Deshpande wrote: Or, is it okay to convert all the ramblock list traversals in exec.c (under iothread) to mru traversals, and probably it makes sense as the original list was also maintained in the mru order, whereas the sequence of blocks doesn't matter for the

Re: [PATCH v2 00/24] Memory API batch 4: more conversions

2011-08-22 Thread Avi Kivity
On 08/15/2011 05:17 PM, Avi Kivity wrote: This patchset converts a few more devices (and boards) to the memory API. Nothing is really interesting except for the last patch, which brings proper PAM support (and better SMRAM emulation). It should also fix the regressions that were reported in

Re: Host where KSM appears to save a negative amount of memory

2011-08-22 Thread Chris Webb
Hugh Dickins hu...@google.com writes: KSM chooses to show the numbers pages_shared and pages_sharing as exclusive counts: pages_sharing indicates the saving being made. So it would be perfectly reasonable to add those two numbers together to get the total number of pages sharing, the number

Re: [PATCH 1/3] Avoid the use of deprecated gnutls gnutls_*_set_priority functions.

2011-08-22 Thread Stefan Hajnoczi
On Mon, Jul 4, 2011 at 11:00 PM, Raghavendra D Prabhu raghu.prabh...@gmail.com wrote: The gnutls_*_set_priority family of functions has been marked deprecated in 2.12.x. These functions have been superceded by gnutls_priority_set_direct(). Signed-off-by: Raghavendra D Prabhu

Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-08-22 Thread Michael S. Tsirkin
On Mon, Aug 22, 2011 at 09:54:50AM +0930, Rusty Russell wrote: On Fri, 19 Aug 2011 18:23:35 +0300, Michael S. Tsirkin m...@redhat.com wrote: On Sat, Aug 13, 2011 at 11:51:01AM +0300, Sasha Levin wrote: The MAC of a virtio-net device is located at the first field of the device specific

Re: [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-08-22 Thread Avi Kivity
On 08/17/2011 07:19 AM, Liu, Jinsong wrote: From a9670ddff84080c56183e2d678189e100f891174 Mon Sep 17 00:00:00 2001 From: Liu, Jinsongjinsong@intel.com Date: Wed, 17 Aug 2011 11:36:28 +0800 Subject: [PATCH] KVM: emulate lapic tsc deadline timer for hvm kvm doesn't have hvm. This patch

Re: DMI BIOS String

2011-08-22 Thread Daniel P. Berrange
On Mon, Aug 22, 2011 at 03:52:19PM +1200, Derek wrote: Hi Folks, I could not track down any solid info on modifying the DMI BIOS string. For example, in VirtualBox you can use 'vboxmanage setsextradata' to set the BIOS product and vendor string per VM. Any ideas if this is possible with

Re: A non-responsive guest problem

2011-08-22 Thread Paul
Hi, I found the clock of guest OS has been changed. For example, today was Aug 22, but I found the time of guest was Mar 22 from the VNC desktop. The clock source of guest was kvm-clock. Was it related to KVM clock bug? How about it if I changed the clock to tsc? Thanks, Paul On Fri, Aug 19,

Re: [PATCH 1/3] Avoid the use of deprecated gnutls gnutls_*_set_priority functions.

2011-08-22 Thread Gerd Hoffmann
On 08/22/11 10:26, Stefan Hajnoczi wrote: On Mon, Jul 4, 2011 at 11:00 PM, Raghavendra D Prabhu raghu.prabh...@gmail.com wrote: The gnutls_*_set_priority family of functions has been marked deprecated in 2.12.x. These functions have been superceded by gnutls_priority_set_direct().

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-22 Thread Avi Kivity
On 08/11/2011 10:01 PM, Gerhard Wiesinger wrote: On Thu, 11 Aug 2011, Avi Kivity wrote: Or maybe it's just -O2 screwing up debug information. Please change ./configure to set -O1 and redo. Please print *r.memory as well. ./configure --target-list=x86_64-softmmu,i386-softmmu --enable-debug

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Joerg Roedel
On Mon, Aug 22, 2011 at 02:30:26AM -0400, Avi Kivity wrote: On 08/20/2011 07:51 PM, Alex Williamson wrote: We need to address both the description and enforcement of device groups. Groups are formed any time the iommu does not have resolution between a set of devices. On x86, this

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 01:46 PM, Joerg Roedel wrote: $ readlink /sys/devices/pci:00/:00:19.0/iommu_group ../../../path/to/device/which/represents/the/resource/constraint (the pci-to-pci bridge on x86, or whatever node represents partitionable endpoints on power) That does not work. The

Re: DMI BIOS String

2011-08-22 Thread Andrew Cathrow
- Original Message - From: Derek li...@stuntkiwi.com To: kvm@vger.kernel.org Sent: Sunday, August 21, 2011 11:52:19 PM Subject: DMI BIOS String Hi Folks, I could not track down any solid info on modifying the DMI BIOS string. qemu-kvm -help | grep bios -smbios file=binary

Re: A non-responsive guest problem

2011-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 10:37 AM, Paul fly...@gmail.com wrote: Hi, I found the clock of guest OS has been changed. For example, today was Aug 22, but I found the time of guest was Mar 22 from the VNC desktop. The clock source of guest was kvm-clock. Was it related to KVM clock bug? How about

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 06:51:35AM -0400, Avi Kivity wrote: On 08/22/2011 01:46 PM, Joerg Roedel wrote: That does not work. The bridge in question may not even be visible as a PCI device, so you can't link to it. This is the case on a few PCIe cards which only have a PCIx chip and a

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 03:36 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 06:51:35AM -0400, Avi Kivity wrote: On 08/22/2011 01:46 PM, Joerg Roedel wrote: That does not work. The bridge in question may not even be visible as a PCI device, so you can't link to it. This is the case on a few

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 08:42:35AM -0400, Avi Kivity wrote: On 08/22/2011 03:36 PM, Roedel, Joerg wrote: On the AMD IOMMU side this information is stored in the IVRS ACPI table. Not sure about the VT-d side, though. I see. There is no sysfs node representing it? No. It also doesn't exist

[PATCH 1/6] kvm tools: Seperate virtio-pci layer

2011-08-22 Thread Sasha Levin
This patch builds a virtio-pci layer which can be used by virtio devices as a layer to interact with virtio-pci. The purpose of the patch is to seperate the common virtio-pci layer from being replicated in all virtio devices. The new layer provides a callback interface to receive information

[PATCH 2/6] kvm tools: Seperate virtio-pci layer out of virtio-rng

2011-08-22 Thread Sasha Levin
Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/virtio/rng.c | 254 ++-- 1 files changed, 74 insertions(+), 180 deletions(-) diff --git a/tools/kvm/virtio/rng.c b/tools/kvm/virtio/rng.c index 93258f6..5bea56c 100644 ---

[PATCH 3/6] kvm tools: Seperate virtio-pci layer out of virtio-net

2011-08-22 Thread Sasha Levin
Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/virtio/net.c | 344 ++-- 1 files changed, 100 insertions(+), 244 deletions(-) diff --git a/tools/kvm/virtio/net.c b/tools/kvm/virtio/net.c index aa4536b..6247642 100644 ---

[PATCH 4/6] kvm tools: Seperate virtio-pci layer out of virtio-balloon

2011-08-22 Thread Sasha Levin
Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/virtio/balloon.c | 267 1 files changed, 97 insertions(+), 170 deletions(-) diff --git a/tools/kvm/virtio/balloon.c b/tools/kvm/virtio/balloon.c index 7f3fe65..6b93121 100644 ---

[PATCH 5/6] kvm tools: Seperate virtio-pci layer out of virtio-9p

2011-08-22 Thread Sasha Levin
Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/builtin-run.c |8 +- tools/kvm/include/kvm/virtio-9p.h | 16 ++-- tools/kvm/virtio/9p.c | 247 +++-- 3 files changed, 111 insertions(+), 160 deletions(-) diff --git

[PATCH 6/6] kvm tools: Seperate virtio-pci layer out of virtio-blk

2011-08-22 Thread Sasha Levin
Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/virtio/blk.c | 263 1 files changed, 88 insertions(+), 175 deletions(-) diff --git a/tools/kvm/virtio/blk.c b/tools/kvm/virtio/blk.c index 2ccf585..2e047d7 100644 ---

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 03:55 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 08:42:35AM -0400, Avi Kivity wrote: On 08/22/2011 03:36 PM, Roedel, Joerg wrote: On the AMD IOMMU side this information is stored in the IVRS ACPI table. Not sure about the VT-d side, though. I see. There is no

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 09:06:07AM -0400, Avi Kivity wrote: On 08/22/2011 03:55 PM, Roedel, Joerg wrote: Well, I don't think its really meaningless, but we need some way to communicate the information about device groups to userspace. I mean the contents of the group descriptor. There

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 04:15 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 09:06:07AM -0400, Avi Kivity wrote: On 08/22/2011 03:55 PM, Roedel, Joerg wrote: Well, I don't think its really meaningless, but we need some way to communicate the information about device groups to userspace. I

[PATCH 0/3] Emulator fuzz tester

2011-08-22 Thread Avi Kivity
As it is exposed directly to guest code, the x86 emulator is an interesting target for exploiters: a vulnerability may lead to compromise of the entire host. In an attempt to catch vulnerabilities before they make it into production code, this patchset adds a fuzz tester for the emulator.

[PATCH 2/3] KVM: x86 emulator: export main interface

2011-08-22 Thread Avi Kivity
Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/emulate.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 0453c07..aea313b 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -3685,6 +3685,7

[PATCH 3/3] KVM: x86 emulator: fuzz tester

2011-08-22 Thread Avi Kivity
The x86 emulator is directly exposed to guest code; therefore it is part of the directly exposed attack surface. To reduce the risk of vulnerabilities, this patch adds a fuzz test that runs random instructions through the emulator. A vulnerability will usually result in an oops. One way to run

[PATCH 1/3] KVM: x86 emulator: make prototype of -write_std() the same as -write_emulated

2011-08-22 Thread Avi Kivity
This allows implementations to reuse code. Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/include/asm/kvm_emulate.h |3 ++- arch/x86/kvm/x86.c |4 ++-- arch/x86/kvm/x86.h |2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH] pcnet-pci: fix wrong opaque given to I/O accessors

2011-08-22 Thread Avi Kivity
Another casualty of the memory API conversion. Signed-off-by: Avi Kivity a...@redhat.com --- hw/pcnet-pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c index 13d9380..51e1320 100644 --- a/hw/pcnet-pci.c +++ b/hw/pcnet-pci.c @@

Re: [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors

2011-08-22 Thread Gerhard Wiesinger
Hello Avi, Thnx, fixed: OK, maybe some credits :-) Acked-by: Gerhard Wiesinger li...@wiesinger.com This pattern is still present at (maybe some further problems!!!) and I guess it has to be fixed, too: grep -ir 'ops, s, ' . ./hw/rtl8139.c:memory_region_init_io(s-bar_io, rtl8139_io_ops,

Re: [PATCH 02/11] KVM: x86: tag the instructions which are used to write page table

2011-08-22 Thread Marcelo Tosatti
On Tue, Aug 16, 2011 at 02:41:27PM +0800, Xiao Guangrong wrote: The idea is from Avi: | tag instructions that are typically used to modify the page tables, and | drop shadow if any other instruction is used. | The list would include, I'd guess, and, or, bts, btc, mov, xchg, cmpxchg, | and

Re: [PATCH 02/11] KVM: x86: tag the instructions which are used to write page table

2011-08-22 Thread Avi Kivity
On 08/22/2011 05:32 PM, Marcelo Tosatti wrote: On Tue, Aug 16, 2011 at 02:41:27PM +0800, Xiao Guangrong wrote: The idea is from Avi: | tag instructions that are typically used to modify the page tables, and | drop shadow if any other instruction is used. | The list would include, I'd

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 09:17:41AM -0400, Avi Kivity wrote: On 08/22/2011 04:15 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 09:06:07AM -0400, Avi Kivity wrote: On 08/22/2011 03:55 PM, Roedel, Joerg wrote: Well, I don't think its really meaningless, but we need some way to

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-22 Thread Anthony Liguori
On 08/11/2011 02:40 AM, Avi Kivity wrote: The memory API automatically cracks wide memory accesses into narrower (usually byte) accesses when needed. Unfortunately this wasn't implemented for ioports, leading to an lsi53c895a failure. This series implements cracking for ioports as well. Note

[GIT PULL] Memory API fixes

2011-08-22 Thread Avi Kivity
Anthony, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git refs/tags/memory-region-fixes-1 to receive a memory API fix. The fix is not required for any of the already merged patches, but is needed by other patches in my queue. I am sending core patches separately than

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Alex Williamson
On Mon, 2011-08-22 at 15:55 +1000, David Gibson wrote: On Sat, Aug 20, 2011 at 09:51:39AM -0700, Alex Williamson wrote: We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think we agreed to: We need to address both the description and

Re: [Qemu-devel] [GIT PULL] Memory API fixes

2011-08-22 Thread Anthony Liguori
On 08/22/2011 10:42 AM, Avi Kivity wrote: Anthony, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git refs/tags/memory-region-fixes-1 I don't fetch tags from subtrees at the moment. Could you make this a branch instead? Regards, Anthony Liguori to receive a memory

Re: [Qemu-devel] [GIT PULL] Memory API fixes

2011-08-22 Thread Anthony Liguori
On 08/22/2011 10:42 AM, Avi Kivity wrote: Anthony, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git refs/tags/memory-region-fixes-1 Also, please use the tag '[PULL]' as that's what I (and presumably others) currently filter for. Regards, Anthony Liguori to receive a

Re: [Qemu-devel] [PATCH v2 00/24] Memory API batch 4: more conversions

2011-08-22 Thread Anthony Liguori
On 08/15/2011 09:17 AM, Avi Kivity wrote: This patchset converts a few more devices (and boards) to the memory API. Nothing is really interesting except for the last patch, which brings proper PAM support (and better SMRAM emulation). It should also fix the regressions that were reported in

[PULL] Memory API fix

2011-08-22 Thread Avi Kivity
Anthony, please pull from: ssh://master.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/core to receive a memory API fix. The fix is not required for any of the already merged patches, but is needed by other patches in my queue. I am sending core patches separately than the conversions to

[PULL][v2] Memory API fix

2011-08-22 Thread Avi Kivity
[v2: fix git url...] Anthony, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/core to receive a memory API fix. The fix is not required for any of the already merged patches, but is needed by other patches in my queue. I am sending core patches separately than

Merging invasive changes (Was Re: [Qemu-devel] [PULL][v2] Memory API fix)

2011-08-22 Thread Anthony Liguori
Hi, This is a summary from a discussion Avi and I had earlier about merging invasive changes (like the memory API) into the tree in a more fluid fashion. Here's my suggestions: - Invasive changes over a long period of time (multi batches) should be done via git pull. patch (and therefore

Re: [PATCH v2] posix-aio-compat: fix latency issues

2011-08-22 Thread Kevin Wolf
Am 14.08.2011 06:04, schrieb Avi Kivity: In certain circumstances, posix-aio-compat can incur a lot of latency: - threads are created by vcpu threads, so if vcpu affinity is set, aio threads inherit vcpu affinity. This can cause many aio threads to compete for one cpu. - we can

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Joerg Roedel
On Sat, Aug 20, 2011 at 12:51:39PM -0400, Alex Williamson wrote: We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think we agreed to: We need to address both the description and enforcement of device groups. Groups are formed any time the

Re: [PATCH v2] posix-aio-compat: fix latency issues

2011-08-22 Thread Jan Kiszka
On 2011-08-14 06:04, Avi Kivity wrote: In certain circumstances, posix-aio-compat can incur a lot of latency: - threads are created by vcpu threads, so if vcpu affinity is set, aio threads inherit vcpu affinity. This can cause many aio threads to compete for one cpu. - we can create

Re: [Qemu-devel] [PULL][v2] Memory API fix

2011-08-22 Thread Anthony Liguori
On 08/22/2011 11:54 AM, Avi Kivity wrote: [v2: fix git url...] Anthony, please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/core Pulled. Thanks. Regards, Anthony Liguori to receive a memory API fix. The fix is not required for any of the already merged patches,

Re: [PATCH 03/11] KVM: x86: retry non-page-table writing instruction

2011-08-22 Thread Marcelo Tosatti
On Tue, Aug 16, 2011 at 02:42:07PM +0800, Xiao Guangrong wrote: If the emulation is caused by #PF and it is non-page_table writing instruction, it means the VM-EXIT is caused by shadow page protected, we can zap the shadow page and retry this instruction directly The idea is from Avi

Re: DMI BIOS String

2011-08-22 Thread Ryan Harper
* Andrew Cathrow acath...@redhat.com [2011-08-22 06:55]: - Original Message - From: Derek li...@stuntkiwi.com To: kvm@vger.kernel.org Sent: Sunday, August 21, 2011 11:52:19 PM Subject: DMI BIOS String Hi Folks, I could not track down any solid info on modifying the DMI

Re: [PATCH 03/11] KVM: x86: retry non-page-table writing instruction

2011-08-22 Thread Xiao Guangrong
On 08/23/2011 03:59 AM, Marcelo Tosatti wrote: +if (!vcpu-arch.mmu.direct_map !mmu_is_nested(vcpu)) +gpa = kvm_mmu_gva_to_gpa_write(vcpu, cr2, NULL); Why write? Since the fault is caused by page table written, and the 'gpa' can be written after instruction is retied. +

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread aafabbri
On 8/20/11 9:51 AM, Alex Williamson alex.william...@redhat.com wrote: We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think we agreed to: We need to address both the description and enforcement of device groups. Groups are formed any time

Re: [PATCH 03/11] KVM: x86: retry non-page-table writing instruction

2011-08-22 Thread Marcelo Tosatti
On Tue, Aug 23, 2011 at 04:21:05AM +0800, Xiao Guangrong wrote: On 08/23/2011 03:59 AM, Marcelo Tosatti wrote: + if (!vcpu-arch.mmu.direct_map !mmu_is_nested(vcpu)) + gpa = kvm_mmu_gva_to_gpa_write(vcpu, cr2, NULL); Why write? Since the fault is caused by page table

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
On Mon, 2011-08-22 at 13:29 -0700, aafabbri wrote: Each device fd would then support a similar set of ioctls and mapping (mmio/pio/config) interface as current vfio, except for the obvious domain and dma ioctls superseded by the group fd. Another valid model might be that

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
On Mon, 2011-08-22 at 09:30 +0300, Avi Kivity wrote: On 08/20/2011 07:51 PM, Alex Williamson wrote: We need to address both the description and enforcement of device groups. Groups are formed any time the iommu does not have resolution between a set of devices. On x86, this typically

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
On Mon, 2011-08-22 at 09:45 -0600, Alex Williamson wrote: Yes, that's the idea. An open question I have towards the configuration side is whether we might add iommu driver specific options to the groups. For instance on x86 where we typically have B:D.F granularity, should we have an option

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
I am in favour of /dev/vfio/$GROUP. If multiple devices should be assigned to a guest, there can also be an ioctl to bind a group to an address-space of another group (certainly needs some care to not allow that both groups belong to different processes). Btw, a problem we havn't talked

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread aafabbri
On 8/22/11 1:49 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2011-08-22 at 13:29 -0700, aafabbri wrote: Each device fd would then support a similar set of ioctls and mapping (mmio/pio/config) interface as current vfio, except for the obvious domain and dma ioctls

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
I wouldn't use uiommu for that. Any particular reason besides saving a file descriptor? We use it today, and it seems like a cleaner API than what you propose changing it to. Well for one, we are back to square one vs. grouping constraints. .../... If we in singleton-group land were

Re: DMI BIOS String

2011-08-22 Thread Derek
Thanks everyone for the useful replies. I am using libvirt, one thing i'm observing after adding the following sysinfo to the VM.xml file is that in the qemu log file for the VM it is not being passed to the command when booting. os type arch='x86_64' machine='pc-0.12'hvm/type boot

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread aafabbri
On 8/22/11 2:49 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: I wouldn't use uiommu for that. Any particular reason besides saving a file descriptor? We use it today, and it seems like a cleaner API than what you propose changing it to. Well for one, we are back to

Re: [PATCH 07/11] KVM: MMU: fast prefetch spte on invlpg path

2011-08-22 Thread Marcelo Tosatti
On Tue, Aug 16, 2011 at 02:44:42PM +0800, Xiao Guangrong wrote: Fast prefetch spte for the unsync shadow page on invlpg path Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com --- arch/x86/include/asm/kvm_host.h |4 +--- arch/x86/kvm/mmu.c | 38

Re: [PATCH 07/11] KVM: MMU: fast prefetch spte on invlpg path

2011-08-22 Thread Xiao Guangrong
On 08/23/2011 06:28 AM, Marcelo Tosatti wrote: + +if (rmap_can_add(vcpu)) +break; if (!rmap_can_add(vcpu)) break; ? Oh, oops, thanks for you point it out. Will fix it. -- To unsubscribe from this list: send the line unsubscribe

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread David Gibson
On Mon, Aug 22, 2011 at 09:45:48AM -0600, Alex Williamson wrote: On Mon, 2011-08-22 at 15:55 +1000, David Gibson wrote: On Sat, Aug 20, 2011 at 09:51:39AM -0700, Alex Williamson wrote: We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think

Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-08-22 Thread Rusty Russell
On Mon, 22 Aug 2011 11:36:13 +0300, Michael S. Tsirkin m...@redhat.com wrote: Yes. Or maybe 'WHEN' - since if MSI-X is disabled again, it moves back. Let's update the spec to make it clearer? I left the language as is, but added a footnote at the end of the sentence: If MSI-X is enabled for

Re: DMI BIOS String

2011-08-22 Thread Derek
I found 'virsh edit' is the recommended way to make changes to a VM configuration, the XML file is not referenced at boot, it is only saved to with 'virsh dumpxml'. 'virsh edit' will update both areas - hypervisor and XML file. Unfortunately the changes I make for smbios and sysinfo (as below)