Re: [PATCH] pci-assign: Hide ioport regions on lacking sysfs support

2012-05-30 Thread Avi Kivity
On 05/29/2012 08:28 PM, Alex Williamson wrote: > On Tue, 2012-05-29 at 20:13 +0300, Avi Kivity wrote: >> On 05/29/2012 08:04 PM, Jan Kiszka wrote: >> > As suggested by Alex: Instead of failing if the kernel does not allow us >> > to speak to an ioport region, warn the user but, hide the region and

Re: [PATCH] spapr: Add "memop" hypercall

2012-05-30 Thread Alexander Graf
On 28.05.2012, at 12:40, Avi Kivity wrote: > On 05/25/2012 06:12 AM, Benjamin Herrenschmidt wrote: >> >> BTW. This is a qemu patch, and that hypercall isn't KVM related at all, >> ie, it's implemented in qemu and is used with or without KVM, so >> documenting it in the kernel tree makes little s

Re: [PATCH] pci-assign: Hide ioport regions on lacking sysfs support

2012-05-30 Thread Jan Kiszka
On 2012-05-30 10:21, Avi Kivity wrote: > On 05/29/2012 08:28 PM, Alex Williamson wrote: >> On Tue, 2012-05-29 at 20:13 +0300, Avi Kivity wrote: >>> On 05/29/2012 08:04 PM, Jan Kiszka wrote: As suggested by Alex: Instead of failing if the kernel does not allow us to speak to an ioport regi

Re: [PATCH] pci-assign: Hide ioport regions on lacking sysfs support

2012-05-30 Thread Avi Kivity
On 05/30/2012 11:47 AM, Jan Kiszka wrote: > On 2012-05-30 10:21, Avi Kivity wrote: >> On 05/29/2012 08:28 PM, Alex Williamson wrote: >>> On Tue, 2012-05-29 at 20:13 +0300, Avi Kivity wrote: On 05/29/2012 08:04 PM, Jan Kiszka wrote: > As suggested by Alex: Instead of failing if the kernel d

Re: [PATCH] pci-assign: Hide ioport regions on lacking sysfs support

2012-05-30 Thread Jan Kiszka
On 2012-05-30 10:50, Avi Kivity wrote: > On 05/30/2012 11:47 AM, Jan Kiszka wrote: >> On 2012-05-30 10:21, Avi Kivity wrote: >>> On 05/29/2012 08:28 PM, Alex Williamson wrote: On Tue, 2012-05-29 at 20:13 +0300, Avi Kivity wrote: > On 05/29/2012 08:04 PM, Jan Kiszka wrote: >> As suggest

[PATCH 0/5] pci-assign: More small cleanups

2012-05-30 Thread Jan Kiszka
Besides an update for hiding unsupported ioport BARs and tiny code massages, this removes the obsolete iommu property from the pci-assign device. Jan Kiszka (5): pci-assign: Hide ioport regions on lacking sysfs support pci-assign: Drop iommu property pci-assign: Privatize type definitions

[PATCH 1/5] pci-assign: Hide ioport regions on lacking sysfs support

2012-05-30 Thread Jan Kiszka
As suggested by Alex: Instead of failing if the kernel does not allow us to speak to an ioport region, warn the user but, hide the region and continue. Signed-off-by: Jan Kiszka --- hw/device-assignment.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/device-as

[PATCH 3/5] pci-assign: Privatize type definitions

2012-05-30 Thread Jan Kiszka
No need to carry the type definitions in device-assignment.h. Move them over to allow dropping the header once we use an INTx routing notifier instead of exporting assigned_dev_update_irqs. Signed-off-by: Jan Kiszka --- hw/device-assignment.c | 90 +

[PATCH 2/5] pci-assign: Drop iommu property

2012-05-30 Thread Jan Kiszka
Disabling the IOMMU for an assigned device was never more than a highly experimental features and is no longer supported by host kernels >= 3.2. So drop this useless control from property list. Signed-off-by: Jan Kiszka --- hw/device-assignment.c | 22 ++ hw/device-assignme

[PATCH 5/5] pci-assign: Drop kvm_assigned_irq::host_irq initialization

2012-05-30 Thread Jan Kiszka
real_device.irq is never set explicitly, thus remains 0. So we can simply drop this line as assigned_irq_data is zero-initialized anyway. Signed-off-by: Jan Kiszka --- hw/device-assignment.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/device-assignment.c b/hw/devi

[PATCH 4/5] pci-assign: Drop write-only AssignedDevRegion::num

2012-05-30 Thread Jan Kiszka
No one was reading back this field. Signed-off-by: Jan Kiszka --- hw/device-assignment.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index da50069..713e32a 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment

Re: UDP problem with virtio...

2012-05-30 Thread Erik Brakkee
Stefan Hajnoczi wrote: On Sat, May 26, 2012 at 11:23 AM, Erik Brakkee wrote: I have done some more experiments and it does work when using a Centos 6.2 guest. Therefore, it is most likely a compatibility issues between the guest and host virtio implementation. I read somewhere there is some sor

[PULL 0/4] ppc patch queue 2012-05-30

2012-05-30 Thread Alexander Graf
Hi Avi, This is my current patch queue for ppc. Please pull. Changes this time include: - Generalize KVM_GUEST support to overall ePAPR code - Fix reset for Book3S HV - Fix machine check deferral when CONFIG_KVM_GUEST=y - Add support for BookE register DECAR Alex The following changes

[PATCH 1/4] KVM: PPC: Factor out guest epapr initialization

2012-05-30 Thread Alexander Graf
From: Liu Yu-B13201 epapr paravirtualization support is now a Kconfig selectable option Signed-off-by: Liu Yu [stuart.yo...@freescale.com: misc minor fixes, description update] Signed-off-by: Stuart Yoder Signed-off-by: Alexander Graf --- arch/powerpc/include/asm/epapr_hcalls.h |2 + arc

[PATCH 4/4] KVM: PPC: Not optimizing MSR_CE and MSR_ME with paravirt.

2012-05-30 Thread Alexander Graf
From: Bharat Bhushan If there is pending critical or machine check interrupt then guest would like to capture it when guest enable MSR.CE and MSR_ME respectively. Also as mostly MSR_CE and MSR_ME are updated with rfi/rfci/rfmii which anyway traps so removing the the paravirt optimization for MSR.

[PATCH 3/4] KVM: PPC: booke: Added DECAR support

2012-05-30 Thread Alexander Graf
From: Bharat Bhushan Added the decrementer auto-reload support. DECAR is readable on e500v2/e500mc and later cpus. Signed-off-by: Bharat Bhushan Signed-off-by: Alexander Graf --- arch/powerpc/include/asm/kvm_host.h |2 ++ arch/powerpc/kvm/booke.c|5 + arch/powerpc/kvm/

[PATCH 2/4] KVM: PPC: Book3S HV: Make the guest hash table size configurable

2012-05-30 Thread Alexander Graf
From: Paul Mackerras This adds a new ioctl to enable userspace to control the size of the guest hashed page table (HPT) and to clear it out when resetting the guest. The KVM_PPC_ALLOCATE_HTAB ioctl is a VM ioctl and takes as its parameter a pointer to a u32 containing the desired order of the HPT

Re: [PATCH RFC V8 0/17] Paravirtualized ticket spinlocks

2012-05-30 Thread Raghavendra K T
On 05/16/2012 08:49 AM, Raghavendra K T wrote: On 05/14/2012 12:15 AM, Raghavendra K T wrote: On 05/07/2012 08:22 PM, Avi Kivity wrote: I could not come with pv-flush results (also Nikunj had clarified that the result was on NOn PLE I'd like to see those numbers, then. Ingo, please hold on t

RE: [PATCH 1/1] Enable LTR/OBFF before device is used by driver

2012-05-30 Thread Hao, Xudong
> -Original Message- > From: Bjorn Helgaas [mailto:bhelg...@google.com] > Sent: Saturday, May 19, 2012 9:20 AM > To: Xudong Hao > Cc: linux-...@vger.kernel.org; linux-ker...@vger.kernel.org; > kvm@vger.kernel.org; a...@redhat.com; alex.william...@redhat.com; Zhang, > Xiantao; Hao, Xudong >

Re: [PATCH RFC V8 17/17] Documentation/kvm : Add documentation on Hypercalls and features used for PV spinlock

2012-05-30 Thread Jan Kiszka
On 2012-05-02 12:09, Raghavendra K T wrote: > From: Raghavendra K T > > KVM_HC_KICK_CPU hypercall added to wakeup halted vcpu in paravirtual spinlock > enabled guest. > > KVM_FEATURE_PV_UNHALT enables guest to check whether pv spinlock can be > enabled > in guest. > > Thanks Alex for KVM_HC_

[PATCH v2] virtio_blk: unlock vblk->lock during kick

2012-05-30 Thread Stefan Hajnoczi
Holding the vblk->lock across kick causes poor scalability in SMP guests. If one CPU is doing virtqueue kick and another CPU touches the vblk->lock it will have to spin until virtqueue kick completes. This patch reduces system% CPU utilization in SMP guests that are running multithreaded I/O-boun

Re: [PATCH v2] virtio_blk: unlock vblk->lock during kick

2012-05-30 Thread Christian Borntraeger
On 30/05/12 15:19, Stefan Hajnoczi wrote: > Holding the vblk->lock across kick causes poor scalability in SMP > guests. If one CPU is doing virtqueue kick and another CPU touches the > vblk->lock it will have to spin until virtqueue kick completes. > > This patch reduces system% CPU utilization i

Re: [PATCH RFC V8 17/17] Documentation/kvm : Add documentation on Hypercalls and features used for PV spinlock

2012-05-30 Thread Raghavendra K T
On 05/30/2012 05:24 PM, Jan Kiszka wrote: On 2012-05-02 12:09, Raghavendra K T wrote: From: Raghavendra K T KVM_HC_KICK_CPU hypercall added to wakeup halted vcpu in paravirtual spinlock enabled guest. KVM_FEATURE_PV_UNHALT enables guest to check whether pv spinlock can be enabled in guest. T

Re: [PATCH] kvm: optimize ISR lookups

2012-05-30 Thread Avi Kivity
On 05/24/2012 01:00 AM, Thomas Gleixner wrote: > Thought more about that. > > We have a clear distinction between HW accessed data and software > accessed data. > > If I look at TPR then it is special cased already and it does: > >case APIC_TASKPRI: > report_tpr_access(apic,

[PATCH] KVM test: use new functions in cdrom_test

2012-05-30 Thread Lukáš Doktor
Use get_block and other framework functions in cdrom test. Also don't fail the whole test when tray-status reporting is not supported by qemu and other cleanups. Signed-off-by: Lukáš Doktor --- client/tests/kvm/tests/cdrom.py | 118 --- client/virt/subtests.c

Re: [PATCH] KVM test: use new functions in cdrom_test

2012-05-30 Thread Lukáš Doktor
I forgot add pull request link: https://github.com/autotest/autotest/pull/368 Dne 30.5.2012 16:43, Lukáš Doktor napsal(a): Use get_block and other framework functions in cdrom test. Also don't fail the whole test when tray-status reporting is not supported by qemu and other cleanups. Signed-off

Re: [PATCH 1/1] Enable LTR/OBFF before device is used by driver

2012-05-30 Thread Don Dutile
While you are making the other recommended fixes, could you add/create a pci_obff_supported() function, like the pci_ltr_supported() function, and more importantly, add it to the pci_disable_obff() function? The latter does not check that DEVCAP2 is supported, and thus, could be writing to non-exi

Re: [Qemu-devel] [PATCH 1/3] start vm after reseting it

2012-05-30 Thread Luiz Capitulino
On Mon, 21 May 2012 14:49:32 +0800 Wen Congyang wrote: > The guest should run after reseting it, but it does not > run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > Signed-off-by: Wen Congyang > --- > vl.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) >

Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event

2012-05-30 Thread Luiz Capitulino
On Mon, 21 May 2012 14:50:51 +0800 Wen Congyang wrote: > When the guest is panicked, it will write 0x1 to the port 0x505. So if > qemu reads 0x1 from this port, we can do the folloing three things > according to the parameter -onpanic: > 1. emit QEVENT_GUEST_PANICKED only > 2. emit QEVENT_GUEST_P

Re: [PATCH v2 2/3] KVM: Optimize vcpu->requests slow path slightly

2012-05-30 Thread Marcelo Tosatti
On Sun, May 20, 2012 at 04:49:27PM +0300, Avi Kivity wrote: > Instead of using a atomic operation per active request, use just one > to get all requests at once, then check them with local ops. This > probably isn't any faster, since simultaneous requests are rare, but > it does reduce code size.

Re: [PATCH 0/5] pci-assign: More small cleanups

2012-05-30 Thread Alex Williamson
On Wed, 2012-05-30 at 11:05 +0200, Jan Kiszka wrote: > Besides an update for hiding unsupported ioport BARs and tiny code > massages, this removes the obsolete iommu property from the pci-assign > device. > > Jan Kiszka (5): > pci-assign: Hide ioport regions on lacking sysfs support > pci-assi

Re: Biweekly KVM Test report, kernel 51bfd299... qemu a1fce560...

2012-05-30 Thread Marcelo Tosatti
On Tue, May 22, 2012 at 07:40:29AM +, Ren, Yongjie wrote: > > -Original Message- > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Sent: Monday, May 21, 2012 11:30 PM > > To: Ren, Yongjie > > Cc: Avi Kivity; kvm@vger.kernel.org; Liu, RongrongX > > Subject: Re: Biweekly KVM Test report,

Re: Biweekly KVM Test report, kernel 51bfd299... qemu a1fce560...

2012-05-30 Thread Marcelo Tosatti
On Tue, May 22, 2012 at 07:40:29AM +, Ren, Yongjie wrote: > > >> > > > Latest commit 3fd9fedb in qemu-kvm master tree still has this issue. > > > And, the commit ID provided in Launchpad is correct. > > > > Can you please check if the bug exists in upstream qemu.git as well? > > > This bug do

Re: [PATCHv2] kvm: optimize ISR lookups

2012-05-30 Thread Marcelo Tosatti
On Tue, May 22, 2012 at 03:54:56PM +0300, Michael S. Tsirkin wrote: > We perform ISR lookups twice: during interrupt > injection and on EOI. Typical workloads only have > a single bit set there. So we can avoid ISR scans by > 1. counting bits as we set/clear them in ISR > 2. if count is 1, caching

[PATCH] virt: Add Fedora 17 to the list of guests

2012-05-30 Thread Lucas Meneghel Rodrigues
Also, make it the default guest for KVM autotest. Signed-off-by: Lucas Meneghel Rodrigues --- client/tests/kvm/tests.cfg.sample | 18 - client/tests/libvirt/tests.cfg.sample | 21 ++-- client/virt/guest-os.cfg.sample | 28 ++

Re: [Autotest] [PATCH] KVM test: use new functions in cdrom_test

2012-05-30 Thread Lucas Meneghel Rodrigues
By the way, looks good, applied to next. On Wed, May 30, 2012 at 11:51 AM, Lukáš Doktor wrote: > I forgot add pull request link: > https://github.com/autotest/autotest/pull/368 > > Dne 30.5.2012 16:43, Lukáš Doktor napsal(a): >> Use get_block and other framework functions in cdrom test. Also >> d

[GIT PULL] KVM updates for v3.5

2012-05-30 Thread Marcelo Tosatti
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master to receive a build fix for non-kvm archs and a transparent hugepage refcount bugfix on hosts with 4M pages. Avi Kivity (1): KVM: Export asm-generic/kvm_para.h Xiao Guangrong (1): KVM: MMU: fix huge pag

RE: [PATCH 1/1] Enable LTR/OBFF before device is used by driver

2012-05-30 Thread Hao, Xudong
> -Original Message- > From: Don Dutile [mailto:ddut...@redhat.com] > Sent: Thursday, May 31, 2012 12:13 AM > To: Xudong Hao > Cc: bhelg...@google.com; linux-...@vger.kernel.org; > linux-ker...@vger.kernel.org; kvm@vger.kernel.org; a...@redhat.com; > alex.william...@redhat.com; Zhang, Xiant

Re: [PATCH] spapr: Add "memop" hypercall

2012-05-30 Thread Benjamin Herrenschmidt
On Mon, 2012-05-28 at 13:40 +0300, Avi Kivity wrote: > Depends. How do you detect it exists? Are you detecting kvm, or qemu, > or the hypercall itself? > > I'd hate us to find ourselves in a maze of disconnected documentation > with no clear guidelines on when a feature is available and when it

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-30 Thread Rusty Russell
On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" wrote: > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > disable_cb is just an optimization: it > > can not guarantee that there are no callbacks. > > > > I didn't yet figure out whether a callback > > in freeze wil