Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization

2015-05-26 Thread Xiao Guangrong
On 05/26/2015 10:48 PM, Paolo Bonzini wrote: On 26/05/2015 16:45, Edward Cree wrote: This breaks older compilers that can't initialize anon structures. How old ? Even gcc 3.1 says you can use unnamed struct/union fields and 3.2 is the minimum version required to compile the kernel as

[PATCH v3 1/1] KVM: PPC: Book3S: correct width in XER handling

2015-05-26 Thread Sam Bobroff
In 64 bit kernels, the Fixed Point Exception Register (XER) is a 64 bit field (e.g. in kvm_regs and kvm_vcpu_arch) and in most places it is accessed as such. This patch corrects places where it is accessed as a 32 bit field by a 64 bit kernel. In some cases this is via a 32 bit load or store

Re: [RFC PATCH 2/4] KVM: x86: Add KVM exit for IOAPIC EOIs

2015-05-26 Thread Steve Rutherford
On Sun, May 24, 2015 at 07:46:03PM +0300, Avi Kivity wrote: On 05/13/2015 04:47 AM, Steve Rutherford wrote: Adds KVM_EXIT_IOAPIC_EOI which passes the interrupt vector up to userspace. Uses a per VCPU exit bitmap to decide whether or not the IOAPIC needs to be informed (which is identical to

Re: Query regarding a kvm patch.

2015-05-26 Thread Wanpeng Li
Hi Puneet, On Tue, May 26, 2015 at 01:07:02PM -0700, Puneet Zaroo wrote: Wanpeng, I am encountering the issue mentioned in the following patch request https://lkml.org/lkml/2014/7/4/52, while running Ubuntu, linux kernel version : 3.13.0-32. I was wondering if the patch you proposed made it to

Re: [RFC PATCH 2/4] KVM: x86: Add KVM exit for IOAPIC EOIs

2015-05-26 Thread Avi Kivity
On 05/27/2015 05:06 AM, Steve Rutherford wrote: On Sun, May 24, 2015 at 07:46:03PM +0300, Avi Kivity wrote: On 05/13/2015 04:47 AM, Steve Rutherford wrote: Adds KVM_EXIT_IOAPIC_EOI which passes the interrupt vector up to userspace. Uses a per VCPU exit bitmap to decide whether or not the

Re: Announcing qboot, a minimal x86 firmware for QEMU

2015-05-26 Thread Stefan Hajnoczi
On Fri, May 22, 2015 at 10:53:54AM +0800, Yong Wang wrote: On Thu, May 21, 2015 at 03:51:43PM +0200, Paolo Bonzini wrote: On the QEMU side, there is no support yet for persistent memory and the NFIT tables from ACPI 6.0. Once that (and ACPI support) is added, qboot will automatically start

Re: [PATCH v2 1/1] KVM: PPC: Book3S: correct width in XER handling

2015-05-26 Thread Alexander Graf
On 26.05.15 02:27, Sam Bobroff wrote: In 64 bit kernels, the Fixed Point Exception Register (XER) is a 64 bit field (e.g. in kvm_regs and kvm_vcpu_arch) and in most places it is accessed as such. This patch corrects places where it is accessed as a 32 bit field by a 64 bit kernel. In

Re: [PATCH 11/12] KVM: x86: add KVM_MEM_X86_SMRAM memory slot flag

2015-05-26 Thread Avi Kivity
On 05/08/2015 02:20 PM, Paolo Bonzini wrote: This adds an arch-specific memslot flag that hides slots unless the VCPU is in system management mode. Some care is needed in order to limit the overhead of x86_gfn_to_memslot when compared with gfn_to_memslot. Thankfully, we have __gfn_to_memslot

Re: [PATCH] KVM: x86: preserve x2APIC LDR on INIT

2015-05-26 Thread Paolo Bonzini
On 22/05/2015 19:22, Radim Krčmář wrote: Logical x2APIC stops working if we rewrite it with zeros. The best references are SDM April 2015: 10.12.10.1 Logical Destination Mode in x2APIC Mode [...], the LDR are initialized by hardware based on the value of x2APIC ID upon x2APIC state

Re: kvm: odd time values since kvmclock: set scheduler clock stable

2015-05-26 Thread Sasha Levin
On 05/26/2015 09:21 AM, Luiz Capitulino wrote: Sasha, Can you give the suggested patch (hypervisor patch...) a try please? (with a patched guest, obviously). KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR I've tried your v2, it works for me. My test-case

Re: [Qemu-devel] Announcing qboot, a minimal x86 firmware for QEMU

2015-05-26 Thread Christopher Covington
On 05/25/2015 08:53 AM, Paolo Bonzini wrote: On 22/05/2015 13:12, Daniel P. Berrange wrote: In particular I don't see why we need to have a SATA controller and ISA/LPC bridge in every virt machine - root PCI bus only should be possible, as you can provide disks via virtio-blk or virtio-scsi

Re: kvm: odd time values since kvmclock: set scheduler clock stable

2015-05-26 Thread Luiz Capitulino
On Thu, 21 May 2015 21:41:23 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: On Mon, May 18, 2015 at 10:13:03PM -0400, Sasha Levin wrote: On 05/18/2015 10:02 PM, Sasha Levin wrote: On 05/18/2015 08:13 PM, Marcelo Tosatti wrote: GOn Mon, May 18, 2015 at 07:45:41PM -0400, Sasha Levin

Re: KVM call agenda for 2015-05-26

2015-05-26 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please, send any topic that you are interested in covering. As there are no topics on the agenda, call get cancelled. Happy hacking, Juan. Call details: By popular demand, a google calendar public entry with it

Re: [PATCH v6 0/8] vhost: support for cross endian guests

2015-05-26 Thread Greg Kurz
On Tue, 12 May 2015 12:52:55 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, May 12, 2015 at 12:44:26PM +0200, Greg Kurz wrote: On Fri, 24 Apr 2015 15:31:54 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Apr 24, 2015 at 02:24:15PM +0200, Greg Kurz wrote: Only

Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization

2015-05-26 Thread Edward Cree
This breaks older compilers that can't initialize anon structures. How old ? Even gcc 3.1 says you can use unnamed struct/union fields and 3.2 is the minimum version required to compile the kernel as mentioned in the README. We could simply just name the structure, but I doubt this is the

Re: [PATCH v2] KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR

2015-05-26 Thread Luiz Capitulino
On Sat, 23 May 2015 17:06:29 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Initialize kvmclock base, on kvmclock system MSR write time, so that the guest sees kvmclock counting from zero. This matches baremetal behaviour when kvmclock in guest sets sched clock stable. Signed-off-by:

Re: [PATCH] KVM: x86: use correct APIC ID on x2APIC transition

2015-05-26 Thread Paolo Bonzini
On 22/05/2015 18:45, Radim Krčmář wrote: SDM April 2015, 10.12.5 State Changes From xAPIC Mode to x2APIC Mode • Any APIC ID value written to the memory-mapped local APIC ID register is not preserved. Fix it by sourcing vcpu_id (= initial APIC ID) instead of memory-mapped APIC ID.

Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization

2015-05-26 Thread Paolo Bonzini
On 26/05/2015 16:45, Edward Cree wrote: This breaks older compilers that can't initialize anon structures. How old ? Even gcc 3.1 says you can use unnamed struct/union fields and 3.2 is the minimum version required to compile the kernel as mentioned in the README. We could simply

Re: [PATCH v4] i386: Introduce ARAT CPU feature

2015-05-26 Thread Eduardo Habkost
(Fixing subject line) On Tue, May 26, 2015 at 06:35:45AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com ARAT signals that the APIC timer does not stop in power saving states. As our APICs are emulated, it's fine to expose this feature to guests, at least when asking for

Re: [Qemu-devel] [PATCH v4] i386: Introduce ARAT CPU feature

2015-05-26 Thread Eduardo Habkost
On Tue, May 26, 2015 at 02:18:32PM -0300, Eduardo Habkost wrote: (Fixing subject line) On Tue, May 26, 2015 at 06:35:45AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com ARAT signals that the APIC timer does not stop in power saving states. As our APICs are emulated,