Re: vhost-net patches

2009-10-29 Thread Shirley Ma
Hello Michael, I am able to get 63xxMb/s throughput with 10% less cpu utilization when I apply deferring skb patch on top of your most recent vhost patch. The userspace TCP_STREAM BW used to be 3xxxMb/s from upper stream git tree. After applying your recent vhost patch, it goes up to 53xxMb/s.

Re: kvm-kmod broken with user-return-notifiers

2009-10-29 Thread Jan Kiszka
Zachary Amsden wrote: With current upstream changes, VMX operation now relies on have the user-notifiers infrastructure. This makes kvm-kmod use on older kernels untenable. I looked a bit at fixing the underlying problem by simulating the user-return callback when we context switch, but it

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Avi Kivity
On 10/28/2009 10:40 PM, Jan Kiszka wrote: [you can get longer, more detailed traces by using /sys/kernel/debug/tracing/trace instead of dmesg] Oct 28 14:29:56 mchn012c kernel: qemu-sys-72000...1. 676996395us : kvm_msr: msr_read c080 = 0x500 Oct 28 14:29:56 mchn012c kernel:

[PATCH] viostor driver. some steps toward better performance on XP.

2009-10-29 Thread Vadim Rozenfeld
repository: /home/vadimr/shares/kvm-guest-drivers-windows branch: XP commit 844cc39863ca914cf47a1fe2e8cde4ea1079753b Author: Vadim Rozenfeldvroze...@redhat.com Date: Thu Oct 29 09:34:19 2009 +0200 [PATCH] viostor driver. some steps toward better performance on XP. Signed-off-by:

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Jan Kiszka
Avi Kivity wrote: On 10/28/2009 10:40 PM, Jan Kiszka wrote: [you can get longer, more detailed traces by using /sys/kernel/debug/tracing/trace instead of dmesg] Oct 28 14:29:56 mchn012c kernel: qemu-sys-72000...1. 676996395us : kvm_msr: msr_read c080 = 0x500 Oct 28 14:29:56

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Jan Kiszka
Jan Kiszka wrote: Avi Kivity wrote: On 10/28/2009 10:40 PM, Jan Kiszka wrote: [you can get longer, more detailed traces by using /sys/kernel/debug/tracing/trace instead of dmesg] Oct 28 14:29:56 mchn012c kernel: qemu-sys-72000...1. 676996395us : kvm_msr: msr_read c080 = 0x500 Oct

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Avi Kivity
On 10/29/2009 10:03 AM, Jan Kiszka wrote: Avi Kivity wrote: On 10/28/2009 10:40 PM, Jan Kiszka wrote: [you can get longer, more detailed traces by using /sys/kernel/debug/tracing/trace instead of dmesg] Oct 28 14:29:56 mchn012c kernel: qemu-sys-72000...1. 676996395us :

RE: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-29 Thread Dietmar Maurer
Locally, you could simply comment out the double definition for now. Yes, that will work. Many thanks for the fast help! Is native_read_tsc the only conflict with hardy's kernel? yes. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Jan Kiszka
Avi Kivity wrote: On 10/29/2009 10:03 AM, Jan Kiszka wrote: Avi Kivity wrote: On 10/28/2009 10:40 PM, Jan Kiszka wrote: [you can get longer, more detailed traces by using /sys/kernel/debug/tracing/trace instead of dmesg] Oct 28 14:29:56 mchn012c kernel: qemu-sys-7200

Re: [PATCH 0/5]: Fix kdump under KVM

2009-10-29 Thread Chris Lalancette
Avi Kivity wrote: On 10/28/2009 12:13 PM, Chris Lalancette wrote: The kick from i8254 code is pretty bad, as you mention. I forget why it is needed at all - shouldn't kvm_set_irq() end up kicking the correct As I understand it, that's not quite how it works. From what I can see, what

Re: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-29 Thread Jan Kiszka
Dietmar Maurer wrote: Locally, you could simply comment out the double definition for now. Yes, that will work. Many thanks for the fast help! Is native_read_tsc the only conflict with hardy's kernel? yes. Then you may want to have a look at [1]. If you want to test it, apply that

[PATCH] viostor driver. fix PREfast warnings.

2009-10-29 Thread Vadim Rozenfeld
repository: /home/vadimr/shares/kvm-guest-drivers-windows branch: XP commit bf13fc498a576236cff8cbc707a4e5a1e70e22fb Author: Vadim Rozenfeldvroze...@redhat.com Date: Thu Oct 29 10:37:41 2009 +0200 [PATCH] viostor driver. fix PREfast warnings. Signed-off-by: Vadim

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-29 Thread Gerd Hoffmann
On 10/29/09 05:37, Christoph Hellwig wrote: - try to create generic scsi device/request structures that the hba driver can access, and which contain additional private data for scsi-disk/generic. Information in the generic one would include the information about the data

[PATCH] tests: Move typedefs to one place.

2009-10-29 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/kvm/user/test/lib/libcflat.h b/kvm/user/test/lib/libcflat.h index 1f96cb8..1da4013 100644 --- a/kvm/user/test/lib/libcflat.h +++ b/kvm/user/test/lib/libcflat.h @@ -22,6 +22,12 @@ #include stdarg.h +typedef unsigned char u8; +typedef

[PATCH] tests: The order of the fields are in reverse one isr stack.

2009-10-29 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/kvm/user/test/x86/apic.c b/kvm/user/test/x86/apic.c index 4e89c77..b6718ec 100644 --- a/kvm/user/test/x86/apic.c +++ b/kvm/user/test/x86/apic.c @@ -19,11 +19,11 @@ typedef struct { } idt_entry_t; typedef struct { -ulong rflags; -

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
Hi Dustin, On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote: I believe that we have identified a regression in qemu-kvm-0.11.0. Regression versus which previous version of qemu-kvm? The kvm process crashes for older guests with virtio networking, when the guest's incoming network

Re: [patch 1/3] KVM: x86: disallow multiple KVM_CREATE_IRQCHIP

2009-10-29 Thread Michael S. Tsirkin
On Wed, Oct 28, 2009 at 06:42:38PM -0200, Marcelo Tosatti wrote: Otherwise kvm will leak memory on multiple KVM_CREATE_IRQCHIP. Also serialize multiple accesses with kvm-lock. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c

[ kvm-Bugs-2873263 ] Segfaults after resize window in monitor virtual console

2009-10-29 Thread SourceForge.net
Bugs item #2873263, was opened at 2009-10-06 10:30 Message generated for change (Comment added) made by kolobrod You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2873263group_id=180599 Please note that this message will contain a full copy of the comment

Re: block virtio excessive VIRTIO_PCI_ISR reads

2009-10-29 Thread Avi Kivity
On 10/28/2009 05:04 PM, Saul Tamari wrote: yep! What do I have to do to turn on MSI-x? Make this PCI capability in QEMU's virtio?? Pick up a new qemu-kvm from git. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 0/5]: Fix kdump under KVM

2009-10-29 Thread Avi Kivity
On 10/29/2009 10:34 AM, Chris Lalancette wrote: I'm starting to take a look at this. While this may be a generically useful cleanup, it occurs to me that even if we call set_irq from the hrtimer callback, we still have to do the kick_vcpus type thing. Otherwise, we still have the problem

Re: xp guest, blue screen c0000221 on boot

2009-10-29 Thread Gerd Hoffmann
On 10/28/09 16:27, Andrew Olney wrote: Thanks. In pursuing this suggestion I discovered that I also can't make new XP VMs. Setup fails with the disk may be damaged. The image was created with qemu-img create xp_new.img 13G And the setup command is kvm -cdrom xp/xp_pro.iso -hda xp_new.img

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Scott Tsai
Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009: Assuming this is something like the virtio-net in 2.6.26, there was no receivable buffers support so (as Scott points out) it must be that we've read a packet from the tap device which is 1514 bytes (or 1524 bytes with

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 20:00 +0800, Scott Tsai wrote: Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009: Assuming this is something like the virtio-net in 2.6.26, there was no receivable buffers support so (as Scott points out) it must be that we've read a packet from

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Scott Tsai
Hmm - 0x930 doesn't seem right. Is that 930 decimal, 0x3a2 hex? yup. printf format string typo. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: kvm memory leak (Was Re: vhost-net patches)

2009-10-29 Thread Avi Kivity
On 10/28/2009 06:46 PM, Michael S. Tsirkin wrote: On Tue, Oct 27, 2009 at 09:36:18AM -0700, Shirley Ma wrote: Hello Michael, On Tue, 2009-10-27 at 17:27 +0200, Michael S. Tsirkin wrote: Possibly GFP_ATOMIC allocations in vring_add_indirect are failing? Is there a chance you are

Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Michael S. Tsirkin
On Thu, Oct 29, 2009 at 09:16:43AM +, Mark McLoughlin wrote: I agree we shouldn't exit in this scenario virtio in qemu generally seems to handle guest errors by calling exit(2). This probably makes it easier to notice the problems, but is likely not the right thing to do. A simple way to

Re: kvm memory leak (Was Re: vhost-net patches)

2009-10-29 Thread Avi Kivity
On 10/29/2009 02:21 PM, Avi Kivity wrote: On 10/28/2009 06:46 PM, Michael S. Tsirkin wrote: On Tue, Oct 27, 2009 at 09:36:18AM -0700, Shirley Ma wrote: Hello Michael, On Tue, 2009-10-27 at 17:27 +0200, Michael S. Tsirkin wrote: Possibly GFP_ATOMIC allocations in vring_add_indirect are

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-29 Thread Gerd Hoffmann
On 10/29/09 05:37, Christoph Hellwig wrote: So something like - Get next request - Attach iovec/bounc-buffer - handle request (command/write/read) - complete request (callback) Btw, from some previuous attempts to sort out this code here are some thing that I think would be beneficial:

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Anthony Liguori
Mark McLoughlin wrote: tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) being called and get an mtu of 1500 on virbr0 using his birdge.sh script. virtio_net_receive2 was trying to transfer a 1534 byte packet (1524 'size' + 10 'virtio_net_hdr') and the guest only had 1524 bytes of

Re: [patch 1/3] KVM: x86: disallow multiple KVM_CREATE_IRQCHIP

2009-10-29 Thread Marcelo Tosatti
On Thu, Oct 29, 2009 at 11:32:48AM +0200, Michael S. Tsirkin wrote: On Wed, Oct 28, 2009 at 06:42:38PM -0200, Marcelo Tosatti wrote: Otherwise kvm will leak memory on multiple KVM_CREATE_IRQCHIP. Also serialize multiple accesses with kvm-lock. Signed-off-by: Marcelo Tosatti

[PATCH] Add ks files for RHEL5,RHEL4,RHEL3 series products

2009-10-29 Thread Bear
Signed-off-by: Bear by...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample| 54 +++--- client/tests/kvm/unattended/RHEL-3-series.ks | 39 ++ client/tests/kvm/unattended/RHEL-4-series.ks | 40 +++

[PATCH] Add ks files for RHEL5,RHEL4,RHEL3 series products

2009-10-29 Thread Bear
Signed-off-by: Bear by...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample| 54 +++--- client/tests/kvm/unattended/RHEL-3-series.ks | 39 ++ client/tests/kvm/unattended/RHEL-4-series.ks | 40 +++

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) being called and get an mtu of 1500 on virbr0 using his birdge.sh script. virtio_net_receive2 was trying to transfer a 1534 byte packet (1524 'size'

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 14:25 +, Mark McLoughlin wrote: On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) being called and get an mtu of 1500 on virbr0 using his birdge.sh script.

Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Avi Kivity
On 10/29/2009 02:23 PM, Michael S. Tsirkin wrote: On Thu, Oct 29, 2009 at 09:16:43AM +, Mark McLoughlin wrote: I agree we shouldn't exit in this scenario virtio in qemu generally seems to handle guest errors by calling exit(2). This probably makes it easier to notice the

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Anthony Liguori
Mark McLoughlin wrote: On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) being called and get an mtu of 1500 on virbr0 using his birdge.sh script. virtio_net_receive2 was trying to transfer a

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 20:00 +0800, Scott Tsai wrote: Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009: Assuming this is something like the virtio-net in 2.6.26, there was no receivable buffers support so (as Scott points out) it must be that we've read a packet from

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 09:16 +, Mark McLoughlin wrote: Hi Dustin, On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote: I believe that we have identified a regression in qemu-kvm-0.11.0. Regression versus which previous version of qemu-kvm? Okay, sorry for the ambiguity. I

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 09:34 -0500, Dustin Kirkland wrote: In the mean time, Hardy's kernel is in git here: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary I'll save you a few clicks...

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:39 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) being called and get an mtu of 1500 on virbr0 using his

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:46 -0500, Dustin Kirkland wrote: On Thu, 2009-10-29 at 09:34 -0500, Dustin Kirkland wrote: In the mean time, Hardy's kernel is in git here: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary I'll save you a few clicks...

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-29 Thread Christoph Hellwig
On Thu, Oct 29, 2009 at 01:57:40PM +0100, Gerd Hoffmann wrote: Trying to go forward in review+bisect friendly baby steps. Here is what I have now: http://repo.or.cz/w/qemu/kraxel.git?a=shortlog;h=refs/heads/scsi.v1 It is far from being completed, will continue tomorrow. Should give a

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 14:48 +, Mark McLoughlin wrote: Ah, it all makes sense now. I was getting confused between HOST_* and GUEST_* this should have been: features |= (1 VIRTIO_NET_F_MAC); features |= (1 VIRTIO_NET_F_HOST_CSUM); features |= (1

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote: On Thu, 2009-10-29 at 14:48 +, Mark McLoughlin wrote: Ah, it all makes sense now. I was getting confused between HOST_* and GUEST_* this should have been: features |= (1 VIRTIO_NET_F_MAC); features |= (1

Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Michael S. Tsirkin
On Thu, Oct 29, 2009 at 04:38:22PM +0200, Avi Kivity wrote: On 10/29/2009 02:23 PM, Michael S. Tsirkin wrote: On Thu, Oct 29, 2009 at 09:16:43AM +, Mark McLoughlin wrote: I agree we shouldn't exit in this scenario virtio in qemu generally seems to handle guest errors by

CPU troubles with kvm 83 redhat 5.4 windows 2008 server 64 bits

2009-10-29 Thread Arnaud Maillet
Hello world, I used to use Xen on my server but due to a non-patched cygwin problem I installed kvm 83 on my redhat 5.4 with the red hat rpm. I found some troubles with a windows 2008 server 64 bits guest. When I install a software like an anti-virus it takes a lot of time compare to Xen ( that

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 15:01 +, Mark McLoughlin wrote: Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct Brilliant! Works like a champ. I'll send a patch in a subsequent email. Would you add a signed-off-by (or whatever), Mark? :-Dustin signature.asc Description: This is a

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-29 Thread Anthony Liguori
Christoph Hellwig wrote: On Thu, Oct 29, 2009 at 01:57:40PM +0100, Gerd Hoffmann wrote: Trying to go forward in review+bisect friendly baby steps. Here is what I have now: http://repo.or.cz/w/qemu/kraxel.git?a=shortlog;h=refs/heads/scsi.v1 It is far from being completed, will continue

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-29 Thread Christoph Hellwig
On Thu, Oct 29, 2009 at 10:14:19AM -0500, Anthony Liguori wrote: Which patches are those? http://repo.or.cz/w/qemu/kraxel.git?a=commitdiff;h=1ee5ee08e4427c3db7e1322d30cc0e58e5ca48b9 and http://repo.or.cz/w/qemu/kraxel.git?a=commitdiff;h=a6e6178185786c582141f993272e00521d3f125a -- To

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 10:13 -0500, Dustin Kirkland wrote: On Thu, 2009-10-29 at 15:01 +, Mark McLoughlin wrote: Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct Brilliant! Works like a champ. I'll send a patch in a subsequent email. Would you add a signed-off-by (or

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-29 Thread Anthony Liguori
Christoph Hellwig wrote: On Thu, Oct 29, 2009 at 10:14:19AM -0500, Anthony Liguori wrote: Which patches are those? http://repo.or.cz/w/qemu/kraxel.git?a=commitdiff;h=1ee5ee08e4427c3db7e1322d30cc0e58e5ca48b9 and

[PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...]

2009-10-29 Thread Dustin Kirkland
whitelist host virtio networking features This patch is a followup to 8eca6b1bc770982595db2f7207c65051572436cb, fixing crashes when guests with 2.6.25 virtio drivers have saturated virtio network connections. https://bugs.edge.launchpad.net/ubuntu/+source/qemu-kvm/+bug/458521 That patch should

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Jan Kiszka
Jan Kiszka wrote: Avi Kivity wrote: On 10/29/2009 10:03 AM, Jan Kiszka wrote: Avi Kivity wrote: On 10/28/2009 10:40 PM, Jan Kiszka wrote: [you can get longer, more detailed traces by using /sys/kernel/debug/tracing/trace instead of dmesg] Oct 28 14:29:56 mchn012c kernel:

[patch 0/3] ioctl fixes v3

2009-10-29 Thread Marcelo Tosatti
Addressing comments. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 1/3] KVM: x86: disallow multiple KVM_CREATE_IRQCHIP

2009-10-29 Thread Marcelo Tosatti
Otherwise kvm will leak memory on multiple KVM_CREATE_IRQCHIP. Also serialize multiple accesses with kvm-lock. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++

[patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without allocated in-kernel lapic

2009-10-29 Thread Marcelo Tosatti
Otherwise kvm might attempt to dereference a NULL pointer. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x86.c @@ -1893,6 +1893,9 @@ long

[patch 3/3] KVM: only clear irq_source_id if irqchip is present

2009-10-29 Thread Marcelo Tosatti
Otherwise kvm might attempt to dereference a NULL pointer. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/virt/kvm/irq_comm.c === --- kvm.orig/virt/kvm/irq_comm.c +++ kvm/virt/kvm/irq_comm.c @@ -243,6 +243,10 @@ void

Re: block virtio excessive VIRTIO_PCI_ISR reads

2009-10-29 Thread Saul Tamari
Hi, The current qemu-kvm from the git indeed adds the MSI-x capability to the virtio block device. With MSI-x enabled on the virtio block device, there aren't VIRTIO_PCI_ISR reads on the unused device. Thanks, Saul On Thu, Oct 29, 2009 at 12:10 PM, Avi Kivity a...@redhat.com wrote: [snip]

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Avi Kivity
On 10/29/2009 05:45 PM, Jan Kiszka wrote: static int vmx_vcpu_setup(struct vcpu_vmx *vmx) { ... for (i = 0; i NR_VMX_MSR; ++i) { u32 index = vmx_msr_index[i]; u32 data_low, data_high; u64 data; int j = vmx-nmsrs;

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Jan Kiszka
Avi Kivity wrote: On 10/28/2009 10:40 PM, Jan Kiszka wrote: [you can get longer, more detailed traces by using /sys/kernel/debug/tracing/trace instead of dmesg] Oct 28 14:29:56 mchn012c kernel: qemu-sys-72000...1. 676996395us : kvm_msr: msr_read c080 = 0x500 Oct 28 14:29:56

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Jan Kiszka
Jan Kiszka wrote: Avi Kivity wrote: On 10/28/2009 10:40 PM, Jan Kiszka wrote: [you can get longer, more detailed traces by using /sys/kernel/debug/tracing/trace instead of dmesg] Oct 28 14:29:56 mchn012c kernel: qemu-sys-72000...1. 676996395us : kvm_msr: msr_read c080 = 0x500 Oct

Impossible to compile kvm-88 on Redhat 5.4

2009-10-29 Thread Arnaud Maillet
Hello, when I try to compile kvm-88 on Redhat 5.4 I have this error : CC [M] /root/kvm-88/kvm/kernel/x86/svm.o In file included from ligne de commande:1: /root/kvm-88/kvm/kernel/x86/external-module-compat.h:12: erreur: redefinition of typedef â include/asm/types.h:50: erreur: previous

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Avi Kivity
On 10/29/2009 06:07 PM, Jan Kiszka wrote: Question: When a VCPU migrates, what syncs the shared_msrs per-cpu vars before or after that, or why is this no problem? The guest's msrs remain on the old cpu (until a new guest is switched in or we return to userspace). The guest msrs are

Daily git testing failure due to build problem

2009-10-29 Thread Lucas Meneghel Rodrigues
Hi folks, today's git test failed due to a build problem. Attached goes the build log. The relevant snippet I could identify is: 10/29 04:57:13 DEBUG| utils:0085| CC [M] /usr/local/autotest/tests/kvm/src/kvm_kmod/x86/i8259.o 10/29 04:57:13 ERROR| utils:0085|

Re: BUG with Win7 and user-return-notifier

2009-10-29 Thread Avi Kivity
On 10/29/2009 06:14 PM, Jan Kiszka wrote: OK, EFER is a globally shared msr. But there still needs to be a consensus on the slot id used for guest_msrs and shared_msrs_global.msrs, right? move_msr_up works per-vcpu and is obviously decoupled... move_msr_up() moves a shared_msr_entry,

[PATCH] KVM: VMX: Use proper slot index for kvm_set_shared_msr

2009-10-29 Thread Jan Kiszka
We were missing one indirection here to translate from vmx-local to x86 slot indices, and this caused subtle host crashes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- IOW: Win7 boots for me again. arch/x86/kvm/vmx.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

[PATCH] KVM: VMX: Build move_msr_up also for x86-32

2009-10-29 Thread Jan Kiszka
It's used now on 32-bit as well. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/vmx.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 6b818c0..3ebb022 100644 --- a/arch/x86/kvm/vmx.c +++

Re: Daily git testing failure due to build problem

2009-10-29 Thread Jan Kiszka
Lucas Meneghel Rodrigues wrote: Hi folks, today's git test failed due to a build problem. Attached goes the build log. The relevant snippet I could identify is: 10/29 04:57:13 DEBUG| utils:0085| CC [M] /usr/local/autotest/tests/kvm/src/kvm_kmod/x86/i8259.o 10/29 04:57:13 ERROR|

Re: Impossible to compile kvm-88 on Redhat 5.4

2009-10-29 Thread Jan Kiszka
Arnaud Maillet wrote: Hello, when I try to compile kvm-88 on Redhat 5.4 I have this error : CC [M] /root/kvm-88/kvm/kernel/x86/svm.o In file included from ligne de commande:1: /root/kvm-88/kvm/kernel/x86/external-module-compat.h:12: erreur: redefinition of typedef â

Re: [PATCH] KVM: VMX: Use proper slot index for kvm_set_shared_msr

2009-10-29 Thread Avi Kivity
On 10/29/2009 06:53 PM, Jan Kiszka wrote: We were missing one indirection here to translate from vmx-local to x86 slot indices, and this caused subtle host crashes. Ahh, good catch. How did it work? Signed-off-by: Jan Kiszkajan.kis...@siemens.com --- IOW: Win7 boots for me again.

Re: [PATCH] KVM: VMX: Build move_msr_up also for x86-32

2009-10-29 Thread Avi Kivity
On 10/29/2009 07:02 PM, Jan Kiszka wrote: It's used now on 32-bit as well. Already have that queued, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH 5/5] Nested VMX patch 5 implements vmlaunch and vmresume

2009-10-29 Thread Gleb Natapov
On Wed, Oct 28, 2009 at 06:23:42PM +0200, Orit Wasserman wrote: Gleb Natapov g...@redhat.com wrote on 25/10/2009 11:44:31: From: Gleb Natapov g...@redhat.com To: Orit Wasserman/Haifa/i...@ibmil Cc: Abel Gordon/Haifa/i...@ibmil, aligu...@us.ibm.com, Ben-Ami Yassour1/

Re: Daily git testing failure due to build problem

2009-10-29 Thread Lucas Meneghel Rodrigues
On Thu, 2009-10-29 at 18:07 +0100, Jan Kiszka wrote: Lucas Meneghel Rodrigues wrote: Hi folks, today's git test failed due to a build problem. Attached goes the build log. The relevant snippet I could identify is: 10/29 04:57:13 DEBUG| utils:0085| CC [M]

Re: kvm problems on new hardware

2009-10-29 Thread Danny ter Haar
Update: I compiled/installed 2.6.32-rc5-git3 on this machine I manually start kvm: vhost1:~# kvm -m 512 -cdrom /vz/template/iso/debian-503-amd64-netinst.iso The bootscreen comes up, i hit enter to install and i get these messages (copied from dmesg) handle_exception: unexpected, vectoring

Re: Daily git testing failure due to build problem

2009-10-29 Thread Lucas Meneghel Rodrigues
Ok, indeed using the -next branch solves the problems. When the next merge is done, we won't have this problem anymore. Thanks for your attention! On Thu, Oct 29, 2009 at 4:36 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: On Thu, 2009-10-29 at 18:07 +0100, Jan Kiszka wrote: Lucas

Re: kvm problems on new hardware

2009-10-29 Thread Ryan Harper
* Danny ter Haar d...@dth.net [2009-10-29 13:38]: Update: I compiled/installed 2.6.32-rc5-git3 on this machine I manually start kvm: vhost1:~# kvm -m 512 -cdrom /vz/template/iso/debian-503-amd64-netinst.iso The bootscreen comes up, i hit enter to install and i get these messages

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Scott Tsai
Hi, Dustin, What's the easiest way to see the patches to qemu that Canonical carries for the different Ubuntu releases? (I think http://patches.ubuntu.com/ only diffs against Debian for the last stable Ubuntu release?) Also, is there a way for an outside developer to get email notifications when

Re: kvm problems on new hardware

2009-10-29 Thread Danny ter Haar
On Thu, 2009-10-29 at 17:07 -0500, Ryan Harper wrote: I've seen that in a couple places. I don't think we have root cause, but in at least one situation (running win2k3 with 4G of ram) the work around was to use: -cpu pentium3 Thanks for your response. When i add this option it segv's