[COMMIT master] Fix parameters of prctl

2009-12-20 Thread Avi Kivity
From: Huang Ying ying.hu...@intel.com Because kenrel prctl implementation checks whether arg4 and arg5 are 0 for PR_MCE_KILL, qmeu-kvm should invoke prctl syscall as that. Reported-by: Max Asbock masb...@linux.vnet.ibm.com Signed-off-by: Huang Ying ying.hu...@intel.com Signed-off-by: Avi Kivity

[COMMIT master] compatfd: trivial compile fix

2009-12-20 Thread Avi Kivity
From: Chris Wright chr...@sous-sol.org Fix build when !CONFIG_EVENTFD CCcompatfd.o compatfd.c: In function ‘qemu_eventfd’: compatfd.c:137: error: ‘ret’ undeclared (first use in this function) compatfd.c:137: error: (Each undeclared identifier is reported only once compatfd.c:137: error: for

[COMMIT master] Fix infinite recursion in pci

2009-12-20 Thread Avi Kivity
From: Michael S. Tsirkin m...@redhat.com Make config reads for assigned devices work like they used to: both pci_default_read_config and pci_default_cap_read_config call to pci_read_config, which does the actual work. This fixes infinite recursion introduced by a recent merge. Signed-off-by:

[COMMIT master] Remove pcbios subdirectory

2009-12-20 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/roms/pcbios b/roms/pcbios deleted file mode 16 index 7293e43..000 --- a/roms/pcbios +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 7293e433169142a3cd58c7761f3c518e8b41750f -- To unsubscribe from this

[COMMIT master] KVM: Fix possible circular locking in kvm_vm_ioctl_assign_device()

2009-12-20 Thread Avi Kivity
From: Sheng Yang sh...@linux.intel.com One possible order is: KVM_CREATE_IRQCHIP ioctl(took kvm-lock) - kvm_iobus_register_dev() - down_write(kvm-slots_lock). The other one is in kvm_vm_ioctl_assign_device(), which take kvm-slots_lock first, then kvm-lock. Update the comment of lock order as

[COMMIT master] KVM: VMX: When using ept, allow the guest to own cr4.pge

2009-12-20 Thread Avi Kivity
From: Avi Kivity a...@redhat.com We make no use of cr4.pge if ept is enabled, but the guest does (to flush global mappings, as with vmap()), so give the guest ownership of this bit. Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index

[COMMIT master] KVM: VMX: Fold ept_update_paging_mode_cr4() into its caller

2009-12-20 Thread Avi Kivity
From: Avi Kivity a...@redhat.com ept_update_paging_mode_cr4() accesses vcpu-arch.cr4 directly, which usually needs to be accessed via kvm_read_cr4(). In this case, we can't, since cr4 is in the process of being updated. Instead of adding inane comments, fold the function into its caller

[COMMIT master] Merge branch 'master' of ssh://master.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6

2009-12-20 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Conflicts: Documentation/kvm/api.txt arch/x86/include/asm/kvm.h arch/x86/include/asm/vmx.h arch/x86/kvm/svm.c arch/x86/kvm/vmx.c arch/x86/kvm/x86.c include/linux/kvm.h virt/kvm/assigned-dev.c

[COMMIT master] x86: Raise vsyscall priority on hotplug notifier chain

2009-12-20 Thread Avi Kivity
From: Sheng Yang sh...@linux.intel.com KVM need vsyscall_init() to initialize MSR_TSC_AUX before it read the value. Per Avi's suggestion, this patch raised vsyscall priority on hotplug notifier chain, to 30. CC: Ingo Molnar mi...@elte.hu CC: linux-ker...@vger.kernel.org Signed-off-by: Sheng Yang

[COMMIT master] KVM: Add cpuid_update() callback to kvm_x86_ops

2009-12-20 Thread Avi Kivity
From: Sheng Yang sh...@linux.intel.com Sometime, we need to adjust some state in order to reflect guest CPUID setting, e.g. if we don't expose rdtscp to guest, we won't want to enable it on hardware. cpuid_update() is introduced for this purpose. Also export kvm_find_cpuid_entry() for later use.

[COMMIT master] KVM: Extended shared_msr_global to per CPU

2009-12-20 Thread Avi Kivity
From: Sheng Yang sh...@linux.intel.com shared_msr_global saved host value of relevant MSRs, but it have an assumption that all MSRs it tracked shared the value across the different CPUs. It's not true with some MSRs, e.g. MSR_TSC_AUX. Extend it to per CPU to provide the support of MSR_TSC_AUX,

[COMMIT master] KVM: SVM: Adjust tsc_offset only if tsc_unstable

2009-12-20 Thread Avi Kivity
From: Joerg Roedel joerg.roe...@amd.com The tsc_offset adjustment in svm_vcpu_load is executed unconditionally even if Linux considers the host tsc as stable. This causes a Linux guest detecting an unstable tsc in any case. This patch removes the tsc_offset adjustment if the host tsc is stable.

[COMMIT master] KVM: Add include guards for coalesced_mmio.h

2009-12-20 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/virt/kvm/coalesced_mmio.h b/virt/kvm/coalesced_mmio.h index 4b49f27..e703346 100644 --- a/virt/kvm/coalesced_mmio.h +++ b/virt/kvm/coalesced_mmio.h @@ -1,3 +1,6 @@ +#ifndef __KVM_COALESCED_MMIO_H__ +#define

[COMMIT master] KVM: Simplify coalesced mmio initialization

2009-12-20 Thread Avi Kivity
From: Avi Kivity a...@redhat.com - add destructor function - move related allocation into constructor - add stubs for !CONFIG_KVM_MMIO Signed-off-by: Avi Kivity a...@redhat.com diff --git a/virt/kvm/coalesced_mmio.c b/virt/kvm/coalesced_mmio.c index 04d69cd..d68e6c6 100644 ---

[COMMIT master] KVM: Remove ifdefs from mmu notifier initialization

2009-12-20 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index ab5f977..b46b901 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -341,6 +341,20 @@ static const struct mmu_notifier_ops kvm_mmu_notifier_ops = {

Re: [PATCH 0/6 v2] Add support for RDTSCP in VMX

2009-12-20 Thread Avi Kivity
On 12/18/2009 10:48 AM, Sheng Yang wrote: Applied all, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] KVM-PPC: Fix mtsrin in book3s_64 mmu

2009-12-20 Thread Avi Kivity
On 12/19/2009 07:07 PM, Alexander Graf wrote: We were shifting the Ks/Kp/N bits one bit too far on mtsrin. It took me some time to figure that out, so I also put in some debugging and a comment explaining the conversion. This fixes current OpenBIOS boot on PPC64 KVM. Applied and queued

Re: [PATCH] KVM: SVM: Adjust tsc_offset only if tsc_unstable

2009-12-20 Thread Avi Kivity
On 12/15/2009 05:38 AM, Zachary Amsden wrote: On 12/14/2009 01:22 AM, Joerg Roedel wrote: The tsc_offset adjustment in svm_vcpu_load is executed unconditionally even if Linux considers the host tsc as stable. This causes a Linux guest detecting an unstable tsc in any case. This patch removes

Re: [PATCH 1/2] virtio: Add detach unused buffer from vring

2009-12-20 Thread Michael S. Tsirkin
On Thu, Dec 17, 2009 at 11:43:50PM -0800, Shirley Ma wrote: There's currently no way for a virtio driver to ask for unused buffers, so it has to keep a list itself to reclaim them at shutdown. This is redundant, since virtio_ring stores that information. So add a new hook to do this:

Re: [PATCH] fix vhost ioctl handling for 32-bit

2009-12-20 Thread Michael S. Tsirkin
On Thu, Dec 17, 2009 at 12:44:55PM -0700, David Stevens wrote: VHOST_GET_FEATURES returns high-order garbage on 32-bit machines. This patch fixes it to use 64 bits throughout. +-DLS [in-line for viewing, attached to avoid whitespace mangling]

Re: [PATCH] kvm: get rid of unused label warning

2009-12-20 Thread Avi Kivity
On 12/18/2009 10:41 AM, Heiko Carstens wrote: From: Heiko Carstensheiko.carst...@de.ibm.com arch/s390/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_create_vm': arch/s390/kvm/../../../virt/kvm/kvm_main.c:409: warning: label 'out_err' defined but not used Thanks, applied and queued

qemu-kvm 0.12.0-rc2: can't install windows 2008 std

2009-12-20 Thread Thomas Mueller
after having problems with qemu-kvm 0.11.0 and windows 2008 under i/o I thought trying the new 0.12.0-rc2 and make some tests. so i've compiled qemu-kvm 0.12.0-rc2 and tried to install Windows 2008 Standard 64bit. it shows the Windows is loading files screen and then BSOD with 0x007E . I

Re: [PATCH 1/7] Nested VMX patch 1 implements vmon and vmoff

2009-12-20 Thread Gleb Natapov
On Thu, Dec 10, 2009 at 08:38:23PM +0200, or...@il.ibm.com wrote: From: Orit Wasserman or...@il.ibm.com --- arch/x86/kvm/svm.c |3 - arch/x86/kvm/vmx.c | 265 +++- arch/x86/kvm/x86.c | 11 ++- arch/x86/kvm/x86.h |2 + 4 files

Re: [PATCH 1/7] Nested VMX patch 1 implements vmon and vmoff

2009-12-20 Thread Avi Kivity
On 12/20/2009 04:20 PM, Gleb Natapov wrote: + + if (create_l1_state(vcpu)) { + printk(KERN_ERR %s create_l1_state failed\n, __func__); + kvm_queue_exception(vcpu, UD_VECTOR); Should we send UD exception if there is internal error? May be doing

Re: qemu-kvm 0.12.0-rc2: can't install windows 2008 std

2009-12-20 Thread Avi Kivity
On 12/20/2009 04:11 PM, Thomas Mueller wrote: after having problems with qemu-kvm 0.11.0 and windows 2008 under i/o I thought trying the new 0.12.0-rc2 and make some tests. so i've compiled qemu-kvm 0.12.0-rc2 and tried to install Windows 2008 Standard 64bit. it shows the Windows is loading

Re: [PATCH 1/7] Nested VMX patch 1 implements vmon and vmoff

2009-12-20 Thread Gleb Natapov
On Sun, Dec 20, 2009 at 04:23:38PM +0200, Avi Kivity wrote: On 12/20/2009 04:20 PM, Gleb Natapov wrote: + + if (create_l1_state(vcpu)) { + printk(KERN_ERR %s create_l1_state failed\n, __func__); + kvm_queue_exception(vcpu, UD_VECTOR); Should we send UD exception if

Re: qemu-kvm 0.12.0-rc2: can't install windows 2008 std

2009-12-20 Thread Gleb Natapov
On Sun, Dec 20, 2009 at 04:25:35PM +0200, Avi Kivity wrote: On 12/20/2009 04:11 PM, Thomas Mueller wrote: after having problems with qemu-kvm 0.11.0 and windows 2008 under i/o I thought trying the new 0.12.0-rc2 and make some tests. so i've compiled qemu-kvm 0.12.0-rc2 and tried to install

Re: qemu-kvm 0.12.0-rc2: can't install windows 2008 std

2009-12-20 Thread Thomas Mueller
Am Sun, 20 Dec 2009 16:25:35 +0200 schrieb Avi Kivity: On 12/20/2009 04:11 PM, Thomas Mueller wrote: after having problems with qemu-kvm 0.11.0 and windows 2008 under i/o I thought trying the new 0.12.0-rc2 and make some tests. so i've compiled qemu-kvm 0.12.0-rc2 and tried to install

Re: qemu-kvm 0.12.0-rc2: can't install windows 2008 std

2009-12-20 Thread Thomas Mueller
Am Sun, 20 Dec 2009 16:37:59 +0200 schrieb Gleb Natapov: On Sun, Dec 20, 2009 at 04:25:35PM +0200, Avi Kivity wrote: On 12/20/2009 04:11 PM, Thomas Mueller wrote: after having problems with qemu-kvm 0.11.0 and windows 2008 under i/o I thought trying the new 0.12.0-rc2 and make some tests.

Re: qemu-kvm 0.12.0-rc2: can't install windows 2008 std

2009-12-20 Thread Avi Kivity
On 12/20/2009 04:11 PM, Thomas Mueller wrote: after having problems with qemu-kvm 0.11.0 and windows 2008 under i/o I thought trying the new 0.12.0-rc2 and make some tests. so i've compiled qemu-kvm 0.12.0-rc2 and tried to install Windows 2008 Standard 64bit. it shows the Windows is loading

Re: [ANNOUNCE] qemu-kvm-0.12.0-rc2 released

2009-12-20 Thread Avi Kivity
On 12/15/2009 05:21 PM, Dustin Kirkland wrote: - fetch the submodules and include them in the tarball ... I think this option would help keep us all on the same page. But I could live with pointers to the submodules, since packaging a new release only happens a couple of times per

[ANNOUNCE] qemu-kvm-0.12.1

2009-12-20 Thread Avi Kivity
qemu-kvm-0.12.1 is now available. This release is is based on the upstream qemu 0.12.1, plus kvm-specific enhancements. Please see the original qemu 0.12.1 release announcement for details. This release can be used with the kvm kernel modules provided by your distribution kernel, or by the

0.12.0-rc2: undefined reference to `kvm_save_mpstate

2009-12-20 Thread Nikola Ciprich
Hi, while trying to build qemu-kvm 0.12.0-rc2, I'm getting following error: monitor.o: In function `mon_get_cpu': /usr/src/redhat/BUILD/qemu-kvm-0.12.0-rc2/monitor.c:675: undefined reference to `kvm_save_mpstate' monitor.o: In function `do_info_cpus':

Re: [ANNOUNCE] qemu-kvm-0.12.1

2009-12-20 Thread Nikola Ciprich
Hi Avi, I just tried compiling and the same problem I've reported minutes ago: gcc -I/usr/src/redhat/BUILD/qemu-kvm-0.12.1/slirp -m64 -Wold-style-definition -I. -I/usr/src/redhat/BUILD/qemu-kvm-0.12.1 -U_FORTIFY_SOURCE -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes

Re: [PATCH 1/7] Nested VMX patch 1 implements vmon and vmoff

2009-12-20 Thread Andi Kleen
Gleb Natapov g...@redhat.com writes: +int nested = 1; +EXPORT_SYMBOL_GPL(nested); Unless this is a lot better tested and audited wouldn't it make more sense to default it to off? I don't think it's a big burden to let users set a special knob for this, but it would be a big problem if there

[SOLVED] Re: qemu-kvm 0.12.0-rc2: can't install windows 2008 std

2009-12-20 Thread Thomas Mueller
Am Sun, 20 Dec 2009 17:52:11 +0200 schrieb Avi Kivity: On 12/20/2009 04:11 PM, Thomas Mueller wrote: after having problems with qemu-kvm 0.11.0 and windows 2008 under i/o I thought trying the new 0.12.0-rc2 and make some tests. so i've compiled qemu-kvm 0.12.0-rc2 and tried to install

Re: [PATCH 1/7] Nested VMX patch 1 implements vmon and vmoff

2009-12-20 Thread Avi Kivity
On 12/20/2009 07:08 PM, Andi Kleen wrote: Gleb Natapovg...@redhat.com writes: +int nested = 1; +EXPORT_SYMBOL_GPL(nested); Unless this is a lot better tested and audited wouldn't it make more sense to default it to off? This is actually a move of an existing svm-only

[PATCH] Change PowerPC KVM maintainer

2009-12-20 Thread Alexander Graf
Progress on KVM for Embedded PowerPC has stalled, but for Book3S there's quite a lot of work to do and going on. So in agreement with Hollis and Avi, we should switch maintainers for PowerPC. I'll still demand Acks from Hollis for code that changes BookE parts when I can't say for sure if the

[PATCH] Show KVM timing option only on embedded

2009-12-20 Thread Alexander Graf
Embedded PowerPC KVM has an exit timing implementation to track and evaluate how much time was spent in which exit path. For Book3S, we don't implement it. So let's not expose it as a config option either. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/Kconfig |2 +- 1

Re: [PATCH] Change PowerPC KVM maintainer

2009-12-20 Thread Hollis Blanchard
On Sun, Dec 20, 2009 at 1:24 PM, Alexander Graf ag...@suse.de wrote: Progress on KVM for Embedded PowerPC has stalled, but for Book3S there's quite a lot of work to do and going on. So in agreement with Hollis and Avi, we should switch maintainers for PowerPC. I'll still demand Acks from

Re: [ANNOUNCE] qemu-kvm-0.12.1

2009-12-20 Thread Alexander Graf
On 20.12.2009, at 17:57, Nikola Ciprich wrote: Hi Avi, I just tried compiling and the same problem I've reported minutes ago: gcc -I/usr/src/redhat/BUILD/qemu-kvm-0.12.1/slirp -m64 -Wold-style-definition -I. -I/usr/src/redhat/BUILD/qemu-kvm-0.12.1 -U_FORTIFY_SOURCE -D_GNU_SOURCE

Qemu vs Qemu-KVM

2009-12-20 Thread Mikolaj Kucharski
Hi all, Qemu and Qemu-KVM, are they the same projects with the same developers behind of those projects or not? Are those projects trying to converge at some stage, or is this just RedHat's convention to create from kvm's sources package named qemu? I have an issue with qemu from Fedora 12, and

Re: [PATCH] KVM: SVM: Adjust tsc_offset only if tsc_unstable

2009-12-20 Thread Zachary Amsden
On 12/19/2009 11:59 PM, Avi Kivity wrote: On 12/15/2009 05:38 AM, Zachary Amsden wrote: On 12/14/2009 01:22 AM, Joerg Roedel wrote: The tsc_offset adjustment in svm_vcpu_load is executed unconditionally even if Linux considers the host tsc as stable. This causes a Linux guest detecting an

qemu-kvm 0.12.1 undefined reference to `kvm_save_mpstate'

2009-12-20 Thread Mikolaj Kucharski
Hi, Just downloaded kvm 0.12.1 and used Fedora's qemu.spec file after removing all patches from the spec file to create packages. Compilation failed at compiling i386-softmmu with errors: rm -f libqemu.a ar rcs libqemu.a exec.o cpu-exec.o translate-all.o translate.o tcg/tcg.o

undefined reference to `kvm_save_mpstate' since qemu-kvm-0.12.0-rc2 with all *-softmmu targets except i386 and x86_64

2009-12-20 Thread Thomas Sachau
Hi, when i try to build qemu-kvm, qemu-kvm-0.11.1 did compile fine. But with qemu-kvm-0.12.0-rc2 and qemu-kvm-0.12.1, i get the following output for all $ARCH-softmmu targets except i386-softmmu and x86_64-softmmu targets (example output for arm-softmmu): CCarm-softmmu/disas.o CC

Re: [ANNOUNCE] qemu-kvm-0.12.0-rc2 released

2009-12-20 Thread Dustin Kirkland
On Sun, Dec 20, 2009 at 10:25 AM, Avi Kivity a...@redhat.com wrote: On 12/15/2009 05:21 PM, Dustin Kirkland wrote: - fetch the submodules and include them in the tarball ... I think this option would help keep us all on the same page.  But I could live with pointers to the submodules,

Re: [ANNOUNCE] qemu-kvm-0.12.1

2009-12-20 Thread Nikola Ciprich
Hi Alex, well, I see, I based my rpm on latest fedora spec and it builds all targets by default. But using just plain configure doesn't help either, as others already reported in the meantime, seems like (default) x86_64-softmmu target is broken as well: gcc

[PATCH] Add definitions for current cpu models..

2009-12-20 Thread john cooper
This adds definitions for contemporary processors which may be selected via -cpu model, as an alternative to the existing use of -cpu qemu64 augmented with a series of feature flags. The primary motivation was determination of a least common denominator within a given processor class for

Re: Qemu vs Qemu-KVM

2009-12-20 Thread Gleb Natapov
On Sun, Dec 20, 2009 at 11:10:24PM +, Mikolaj Kucharski wrote: Hi all, Qemu and Qemu-KVM, are they the same projects with the same developers behind of those projects or not? Are those projects trying to converge at some stage, or is this just RedHat's convention to create from kvm's

[PATCH] Show KVM timing option only on embedded

2009-12-20 Thread Alexander Graf
Embedded PowerPC KVM has an exit timing implementation to track and evaluate how much time was spent in which exit path. For Book3S, we don't implement it. So let's not expose it as a config option either. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/Kconfig |2 +- 1

Re: [PATCH] Change PowerPC KVM maintainer

2009-12-20 Thread Hollis Blanchard
On Sun, Dec 20, 2009 at 1:24 PM, Alexander Graf ag...@suse.de wrote: Progress on KVM for Embedded PowerPC has stalled, but for Book3S there's quite a lot of work to do and going on. So in agreement with Hollis and Avi, we should switch maintainers for PowerPC. I'll still demand Acks from