Re: [Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 06/15/2010 10:41 AM, Christoph Hellwig wrote: On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote: KVM/qemu patches - patch rate is high, documentation is low, review is low - patches need to include better descriptions and

Re: [PATCH 0/4] Really lazy fpu

2010-06-16 Thread Avi Kivity
On 06/13/2010 06:03 PM, Avi Kivity wrote: Currently fpu management is only lazy in one direction. When we switch into a task, we may avoid loading the fpu state in the hope that the task will never use it. If we guess right we save an fpu load/save cycle; if not, a Device not Available

Re: [PATCH 0/4] Really lazy fpu

2010-06-16 Thread H. Peter Anvin
On 06/16/2010 12:24 AM, Avi Kivity wrote: Ingo, Peter, any feedback on this? Conceptually, this makes sense to me. However, I have a concern what happens when a task is scheduled on another CPU, while its FPU state is still in registers in the original CPU. That would seem to require

Re: [PATCH 3/24] Implement VMXON and VMXOFF

2010-06-16 Thread Nadav Har'El
On Tue, Jun 15, 2010, Marcelo Tosatti wrote about Re: [PATCH 3/24] Implement VMXON and VMXOFF: + if (!(vcpu-arch.cr4 X86_CR4_VMXE) || + !(vcpu-arch.cr0 X86_CR0_PE) || kvm_read_cr0_bits, kvm_read_cr4_bits. Thanks. I'll change that. -- Nadav Har'El|

Re: [PATCH 3/6] KVM: MMU: introduce gfn_to_page_atomic() and gfn_to_pfn_atomic()

2010-06-16 Thread Andi Kleen
On Tue, Jun 15, 2010 at 02:22:06PM +0300, Avi Kivity wrote: Too much duplication. How about putting the tail end of the function in a common helper (with an inatomic flag)? btw, is_hwpoison_address() is racy. While it looks up the address, some other task can unmap the page tables under

Re: [PATCH 0/4] Really lazy fpu

2010-06-16 Thread Avi Kivity
On 06/16/2010 10:32 AM, H. Peter Anvin wrote: On 06/16/2010 12:24 AM, Avi Kivity wrote: Ingo, Peter, any feedback on this? Conceptually, this makes sense to me. However, I have a concern what happens when a task is scheduled on another CPU, while its FPU state is still in registers

Re: [PATCH 03/17] Unify vendor TSC logic

2010-06-16 Thread Jason Wang
Zachary Amsden wrote: Move the TSC control logic from the vendor backends into x86.c by adding adjust_tsc_offset to x86 ops. Now all TSC decisions can be done in one place. Also, rename some variable in the VCPU structure to more accurately reflect their actual content. VMX backend would

Re: [PATCH 04/17] Fix deep C-state TSC desynchronization

2010-06-16 Thread Jason Wang
Zachary Amsden wrote: When CPUs with unstable TSCs enter deep C-state, TSC may stop running. This causes us to require resynchronization. Since we can't tell when this may potentially happen, we assume the worst by forcing re-compensation for it at every point the VCPU task is descheduled.

Re: [PATCH 05/17] Keep SMP VMs more in sync on unstable TSC

2010-06-16 Thread Jason Wang
Zachary Amsden wrote: SMP VMs on machines with unstable TSC have their TSC offset adjusted by the local offset delta from last measurement. This does not take into account how long it has been since the measurement, leading to drift. Minimize the drift by accounting for any time difference

Re: [PATCH 11/17] Fix a possible backwards warp of kvmclock

2010-06-16 Thread Jason Wang
Zachary Amsden wrote: Kernel time, which advances in discrete steps may progress much slower than TSC. As a result, when kvmclock is adjusted to a new base, the apparent time to the guest, which runs at a much higher, nsec scaled rate based on the current TSC, may have already been observed

Re: [PATCH 3/6] KVM: MMU: introduce gfn_to_page_atomic() and gfn_to_pfn_atomic()

2010-06-16 Thread Avi Kivity
On 06/16/2010 10:59 AM, Andi Kleen wrote: On Tue, Jun 15, 2010 at 02:22:06PM +0300, Avi Kivity wrote: Too much duplication. How about putting the tail end of the function in a common helper (with an inatomic flag)? btw, is_hwpoison_address() is racy. While it looks up the address, some

Re: [PATCH 12/17] Add helper function get_kernel_ns

2010-06-16 Thread Jason Wang
Zachary Amsden wrote: On 06/14/2010 10:41 PM, Avi Kivity wrote: On 06/15/2010 10:34 AM, Zachary Amsden wrote: Add a helper function for the multiple places this is used. Note that it must not be called in preemptible context, as that would mean the kernel could enter software

Re: [PATCH RFC] KVM: busy-spin detector

2010-06-16 Thread Avi Kivity
On 06/11/2010 05:25 AM, Marcelo Tosatti wrote: The following patch implements a simple busy-spin detector. It considers a vcpu as busy-spinning if there are two consecutive exits due to external interrupt on the same RIP, and sleeps for 100us in that case. It is very likely that if the vcpu is

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-16 Thread Markus Armbruster
Alex Williamson alex.william...@redhat.com writes: On Tue, 2010-06-15 at 12:28 +0100, Paul Brook wrote: Alex proposed to disambiguate by adding identified properties of the immediate parent bus and device to the path component. For PCI, these are dev.fn. Likewise for any other bus

Re: [Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string

2010-06-16 Thread Markus Armbruster
Alex Williamson alex.william...@redhat.com writes: On Tue, 2010-06-15 at 10:53 +0200, Markus Armbruster wrote: Alex Williamson alex.william...@redhat.com writes: On Mon, 2010-06-14 at 09:02 +0200, Gerd Hoffmann wrote: Hi, My premise with this attempt is that we walk the hierarchy

Re: [Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string

2010-06-16 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Alex Williamson alex.william...@redhat.com writes: On Tue, 2010-06-15 at 10:53 +0200, Markus Armbruster wrote: Alex Williamson alex.william...@redhat.com writes: [...] virtio-serial doesn't seem to make a DeviceState per port, so I think it can

Re: [RFC][PATCH 0/9] rework KVM mmu_shrink() code

2010-06-16 Thread Avi Kivity
On 06/15/2010 04:55 PM, Dave Hansen wrote: This is a big RFC for the moment. These need a bunch more runtime testing. -- We've seen contention in the mmu_shrink() function. First of all, that's surprising. I tried to configure the shrinker so it would stay away from kvm unless memory was

Re: [PATCH 0/4] Really lazy fpu

2010-06-16 Thread Ingo Molnar
(Cc:-ed various performance/optimization folks) * Avi Kivity a...@redhat.com wrote: On 06/16/2010 10:32 AM, H. Peter Anvin wrote: On 06/16/2010 12:24 AM, Avi Kivity wrote: Ingo, Peter, any feedback on this? Conceptually, this makes sense to me. However, I have a concern what happens

Re: [RFC][PATCH 1/9] abstract kvm x86 mmu-n_free_mmu_pages

2010-06-16 Thread Avi Kivity
On 06/15/2010 04:55 PM, Dave Hansen wrote: First of all, I think free is a poor name for this value. In this context, it means, the number of mmu pages which this kvm instance should be able to allocate. To me, free implies much more that the objects are there and ready for use. I think

Re: [RFC][PATCH 4/9] create aggregate kvm_total_used_mmu_pages value

2010-06-16 Thread Avi Kivity
On 06/15/2010 04:55 PM, Dave Hansen wrote: Note: this is the real meat of the patch set. It can be applied up to this point, and everything will probably be improved, at least a bit. Of slab shrinkers, the VM code says: * Note that 'shrink' will be passed nr_to_scan == 0 when the VM is *

Re: [PATCH 3/6] KVM: MMU: introduce gfn_to_page_atomic() and gfn_to_pfn_atomic()

2010-06-16 Thread Andi Kleen
The page is fine, the page tables are not. Another task can munmap() the thing while is_hwpoison_address() is running. Ok that boils down to me not seeing that source. If it accesses the page tables yes then it's racy. But whoever looked up the page tables in the first place should have

Re: [RFC][PATCH 8/9] reduce kvm_lock hold times in mmu_skrink()

2010-06-16 Thread Avi Kivity
On 06/15/2010 04:55 PM, Dave Hansen wrote: mmu_shrink() is effectively single-threaded since the global kvm_lock is held over the entire function. I beleive its only use here is for synchronization of the vm_list. Instead of using the kvm_lock to ensure consistency of the list, we instead

Re: [Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Yoshiaki Tamura
2010/6/16 Markus Armbruster arm...@redhat.com: Anthony Liguori anth...@codemonkey.ws writes: On 06/15/2010 10:41 AM, Christoph Hellwig wrote: On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote: KVM/qemu patches - patch rate is high, documentation is low, review is low - patches

Re: KVM call minutes for June 15

2010-06-16 Thread Paolo Bonzini
On 06/15/2010 05:18 PM, Chris Wright wrote: - size for each section would be useful (breaks protocol) - while size is possibly useful, breaks protocol It is not necessary to break the protocol. If you're okay with only having the size information when the migration data has been saved to

Re: [PATCH 0/4] Really lazy fpu

2010-06-16 Thread Nick Piggin
On Wed, Jun 16, 2010 at 10:39:41AM +0200, Ingo Molnar wrote: (Cc:-ed various performance/optimization folks) * Avi Kivity a...@redhat.com wrote: On 06/16/2010 10:32 AM, H. Peter Anvin wrote: On 06/16/2010 12:24 AM, Avi Kivity wrote: Ingo, Peter, any feedback on this? Conceptually,

Re: [PATCH 0/4] Really lazy fpu

2010-06-16 Thread Samuel Thibault
Ingo Molnar, le Wed 16 Jun 2010 10:39:41 +0200, a écrit : in the long run most processes will be using the FPU due to SIMM instructions. I believe glibc already uses SIMM instructions for e.g. memcpy and friends, i.e. basically all applications... Samuel -- To unsubscribe from this list:

[ kvm-Bugs-2933400 ] virtio-blk io errors / data corruption on raw drives 1 TB

2010-06-16 Thread SourceForge.net
Bugs item #2933400, was opened at 2010-01-16 15:35 Message generated for change (Comment added) made by masc82 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2933400group_id=180599 Please note that this message will contain a full copy of the comment

Re: [RFC][PATCH 9/9] make kvm mmu shrinker more aggressive

2010-06-16 Thread Avi Kivity
On 06/15/2010 04:55 PM, Dave Hansen wrote: In a previous patch, we removed the 'nr_to_scan' tracking. It was not being used to track the number of objects scanned, so we stopped using it entirely. Here, we strart using it again. The theory here is simple; if we already have the refcount and

Re: [PATCH 0/4] Really lazy fpu

2010-06-16 Thread Avi Kivity
On 06/16/2010 11:39 AM, Ingo Molnar wrote: (Cc:-ed various performance/optimization folks) * Avi Kivitya...@redhat.com wrote: On 06/16/2010 10:32 AM, H. Peter Anvin wrote: On 06/16/2010 12:24 AM, Avi Kivity wrote: Ingo, Peter, any feedback on this?

Re: [PATCH 0/4] Really lazy fpu

2010-06-16 Thread Avi Kivity
On 06/16/2010 12:10 PM, Nick Piggin wrote: This cannot be stated categorically without precise measurements of known-good, known-bad, average FPU usage and average CPU usage scenarios. All these workloads have different characteristics. I can imagine bad effects across all sorts of workloads:

Re: [PATCH 3/6] KVM: MMU: introduce gfn_to_page_atomic() and gfn_to_pfn_atomic()

2010-06-16 Thread Avi Kivity
On 06/16/2010 11:49 AM, Andi Kleen wrote: The page is fine, the page tables are not. Another task can munmap() the thing while is_hwpoison_address() is running. Ok that boils down to me not seeing that source. If it accesses the page tables yes then it's racy. But whoever looked up the

Re: [PATCH 0/4] Really lazy fpu

2010-06-16 Thread Avi Kivity
On 06/16/2010 12:01 PM, Samuel Thibault wrote: Ingo Molnar, le Wed 16 Jun 2010 10:39:41 +0200, a écrit : in the long run most processes will be using the FPU due to SIMM instructions. I believe glibc already uses SIMM instructions for e.g. memcpy and friends, i.e. basically all

RFC qdev path semantics (was: [Qemu-devel] [RFC PATCH 0/5] Introduce canonical device hierarchy string)

2010-06-16 Thread Markus Armbruster
A number of changes to qdev paths have been proposed in various threads. It's becoming harder to keep track of them, so let me sum them up in one place. Please correct me if I misrepresent your ideas. I'm going to describe the current state of things, and the proposed changes (marked with ###).

kvm_queue_exception - what is going wrong here?

2010-06-16 Thread Sebastian Hetze
Hi *, we recently have encountered kvm_queue_exception events in dmesg. What is causing these exceptions? It appears that the guest is at least suffering performance loss. Is the qemu-system-x86 hang event linked to the exception? Is there anything we can do to prevent these exceptions to happen?

Re: Loss of network connectivity with high load

2010-06-16 Thread Daniel Bareiro
On Wednesday, 16 June 2010 00:36:43 -0300, Daniel Bareiro wrote: There have been a few bugs similar to this reported that should be pretty easy to find. Basically, I'd say try 0.12.4, it should have a few fixes in this area over 0.12.3. I was testing with qemu-kvm 0.12.4 but I'm having

Re: kvm_queue_exception - what is going wrong here?

2010-06-16 Thread Gleb Natapov
On Wed, Jun 16, 2010 at 12:05:10PM +0200, Sebastian Hetze wrote: Hi *, we recently have encountered kvm_queue_exception events in dmesg. What is causing these exceptions? It appears that the guest is at least suffering performance loss. Is the qemu-system-x86 hang event linked to the

Re: RFC qdev path semantics (was: [Qemu-devel] [RFC PATCH 0/5] Introduce canonical device hierarchy string)

2010-06-16 Thread Paul Brook
* Else, use TYPE.NUM, where TYPE is derived from the bus type, and NUM is the bus number, as above. ### Paul proposes to either drop TYPE.NUM (and require drivers to provide bus names), or make NUM count separately for each bus type. I revised this proposal: Drop the .NUM part, and

Re: [PATCH 3/6] KVM: MMU: introduce gfn_to_page_atomic() and gfn_to_pfn_atomic()

2010-06-16 Thread huang ying
On Tue, Jun 15, 2010 at 7:22 PM, Avi Kivity a...@redhat.com wrote: btw, is_hwpoison_address() is racy.  While it looks up the address, some other task can unmap the page tables under us. Andi/Huang? One way of fixing it is get_user_pages_ptes_fast(), which also returns the pte, also

Re: [PATCH 3/6] KVM: MMU: introduce gfn_to_page_atomic() and gfn_to_pfn_atomic()

2010-06-16 Thread Avi Kivity
On 06/16/2010 01:51 PM, huang ying wrote: On Tue, Jun 15, 2010 at 7:22 PM, Avi Kivitya...@redhat.com wrote: btw, is_hwpoison_address() is racy. While it looks up the address, some other task can unmap the page tables under us. Andi/Huang? One way of fixing it is

Re: [PATCH 3/24] Implement VMXON and VMXOFF

2010-06-16 Thread Nadav Har'El
Hi, On Mon, Jun 14, 2010, Avi Kivity wrote about Re: [PATCH 3/24] Implement VMXON and VMXOFF: On 06/13/2010 03:24 PM, Nadav Har'El wrote: This patch allows a guest to use the VMXON and VMXOFF instructions, and emulates them accordingly. Basically this amounts to checking some prerequisites,

Re: [PATCH 3/24] Implement VMXON and VMXOFF

2010-06-16 Thread Avi Kivity
On 06/16/2010 02:14 PM, Nadav Har'El wrote: Hi, On Mon, Jun 14, 2010, Avi Kivity wrote about Re: [PATCH 3/24] Implement VMXON and VMXOFF: On 06/13/2010 03:24 PM, Nadav Har'El wrote: This patch allows a guest to use the VMXON and VMXOFF instructions, and emulates them accordingly.

Re: RFC qdev path semantics

2010-06-16 Thread Jan Kiszka
Markus Armbruster wrote: A number of changes to qdev paths have been proposed in various threads. It's becoming harder to keep track of them, so let me sum them up in one place. Please correct me if I misrepresent your ideas. I'm going to describe the current state of things, and the

Re: [RFC/T/D][PATCH 2/2] Linux/Guest cooperative unmapped page cache control

2010-06-16 Thread Avi Kivity
On 06/15/2010 05:47 PM, Dave Hansen wrote: That's a bug that needs to be fixed. Eventually the host will come under pressure and will balloon the guest. If that kills the guest, the ballooning is not effective as a host memory management technique. I'm not convinced that it's just a

Re: RFC qdev path semantics

2010-06-16 Thread Paul Brook
Markus Armbruster wrote: A number of changes to qdev paths have been proposed in various threads. It's becoming harder to keep track of them, so let me sum them up in one place. Please correct me if I misrepresent your ideas. I'm going to describe the current state of things, and the

Re: [Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Arnd Bergmann
On Wednesday 16 June 2010, Markus Armbruster wrote: Can't hurt reviewer motivation. Could it be automated? Find replies, extract tags. If you want your acks to be picked up, you better make sure your References header works, and your tags are formatted correctly. I think pwclient

Re: RFC qdev path semantics

2010-06-16 Thread Jan Kiszka
Paul Brook wrote: Markus Armbruster wrote: A number of changes to qdev paths have been proposed in various threads. It's becoming harder to keep track of them, so let me sum them up in one place. Please correct me if I misrepresent your ideas. I'm going to describe the current state of

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Kevin Wolf
Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and PERSISTENT_RESERVE_IN case in scsi_req_length() to extra the incoming buffer length

Re: [Qemu-devel] Re: RFC qdev path semantics

2010-06-16 Thread Paul Brook
I think this would be better served by adding explicit aliases/IDs for those use-cases. i.e. define the global ID pci.0 to be an alias for /i440FX-pcihost/pci Makes sense. We could attach this ID to the BusState (corresponding to DeviceState:id) and manually set it during machine

Re: [PATCH 5/24] Introduce vmcs12: a VMCS structure for L1

2010-06-16 Thread Nadav Har'El
On Mon, Jun 14, 2010, Avi Kivity wrote about Re: [PATCH 5/24] Introduce vmcs12: a VMCS structure for L1: +struct __attribute__ ((__packed__)) vmcs12 { +/* According to the Intel spec, a VMCS region must start with the + * following two fields. Then follow implementation-specific data.

[PATCH 0/3] Monitor support QEMU trace framework

2010-06-16 Thread Prerna Saxena
This is v3 of a set of patches to enable trace visualization control via the QEMU monitor. It is based on trace infrastructure posted by Stefan : ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html ) This patchset adds monitor commands : - info trace : to view current

[PATCH 1/3] Export hash function

2010-06-16 Thread Prerna Saxena
Rename tdb_hash() to qemu_hash(). Move definition from qdict.c to a new file qemu-misc.c for use by tracing infrastructure. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- Makefile.objs |2 +- qdict.c | 24 qemu-common.h |3 +++ qemu-misc.c

[PATCH 2/3] Monitor command 'info trace'

2010-06-16 Thread Prerna Saxena
Monitor command 'info trace' to display contents of trace buffer Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- configure |3 +++ monitor.c | 12 qemu-monitor.hx |4 simpletrace.c | 13 + tracetool |2 ++ 5 files

[PATCH 3/3] Toggle tracepoint state

2010-06-16 Thread Prerna Saxena
This patch adds support for dynamically enabling/disabling of tracepoints. This is done by internally maintaining each tracepoint's state, and permitting logging of data from a tracepoint only if it is in an 'active' state. Monitor commands added : 1) info tracepoints : to view all

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-16 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: [...] The format I will propose is global-ID|/absolute/path, no more /path/global-ID as this comes with the risk of ambiguity (ID may shadow bus-local name of a device). Doesn't

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Nicholas A. Bellinger
On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and PERSISTENT_RESERVE_IN

Re: RFC qdev path semantics

2010-06-16 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: [...] Bus names are chosen by the system as follows: * If the driver of the parent device model provides a name, use that. * Else, if the parent device has id ID, use ID.NUM, where NUM is the bus number, counting from zero in creation order. *

Re: [PATCH 01/17] Eliminate duplicated timer code

2010-06-16 Thread Glauber Costa
On Mon, Jun 14, 2010 at 09:34:03PM -1000, Zachary Amsden wrote: Move duplicated timer related code into arch_vcpu_load rather than vendor callouts. Should be an isomorphic transformation. Signed-off-by: Zachary Amsden zams...@redhat.com Acked-by: Glauber Costa glom...@redhat.com -- To

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 15:03, schrieb Nicholas A. Bellinger: On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Nicholas A. Bellinger
On Wed, 2010-06-16 at 06:03 -0700, Nicholas A. Bellinger wrote: On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates

Re: [PATCH 5/24] Introduce vmcs12: a VMCS structure for L1

2010-06-16 Thread Avi Kivity
On 06/16/2010 03:24 PM, Nadav Har'El wrote: On Mon, Jun 14, 2010, Avi Kivity wrote about Re: [PATCH 5/24] Introduce vmcs12: a VMCS structure for L1: +struct __attribute__ ((__packed__)) vmcs12 { + /* According to the Intel spec, a VMCS region must start with the +* following

Re: [PATCH 03/17] Unify vendor TSC logic

2010-06-16 Thread Glauber Costa
On Wed, Jun 16, 2010 at 04:10:10PM +0800, Jason Wang wrote: Zachary Amsden wrote: void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) { + kvm_x86_ops-vcpu_load(vcpu, cpu); if (unlikely(vcpu-cpu != cpu)) { + /* Make sure TSC doesn't go backwards */ +

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 15:09, schrieb Nicholas A. Bellinger: On Wed, 2010-06-16 at 06:03 -0700, Nicholas A. Bellinger wrote: On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger

Re: RFC qdev path semantics

2010-06-16 Thread Paul Brook
Bus names are chosen by the system as follows: * If the driver of the parent device model provides a name, use that. * Else, if the parent device has id ID, use ID.NUM, where NUM is the bus number, counting from zero in creation order. * Else, use TYPE.NUM, where TYPE is

Re: [PATCH 04/17] Fix deep C-state TSC desynchronization

2010-06-16 Thread Glauber Costa
On Mon, Jun 14, 2010 at 09:34:06PM -1000, Zachary Amsden wrote: When CPUs with unstable TSCs enter deep C-state, TSC may stop running. This causes us to require resynchronization. Since we can't tell when this may potentially happen, we assume the worst by forcing re-compensation for it at

Re: [PATCH 05/17] Keep SMP VMs more in sync on unstable TSC

2010-06-16 Thread Glauber Costa
On Mon, Jun 14, 2010 at 09:34:07PM -1000, Zachary Amsden wrote: SMP VMs on machines with unstable TSC have their TSC offset adjusted by the local offset delta from last measurement. This does not take into account how long it has been since the measurement, leading to drift. Minimize the

Re: [PATCH 10/24] Implement VMPTRLD

2010-06-16 Thread Gleb Natapov
On Sun, Jun 13, 2010 at 03:27:41PM +0300, Nadav Har'El wrote: This patch implements the VMPTRLD instruction. Signed-off-by: Nadav Har'El n...@il.ibm.com --- --- .before/arch/x86/kvm/vmx.c2010-06-13 15:01:29.0 +0300 +++ .after/arch/x86/kvm/vmx.c 2010-06-13 15:01:29.0

[PATCH 0/2] [scsi-bus]: Changes for PERSISTENT_RESERVE_OUT and MAINTENANCE CDBs v2

2010-06-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings, Attached is v2 for a series containing a handful of changes required for scsi-bus in order to get PERSISTENT_RESERVE_OUT and MAINTENANCE CDBs working as expected. Thanks to Kevin Wolf for pointing out the unnecessary

[PATCH 1/2] [scsi-bus]: Add PERSISTENT_RESERVE_OUT SCSIRequest-cmd.mode setup

2010-06-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add the PERSISTENT_RESERVE_OUT cdb case in scsi_req_xfer_mode() to set SCSI_XFER_TO_DEV for outgoing WRITE data. Signed-off-by: Nicholas A. Bellinger n...@linux-iscsi.org --- hw/scsi-bus.c |1 + 1 files

[PATCH 2/2] [scsi-bus]: Add MAINTENANCE_IN and MAINTENANCE_OUT SCSIRequest xfer and mode assignments

2010-06-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add MAINTENANCE_IN and MAINTENANCE_OUT case in scsi_req_length() for TYPE_ROM with MMC commands. It also adds the MAINTENANCE_OUT case in scsi_req_xfer_mode() to set SCSI_XFER_TO_DEV for outgoing write data.

Re: [Qemu-devel] Re: RFC qdev path semantics

2010-06-16 Thread Jan Kiszka
Paul Brook wrote: I think this would be better served by adding explicit aliases/IDs for those use-cases. i.e. define the global ID pci.0 to be an alias for /i440FX-pcihost/pci Makes sense. We could attach this ID to the BusState (corresponding to DeviceState:id) and manually set it during

Re: [PATCH 0/3] Monitor support QEMU trace framework

2010-06-16 Thread Jan Kiszka
Prerna Saxena wrote: This is v3 of a set of patches to enable trace visualization control via the QEMU monitor. It is based on trace infrastructure posted by Stefan : ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html ) This patchset adds monitor commands : - info

Re: [PATCH 16/17] TSC reset compensation

2010-06-16 Thread Glauber Costa
On Mon, Jun 14, 2010 at 09:34:18PM -1000, Zachary Amsden wrote: Attempt to synchronize TSCs which are reset to the same value. In the case of a reliable hardware TSC, we can just re-use the same offset, but on non-reliable hardware, we can get closer by adjusting the offset to match the

Re: [PATCH 11/24] Implement VMPTRST

2010-06-16 Thread Gleb Natapov
On Mon, Jun 14, 2010 at 12:15:10PM +0300, Avi Kivity wrote: On 06/13/2010 03:28 PM, Nadav Har'El wrote: This patch implements the VMPTRST instruction. Signed-off-by: Nadav Har'Eln...@il.ibm.com --- --- .before/arch/x86/kvm/x86.c 2010-06-13 15:01:29.0 +0300 +++

Re: [PATCH 11/17] Fix a possible backwards warp of kvmclock

2010-06-16 Thread Glauber Costa
On Wed, Jun 16, 2010 at 04:11:26PM +0800, Jason Wang wrote: Zachary Amsden wrote: Kernel time, which advances in discrete steps may progress much slower than TSC. As a result, when kvmclock is adjusted to a new base, the apparent time to the guest, which runs at a much higher, nsec scaled

Re: [PATCH 12/17] Add helper function get_kernel_ns

2010-06-16 Thread Glauber Costa
On Wed, Jun 16, 2010 at 04:12:46PM +0800, Jason Wang wrote: Zachary Amsden wrote: On 06/14/2010 10:41 PM, Avi Kivity wrote: On 06/15/2010 10:34 AM, Zachary Amsden wrote: Add a helper function for the multiple places this is used. Note that it must not be called in

Re: [PATCH 11/17] Fix a possible backwards warp of kvmclock

2010-06-16 Thread Avi Kivity
On 06/16/2010 04:58 PM, Glauber Costa wrote: On Wed, Jun 16, 2010 at 04:11:26PM +0800, Jason Wang wrote: Zachary Amsden wrote: Kernel time, which advances in discrete steps may progress much slower than TSC. As a result, when kvmclock is adjusted to a new base, the apparent time to

Re: Loss of network connectivity with high load

2010-06-16 Thread Avi Kivity
On 06/16/2010 12:00 AM, Daniel Bareiro wrote: Hi all! I'm using Linux 2.6.31.13 compiled with the kernel.org source code on KVM host with Debian GNU/Linux Lenny amd64. Also I'm using Debian GNU/Linux Lenny amd64 virtual machine with kernel 2.6.26-2 from Debian repositories. I'm using qemu-kvm

Re: [PATCH 0/2] [scsi-bus]: Changes for PERSISTENT_RESERVE_OUT and MAINTENANCE CDBs v2

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 15:42, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org Greetings, Attached is v2 for a series containing a handful of changes required for scsi-bus in order to get PERSISTENT_RESERVE_OUT and MAINTENANCE CDBs working as expected. Thanks to

Re: [PATCH 12/24] Add VMCS fields to the vmcs12

2010-06-16 Thread Gleb Natapov
On Sun, Jun 13, 2010 at 03:28:43PM +0300, Nadav Har'El wrote: In this patch we add to vmcs12 (the VMCS that L1 keeps for L2) all the standard VMCS fields. These fields are encapsulated in a struct shadow_vmcs. Later patches will enable L1 to read and write these fields using VMREAD/ VMWRITE,

Re: [Qemu-devel] Re: RFC qdev path semantics

2010-06-16 Thread Markus Armbruster
Paul Brook p...@codesourcery.com writes: Bus names are chosen by the system as follows: * If the driver of the parent device model provides a name, use that. * Else, if the parent device has id ID, use ID.NUM, where NUM is the bus number, counting from zero in creation order.

Re: [RFC][PATCH 3/9] replace x86 kvm n_free_mmu_pages with n_used_mmu_pages

2010-06-16 Thread Marcelo Tosatti
On Tue, Jun 15, 2010 at 06:55:22AM -0700, Dave Hansen wrote: I think doing this makes the code much more readable. That's borne out by the fact that this patch removes code. used also happens to be the number that we need to return back to the slab code when our shrinker gets called.

Re: [PATCH] KVM: x86 emulator: fix pusha instruction emulation

2010-06-16 Thread Marcelo Tosatti
On Tue, Jun 15, 2010 at 09:00:16AM +0800, Wei Yongjun wrote: emulate pusha instruction only writeback the last EDI register, but the other registers which need to be writeback is ignored. This patch fixed it. --- arch/x86/kvm/emulate.c | 133

Re: [PATCH 13/24] Implement VMREAD and VMWRITE

2010-06-16 Thread Gleb Natapov
On Mon, Jun 14, 2010 at 12:36:02PM +0300, Avi Kivity wrote: On 06/13/2010 03:29 PM, Nadav Har'El wrote: Implement the VMREAD and VMWRITE instructions. With these instructions, L1 can read and write to the VMCS it is holding. The values are read or written to the fields of the shadow_vmcs

Re: [PATCH 11/17] Fix a possible backwards warp of kvmclock

2010-06-16 Thread Glauber Costa
On Wed, Jun 16, 2010 at 05:13:02PM +0300, Avi Kivity wrote: On 06/16/2010 04:58 PM, Glauber Costa wrote: On Wed, Jun 16, 2010 at 04:11:26PM +0800, Jason Wang wrote: Zachary Amsden wrote: Kernel time, which advances in discrete steps may progress much slower than TSC. As a result, when

Re: [PATCH 2/3] qemu: Enable XSAVE related CPUID

2010-06-16 Thread Sheng Yang
On Thursday 10 June 2010 11:31:02 Sheng Yang wrote: We can support it in KVM now. The 0xd leaf is queried from KVM. Hi Marcelo Avi How about patch 1 and 2 in this series? They are used to enable XSAVE cpuid. -- regards Yang, Sheng

Re: [PATCH 13/24] Implement VMREAD and VMWRITE

2010-06-16 Thread Gleb Natapov
On Sun, Jun 13, 2010 at 03:29:13PM +0300, Nadav Har'El wrote: Implement the VMREAD and VMWRITE instructions. With these instructions, L1 can read and write to the VMCS it is holding. The values are read or written to the fields of the shadow_vmcs structure introduced in the previous patch.

Re: [RFC][PATCH 0/9] rework KVM mmu_shrink() code

2010-06-16 Thread Dave Hansen
On Wed, 2010-06-16 at 11:38 +0300, Avi Kivity wrote: On 06/15/2010 04:55 PM, Dave Hansen wrote: These seem to boot and run fine. I'm running about 40 VMs at once, while doing echo 3 /proc/sys/vm/drop_caches, and killing/restarting VMs constantly. Will drop_caches actually shrink

Re: [RFC][PATCH 4/9] create aggregate kvm_total_used_mmu_pages value

2010-06-16 Thread Dave Hansen
On Wed, 2010-06-16 at 11:48 +0300, Avi Kivity wrote: On 06/15/2010 04:55 PM, Dave Hansen wrote: +/* + * This value is the sum of all of the kvm instances's + * kvm-arch.n_used_mmu_pages values. We need a global, + * aggregate version in order to make the slab shrinker + * faster + */

Re: [RFC][PATCH 9/9] make kvm mmu shrinker more aggressive

2010-06-16 Thread Dave Hansen
On Wed, 2010-06-16 at 12:24 +0300, Avi Kivity wrote: On 06/15/2010 04:55 PM, Dave Hansen wrote: In a previous patch, we removed the 'nr_to_scan' tracking. It was not being used to track the number of objects scanned, so we stopped using it entirely. Here, we strart using it again.

Re: [PATCH 11/24] Implement VMPTRST

2010-06-16 Thread Nadav Har'El
On Wed, Jun 16, 2010, Gleb Natapov wrote about Re: [PATCH 11/24] Implement VMPTRST: On Mon, Jun 14, 2010 at 12:15:10PM +0300, Avi Kivity wrote: write_guest_virt_system() is used by writes which need to ignore the cpl, for example when a cpl 3 instruction loads a segment, the processor

[ kvm-Bugs-2948108 ] qemu-kvm fails to migrate properly in 0.12.2

2010-06-16 Thread SourceForge.net
Bugs item #2948108, was opened at 2010-02-08 14:06 Message generated for change (Comment added) made by ramereth You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2948108group_id=180599 Please note that this message will contain a full copy of the comment

Re: [RFC][PATCH 3/9] replace x86 kvm n_free_mmu_pages with n_used_mmu_pages

2010-06-16 Thread Dave Hansen
On Wed, 2010-06-16 at 11:25 -0300, Marcelo Tosatti wrote: - if (used_pages kvm_nr_mmu_pages) { - while (used_pages kvm_nr_mmu_pages + if (kvm-arch.n_used_mmu_pages goal_nr_mmu_pages) { + while (kvm-arch.n_used_mmu_pages goal_nr_mmu_pages

Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-16 Thread Juan Quintela
Anthony Liguori anth...@codemonkey.ws wrote: On 06/14/2010 03:28 PM, Alex Williamson wrote: PCI hotplug currently doesn't work after a migration because we don't migrate the enable bits of the GPE state. Pull hotplug structs into vmstate. Signed-off-by: Alex

Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support

2010-06-16 Thread Jan Kiszka
Marcelo Tosatti wrote: On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: Signed-off-by: Sheng Yang sh...@linux.intel.com --- qemu-kvm-x86.c| 109 - qemu-kvm.c| 24 +++ qemu-kvm.h| 28

Re: [RFC][PATCH 4/9] create aggregate kvm_total_used_mmu_pages value

2010-06-16 Thread Dave Hansen
On Wed, 2010-06-16 at 11:48 +0300, Avi Kivity wrote: +static inline void kvm_mod_used_mmu_pages(struct kvm *kvm, int nr) +{ + kvm-arch.n_used_mmu_pages += nr; + kvm_total_used_mmu_pages += nr; Needs an atomic operation, since there's no global lock here. To avoid

Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status

2010-06-16 Thread Alex Williamson
On Wed, 2010-06-16 at 17:47 +0200, Juan Quintela wrote: Anthony Liguori anth...@codemonkey.ws wrote: On 06/14/2010 03:28 PM, Alex Williamson wrote: PCI hotplug currently doesn't work after a migration because we don't migrate the enable bits of the GPE state. Pull hotplug structs into

Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration support

2010-06-16 Thread Marcelo Tosatti
On Wed, Jun 16, 2010 at 05:48:46PM +0200, Jan Kiszka wrote: Marcelo Tosatti wrote: On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote: Signed-off-by: Sheng Yang sh...@linux.intel.com --- qemu-kvm-x86.c| 109 -

[ kvm-Bugs-2948108 ] qemu-kvm fails to migrate properly in 0.12.2

2010-06-16 Thread SourceForge.net
Bugs item #2948108, was opened at 2010-02-08 16:06 Message generated for change (Comment added) made by iggy_cav You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2948108group_id=180599 Please note that this message will contain a full copy of the comment

Re: [PATCH 2/3] qemu: Enable XSAVE related CPUID

2010-06-16 Thread Marcelo Tosatti
On Wed, Jun 16, 2010 at 10:59:07PM +0800, Sheng Yang wrote: On Thursday 10 June 2010 11:31:02 Sheng Yang wrote: We can support it in KVM now. The 0xd leaf is queried from KVM. Hi Marcelo Avi How about patch 1 and 2 in this series? They are used to enable XSAVE cpuid. Applied. -- To

Re: [Qemu-devel] Re: KVM call minutes for June 15

2010-06-16 Thread Blue Swirl
On Tue, Jun 15, 2010 at 4:13 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 06/15/2010 10:41 AM, Christoph Hellwig wrote: On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote: KVM/qemu patches - patch rate is high, documentation is low, review is low - patches need to include

  1   2   >