Re: [RFC PATCH 3/3] KVM: MMU: Optimize guest page table walk

2011-04-19 Thread Joerg Roedel
On Tue, Apr 19, 2011 at 10:24:10AM +0900, Takuya Yoshikawa wrote: Can I test nested SVM easily, e.g.? Yes, nested SVM would be good to test too with those changes. We should make sure to not break something there. Regards, Joerg -- To unsubscribe from this list: send the line

Re: [PATCH 3/6] KVM: X86: Make tsc_delta calculation a function of guest tsc

2011-04-19 Thread Roedel, Joerg
On Mon, Apr 18, 2011 at 08:02:35PM -0400, Zachary Amsden wrote: On Sat, Apr 16, 2011 at 06:09:17PM +0200, Jan Kiszka wrote: On 2011-03-25 09:44, Joerg Roedel wrote: + tsc_delta = !vcpu-arch.last_guest_tsc ? 0 : + tsc -

Re: [PATCH 3/6] KVM: X86: Make tsc_delta calculation a function of guest tsc

2011-04-19 Thread Jan Kiszka
On 2011-04-19 08:46, Roedel, Joerg wrote: On Mon, Apr 18, 2011 at 08:02:35PM -0400, Zachary Amsden wrote: On Sat, Apr 16, 2011 at 06:09:17PM +0200, Jan Kiszka wrote: On 2011-03-25 09:44, Joerg Roedel wrote: + tsc_delta = !vcpu-arch.last_guest_tsc ? 0 : +

[PATCH] kvm tools: Fix possible leak in disk_image

2011-04-19 Thread Sasha Levin
Close leaking fd if ioctl fails. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/disk-image.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/kvm/disk-image.c b/tools/kvm/disk-image.c index 252ff1c..0fb2083 100644 --- a/tools/kvm/disk-image.c

Re: [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-19 Thread Isaku Yamahata
On Mon, Apr 18, 2011 at 06:26:08PM +0200, Juan Quintela wrote: Isaku Yamahata yamah...@valinux.co.jp wrote: It's vmstate parameter was wrong. This patch fixes it. Reported-by: Avi Kivity a...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/acpi_piix4.c |3

Re: [PATCH V2] kvm tool: QCOW version 1 write support.

2011-04-19 Thread Ingo Molnar
* Prasad Joshi prasadjoshi...@gmail.com wrote: The code is based on the following QCOW 1 image format specification: http://people.gnome.org/~markmc/qcow-image-format-version-1.html Changes since V1: - Variable data type change. - Added a function qcow_write_l2_table() to write level2

[PATCH v2 2a/6] x86: Allow multiple cpu feature matches of lookup_feature

2011-04-19 Thread Jan Kiszka
kvmclock is represented by two feature bits. Therefore, lookup_feature needs to continue its search even after the first match. Enhance it accordingly and switch to a bool return type at this chance. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/cpuid.c | 14 --

[PATCH v2 2b/6] kvm: add kvmclock to its second bit

2011-04-19 Thread Jan Kiszka
From: Glauber Costa glom...@redhat.com We have two bits that can represent kvmclock in cpuid. They signal the guest which msr set to use. When we tweak flags involving this value - specially when we use -, we have to act on both. [Jan: factored out lookup_feature changes] Signed-off-by: Jan

Re: Does macvtap support host to guest communication?

2011-04-19 Thread Arnd Bergmann
On Monday 18 April 2011, Asias He wrote: If you want a regular device to be able to send to a macvlan port, that would require at least these changes: * Add an option to put a plain device into macvlan-bridge mode * Add support for that option into iproute2 * Add a hook into

Re: [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-19 Thread Juan Quintela
Isaku Yamahata yamah...@valinux.co.jp wrote: shouldn't last one still be uint16_t? It results in an error by type_check_pointer. You are right. We are just lying. Will think about how to fix this properly (basically move the whole thing to a uint8_t array, and work from there. I guess that

Re: [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-19 Thread Isaku Yamahata
On Tue, Apr 19, 2011 at 02:33:46PM +0200, Juan Quintela wrote: Isaku Yamahata yamah...@valinux.co.jp wrote: shouldn't last one still be uint16_t? It results in an error by type_check_pointer. You are right. We are just lying. Will think about how to fix this properly (basically move

Re: KVM call agenda for April 19th

2011-04-19 Thread Juan Quintela
Antonio Galindo Castro funkymons...@gmail.com wrote: Tools for resource accounting the virtual machines. This was the only topic for today call. Moving item to next week agenda. It appears that it is Eastern all around and not everybody able to attend. Have a nice day, Juan. -- To

Re: [PATCH 3/6] KVM: X86: Make tsc_delta calculation a function of guest tsc

2011-04-19 Thread Zachary Amsden
On 2011-04-19 08:46, Roedel, Joerg wrote: On Mon, Apr 18, 2011 at 08:02:35PM -0400, Zachary Amsden wrote: On Sat, Apr 16, 2011 at 06:09:17PM +0200, Jan Kiszka wrote: On 2011-03-25 09:44, Joerg Roedel wrote: + tsc_delta =

Re: [PATCH 3/6] KVM: X86: Make tsc_delta calculation a function of guest tsc

2011-04-19 Thread Jan Kiszka
On 2011-04-19 16:15, Zachary Amsden wrote: On 2011-04-19 08:46, Roedel, Joerg wrote: On Mon, Apr 18, 2011 at 08:02:35PM -0400, Zachary Amsden wrote: On Sat, Apr 16, 2011 at 06:09:17PM +0200, Jan Kiszka wrote: On 2011-03-25 09:44, Joerg Roedel wrote:

[PATCH V4] kvm tool: Use the root partition of the host to boot the guest machine

2011-04-19 Thread Prasad Joshi
The kvm run command should automatically pickup the image file to boot if one is not explicitly specified. Changes since V1: - Deallocate variable 'line' when fopen(/proc/mounts) fails Changes since V2: - Instead of searching from /proc/mounts, use the device file /dev/root to detect the

Re: [PATCH V4] kvm tool: Use the root partition of the host to boot the guest machine

2011-04-19 Thread Ingo Molnar
* Prasad Joshi prasadjoshi...@gmail.com wrote: The kvm run command should automatically pickup the image file to boot if one is not explicitly specified. Changes since V1: - Deallocate variable 'line' when fopen(/proc/mounts) fails Changes since V2: - Instead of searching from

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Pekka Enberg
On Mon, Apr 18, 2011 at 4:02 PM, Sasha Levin levinsasha...@gmail.com wrote: Add --debug-io-delay-cycles and --debug-io-delay-amount to delay the completion of IO requests within virtio-blk. This feature allows to verify and debug the threading within virtio-blk. Signed-off-by: Sasha Levin

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Sasha Levin
On Tue, 2011-04-19 at 19:52 +0300, Pekka Enberg wrote: On Mon, Apr 18, 2011 at 4:02 PM, Sasha Levin levinsasha...@gmail.com wrote: Add --debug-io-delay-cycles and --debug-io-delay-amount to delay the completion of IO requests within virtio-blk. This feature allows to verify and debug the

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Ingo Molnar
* Sasha Levin levinsasha...@gmail.com wrote: On Tue, 2011-04-19 at 19:52 +0300, Pekka Enberg wrote: On Mon, Apr 18, 2011 at 4:02 PM, Sasha Levin levinsasha...@gmail.com wrote: Add --debug-io-delay-cycles and --debug-io-delay-amount to delay the completion of IO requests within

[PATCH v2 0/2] Store and load PCI device saved state across function resets

2011-04-19 Thread Alex Williamson
v1 - v2: Make the pointer passed around less opaque for type safety. Bug https://bugs.launchpad.net/qemu/+bug/754591 is caused because the KVM module attempts to do a pci_save_state() before assigning the device to a VM, expecting that the saved state will remain valid until we release the

[PATCH v2 1/2] PCI: Add interfaces to store and load the device saved state

2011-04-19 Thread Alex Williamson
For KVM device assignment, we'd like to save off the state of a device prior to passing it to the guest and restore it later. We also want to allow pci_reset_funciton() to be called while the device is owned by the guest. This however overwrites and invalidates the struct pci_dev buffers, so we

[PATCH v2 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-19 Thread Alex Williamson
Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state survives across pci_reset_function() calls via the PCI sysfs reset interface while the VM is using the device. Signed-off-by: Alex Williamson

[PATCH] kvm tools: Add read-only support for QCOW2 images

2011-04-19 Thread Pekka Enberg
This patch extends the QCOW1 format to also support QCOW2 images as specified by the following document: http://people.gnome.org/~markmc/qcow-image-format.html Cc: Asias He asias.he...@gmail.com Cc: Cyrill Gorcunov gorcu...@gmail.com Cc: Prasad Joshi prasadjoshi...@gmail.com Cc: Sasha Levin

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Asias He
On 04/20/2011 01:11 AM, Ingo Molnar wrote: * Sasha Levin levinsasha...@gmail.com wrote: On Tue, 2011-04-19 at 19:52 +0300, Pekka Enberg wrote: On Mon, Apr 18, 2011 at 4:02 PM, Sasha Levin levinsasha...@gmail.com wrote: Add --debug-io-delay-cycles and --debug-io-delay-amount to delay the

Re: [Autotest] [PATCH 0/5] Make unattended install on Linux safer, fix OpenSUSE/SLES installs

2011-04-19 Thread pradeep
On Mon, 18 Apr 2011 19:40:40 -0300 Lucas Meneghel Rodrigues l...@redhat.com wrote: While working on making unattended install on Linux guests safer, noticed that the recent patches changing unattended install to use -kernel and -initrd options [1] were breaking OpenSUSE and SLES installation.

Re: [Autotest] [PATCH 0/5] Make unattended install on Linux safer, fix OpenSUSE/SLES installs

2011-04-19 Thread Lucas Meneghel Rodrigues
On Wed, 2011-04-20 at 06:33 +0530, pradeep wrote: On Mon, 18 Apr 2011 19:40:40 -0300 Lucas Meneghel Rodrigues l...@redhat.com wrote: While working on making unattended install on Linux guests safer, noticed that the recent patches changing unattended install to use -kernel and -initrd

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-19 Thread Lai Jiangshan
On 04/04/2011 09:09 PM, Anthony Liguori wrote: On 04/04/2011 07:19 AM, Markus Armbruster wrote: [Note cc: Anthony] Daniel P. Berrangeberra...@redhat.com writes: On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: From: Lai Jiangshanla...@cn.fujitsu.com Date: Mon, 7 Mar 2011

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-19 Thread Lai Jiangshan
On 04/20/2011 09:53 AM, Lai Jiangshan wrote: On 04/04/2011 09:09 PM, Anthony Liguori wrote: On 04/04/2011 07:19 AM, Markus Armbruster wrote: [Note cc: Anthony] Daniel P. Berrangeberra...@redhat.com writes: On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: From: Lai

Re: [PATCH 3/4] kvm tools: Add debug feature to test the IO thread

2011-04-19 Thread Pekka Enberg
On Wed, Apr 20, 2011 at 2:10 AM, Asias He asias.he...@gmail.com wrote: This came up during our testing. Ingo suggested a large delay so we could easily see the results of threading. The problem we encountered was that having a delay right from the beginning will make the guest kernel take a

Re: [PATCH 2/2] KVM: PPC: booke: add sregs support

2011-04-19 Thread Scott Wood
On Tue, 19 Apr 2011 01:19:39 +0200 Alexander Graf ag...@suse.de wrote: On 19.04.2011, at 00:31, Scott Wood wrote: int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs) { - return -ENOTSUPP; + int ret; + +