Re: [RFC PATCH v4 2/5] ramlist mutex

2011-08-17 Thread Paolo Bonzini
On 08/16/2011 08:56 PM, Umesh Deshpande wrote: @@ -3001,8 +3016,10 @@ void qemu_ram_free_from_ptr(ram_addr_t addr) QLIST_FOREACH(block,ram_list.blocks, next) { if (addr == block-offset) { +qemu_mutex_lock_ramlist(); QLIST_REMOVE(block, next);

Re: [RFC PATCH v4 4/5] separate thread for VM migration

2011-08-17 Thread Paolo Bonzini
On 08/16/2011 08:56 PM, Umesh Deshpande wrote: +qemu_mutex_lock_ramlist(); Taken locks: iothread, ramlist +qemu_mutex_unlock_iothread(); Taken locks: ramlist +s-wait_for_unfreeze(s); +qemu_mutex_lock_iothread(); Taken locks: ramlist,

Re: [RFC PATCH v3 5/5] Making iothread block for migrate_cancel

2011-08-17 Thread Paolo Bonzini
On 08/16/2011 08:56 PM, Umesh Deshpande wrote: diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c index 2bd02ef..0d18b35 100644 --- a/qemu-thread-posix.c +++ b/qemu-thread-posix.c @@ -115,6 +115,16 @@ void qemu_cond_wait(QemuCond *cond, QemuMutex *mutex) error_exit(err, __func__);

Re: [KVM]:could anyone give me some instruction for KVM pci driver? Thanks

2011-08-17 Thread liu pf
Hi guys, After objdump the driver, I found that the access to the pci-memmap register was optimized by GCC, and no code was generated. And the EPT in 2.6.39 is fine. Thanks, Pierce On Fri, Aug 12, 2011 at 4:33 PM, liu pf kernelf...@gmail.com wrote: Hi guys, When I develop a PCI device

[PATCH 1/2] kvm tools: fix wrong virtio id for balloon

2011-08-17 Thread Liming Wang
Replace the wrong rng virtio id with the correct balloon id. Signed-off-by: Liming Wang walimis...@gmail.com --- tools/kvm/virtio/balloon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/kvm/virtio/balloon.c b/tools/kvm/virtio/balloon.c index c5853a5..aba52d6

[PATCH 2/2] kvm tools: change option type of RNG from increment to boolean

2011-08-17 Thread Liming Wang
Becasue virtio random generator is a single device, change its option type to boolean. Signed-off-by: Liming Wang walimis...@gmail.com --- tools/kvm/builtin-run.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c

Re: [PATCH 2/2] kvm tools: change option type of RNG from increment to boolean

2011-08-17 Thread Pekka Enberg
On 8/17/11 12:44 PM, Liming Wang wrote: Becasue virtio random generator is a single device, change its option type to boolean. Signed-off-by: Liming Wangwalimis...@gmail.com I suppose the idea here was to support multiple rng devices. Sasha? --- tools/kvm/builtin-run.c |7 +++ 1

Re: [PATCH 2/2] kvm tools: change option type of RNG from increment to boolean

2011-08-17 Thread Sasha Levin
On Wed, Aug 17, 2011 at 2:44 PM, Pekka Enberg penb...@kernel.org wrote: On 8/17/11 12:44 PM, Liming Wang wrote: Becasue virtio random generator is a single device, change its option type to boolean. Signed-off-by: Liming Wangwalimis...@gmail.com I suppose the idea here was to support

Re: [net-next RFC PATCH 7/7] virtio-net changes

2011-08-17 Thread WANG Cong
On Fri, 12 Aug 2011 09:55:51 +0800, Jason Wang wrote: From: Krishna Kumar krkum...@in.ibm.com Implement mq virtio-net driver. Though struct virtio_net_config changes, it works with the old qemu since the last element is not accessed unless qemu sets VIRTIO_NET_F_MULTIQUEUE. ... +

[AUTOTEST][KVM][PATCH] Add test for testing of killing guest when network is under usage.

2011-08-17 Thread Jiří Župka
This patch contain two tests. 1) Try kill guest when guest netwok is under loading. 2) Try kill guest after multiple adding and removing network drivers. Signed-off-by: Jiří Župka jzu...@redhat.com --- client/tests/kvm/tests_base.cfg.sample| 23 +

Re: [PATCH 2/2] kvm tools: change option type of RNG from increment to boolean

2011-08-17 Thread walimis
On Wed, Aug 17, 2011 at 03:02:55PM +0300, Sasha Levin wrote: On Wed, Aug 17, 2011 at 2:44 PM, Pekka Enberg penb...@kernel.org wrote: On 8/17/11 12:44 PM, Liming Wang wrote: Becasue virtio random generator is a single device, change its option type to boolean. Signed-off-by: Liming

Re: [PATCH 2/2] kvm tools: change option type of RNG from increment to boolean

2011-08-17 Thread Sasha Levin
On Wed, Aug 17, 2011 at 6:14 PM, walimis walimis...@gmail.com wrote: On Wed, Aug 17, 2011 at 03:02:55PM +0300, Sasha Levin wrote: On Wed, Aug 17, 2011 at 2:44 PM, Pekka Enberg penb...@kernel.org wrote: On 8/17/11 12:44 PM, Liming Wang wrote: Becasue virtio random generator is a single device,

RCU treating guest mode just like it does user-mode execution

2011-08-17 Thread Paul E. McKenney
Hello, Gleb, I was looking at KVM's call to rcu_virt_note_context_switch() in kvm_guest_enter(), and noting the comment talking about treating guest mode like user-mode execution is. One difference between RCU's treatment of KVM guest execution and user-mode execution is that RCU notes a context

Re: RCU treating guest mode just like it does user-mode execution

2011-08-17 Thread Gleb Natapov
On Wed, Aug 17, 2011 at 01:43:27PM -0700, Paul E. McKenney wrote: Hello, Gleb, I was looking at KVM's call to rcu_virt_note_context_switch() in kvm_guest_enter(), and noting the comment talking about treating guest mode like user-mode execution is. One difference between RCU's treatment of

Re: RCU treating guest mode just like it does user-mode execution

2011-08-17 Thread Paul E. McKenney
On Thu, Aug 18, 2011 at 12:50:15AM +0300, Gleb Natapov wrote: On Wed, Aug 17, 2011 at 01:43:27PM -0700, Paul E. McKenney wrote: Hello, Gleb, I was looking at KVM's call to rcu_virt_note_context_switch() in kvm_guest_enter(), and noting the comment talking about treating guest mode like

Re: [PATCH] virtio-blk: Add stats VQ to collect information about devices

2011-08-17 Thread Avi Kivity
On 08/16/2011 12:47 PM, Sasha Levin wrote: This patch adds support for an optional stats vq that works similary to the stats vq provided by virtio-balloon. The purpose of this change is to allow collection of statistics about working virtio-blk devices to easily analyze performance without

Re: RCU treating guest mode just like it does user-mode execution

2011-08-17 Thread Gleb Natapov
On Wed, Aug 17, 2011 at 03:05:20PM -0700, Paul E. McKenney wrote: On Thu, Aug 18, 2011 at 12:50:15AM +0300, Gleb Natapov wrote: On Wed, Aug 17, 2011 at 01:43:27PM -0700, Paul E. McKenney wrote: Hello, Gleb, I was looking at KVM's call to rcu_virt_note_context_switch() in

Re: RCU treating guest mode just like it does user-mode execution

2011-08-17 Thread Paul E. McKenney
On Thu, Aug 18, 2011 at 02:55:29AM +0300, Gleb Natapov wrote: On Wed, Aug 17, 2011 at 03:05:20PM -0700, Paul E. McKenney wrote: On Thu, Aug 18, 2011 at 12:50:15AM +0300, Gleb Natapov wrote: On Wed, Aug 17, 2011 at 01:43:27PM -0700, Paul E. McKenney wrote: Hello, Gleb, I was

Re: RCU treating guest mode just like it does user-mode execution

2011-08-17 Thread Avi Kivity
On 08/17/2011 05:25 PM, Paul E. McKenney wrote: Wouldn't scheduling-clock interrupt kick vcpu out of a guest mode much earlier then 30 seconds? The scheduling-clock interrupt would happen, but I do not know whether or not it would kick the vcpu out of guest mode in such a way that would

Re: RCU treating guest mode just like it does user-mode execution

2011-08-17 Thread Gleb Natapov
On Wed, Aug 17, 2011 at 05:25:13PM -0700, Paul E. McKenney wrote: On Thu, Aug 18, 2011 at 02:55:29AM +0300, Gleb Natapov wrote: On Wed, Aug 17, 2011 at 03:05:20PM -0700, Paul E. McKenney wrote: On Thu, Aug 18, 2011 at 12:50:15AM +0300, Gleb Natapov wrote: On Wed, Aug 17, 2011 at

Re: RCU treating guest mode just like it does user-mode execution

2011-08-17 Thread Paul E. McKenney
On Wed, Aug 17, 2011 at 05:28:46PM -0700, Avi Kivity wrote: On 08/17/2011 05:25 PM, Paul E. McKenney wrote: Wouldn't scheduling-clock interrupt kick vcpu out of a guest mode much earlier then 30 seconds? The scheduling-clock interrupt would happen, but I do not know whether or not

Re: RCU treating guest mode just like it does user-mode execution

2011-08-17 Thread Avi Kivity
On 08/17/2011 05:44 PM, Paul E. McKenney wrote: The result can only be one of reenter guest (and rcu_virt_note_context_switch) schedule() exit to userspace Very good, thank you both for bearing with me on this! Hey, it's our pleasure. Pester us as often as you'll like and

[PATCH 1/2] kvm tools: fix repeated io emulation

2011-08-17 Thread Xiao Guangrong
When kvm emulates repeation io read instruction, it can exit to user-space with 'count' 1, we need to emulate io access for many times Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com --- tools/kvm/ioport.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-)

[PATCH 2/2] kvm tools: remove count in io emulation callbacks

2011-08-17 Thread Xiao Guangrong
'count' parameter in io emulation callbacks is useless, just remove it Signed-off-by: Xiao Guangrong xiaoguangr...@cn.fujitsu.com --- tools/kvm/hw/i8042.c |4 ++-- tools/kvm/hw/rtc.c |6 +++--- tools/kvm/hw/serial.c |6 +++--- tools/kvm/hw/vesa.c

Re: [PATCH] virtio-blk: Add stats VQ to collect information about devices

2011-08-17 Thread Sasha Levin
On Wed, 2011-08-17 at 16:00 -0700, Avi Kivity wrote: On 08/16/2011 12:47 PM, Sasha Levin wrote: This patch adds support for an optional stats vq that works similary to the stats vq provided by virtio-balloon. The purpose of this change is to allow collection of statistics about working