Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread John Fastabend
On 2/1/2012 11:24 PM, Michael S. Tsirkin wrote: On Sun, Nov 20, 2011 at 08:30:24AM -0800, Roopa Prabhu wrote: On 11/17/11 4:15 PM, Ben Hutchings bhutchi...@solarflare.com wrote: Sorry to come to this rather late. On Tue, 2011-11-08 at 23:55 -0800, Roopa Prabhu wrote: [...] v2 - v3 -

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2012 at 12:46:57AM -0800, John Fastabend wrote: On 2/1/2012 11:24 PM, Michael S. Tsirkin wrote: On Sun, Nov 20, 2011 at 08:30:24AM -0800, Roopa Prabhu wrote: On 11/17/11 4:15 PM, Ben Hutchings bhutchi...@solarflare.com wrote: Sorry to come to this rather late. On

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread John Fastabend
On 2/2/2012 12:50 AM, Michael S. Tsirkin wrote: On Thu, Feb 02, 2012 at 12:46:57AM -0800, John Fastabend wrote: On 2/1/2012 11:24 PM, Michael S. Tsirkin wrote: On Sun, Nov 20, 2011 at 08:30:24AM -0800, Roopa Prabhu wrote: On 11/17/11 4:15 PM, Ben Hutchings bhutchi...@solarflare.com wrote:

Re: [test result] dirty logging without srcu update -- Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-02 Thread Avi Kivity
On 02/02/2012 07:46 AM, Takuya Yoshikawa wrote: Avi Kivity a...@redhat.com wrote: That'll be great, numbers are better than speculation. Yes, I already have some good numbers to show (and some patches). Looking forward. I made a patch to see if Avi's suggestion of getting

Re: [PULL 0/5] ppc patch queue 2012-02-02

2012-02-02 Thread Avi Kivity
On 02/02/2012 05:04 AM, Alexander Graf wrote: Hi Avi / Marcelo, This is my current patch queue for ppc. Please pull. Pulled, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [test result] dirty logging without srcu update -- Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-02 Thread Takuya Yoshikawa
(2012/02/02 19:10), Avi Kivity wrote: = # of dirty pages: kvm.git (ns), with this patch (ns) 1: 102,077 ns 10,105 ns 2: 47,197 ns 9,395 ns 4: 43,563 ns 9,938 ns 8: 41,239 ns

Re: [test result] dirty logging without srcu update -- Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-02 Thread Avi Kivity
On 02/02/2012 12:21 PM, Takuya Yoshikawa wrote: (2012/02/02 19:10), Avi Kivity wrote: = # of dirty pages: kvm.git (ns), with this patch (ns) 1: 102,077 ns 10,105 ns 2: 47,197 ns 9,395 ns 4:

Re: [test result] dirty logging without srcu update -- Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-02 Thread Takuya Yoshikawa
(2012/02/02 19:21), Avi Kivity wrote: I used unsigned int just because I wanted to use the current atomic_clear_mask() as is. We need to implement atomic_clear_mask_long() or use ... If we use cmpxchg8b/cmpxchg16b then this won't fit with the atomic_*_long family. OK, I will try. I

Re: performance trouble

2012-02-02 Thread David Cure
Hello, Le Tue, Jan 31, 2012 at 07:21:25PM +0200, Avi Kivity ecrivait : How many vcpus are there in total (over all guests)? For test we run only 2 VM (RDS/TSE) with 2vcpus for each That's really strange. No network traffic/cpu/block I/O? What do 'vmstat 1' and

Re: [test result] dirty logging without srcu update -- Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-02 Thread Avi Kivity
On 02/02/2012 12:40 PM, Takuya Yoshikawa wrote: I have one concern about correctness issue though: concurrent rmap write protection may not be safe due to delayed tlb flush ... cannot happen? What do you mean by concurrent rmap write protection? -- error compiling committee.c: too

Need advice how to fix an access to uninitialized per_cpu clock

2012-02-02 Thread Igor Mammedov
While playing with kvm cpu hot-plug, I've probably stumbled on general kernel bug. So I'm lookng for advice on approach to fix it. When kvm guest uses kvmclock, it may hang on cpu hot-plug at BSP: smp_apic_timer_interrupt ... - do_timer - update_wall_time

Re: [Qemu-devel] general protection fault

2012-02-02 Thread Robert Richter
Dyweni, On 17.01.12 23:22:29, Dyweni - KVM wrote: I'm getting a very similar error when running oprofile on the host...same version of oprofile... general protection fault: [#1] PREEMPT SMP CPU 5 Modules linked in: iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi

Re: general protection fault

2012-02-02 Thread Avi Kivity
On 01/18/2012 06:40 AM, Dyweni - KVM wrote: Hi All, I'm not sure who this falls to, so I've included all all parties that I thought may be relevant. I'm getting the following error from my guest kernel when running oprofile within qemu-kvm: kvm does not virtualize a PMU before Linux 3.3,

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-02 Thread Erik Rull
On February 1, 2012 at 11:05 PM Erik Rull erik.r...@rdsoftware.de wrote: Jan Kiszka wrote: On 2012-02-01 13:52, Erik Rull wrote: Hi all, first of all I'm a bit confused: What is the difference between qemu with command line option --enable-kvm and qemu-kvm? It seems to be a

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-02 Thread Jan Kiszka
On 2012-02-02 14:18, Erik Rull wrote: On February 1, 2012 at 11:05 PM Erik Rull erik.r...@rdsoftware.de wrote: Jan Kiszka wrote: On 2012-02-01 13:52, Erik Rull wrote: Hi all, first of all I'm a bit confused: What is the difference between qemu with command line option --enable-kvm

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-02 Thread Erik Rull
On February 2, 2012 at 2:21 PM Jan Kiszka jan.kis...@siemens.com wrote: On 2012-02-02 14:18, Erik Rull wrote: On February 1, 2012 at 11:05 PM Erik Rull erik.r...@rdsoftware.de wrote: Jan Kiszka wrote: On 2012-02-01 13:52, Erik Rull wrote: Hi all, first of all I'm a bit

Re: [Qemu-devel] git bisect results: ec757c67c40a56492001487e69272f62144fd124 breaks windows boot in qemu-kvm

2012-02-02 Thread Jan Kiszka
On 2012-02-02 15:07, Erik Rull wrote: On February 2, 2012 at 2:21 PM Jan Kiszka jan.kis...@siemens.com wrote: On 2012-02-02 14:18, Erik Rull wrote: On February 1, 2012 at 11:05 PM Erik Rull erik.r...@rdsoftware.de wrote: Jan Kiszka wrote: On 2012-02-01 13:52, Erik Rull wrote: Hi

Re: [test result] dirty logging without srcu update -- Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-02 Thread Takuya Yoshikawa
Avi Kivity a...@redhat.com wrote: I have one concern about correctness issue though: concurrent rmap write protection may not be safe due to delayed tlb flush ... cannot happen? What do you mean by concurrent rmap write protection? Not sure, but other codes like: -

Re: Partial review of kvm arm git patches.

2012-02-02 Thread Christoffer Dall
On Thu, Feb 2, 2012 at 12:04 AM, Rusty Russell ru...@rustcorp.com.au wrote: Hi all,        Started reading through the git tree at git://github.com/virtualopensystems/linux-kvm-arm.git (kvm-a15-v6-stage branch), and noticed some things.  I'm learning ARM as I go, so apologies in advance for

Re: [test result] dirty logging without srcu update -- Re: [RFC][PATCH] srcu: Implement call_srcu()

2012-02-02 Thread Avi Kivity
On 02/02/2012 04:44 PM, Takuya Yoshikawa wrote: Avi Kivity a...@redhat.com wrote: I have one concern about correctness issue though: concurrent rmap write protection may not be safe due to delayed tlb flush ... cannot happen? What do you mean by concurrent rmap write

[RFC] Next gen kvm api

2012-02-02 Thread Avi Kivity
The kvm api has been accumulating cruft for several years now. This is due to feature creep, fixing mistakes, experience gained by the maintainers and developers on how to do things, ports to new architectures, and simply as a side effect of a code base that is developed slowly and incrementally.

[PATCH v2] KVM: perf: a smart tool to analyse kvm events

2012-02-02 Thread Xiao Guangrong
Changlog: - calculate stddev. - make it works both for old kernel and new kernel. - dynamically inquire max vcpus and cpu isa. This is a example result of vmexit: # ./perf kvm-events report Warning: Error: expected type 5 but read 4 Warning: Error: expected type 5 but read 0 Warning:

[PATCH v2 1/3] KVM: x86: move kvm_exit related definitions into kvm_exit.h

2012-02-02 Thread Xiao Guangrong
From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Move the definitions into a separate .h file so that 'perf kvm-events' can easily use these Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/include/asm/kvm_exit.h | 229 +++

[PATCH v2 2/3] KVM: x86: add tracepoints to trace mmio begin and complete

2012-02-02 Thread Xiao Guangrong
From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com 'perf kvm-events' will use kvm_exit and kvm_mmio(read...) to calculate mmio read emulated time for the old kernel, in order to trace mmio read event more exactly, we add kvm_mmio_begin to trace the time when mmio read begins Also, add

[PATCH v2 3/3] KVM: perf: kvm events analysis tool

2012-02-02 Thread Xiao Guangrong
From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Add 'perf kvm-events' support to analyze kvm vmexit/mmio/ioport smartly Usage: - trace kvm events: perf kvm-events record, or, if other tracepoints are also interesting, we can append the events like this: perf

Re: [PATCH v2 1/3] KVM: x86: move kvm_exit related definitions into kvm_exit.h

2012-02-02 Thread Avi Kivity
On 02/02/2012 07:26 PM, Xiao Guangrong wrote: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Move the definitions into a separate .h file so that 'perf kvm-events' can easily use these Why not just include vmx.h and svm.h? I don't like scattering those definitions around.

Re: [PATCH v2 2/3] KVM: x86: add tracepoints to trace mmio begin and complete

2012-02-02 Thread Avi Kivity
On 02/02/2012 07:27 PM, Xiao Guangrong wrote: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com 'perf kvm-events' will use kvm_exit and kvm_mmio(read...) to calculate mmio read emulated time for the old kernel, in order to trace mmio read event more exactly, we add kvm_mmio_begin to trace

Re: [PATCH v2 1/3] KVM: x86: move kvm_exit related definitions into kvm_exit.h

2012-02-02 Thread Xiao Guangrong
On 02/03/2012 01:30 AM, Avi Kivity wrote: On 02/02/2012 07:26 PM, Xiao Guangrong wrote: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Move the definitions into a separate .h file so that 'perf kvm-events' can easily use these Why not just include vmx.h and svm.h? I don't like

Re: [PATCH v2 2/3] KVM: x86: add tracepoints to trace mmio begin and complete

2012-02-02 Thread Xiao Guangrong
On 02/03/2012 01:36 AM, Avi Kivity wrote: On 02/02/2012 07:27 PM, Xiao Guangrong wrote: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com 'perf kvm-events' will use kvm_exit and kvm_mmio(read...) to calculate mmio read emulated time for the old kernel, in order to trace mmio read event

Re: [PATCH v2 2/3] KVM: x86: add tracepoints to trace mmio begin and complete

2012-02-02 Thread Avi Kivity
On 02/02/2012 07:55 PM, Xiao Guangrong wrote: On 02/03/2012 01:36 AM, Avi Kivity wrote: On 02/02/2012 07:27 PM, Xiao Guangrong wrote: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com 'perf kvm-events' will use kvm_exit and kvm_mmio(read...) to calculate mmio read emulated time for

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread Roopa Prabhu
On 2/2/12 12:46 AM, John Fastabend john.r.fastab...@intel.com wrote: On 2/1/2012 11:24 PM, Michael S. Tsirkin wrote: On Sun, Nov 20, 2011 at 08:30:24AM -0800, Roopa Prabhu wrote: On 11/17/11 4:15 PM, Ben Hutchings bhutchi...@solarflare.com wrote: Sorry to come to this rather late.

Re: [PATCH v2 2/3] KVM: x86: add tracepoints to trace mmio begin and complete

2012-02-02 Thread Xiao Guangrong
On 02/03/2012 01:56 AM, Avi Kivity wrote: On 02/02/2012 07:55 PM, Xiao Guangrong wrote: On 02/03/2012 01:36 AM, Avi Kivity wrote: On 02/02/2012 07:27 PM, Xiao Guangrong wrote: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com 'perf kvm-events' will use kvm_exit and kvm_mmio(read...) to

Re: [PATCH v2 2/3] KVM: x86: add tracepoints to trace mmio begin and complete

2012-02-02 Thread Xiao Guangrong
On 02/03/2012 02:27 AM, Xiao Guangrong wrote: On 02/03/2012 01:56 AM, Avi Kivity wrote: On 02/02/2012 07:55 PM, Xiao Guangrong wrote: On 02/03/2012 01:36 AM, Avi Kivity wrote: On 02/02/2012 07:27 PM, Xiao Guangrong wrote: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com 'perf

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread John Fastabend
On 2/2/2012 10:07 AM, Roopa Prabhu wrote: On 2/2/12 12:46 AM, John Fastabend john.r.fastab...@intel.com wrote: On 2/1/2012 11:24 PM, Michael S. Tsirkin wrote: On Sun, Nov 20, 2011 at 08:30:24AM -0800, Roopa Prabhu wrote: On 11/17/11 4:15 PM, Ben Hutchings bhutchi...@solarflare.com

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread Ben Hutchings
On Thu, 2012-02-02 at 00:46 -0800, John Fastabend wrote: [...] OK finally got to read through this. And its not clear to me why we need these per VF/PF filter netdevice ops and netlink extensions if we can get the stacking correct. (Adding filters to the macvlan seems reasonable to me) In

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread John Fastabend
On 2/2/2012 12:38 PM, Ben Hutchings wrote: On Thu, 2012-02-02 at 00:46 -0800, John Fastabend wrote: [...] OK finally got to read through this. And its not clear to me why we need these per VF/PF filter netdevice ops and netlink extensions if we can get the stacking correct. (Adding filters to

windows PIO question

2012-02-02 Thread Nikola Ciprich
Hello everybody, I'm a bit confused regarding windows guests and PIO.. some time ago, I was trying to find out, why one of my windows guests was running terribly slow. After checking the trace-cmd output, Avi stated that windows were using PIO instead of DMA, after changing that, windows indeed

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-02 Thread Rob Earhart
(Resending as plain text to appease vger.kernel.org :-) On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivity a...@redhat.com wrote: The kvm api has been accumulating cruft for several years now.  This is due to feature creep, fixing mistakes, experience gained by the maintainers and developers on how

Re: linux-next: Tree for Feb 2 (kvmtool)

2012-02-02 Thread Randy Dunlap
On 02/01/2012 07:45 PM, Stephen Rothwell wrote: Hi all, Changes since 20120201: On some randconfig i386 builds, I am seeing this: warning: (KVMTOOL_TEST_ENABLE AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI ARCH_SUPPORTS_MSI) because ARCH_SUPPORTS_MSI needs both

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-02 Thread Anthony Liguori
On 02/02/2012 10:09 AM, Avi Kivity wrote: The kvm api has been accumulating cruft for several years now. This is due to feature creep, fixing mistakes, experience gained by the maintainers and developers on how to do things, ports to new architectures, and simply as a side effect of a code base

Biweekly KVM Test report, kernel e27aad2f... qemu 2793248c...

2012-02-02 Thread Ren, Yongjie
Hi All, This is KVM upstream test result against kvm.git e27aad2f39d85009e8b6ce8f58b9809b22083c23 based on kernel 3.3.0, and qemu-kvm.git 2793248c5427c0bc585fdf9c101680bab29f4839. We found 2 bugs got fixed during the past two weeks. New issue(0): Fixed issues (2): 1. rhel5u5 guest panic when