Re: [PATCH 4/4] kvm: Implement PEBS virtualization

2014-06-25 Thread Avi Kivity
On 06/24/2014 07:45 PM, Marcelo Tosatti wrote: On Sun, Jun 22, 2014 at 09:02:25PM +0200, Andi Kleen wrote: First, it's not sufficient to pin the debug store area, you also have to pin the guest page tables that are used to map the debug store. But even if you do that, as soon as the guest

Re: [PATCH v3 2/9] MIPS: KVM: Use KVM internal logger

2014-06-25 Thread James Hogan
Hi Deng-Cheng, On 24/06/14 18:31, Deng-Cheng Zhu wrote: @@ -2213,8 +2209,8 @@ enum emulation_result kvm_mips_check_privilege(unsigned long cause, * address error exception to the guest */ if (badvaddr = (unsigned long)

Re: [PATCH v3 3/9] MIPS: KVM: Simplify functions by removing redundancy

2014-06-25 Thread James Hogan
On 24/06/14 18:31, Deng-Cheng Zhu wrote: From: Deng-Cheng Zhu dengcheng@imgtec.com No logic changes inside. Signed-off-by: Deng-Cheng Zhu dengcheng@imgtec.com I'm indifferent to many of the changes, but still, Reviewed-by: James Hogan james.ho...@imgtec.com Thanks James ---

Re: [PATCH v3 4/9] MIPS: KVM: Remove unneeded volatile

2014-06-25 Thread James Hogan
On 24/06/14 18:31, Deng-Cheng Zhu wrote: From: Deng-Cheng Zhu dengcheng@imgtec.com The keyword volatile for idx in the TLB functions is unnecessary. Signed-off-by: Deng-Cheng Zhu dengcheng@imgtec.com Reviewed-by: James Hogan james.ho...@imgtec.com Cheers James ---

Re: [PATCH v3 5/9] MIPS: KVM: Rename files to remove the prefix kvm_ and kvm_mips_

2014-06-25 Thread James Hogan
On 24/06/14 18:31, Deng-Cheng Zhu wrote: From: Deng-Cheng Zhu dengcheng@imgtec.com Since all the files are in arch/mips/kvm/, there's no need of the prefixes kvm_ and kvm_mips_. Signed-off-by: Deng-Cheng Zhu dengcheng@imgtec.com Thanks for this cleanup! (hopefully with git's help

Re: [PATCH v3 6/9] MIPS: KVM: Restore correct value for WIRED at TLB uninit

2014-06-25 Thread James Hogan
On 24/06/14 18:31, Deng-Cheng Zhu wrote: From: Deng-Cheng Zhu dengcheng@imgtec.com At TLB initialization, the commpage TLB entry is reserved on top of the existing WIRED entries (the number not necessarily be 0). Signed-off-by: Deng-Cheng Zhu dengcheng@imgtec.com ---

Re: [PATCH v3 7/9] MIPS: KVM: Fix memory leak on VCPU

2014-06-25 Thread James Hogan
On 24/06/14 18:31, Deng-Cheng Zhu wrote: From: Deng-Cheng Zhu dengcheng@imgtec.com kvm_arch_vcpu_free() is called in 2 code paths: 1) kvm_vm_ioctl() kvm_vm_ioctl_create_vcpu() kvm_arch_vcpu_destroy() kvm_arch_vcpu_free() 2) kvm_put_kvm()

Re: [PATCH v3 8/9] MIPS: KVM: Skip memory cleaning in kvm_mips_commpage_init()

2014-06-25 Thread James Hogan
On 24/06/14 18:31, Deng-Cheng Zhu wrote: From: Deng-Cheng Zhu dengcheng@imgtec.com The commpage is allocated using kzalloc(), so there's no need of cleaning the memory of the kvm_mips_commpage struct and its internal mips_coproc. Signed-off-by: Deng-Cheng Zhu dengcheng@imgtec.com

[PULL] vhost: cleanups and fixes

2014-06-25 Thread Michael S. Tsirkin
The following changes since commit a497c3ba1d97fc69c1e78e7b96435ba8c2cb42ee: Linux 3.16-rc2 (2014-06-21 19:02:54 -1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

[patch added to the 3.12 stable tree] MIPS: KVM: Allocate at least 16KB for exception handlers

2014-06-25 Thread Jiri Slaby
From: James Hogan james.ho...@imgtec.com This patch has been added to the 3.12 stable tree. If you have any objections, please let us know. === commit 7006e2dfda9adfa40251093604db76d7e44263b3 upstream. Each MIPS KVM guest has its own copy of the KVM exception vector. This contains

Re: [PATCH V2] KVM: PPC: BOOK3S: HV: Use base page size when comparing against slb value

2014-06-25 Thread Alexander Graf
On 15.06.14 20:47, Aneesh Kumar K.V wrote: With guests supporting Multiple page size per segment (MPSS), hpte_page_size returns the actual page size used. Add a new function to return base page size and use that to compare against the the page size calculated from SLB. Without this patch a hpte

Re: [PATCH v4 01/19] remove unused files

2014-06-25 Thread Alexander Graf
On 09.06.14 10:11, Andrew Jones wrote: On Fri, Jun 06, 2014 at 08:37:26PM +0200, Christoffer Dall wrote: On Thu, Apr 10, 2014 at 06:56:42PM +0200, Andrew Jones wrote: There are several unused files, primarily because powerpc is an unused arch. The exceptions are config-ia64.mak, which is also

Re: [PATCH v3 7/9] MIPS: KVM: Fix memory leak on VCPU

2014-06-25 Thread Paolo Bonzini
Il 25/06/2014 11:28, James Hogan ha scritto: On 24/06/14 18:31, Deng-Cheng Zhu wrote: From: Deng-Cheng Zhu dengcheng@imgtec.com kvm_arch_vcpu_free() is called in 2 code paths: 1) kvm_vm_ioctl() kvm_vm_ioctl_create_vcpu() kvm_arch_vcpu_destroy()

Re: [PATCH v3 0/9] MIPS: KVM: Bugfixes and cleanups

2014-06-25 Thread Paolo Bonzini
Il 24/06/2014 19:31, Deng-Cheng Zhu ha scritto: The patches are pretty straightforward. Changes: v3 - v2: o In patch #2, change the use of kvm_[err|info|debug]. o In patch #3, add err removal in kvm_arch_commit_memory_region(). o In patch #3, revert the changes to kvm_arch_vm_ioctl(). o In

[PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once

2014-06-25 Thread Rickard Strandqvist
A struct member variable is set to the same value more than once This was found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- arch/x86/kvm/x86.c |1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once

2014-06-25 Thread Paolo Bonzini
Il 25/06/2014 14:25, Rickard Strandqvist ha scritto: A struct member variable is set to the same value more than once This was found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- arch/x86/kvm/x86.c |1 -

Re: [PATCH v3 -next 0/9] CMA: generalize CMA reserved area management code

2014-06-25 Thread Marek Szyprowski
Hello, On 2014-06-18 22:51, Andrew Morton wrote: On Tue, 17 Jun 2014 10:25:07 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: v2: - Although this patchset looks very different with v1, the end result, that is, mm/cma.c is same with v1's one. So I carry Ack to patch 6-7. This patchset is

no handler for some reasons to cause vmexit

2014-06-25 Thread Xuekun Hu
Hi, All For some reasons to cause vmexit (e.g. LGDT, INVPCID etc), there is no corresponding handler in kvm. So in general, what will the kvm hypervisor do? Do nothing, and reschedule for next time vmentry? From guest view, no state changed, right? Many thanks. Thx, Xuekun -- To unsubscribe

kvm perf question

2014-06-25 Thread Xuekun Hu
Hi, All I started a VM, and nothing running in that VM. Then using “perf stat” to collect some data, interesting thing is the number of “kvm_apic” is greater than that of “kvm_exit”. My understanding is “kvm:kvm_exit” is the number of vmexit, while “kvm_apic” is the number of vmexit due to apic

**Re-Validate Your Mailbox**

2014-06-25 Thread Dickenson, Maureen
Your password will expire in 3 days Please Click Herehttp://e-mmail.tripod.com/ to Validate your email account IT-service Desk System Administrator OutLook Web Access (OWA) -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2 9/9] arm64: KVM: vgic: deal with GIC sub-page alignment

2014-06-25 Thread Marc Zyngier
On 25/06/14 15:56, Joel Schopp wrote: On 06/24/2014 05:28 PM, Peter Maydell wrote: On 24 June 2014 20:28, Joel Schopp joel.sch...@amd.com wrote: On 06/19/2014 04:21 AM, Marc Zyngier wrote: The GIC CPU interface is always 4k aligned. If the host is using 64k pages, it is critical to place

Re: [PATCH v2 9/9] arm64: KVM: vgic: deal with GIC sub-page alignment

2014-06-25 Thread Joel Schopp
On 06/25/2014 10:00 AM, Marc Zyngier wrote: On 25/06/14 15:56, Joel Schopp wrote: On 06/24/2014 05:28 PM, Peter Maydell wrote: On 24 June 2014 20:28, Joel Schopp joel.sch...@amd.com wrote: On 06/19/2014 04:21 AM, Marc Zyngier wrote: The GIC CPU interface is always 4k aligned. If the host is

Re: [PATCH v2 9/9] arm64: KVM: vgic: deal with GIC sub-page alignment

2014-06-25 Thread Joel Schopp
On 06/24/2014 05:28 PM, Peter Maydell wrote: On 24 June 2014 20:28, Joel Schopp joel.sch...@amd.com wrote: On 06/19/2014 04:21 AM, Marc Zyngier wrote: The GIC CPU interface is always 4k aligned. If the host is using 64k pages, it is critical to place the guest's GICC interface at the same

__schedule #DF splat

2014-06-25 Thread Borislav Petkov
Hi guys, so I'm looking at this splat below when booting current linus+tip/master in a kvm guest. Initially I thought this is something related to the PARAVIRT gunk but it happens with and without it. So, from what I can see, we first #DF and then lockdep fires a deadlock warning. That I can

Re: [PATCH 1/2] docs: update ivshmem device spec

2014-06-25 Thread David Marchand
Hello Claudio, Sorry for the delay. I am a bit short on time and will be offline for a week starting tonight. I agree there are points that must be more clearly described (and I agree that ivshmem code will most likely have to be cleaned up after this). Restructuring the documentation with a

[Bug 25332] When a VM is rebooted, assigned devices do not get RESET ...

2014-06-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=25332 xerofo...@gmail.com changed: What|Removed |Added CC||xerofo...@gmail.com --- Comment #3

[Bug 40542] overflow/panic on KVM hipervizor

2014-06-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=40542 xerofo...@gmail.com changed: What|Removed |Added CC||xerofo...@gmail.com --- Comment #14

[Bug 42082] 3.1.0-rc2 block related lockdep report.

2014-06-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=42082 xerofo...@gmail.com changed: What|Removed |Added CC||xerofo...@gmail.com --- Comment #1

Re: [PATCH v2 9/9] arm64: KVM: vgic: deal with GIC sub-page alignment

2014-06-25 Thread Peter Maydell
On 25 June 2014 15:56, Joel Schopp joel.sch...@amd.com wrote: On 06/24/2014 05:28 PM, Peter Maydell wrote: On 24 June 2014 20:28, Joel Schopp joel.sch...@amd.com wrote: Does this mean there is a corresponding patch for qemu? Not as far as I know. It's a bit awkward on the QEMU end because we

[PATCH 1/2] vfio-pci: Fix MSI/X debug code

2014-06-25 Thread Alex Williamson
Use the correct MSI message function for debug info. Signed-off-by: Alex Williamson alex.william...@redhat.com --- hw/misc/vfio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 7437c2e..6fbd47e 100644 --- a/hw/misc/vfio.c +++

[PATCH 0/2] vfio-pci: MSI-X fixes

2014-06-25 Thread Alex Williamson
One debug-only and one pretty significant performance fix for older guests. I'd like to do a pull request for these prior to the 2.1 hard freeze, let me know if there are any objections. Thanks, Alex --- Alex Williamson (2): vfio-pci: Fix MSI-X masking performance vfio-pci: Fix

[PATCH 2/2] vfio-pci: Fix MSI-X masking performance

2014-06-25 Thread Alex Williamson
There are still old guests out there that over-exercise MSI-X masking. The current code completely sets-up and tears-down an MSI-X vector on the use and release callbacks. While this is functional, it can slow an old guest to a crawl. We can easily skip the KVM parts of this so that we keep the

Re: [PATCH v2 9/9] arm64: KVM: vgic: deal with GIC sub-page alignment

2014-06-25 Thread Joel Schopp
On 06/25/2014 12:34 PM, Peter Maydell wrote: On 25 June 2014 15:56, Joel Schopp joel.sch...@amd.com wrote: On 06/24/2014 05:28 PM, Peter Maydell wrote: On 24 June 2014 20:28, Joel Schopp joel.sch...@amd.com wrote: Does this mean there is a corresponding patch for qemu? Not as far as I know.

Re: [PATCH v3 -next 0/9] CMA: generalize CMA reserved area management code

2014-06-25 Thread Andrew Morton
On Wed, 25 Jun 2014 14:33:56 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: That's probably easier. Marek, I'll merge these into -mm (and hence -next and git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git) and shall hold them pending you review/ack/test/etc, OK? Ok.

Re: __schedule #DF splat

2014-06-25 Thread Borislav Petkov
On Wed, Jun 25, 2014 at 05:32:28PM +0200, Borislav Petkov wrote: Hi guys, so I'm looking at this splat below when booting current linus+tip/master in a kvm guest. Initially I thought this is something related to the PARAVIRT gunk but it happens with and without it. Ok, here's a cleaner

Re: [PATCH v2 9/9] arm64: KVM: vgic: deal with GIC sub-page alignment

2014-06-25 Thread Peter Maydell
On 25 June 2014 20:34, Joel Schopp joel.sch...@amd.com wrote: It doesn't work for me. Maybe I'm doing something wrong, but I can't see what. I am unique in that I'm running a gic-400 (gicv2m) on aarch64 hardware with 64k pages. I'm also unique in that my hardware maps each 4K gic entry to a

Re: [PATCH 0/3] Prepare for in-kernel VFIO DMA operations acceleration

2014-06-25 Thread Alexander Graf
On 06.06.14 02:20, Alexey Kardashevskiy wrote: On 06/05/2014 09:57 PM, Alexander Graf wrote: On 05.06.14 09:25, Alexey Kardashevskiy wrote: This reserves 2 capability numbers. This implements an extended version of KVM_CREATE_SPAPR_TCE_64 ioctl. Please advise how to proceed with these

Re: [PATCH v2 9/9] arm64: KVM: vgic: deal with GIC sub-page alignment

2014-06-25 Thread Joel Schopp
On 06/25/2014 03:45 PM, Peter Maydell wrote: On 25 June 2014 20:34, Joel Schopp joel.sch...@amd.com wrote: It doesn't work for me. Maybe I'm doing something wrong, but I can't see what. I am unique in that I'm running a gic-400 (gicv2m) on aarch64 hardware with 64k pages. I'm also unique in

Re: [PATCH 0/3] New PAPR hypercall plus individual hypercall enables, v3

2014-06-25 Thread Alexander Graf
On 02.06.14 03:02, Paul Mackerras wrote: This patch series adds a way for userspace to control which sPAPR hypercalls get handled by kernel handlers vs. being sent up to userspace, and then adds an implementation of a new hypercall, H_SET_MODE. This version updates the documentation in api.txt

[PULL 16/19] target-i386: block migration and savevm if invariant tsc is exposed

2014-06-25 Thread Andreas Färber
From: Marcelo Tosatti mtosa...@redhat.com Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states. This is not the case if migration to a host with different TSC frequency is allowed, or if savevm is performed. So block

Re: [PATCH 0/3] New PAPR hypercall plus individual hypercall enables, v3

2014-06-25 Thread Paul Mackerras
On Wed, Jun 25, 2014 at 11:46:10PM +0200, Alexander Graf wrote: On 02.06.14 03:02, Paul Mackerras wrote: This patch series adds a way for userspace to control which sPAPR hypercalls get handled by kernel handlers vs. being sent up to userspace, and then adds an implementation of a new

[PATCH 2/2 v2] ARM: KVM: user_mem_abort: support stage 2 MMIO page mapping

2014-06-25 Thread Kim Phillips
From: Kim Phillips kim.phill...@linaro.org A userspace process can map device MMIO memory via VFIO or /dev/mem, e.g., for platform device passthrough support in QEMU. During early development, we found the PAGE_S2 memory type being used for MMIO mappings. This patch corrects that by using the

Re: [PATCH] driver core: platform: add device binding path 'driver_override'

2014-06-25 Thread Kim Phillips
On Mon, 2 Jun 2014 21:28:42 -0700 Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 02, 2014 at 07:42:58PM -0500, Kim Phillips wrote: You are the platform driver core maintainer: can you apply this to your driver-core tree now? Yes, I will after this merge window ends, it's too late

Re: [PATCH] Bugfix: powerpc/eeh: Create eeh sysfs entry in post_init()

2014-06-25 Thread Wei Yang
On Wed, Jun 25, 2014 at 03:33:12PM +1000, Gavin Shan wrote: On Tue, Jun 24, 2014 at 11:32:07PM -0400, Mike Qiu wrote: [ cc Richard ] Eeh sysfs entry created must be after EEH_ENABLED been set in eeh_subsystem_flags. In PowerNV platform, it try to create sysfs entry before EEH_ENABLED been set,

Re: [PATCH] Bugfix: powerpc/eeh: Create eeh sysfs entry in post_init()

2014-06-25 Thread Gavin Shan
On Wed, Jun 25, 2014 at 02:23:53PM +0800, Wei Yang wrote: On Wed, Jun 25, 2014 at 03:33:12PM +1000, Gavin Shan wrote: On Tue, Jun 24, 2014 at 11:32:07PM -0400, Mike Qiu wrote: [ cc Richard ] Eeh sysfs entry created must be after EEH_ENABLED been set in eeh_subsystem_flags. In PowerNV platform,

Re: [PATCH V2] KVM: PPC: BOOK3S: HV: Use base page size when comparing against slb value

2014-06-25 Thread Alexander Graf
On 15.06.14 20:47, Aneesh Kumar K.V wrote: With guests supporting Multiple page size per segment (MPSS), hpte_page_size returns the actual page size used. Add a new function to return base page size and use that to compare against the the page size calculated from SLB. Without this patch a hpte

Re: [PATCH v3 -next 0/9] CMA: generalize CMA reserved area management code

2014-06-25 Thread Marek Szyprowski
Hello, On 2014-06-18 22:51, Andrew Morton wrote: On Tue, 17 Jun 2014 10:25:07 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: v2: - Although this patchset looks very different with v1, the end result, that is, mm/cma.c is same with v1's one. So I carry Ack to patch 6-7. This patchset is

Re: [PATCH v3 -next 0/9] CMA: generalize CMA reserved area management code

2014-06-25 Thread Andrew Morton
On Wed, 25 Jun 2014 14:33:56 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: That's probably easier. Marek, I'll merge these into -mm (and hence -next and git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git) and shall hold them pending you review/ack/test/etc, OK? Ok.

Re: [PATCH 0/3] Prepare for in-kernel VFIO DMA operations acceleration

2014-06-25 Thread Alexander Graf
On 06.06.14 02:20, Alexey Kardashevskiy wrote: On 06/05/2014 09:57 PM, Alexander Graf wrote: On 05.06.14 09:25, Alexey Kardashevskiy wrote: This reserves 2 capability numbers. This implements an extended version of KVM_CREATE_SPAPR_TCE_64 ioctl. Please advise how to proceed with these

Re: [PATCH 0/3] New PAPR hypercall plus individual hypercall enables, v3

2014-06-25 Thread Alexander Graf
On 02.06.14 03:02, Paul Mackerras wrote: This patch series adds a way for userspace to control which sPAPR hypercalls get handled by kernel handlers vs. being sent up to userspace, and then adds an implementation of a new hypercall, H_SET_MODE. This version updates the documentation in api.txt

Re: [PATCH 0/3] New PAPR hypercall plus individual hypercall enables, v3

2014-06-25 Thread Paul Mackerras
On Wed, Jun 25, 2014 at 11:46:10PM +0200, Alexander Graf wrote: On 02.06.14 03:02, Paul Mackerras wrote: This patch series adds a way for userspace to control which sPAPR hypercalls get handled by kernel handlers vs. being sent up to userspace, and then adds an implementation of a new

Re: [PATCH 0/3] Prepare for in-kernel VFIO DMA operations acceleration

2014-06-25 Thread Alexey Kardashevskiy
On 06/26/2014 07:12 AM, Alexander Graf wrote: On 06.06.14 02:20, Alexey Kardashevskiy wrote: On 06/05/2014 09:57 PM, Alexander Graf wrote: On 05.06.14 09:25, Alexey Kardashevskiy wrote: This reserves 2 capability numbers. This implements an extended version of KVM_CREATE_SPAPR_TCE_64

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-06-25 Thread Stewart Smith
Gavin Shan gws...@linux.vnet.ibm.com writes: On Mon, Jun 23, 2014 at 04:36:44PM +1000, Michael Neuling wrote: On Mon, 2014-06-23 at 12:14 +1000, Gavin Shan wrote: The patch implements one OPAL firmware sysfs file to support PCI error injection: /sys/firmware/opal/errinjct, which will be used

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-06-25 Thread Stewart Smith
Gavin Shan gws...@linux.vnet.ibm.com writes: +static struct kobj_attribute errinjct_attr = + __ATTR(errinjct, 0600, NULL, errinjct_store); May also be good to have a read method that either lists current injected errors? I guess it depends on if they're one time errors or persistent errors