NoWrite instructions (e.g. cmp or test) never set the write access
bit in the error code, even if one of the operands is treated as a
destination.
Fixes: c205fb7d7d4f81e46fc577b707ceb9e356af1456
Cc: Nadav Amit na...@cs.technion.ac.il
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
On 09/02/2015 09:22, Xiao Guangrong wrote:
On 02/06/2015 08:48 PM, Paolo Bonzini wrote:
+unsigned int halt_poll_ns = 0;
+module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
+
Can we make this parameter be changeable? So that we can tune it
on the fly.
It is changeable (S_IWUSR).
On 02/09/2015 02:44 AM, Jeremy Fitzhardinge wrote:
On 02/06/2015 06:49 AM, Raghavendra K T wrote:
[...]
Linus suggested that we should not do any writes to lock after unlock(),
and we can move slowpath clearing to fastpath lock.
Yep, that seems like a sound approach.
Current approach
On 02/09, Raghavendra K T wrote:
+static inline void __ticket_check_and_clear_slowpath(arch_spinlock_t *lock)
+{
+ arch_spinlock_t old, new;
+ __ticket_t diff;
+
+ old.tickets = READ_ONCE(lock-tickets);
+ diff = (old.tickets.tail ~TICKET_SLOWPATH_FLAG) - old.tickets.head;
From: Rik van Riel r...@redhat.com
Only run vtime_user_enter, vtime_user_exit, and the user enter exit
trace points when we are entering or exiting user state, respectively.
The RCU code only distinguishes between idle and not idle or kernel.
There should be no need to add an additional
From: Rik van Riel r...@redhat.com
Export context_tracking_user_enter/exit so it can be used by KVM.
Signed-off-by: Rik van Riel r...@redhat.com
---
kernel/context_tracking.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
index
From: Rik van Riel r...@redhat.com
Rename context_tracking_user_enter context_tracking_user_exit
to just context_tracking_enter context_tracking_exit, since it
will be used to track guest state, too.
This also breaks ARM. The rest of the series does not look like
it impacts ARM.
Cc:
From: Rik van Riel r...@redhat.com
Add the expected ctx_state as a parameter to context_tracking_user_enter
and context_tracking_user_exit, allowing the same functions to not just
track kernel user space switching, but also kernel guest transitions.
Catalin, Will: this patch and the next one
From: Rik van Riel r...@redhat.com
With code elsewhere doing something conditional on whether or not
context tracking is enabled, we want a stub function that tells us
context tracking is not enabled, when CONFIG_CONTEXT_TRACKING is
not set.
Signed-off-by: Rik van Riel r...@redhat.com
---
2015-02-06 17:30+, Andre Przywara:
As kvm_run is a member of kvm_vcpu, the vcpu alone should be sufficient,
right?
Yes.
Also I see the very top of the call chain is effectively:
kvm_arch_vcpu_ioctl_run(vcpu, vcpu-run);
:(
So is that just legacy code still lingering around from the
2015-02-06 13:48+0100, Paolo Bonzini:
[...]
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Reviewed-by: Radim Krčmář rkrc...@redhat.com
Noticed changes since RFC:
- polling is used in more situations
- new tracepoint
- module parameter in nanoseconds
- properly handled time
- no
On 09/02/2015 17:04, r...@redhat.com wrote:
From: Rik van Riel r...@redhat.com
With code elsewhere doing something conditional on whether or not
context tracking is enabled, we want a stub function that tells us
context tracking is not enabled, when CONFIG_CONTEXT_TRACKING is
not set.
On 09/02/2015 17:21, Radim Krčmář wrote:
So is that just legacy code still lingering around from the dawn of time
and nobody dared to rework this or is there a particular reason for
doing so?
Probably laziness in 9a2bb7f486dc639a1cf2ad803bf2227f0dc0809d.
Or microoptimization. Laziness
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/07/2015 03:06 PM, Paul E. McKenney wrote:
On Sat, Feb 07, 2015 at 09:30:41AM +0100, Frederic Weisbecker
wrote:
On Fri, Feb 06, 2015 at 11:14:53PM -0800, Paul E. McKenney
wrote:
On Fri, Feb 06, 2015 at 10:34:21PM -0800, Paul E. McKenney
From: Rik van Riel r...@redhat.com
The host kernel is not doing anything while the CPU is executing
a KVM guest VCPU, so it can be marked as being in an extended
quiescent state, identical to that used when running user space
code.
The only exception to that rule is when the host handles an
On 09/02/2015 17:04, r...@redhat.com wrote:
From: Rik van Riel r...@redhat.com
Export context_tracking_user_enter/exit so it can be used by KVM.
Wrong function name in the commit message...
Paolo
Signed-off-by: Rik van Riel r...@redhat.com
---
kernel/context_tracking.c | 2 ++
1 file
On 09/02/2015 16:21, Radim Krčmář wrote:
2015-02-06 13:48+0100, Paolo Bonzini:
[...]
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Reviewed-by: Radim Krčmář rkrc...@redhat.com
Noticed changes since RFC:
- polling is used in more situations
- new tracepoint
- module
Ccing Davidlohr, (sorry that I got confused with similar address in cc
list).
On 02/09/2015 08:44 PM, Oleg Nesterov wrote:
On 02/09, Raghavendra K T wrote:
+static inline void __ticket_check_and_clear_slowpath(arch_spinlock_t *lock)
+{
+ arch_spinlock_t old, new;
+ __ticket_t
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/09/2015 08:15 PM, Will Deacon wrote:
Hi Rik,
On Mon, Feb 09, 2015 at 04:04:38PM +, r...@redhat.com wrote:
Apologies to Catalin and Will for not fixing up ARM. I am not
familiar with ARM assembly, and not sure how to pass a constant
On Tue, Feb 10, 2015 at 02:44:17AM +0100, Frederic Weisbecker wrote:
On Mon, Feb 09, 2015 at 08:22:59PM -0500, Rik van Riel wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/09/2015 08:15 PM, Will Deacon wrote:
Hi Rik,
On Mon, Feb 09, 2015 at 04:04:38PM +,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/09/2015 10:01 PM, Paul E. McKenney wrote:
On Tue, Feb 10, 2015 at 02:44:17AM +0100, Frederic Weisbecker
wrote:
On Mon, Feb 09, 2015 at 08:22:59PM -0500, Rik van Riel wrote:
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1
On 02/09/2015 08:15
On 09/02/2015 15:37, Chris J Arges wrote:
Why do you need that? If you are disabling something if you are on a
virtualized platform, then that is most of the time (and I am not saying
always only because of things like microcode.service) wrong.
A use-case is disabling KSM if running
When running a KVM guest on a system with NOHZ_FULL enabled, and the
KVM guest running with idle=poll mode, we still get wakeups of the
rcuos/N threads.
This problem has already been solved for user space by telling the
RCU subsystem that the CPU is in an extended quiescent state while
running
On Fri, Feb 6, 2015 at 4:48 AM, Paolo Bonzini pbonz...@redhat.com wrote:
This patch introduces a new module parameter for the KVM module; when it
is present, KVM attempts a bit of polling on every HLT before scheduling
itself out via kvm_vcpu_block.
[...]
Signed-off-by: Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/09/2015 12:05 PM, Paolo Bonzini wrote:
On 09/02/2015 17:04, r...@redhat.com wrote:
From: Rik van Riel r...@redhat.com
Export context_tracking_user_enter/exit so it can be used by
KVM.
Wrong function name in the commit message...
On 02/06/2015 08:48 PM, Paolo Bonzini wrote:
+unsigned int halt_poll_ns = 0;
+module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
+
Can we make this parameter be changeable? So that we can tune it
on the fly.
finish_wait(vcpu-wq, wait);
+ cur = ktime_get();
We can move
On 2015-01-28 16:43, Jan Kiszka wrote:
On 2015-01-28 16:36, Alex Williamson wrote:
On Wed, 2015-01-28 at 16:02 +0100, Jan Kiszka wrote:
Hi Alex,
before getting dirty fingers in vain: what is the current status of
handing an IGD GPU to a KVM guest, specifically Windows? I found some
related
On 09/02/2015 22:00, Christian Borntraeger wrote:
I can confirm that this also helps uperf with a 1/1 byte round trip work load
between guests on s390. And I can confirm the higher CPU load. This is
normally
a no-go for the typical s390 users, which utilize their systems as much as
Radim, Paolo,
On 09/02/15 16:26, Paolo Bonzini wrote:
On 09/02/2015 17:21, Radim Krčmář wrote:
So is that just legacy code still lingering around from the dawn of time
and nobody dared to rework this or is there a particular reason for
doing so?
Probably laziness in
Building with the attached random configuration file,
arch/x86/kvm/vmx.c: In function ‘vmx_deliver_nested_posted_interrupt’:
arch/x86/kvm/vmx.c:4378:4: error: ‘apic’ undeclared (first use in this function)
apic-send_IPI_mask(get_cpu_mask(vcpu-cpu),
^
arch/x86/kvm/vmx.c:4378:4: note: each
Thanks for the pointer I'll try it out.
- mario
On 02/06/2015 07:57 AM, Paolo Bonzini wrote:
On 06/02/2015 02:18, Mario Smarduch wrote:
Hi,
I'm looking into qemu/balloon driver VM overcommit. I noticed
virtio-balloon driver will take any setting from virtio-balloon-device
to the point
2015-02-09 17:10+0100, Paolo Bonzini:
On 09/02/2015 16:21, Radim Krčmář wrote:
2015-02-06 13:48+0100, Paolo Bonzini:
+TRACE_EVENT(kvm_vcpu_wakeup,
+ TP_PROTO(__u64 ns, bool waited),
(__u64 is preferred here?)
Preferred to what?
To 'u64'. (The header file shouldn't be
On Mon, Feb 9, 2015 at 4:02 AM, Peter Zijlstra pet...@infradead.org wrote:
On Mon, Feb 09, 2015 at 03:04:22PM +0530, Raghavendra K T wrote:
So we have 3 choices,
1. xadd
2. continue with current approach.
3. a read before unlock and also after that.
For the truly paranoid we have
Hi Rik,
On Mon, Feb 09, 2015 at 04:04:38PM +, r...@redhat.com wrote:
Apologies to Catalin and Will for not fixing up ARM. I am not
familiar with ARM assembly, and not sure how to pass a constant
argument to a function from assembly code on ARM :)
It's a bit of a faff getting enum values
Am 06.02.2015 um 13:48 schrieb Paolo Bonzini:
This patch introduces a new module parameter for the KVM module; when it
is present, KVM attempts a bit of polling on every HLT before scheduling
itself out via kvm_vcpu_block.
This parameter helps a lot for latency-bound workloads---in
On 02/09/2015 05:06 PM, Paolo Bonzini wrote:
On 09/02/2015 09:22, Xiao Guangrong wrote:
On 02/06/2015 08:48 PM, Paolo Bonzini wrote:
+unsigned int halt_poll_ns = 0;
+module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
+
Can we make this parameter be changeable? So that we can tune
On Mon, Feb 09, 2015 at 03:04:22PM +0530, Raghavendra K T wrote:
So we have 3 choices,
1. xadd
2. continue with current approach.
3. a read before unlock and also after that.
For the truly paranoid we have probe_kernel_address(), suppose the lock
was in module space and the module just got
2015-02-09 10:46-0700, Jim Davis:
Building with the attached random configuration file,
Thank you for catching it!
arch/x86/kvm/vmx.c: In function ‘vmx_deliver_nested_posted_interrupt’:
arch/x86/kvm/vmx.c:4378:4: error: ‘apic’ undeclared (first use in this
function)
On 02/09/2015 05:32 PM, Peter Zijlstra wrote:
On Mon, Feb 09, 2015 at 03:04:22PM +0530, Raghavendra K T wrote:
So we have 3 choices,
1. xadd
2. continue with current approach.
3. a read before unlock and also after that.
For the truly paranoid we have probe_kernel_address(), suppose the lock
Paravirt spinlock clears slowpath flag after doing unlock.
As explained by Linus currently it does:
prev = *lock;
add_smp(lock-tickets.head, TICKET_LOCK_INC);
/* add_smp() is a full mb() */
if (unlikely(lock-tickets.tail
On 06/02/2015 20:40, Jan Kiszka wrote:
On 2015-02-02 10:05, Paolo Bonzini wrote:
On 02/02/2015 08:04, Jan Kiszka wrote:
+#if X86_FEATURE_XSAVEOPT 10 * 32
+#undef X86_FEATURE_XSAVEOPT
+#endif
+#define X86_FEATURE_XSAVEOPT (10*32+0) /* XSAVEOPT instruction */
This causes redefinition
On 06/02/2015 21:08, Chris J Arges wrote:
Is there a architecture and machine type independent way to detect that
one is running inside a KVM guest? I've noticed the following systemd
code which does this detection and it seems to be very architecture
dependent for KVM:
On 2015-02-09 14:17, Paolo Bonzini wrote:
On 06/02/2015 20:40, Jan Kiszka wrote:
On 2015-02-02 10:05, Paolo Bonzini wrote:
On 02/02/2015 08:04, Jan Kiszka wrote:
+#if X86_FEATURE_XSAVEOPT 10 * 32
+#undef X86_FEATURE_XSAVEOPT
+#endif
+#define X86_FEATURE_XSAVEOPT(10*32+0) /*
On 09/02/2015 14:44, Jan Kiszka wrote:
Tested already? If so, please provide it as patch.
Tested but not with APICv, so it's not really worthy except as a compile
check.
Paolo
If not: I can run it later through buildbot here.
--
To unsubscribe from this list: send the line unsubscribe kvm
From: David Hildenbrand d...@linux.vnet.ibm.com
If a vm with no VCPUs is created, the injection of a floating irq
leads to an endless loop in the kernel.
Let's skip the search for a destination VCPU for a floating irq if no
VCPUs were created.
Reviewed-by: Dominik Dingel
From: Tony Krowiak akrow...@linux.vnet.ibm.com
We need to specify a different format for the crypto control block
depending on whether the APXA facility is installed or not. Let's
test for it by executing the PQAP(QCI) function and use either a
format-1 or a format-2 crypto control block
From: Michael Mueller m...@linux.vnet.ibm.com
The patch introduces facilities and cpu_ids per virtual machine.
Different virtual machines may want to expose different facilities and
cpu ids to the guest, so let's make them per-vm instead of global.
Signed-off-by: Michael Mueller
commit 7be81a46695d (KVM: s390/facilities: allow TOD-CLOCK steering
facility bit) accidentially disabled the load program parameter
facility bit during rebase for upstream submission (my fault).
Re-add that bit.
As this is only for a performance measurement helper instruction
(used by KVM
+0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git
tags/kvm-s390-next-20150209
for you to fetch changes up to de8e5d744051568c8aad35c1c2dcf8fd137d10c9:
KVM: Disable compat ioctl for s390 (2015-02-09 12:44:14 +0100
From: Michael Mueller m...@linux.vnet.ibm.com
This patch enables cpu model support in kvm/s390 via the vm attribute
interface.
During KVM initialization, the host properties cpuid, IBC value and the
facility list are stored in the architecture specific cpu model structure.
During vcpu setup,
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
A new architecture extends STSI 3.2.2 with UUID and long names. KVM
will provide the first implementation. This patch adds the additional
data fields (Extended Name and UUID) from the 4KB block returned by
the STSI 3.2.2 command and reflect
We never had a 31bit QEMU/kuli running. We would need to review several
ioctls to check if this creates holes, bugs or whatever to make it work.
Lets just disable compat support for KVM on s390.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Acked-by: Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/06/2015 07:16 AM, Paolo Bonzini wrote:
Rename the old __vcpu_run to vcpu_run, and extract its main logic
to a new function.
The next patch will add a new early-exit condition to __vcpu_run,
avoid extra indentation.
Signed-off-by:
On Fri, Feb 6, 2015 at 4:16 AM, Paolo Bonzini pbonz...@redhat.com wrote:
Rename the old __vcpu_run to vcpu_run, and extract its main logic
to a new function.
The next patch will add a new early-exit condition to __vcpu_run,
avoid extra indentation.
Signed-off-by: Paolo Bonzini
Hi Paolo,
On Wed, Feb 04, 2015 at 05:06:37PM +, James Hogan wrote:
The FPU and DSP are enabled via the CP0 Status CU1 and MX bits by
kvm_mips_set_c0_status() on a guest exit, presumably in case there is
active state that needs saving if pre-emption occurs. However neither of
these bits
On 02/09/2015 07:26 AM, Paolo Bonzini wrote:
On 06/02/2015 21:08, Chris J Arges wrote:
Is there a architecture and machine type independent way to detect that
one is running inside a KVM guest? I've noticed the following systemd
code which does this detection and it seems to be very
On Mon, Feb 09, 2015 at 08:22:59PM -0500, Rik van Riel wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/09/2015 08:15 PM, Will Deacon wrote:
Hi Rik,
On Mon, Feb 09, 2015 at 04:04:38PM +, r...@redhat.com wrote:
Apologies to Catalin and Will for not fixing up ARM. I am
On Mon, Feb 09, 2015 at 10:03:08PM -0500, Rik van Riel wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/09/2015 10:01 PM, Paul E. McKenney wrote:
On Tue, Feb 10, 2015 at 02:44:17AM +0100, Frederic Weisbecker
wrote:
On Mon, Feb 09, 2015 at 08:22:59PM -0500, Rik van Riel wrote:
58 matches
Mail list logo
