[PATCH 0/2] vfio: powerpc/spapr: Deletion of an unnecessary check

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete an unnecessary check before the function call kfree One function call less in tce_iommu_attach_group()

[PATCH 1/2] vfio: powerpc/spapr: Delete an unnecessary check before the function call kfree

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 28 Jun 2015 17:43:48 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH 2/2] vfio: powerpc/spapr: One function call less in tce_iommu_attach_group() after kzalloc() failure

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 28 Jun 2015 17:58:42 +0200 The kfree() function was called even if a previous memory allocation try failed. This implementation detail could be improved by the introduction of another jump label. Signed-off-by: Markus Elfring

Re: [PATCH 0/3] arm: KVM: VFP lazy switch in KVM Host Mode may save upto 98%

2015-06-28 Thread Mario Smarduch
Hi Marc, Christoffer - to clarify - this series may be causing a conflict with the arm64 basic approach, and arm32 exit code touch ups. The intent for this series is more of an RFC or preview, to get some feedback - if this approach is sensible (I guess later applied to arm64 as well if it is).

Re: [PATCH 10/13] KVM: arm64: sync LPI properties and status between guest and KVM

2015-06-28 Thread Christoffer Dall
On Fri, May 29, 2015 at 10:53:26AM +0100, Andre Przywara wrote: The properties and status of the GICv3 LPIs are hold in tables in (guest) memory. To achieve reasonable performance, we cache this data in our own data structures, so we need to sync those two views from time to time. This

Re: [PATCH 02/13] KVM: extend struct kvm_msi to hold a 32-bit device ID

2015-06-28 Thread Christoffer Dall
On Fri, May 29, 2015 at 10:53:18AM +0100, Andre Przywara wrote: The ARM GICv3 ITS MSI controller requires a device ID to be able to assign the proper interrupt vector. On real hardware, this ID is sampled from the bus. To be able to emulate an ITS controller, extend the KVM MSI interface to

Re: [PATCH 07/13] KVM: arm64: implement basic ITS register handlers

2015-06-28 Thread Christoffer Dall
On Fri, May 29, 2015 at 10:53:23AM +0100, Andre Przywara wrote: Add emulation for some basic MMIO registers used in the ITS emulation. This includes: - GITS_{CTLR,TYPER,IIDR} - ID registers - GITS_{CBASER,CREAD,CWRITER} those implement the ITS command buffer handling Signed-off-by:

Re: [PATCH 11/13] KVM: arm64: implement ITS command queue command handlers

2015-06-28 Thread Christoffer Dall
On Fri, May 29, 2015 at 10:53:27AM +0100, Andre Przywara wrote: The connection between a device, an event ID, the LPI number and the allocated CPU is stored in in-memory tables in a GICv3, but their format is not specified by the spec. Instead software uses a command queue to let the ITS

Re: [PATCH 03/13] KVM: arm/arm64: add emulation model specific destroy function

2015-06-28 Thread Christoffer Dall
On Fri, May 29, 2015 at 10:53:19AM +0100, Andre Przywara wrote: Currently we destroy the VGIC emulation in one function that cares for all emulated models. The ITS emulation will require some differentiation, so introduce a per-emulation-model destroy method. why do we need to differentiate

Re: [PATCH 2/2] vfio: powerpc/spapr: One function call less in tce_iommu_attach_group() after kzalloc() failure

2015-06-28 Thread Alexey Kardashevskiy
On 06/29/2015 02:24 AM, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 28 Jun 2015 17:58:42 +0200 The kfree() function was called even if a previous memory allocation try failed. tcegrp will be NULL and kfree() can handle this just fine (is not it the