MSI-X not enabled for ixgbe device-passthrough

2010-03-24 Thread Hannes Reinecke
Kernel modules: ixgbe please let me know if you need more information. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg

Re: MSI-X not enabled for ixgbe device-passthrough

2010-03-25 Thread Hannes Reinecke
Sheng Yang wrote: On Wednesday 24 March 2010 23:54:15 Hannes Reinecke wrote: Hi all, I'm trying to setup a system with device-passthrough for an ixgbe NIC. The device itself seems to work, but it isn't using MSI-X. So some more advanced features like DCB offloading etc won't work. How

Re: MSI-X not enabled for ixgbe device-passthrough

2010-03-26 Thread Hannes Reinecke
Chris Wright wrote: * Hannes Reinecke (h...@suse.de) wrote: Hi all, I'm trying to setup a system with device-passthrough for an ixgbe NIC. The device itself seems to work, but it isn't using MSI-X. So some more advanced features like DCB offloading etc won't work. Please send

Re: MSI-X not enabled for ixgbe device-passthrough

2010-03-29 Thread Hannes Reinecke
Chris Wright wrote: * Hannes Reinecke (h...@suse.de) wrote: Chris Wright wrote: * Hannes Reinecke (h...@suse.de) wrote: Hi all, I'm trying to setup a system with device-passthrough for an ixgbe NIC. The device itself seems to work, but it isn't using MSI-X. So some more advanced features

Re: [QEMU-KVM]: Megasas + TCM_Loop + SG_IO into Windows XP guests

2010-05-14 Thread Hannes Reinecke
boots up :-) Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe

Re: [QEMU-KVM]: Megasas + TCM_Loop + SG_IO into Windows XP guests

2010-05-18 Thread Hannes Reinecke
Nicholas A. Bellinger wrote: On Fri, 2010-05-14 at 02:42 -0700, Nicholas A. Bellinger wrote: On Fri, 2010-05-14 at 09:22 +0200, Hannes Reinecke wrote: Nicholas A. Bellinger wrote: Greetings Hannes and co, SNIP Let's see if I can find some time working on the megasas emulation. Maybe I find

[PATCH 0/4] megaraid_sas HBA emulation

2009-10-27 Thread Hannes Reinecke
support is not quite there yet. Anything else might work; if not, enable debugging and sent me the logfile. As usual, comment / suggestions etc welcome. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX

[PATCH 1/4] Add 'raid' interface class

2009-10-27 Thread Hannes Reinecke
This patch adds a 'raid' interface class. It is basically a clone of the existing 'scsi' interface, only allowing up to 128 disks. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/pc.c |5 + hw/pci-hotplug.c |1 + hw/scsi-disk.c | 17 + hw/scsi-disk.h

[PATCH 2/4] megasas: LSI MegaRAID SAS HBA emulation

2009-10-27 Thread Hannes Reinecke
This patch add an emulation for the LSI MegaRAID SAS HBA. It is using SG_IO to forward / pass through SCSI commands to the underlying block driver, so no emulation is done currently. Signed-off-by: Hannes Reinecke h...@suse.de --- Makefile.hw |2 +- hw/megasas.c | 1134

[PATCH 3/4] scsi-disk: Factor out SCSI command emulation

2009-10-27 Thread Hannes Reinecke
Other drives might want to use SCSI command emulation without going through the SCSI disk abstraction, as this imposes too many limits on the emulation. Signed-off-by: Hannes Reinecke h...@suse.de --- block.c| 15 ++ block.h|3 + block_int.h|1 + hw/scsi-disk.c

[PATCH 4/4] megasas: Add SCSI command emulation

2009-10-27 Thread Hannes Reinecke
Now that we can use SCSI command emulation without using the SCSI disk abstraction we can easily add it to the megasas HBA. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/megasas.c | 88 +++--- 1 files changed, 53 insertions(+), 35

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Hannes Reinecke
Am Wed 28 Oct 2009 02:58:33 PM CET schrieb Gerd Hoffmann kra...@redhat.com: Hi, From a really quick view fixing up the data xfer code paths doesn't look too bad. Think I'll give it a try. Oh well. The interface pretty obviously designed for the esp, which is the oldest scsi adapter in

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-30 Thread Hannes Reinecke
. Comments welcome. Yep, this looks good. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe from

Indefinite recursion in pci_default_read_config

2009-12-15 Thread Hannes Reinecke
, msix_page_size = 0, msix_irq_entries = 0x0, cap = {supported = 1, start = 64, length = 16, config_read = 0x416770 pci_default_cap_read_config, config_write = 0x46b750 assigned_device_pci_cap_write_config}} Not good ... Cheers, Hannes -- Dr. Hannes Reinecke

Re: Indefinite recursion in pci_default_read_config

2009-12-15 Thread Hannes Reinecke
Michael S. Tsirkin wrote: On Tue, Dec 15, 2009 at 12:59:41PM +0200, Avi Kivity wrote: On 12/15/2009 12:57 PM, Hannes Reinecke wrote: Hi all, I just triggered a nasty indefinite recursion in pci_default_read_config: uint32_t pci_default_read_config(PCIDevice *d

[RFC] [PATCH] SCSI passthrough for virtio-blk

2008-08-29 Thread Hannes Reinecke
driver in the guest and one for the qemu/kvm userland program to modify the virtio-blk driver on the host. This patch is relative to avi's kvm-userland tree from kernel.org. As usual, comments etc to me. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage [EMAIL PROTECTED

Re: [RFC] [PATCH] SCSI passthrough for virtio-blk

2008-08-29 Thread Hannes Reinecke
Hi Christian, Christian Borntraeger wrote: Am Freitag, 29. August 2008 schrieb Hannes Reinecke: So when using '-drive file=/dev/sgXX,if=virtio,format=host_device' you can happily call any sg_XX command on the resulting vdX device. Quite neat, methinks. And it's even backwards compatible, so

Re: [RFC] [PATCH] SCSI passthrough for virtio-blk

2008-08-29 Thread Hannes Reinecke
Hi Christian, Christian Borntraeger wrote: Am Freitag, 29. August 2008 schrieb Hannes Reinecke: Hmm. Works here, using an unpatched kvm-73. Which version did you use? I use the s390 userspace prototype kuli which uses an virtio transport similar to lguest. I retried and it seems to race

Re: [PATCH] lsi53c895a: Add support for OS/2 Warp SYM8XX.ADD driver

2010-09-30 Thread Hannes Reinecke
Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Greetings Paul, Jan, Kevin and co, This series is against my v0.12.5 qemu-kvm.git that contains QEMU SCSI layer SGL passthrough from Gerd Hoffman, 8708EM2 MegaSas emulation from Dr. Hannes Reinecke, and well as my

PCI device not properly reset after VFIO

2012-10-18 Thread Hannes Reinecke
-- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe kvm

Re: PCI device not properly reset after VFIO

2012-10-18 Thread Hannes Reinecke
On 10/18/2012 04:40 PM, Alex Williamson wrote: Hi Hannes, Thanks for testing vfio On Thu, 2012-10-18 at 08:47 +0200, Hannes Reinecke wrote: Hi Alex, I've been playing around with VFIO and megasas (of course). What I did now was switching between VFIO and 'normal' operation, ie emulated

Re: virtio scsi host draft specification, v3

2011-07-01 Thread Hannes Reinecke
detail to the guest, but would save us _a lot_ of processing. I'm all for the latter. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F

[PATCH 0/3] [v4] Megasas HBA emulation

2011-07-01 Thread Hannes Reinecke
it not. But we'll be needing it if the iovec is larger than the buffer. So there. And, of course, the megasas driver itself. Which has been modified to work with the new interface; otherwise there have been no changes to the previous submission. Hannes Reinecke (3): iov: Add 'offset

[PATCH 1/3] iov: Add 'offset' parameter to iov_to_buf()

2011-07-01 Thread Hannes Reinecke
Occasionally, the buffer needs to be placed at a offset within the iovec when copying the buffer to the iovec. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/virtio-net.c|2 +- hw/virtio-serial-bus.c |2 +- iov.c | 23 ++- iov.h

[PATCH 2/3] scsi: replace 'tag' with 'hba_private' pointer

2011-07-01 Thread Hannes Reinecke
'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a driver-defined pointer 'hba_private'. This saves the lookup for driver handling several commands in parallel. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/esp.c

Re: [PATCH 1/3] iov: Add 'offset' parameter to iov_to_buf()

2011-07-01 Thread Hannes Reinecke
On 07/01/2011 10:03 AM, Paolo Bonzini wrote: On 07/01/2011 09:42 AM, Hannes Reinecke wrote: size_t iov_from_buf(struct iovec *iov, unsigned int iovcnt, - const void *buf, size_t size) + const void *buf, size_t offset, size_t size) Wrong commit subject, it seems. :) Bummer. Cheers, Hannes

Re: [PATCH 1/3] iov: Add 'offset' parameter to iov_to_buf()

2011-07-01 Thread Hannes Reinecke
On 07/01/2011 10:02 AM, Alexander Graf wrote: On 01.07.2011, at 09:42, Hannes Reinecke wrote: Occasionally, the buffer needs to be placed at a offset within the iovec when copying the buffer to the iovec. So this is a buffer into the iovec, right? Wouldn't it make sense to also modify

Re: [PATCH 2/3] scsi: replace 'tag' with 'hba_private' pointer

2011-07-01 Thread Hannes Reinecke
On 07/01/2011 10:27 AM, Paolo Bonzini wrote: On 07/01/2011 09:42 AM, Hannes Reinecke wrote: 'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a driver-defined pointer 'hba_private'. This saves the lookup for driver

Re: [PATCH 2/3] scsi: replace 'tag' with 'hba_private' pointer

2011-07-01 Thread Hannes Reinecke
On 07/01/2011 10:27 AM, Paolo Bonzini wrote: On 07/01/2011 09:42 AM, Hannes Reinecke wrote: 'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a driver-defined pointer 'hba_private'. This saves the lookup for driver

[PATCH 0/3] [v5] Megasas HBA Emulation

2011-07-01 Thread Hannes Reinecke
. Hannes Reinecke (3): iov: Update parameter usage in iov_(to|from)_buf() scsi: Add 'hba_private' to SCSIRequest megasas: LSI Megaraid SAS emulation Makefile.objs |1 + default-configs/pci.mak |1 + hw/esp.c|2 +- hw/lsi53c895a.c | 22 +- hw

[PATCH 1/3] iov: Update parameter usage in iov_(to|from)_buf()

2011-07-01 Thread Hannes Reinecke
iov_to_buf() has an 'offset' parameter, iov_from_buf() hasn't. This patch adds the missing parameter to iov_from_buf(). It also renames the 'offset' parameter to 'iov_off' to emphasize it's the offset into the iovec and not the buffer. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/virtio

[PATCH 2/3] scsi: Add 'hba_private' to SCSIRequest

2011-07-01 Thread Hannes Reinecke
-by: Hannes Reinecke h...@suse.de --- hw/esp.c |2 +- hw/lsi53c895a.c | 22 -- hw/scsi-bus.c |9 ++--- hw/scsi-disk.c|4 ++-- hw/scsi-generic.c |5 +++-- hw/scsi.h | 10 +++--- hw/spapr_vscsi.c | 29

Re: [PATCH 3/3] megasas: LSI Megaraid SAS emulation

2011-07-02 Thread Hannes Reinecke
On 07/01/2011 06:42 PM, Alexander Graf wrote: On 01.07.2011, at 17:35, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. Have you tried to execute the current version of megasas and actually do something with it? I just booted up openSUSE 11.4

Re: [PATCH 3/3] megasas: LSI Megaraid SAS emulation

2011-07-04 Thread Hannes Reinecke
On 07/03/2011 04:36 PM, Paolo Bonzini wrote: On 07/02/2011 03:50 PM, Hannes Reinecke wrote: (And no, I will not getting into another dog-fight with Paul B. here. Virtio can do without bounce buffers. AHCI can. So I fail to see why SCSI has to rely on bounce buffers.) I agree, but I do see why

Re: [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation

2011-07-04 Thread Hannes Reinecke
a check to MFI_ODCR0, as this indeed might cause an error when used uninitialized. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F

Re: [PATCH 3/3] megasas: LSI Megaraid SAS emulation

2011-07-04 Thread Hannes Reinecke
On 07/04/2011 12:29 PM, Paolo Bonzini wrote: On 07/04/2011 09:26 AM, Hannes Reinecke wrote: Cool. Exactly what I need. FWIW, feel free to add my 'Acked-by' to it. Any chance of getting them included? I'm not very tied to pvscsi; I just needed an HBA that is not a joke by modern standards

[PATCH 0/5][v6] Megasas HBA emulation

2011-07-05 Thread Hannes Reinecke
Kept 'tag' for tracing and just add 'hba_private' as an additional field as per request from Paolo - megasas: checkpatch.pl fixes and update to work with the changed interface in scsi_req_new(). Also included the suggested fixes from Alex. Hannes Reinecke (5): iov: Update parameter usage

[PATCH 1/5] iov: Update parameter usage in iov_(to|from)_buf()

2011-07-05 Thread Hannes Reinecke
iov_to_buf() has an 'offset' parameter, iov_from_buf() hasn't. This patch adds the missing parameter to iov_from_buf(). It also renames the 'offset' parameter to 'iov_off' to emphasize it's the offset into the iovec and not the buffer. Signed-off-by: Hannes Reinecke h...@suse.de Acked

[PATCH 2/5] scsi: Add 'hba_private' to SCSIRequest

2011-07-05 Thread Hannes Reinecke
-by: Hannes Reinecke h...@suse.de Acked-by: Paolo Bonzini pbonz...@redhat.com --- hw/esp.c |2 +- hw/lsi53c895a.c | 22 -- hw/scsi-bus.c |9 ++--- hw/scsi-disk.c|4 ++-- hw/scsi-generic.c |5 +++-- hw/scsi.h | 10 +++--- hw

[PATCH 3/5] scsi-disk: Fixup debugging statement

2011-07-05 Thread Hannes Reinecke
A debugging statement wasn't converted to the new interface. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index c2a99fe..5804662 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi

[PATCH 4/5] scsi-disk: Mask out serial number EVPD

2011-07-05 Thread Hannes Reinecke
If the serial number is not set we should mask it out in the list of supported VPD pages and mark it as not supported. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-06 Thread Hannes Reinecke
is starting the request with sge_count=1 and then setting it to sge_count=255. We will perform invalid iov[] accesses. Thanks for the hint. Will be fixing it up. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX

[PATCH 0/4] scsi fixes

2011-07-11 Thread Hannes Reinecke
Hi all, these are some fixes I found during debugging my megasas HBA emulation. This time I've sent them as a separate patchset for inclusion. All of them have been acked, so please apply. Hannes Reinecke (4): iov: Update parameter usage in iov_(to|from)_buf() scsi: Add 'hba_private

[PATCH 1/4] iov: Update parameter usage in iov_(to|from)_buf()

2011-07-11 Thread Hannes Reinecke
iov_to_buf() has an 'offset' parameter, iov_from_buf() hasn't. This patch adds the missing parameter to iov_from_buf(). It also renames the 'offset' parameter to 'iov_off' to emphasize it's the offset into the iovec and not the buffer. Signed-off-by: Hannes Reinecke h...@suse.de Acked

[PATCH 2/4] scsi: Add 'hba_private' to SCSIRequest

2011-07-11 Thread Hannes Reinecke
-by: Hannes Reinecke h...@suse.de Acked-by: Paolo Bonzini pbonz...@redhat.com --- hw/esp.c |2 +- hw/lsi53c895a.c | 22 -- hw/scsi-bus.c |9 ++--- hw/scsi-disk.c|4 ++-- hw/scsi-generic.c |5 +++-- hw/scsi.h | 10 +++--- hw

[PATCH 3/4] scsi-disk: Fixup debugging statement

2011-07-11 Thread Hannes Reinecke
A debugging statement wasn't converted to the new interface. Signed-off-by: Hannes Reinecke h...@suse.de Acked-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index c2a99fe..5804662

[PATCH 4/4] scsi-disk: Mask out serial number EVPD

2011-07-11 Thread Hannes Reinecke
If the serial number is not set we should mask it out in the list of supported VPD pages and mark it as not supported. Signed-off-by: Hannes Reinecke h...@suse.de Acked-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions

Re: [PATCH 0/4] scsi fixes

2011-07-11 Thread Hannes Reinecke
with my megasas HBA emulation patchset. This is just a repost as a separate patchset to get them in. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J

[PATCH 0/3] Check for supported SCSI commands

2011-07-22 Thread Hannes Reinecke
Markus Armbruster pointed out that not every SCSI command is supported for a given device type. Based on his patch this series cleans up the SCSI device type and adds a check for supported commands. Hannes Reinecke (3): scsi: Sanitize command definitions scsi-disk: Remove drive_kind scsi

[PATCH 1/3] scsi: Sanitize command definitions

2011-07-22 Thread Hannes Reinecke
Adding some missing command definitions and update the existing ones. No functional change. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-bus.c | 71 ++-- hw/scsi-defs.h| 60 hw

[PATCH 2/3] scsi-disk: Remove drive_kind

2011-07-22 Thread Hannes Reinecke
Instead of using our own type structure we can be using the SCSI type from the parent device. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c | 156 ++-- 1 files changed, 129 insertions(+), 27 deletions(-) diff --git a/hw/scsi

[PATCH 3/3] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c | 102 1 files changed, 0 insertions(+), 102 deletions(-) diff

Re: [Qemu-devel] [PATCH 1/3] scsi: Sanitize command definitions

2011-07-22 Thread Hannes Reinecke
(io_header)); io_header.interface_id = 'S'; OK, convinced. Will be doing a separate patch for removing the obsolete commands. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5

Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
. Looks like something wrent wrong with 2/3 and 3/3. Argl. Yes, correct. Will be sending an updated patchset. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF

[PATCH 0/6][v2] Check for supported SCSI commands

2011-07-22 Thread Hannes Reinecke
Markus Armbruster pointed out that not every SCSI command is supported for a given device type. Based on his patch and suggestiongs this series cleans up the SCSI device type and adds a check for supported commands. Hannes Reinecke (6): scsi-disk: Codingstyle fixes scsi: Remove references

[PATCH 1/6] scsi-disk: Codingstyle fixes

2011-07-22 Thread Hannes Reinecke
Replace tabs with spaces. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 05d14ab..910d3b5 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -526,7

[PATCH 2/6] scsi: Remove references to SET_WINDOW

2011-07-22 Thread Hannes Reinecke
SET_WINDOW command is vendor-specific only. So we shouldn't try to emulate it. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-bus.c |2 -- hw/scsi-defs.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 8b1a412..facc98d

[PATCH 3/6] scsi: Remove REZERO_UNIT emulation

2011-07-22 Thread Hannes Reinecke
REZERO_UNIT command is obsolete. Remove support for it. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-bus.c |3 --- hw/scsi-defs.h |1 - hw/scsi-disk.c |7 --- 3 files changed, 0 insertions(+), 11 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index facc98d

[PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-22 Thread Hannes Reinecke
Instead of using its own definitions scsi-disk should be using the device type of the parent device. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-defs.h |6 +- hw/scsi-disk.c | 48 2 files changed, 29 insertions(+), 25

[PATCH 6/6] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c | 104 +++- 1 files changed, 103 insertions(+), 1 deletions(-) diff

[PATCH 4/6] scsi: Sanitize command definitions

2011-07-22 Thread Hannes Reinecke
, COMPARE_AND_WRITE, VERIFY_16, SYNCHRONIZE_CACHE_16, LOCATE_16, ERASE_16, WRITE_LONG_16, LOAD_UNLOAD, VERIFY_12. Remove invalid definition of WRITE_LONG_2. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-bus.c | 69 hw/scsi-defs.h| 54

Re: [Qemu-devel] [PATCH 0/6][v2] Check for supported SCSI commands

2011-07-26 Thread Hannes Reinecke
commands. I like this series. It conflicts with mine. I can work with Kevin to resolve the conflict. Yes please. I'm happy to assist. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH

Re: [Qemu-devel] [PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-26 Thread Hannes Reinecke
of block devices. By all means, keep it. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg

Re: [Qemu-devel] [PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-26 Thread Hannes Reinecke
afraid you forgot to remove typedef SCSIDriveKind. Care to respin this one? Here you go. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J

Re: [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Hannes Reinecke
On 07/26/2011 03:07 PM, Kevin Wolf wrote: Am 22.07.2011 16:51, schrieb Hannes Reinecke: Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reineckeh...@suse.de --- hw/scsi-disk.c | 104

Re: [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Hannes Reinecke
On 07/26/2011 03:46 PM, Kevin Wolf wrote: Am 22.07.2011 16:51, schrieb Hannes Reinecke: Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reineckeh...@suse.de We do emulate SEEK (6), but it's not in your

Re: Pe: [PATCH v5 1/3] virtio-scsi: first version

2012-02-13 Thread Hannes Reinecke
simply set PQ = 1, return sense code 0x25/00 and be done with ... Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746

Re: about NPIV with qemu-kvm.

2011-10-25 Thread Hannes Reinecke
? and through this new created disk, like device /dev/sdf, then I add qemu-kvm with -drive file=/dev/sdf,if=virtio... arguments? Yes. That's what you need to do. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products

Re: virtio scsi host draft specification, v3

2011-06-10 Thread Hannes Reinecke
hosts to represent that. If that's the intention here I'm fine, but maybe we should be specifying this expressis verbis somewhere. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr

Re: virtio scsi host draft specification, v3

2011-06-14 Thread Hannes Reinecke
for a _long_ time. I personally _really_ would like to see the real backing device details exposed to the guest. Otherwise the more advanced stuff like persistent reservations becomes _really_ hard if not impossible. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h

Re: virtio scsi host draft specification, v3

2011-06-14 Thread Hannes Reinecke
On 06/12/2011 09:51 AM, Michael S. Tsirkin wrote: On Fri, Jun 10, 2011 at 02:55:35PM +0200, Hannes Reinecke wrote: Device operation: request queues The driver queues requests to an arbitrary request queue, and they are used by the device on that same queue

Re: virtio scsi host draft specification, v3

2011-06-29 Thread Hannes Reinecke
on the host is a totally different matter. Same goes for the transport details; I doubt we will expose all the dingy details of the various transports, but rather restrict ourselves to an abstract transport. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de

Re: binding/unbinding devices to vfio-pci

2013-07-02 Thread Hannes Reinecke
would be bound to the device, and vfio must be enabled via manual binding. Much like it is today. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn

Re: updated: kvm PCI todo wiki

2013-08-21 Thread Hannes Reinecke
managed to get this to work? If not it'd be a good topic for the wiki ... Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer

Re: [PATCH] virtio-scsi: Change sense buffer size to 252

2014-03-06 Thread Hannes Reinecke
to SCSI_SENSE_BUFFERSIZE, so using other values have a limited sense. Literally :-) Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746

Re: [PATCH v2] scsi: Change sense buffer size to 252

2014-03-14 Thread Hannes Reinecke
to implement a proper sense code handling (descriptor sense parsing etc) before we need to worry about this. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF

Re: [PATCH v3 1/4] scsi: remove old-style type names from sg.h

2015-09-25 Thread Hannes Reinecke
truct sg_req_info Sg_req_info; > - > > /* vvvvvv */ > /* The older SG interface based on the 'sg_header' structure follows. */ > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Rein

Re: [PATCH v3 3/4] scsi: move all obsolete ioctls to scsi_ioctl.h

2015-09-25 Thread Hannes Reinecke
> Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > include/scsi/scsi.h | 20 > include/scsi/scsi_ioctl.h | 20 > 2 files changed, 20 insertions(+)

Re: [PATCH v3 2/4] scsi: cleanup scsi/scsi_ioctl.h

2015-09-25 Thread Hannes Reinecke
Cc: linux-s...@vger.kernel.org > Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > include/scsi/scsi.h | 6 ++ > include/scsi/scsi_ioctl.h | 8 ---- > 2 files changed, 6 insertions(+), 8

Re: [PATCH v3 4/4] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h

2015-09-25 Thread Hannes Reinecke
e> > Cc: linux-s...@vger.kernel.org > Cc: Bart Van Assche <bart.vanass...@sandisk.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- [ .. ] Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries &a