Re: [Autotest] [KVM-AUTOTEST PATCH v2] KVM test: migration_with_file_transfer: verify transfer correctness

2010-12-28 Thread Michael Goldish
On 12/28/2010 03:31 PM, Jason Wang wrote: Michael Goldish writes: On 12/28/2010 02:38 PM, Jason Wang wrote: Michael Goldish writes: After the transfer, copy the file back from the guest to the host and make sure the returned file is identical to the one sent to the guest

Re: [Autotest] [KVM-AUTOTEST PATCH 12/28] KVM test: use VM.clone() in make_qemu_command()

2010-12-28 Thread Michael Goldish
On 12/28/2010 03:13 PM, Jason Wang wrote: Michael Goldish writes: When make_qemu_command() is called in order to see if a VM should be restarted using a different qemu command line, construction of the qemu command should be based only on the parameters provided to make_qemu_command

Re: [Autotest] [KVM-AUTOTEST PATCH 11/28] KVM test: make_qemu_command(): catch IndexError when accessing self.netdev_id

2010-12-28 Thread Michael Goldish
On 12/28/2010 03:23 PM, Jason Wang wrote: Michael Goldish writes: make_qemu_command() is sometimes called to see if a VM needs to be restarted using a different qemu command line. When it's called with more NICs than the VM currently has, accessing self.netdev_id can raise

[KVM-AUTOTEST PATCH v2] KVM test: make_qemu_command(): catch IndexError when accessing self.netdev_id

2010-12-28 Thread Michael Goldish
). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 6aa8eb4..ebab981 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests

[KVM-AUTOTEST PATCH 1/4] KVM test: introduce the Env class

2010-12-28 Thread Michael Goldish
It's a wrapper to the 'env' object used by KVM tests. It behaves like a dictionary, but may implement additional common operations used by KVM tests. Signed-off-by: Eduardo Habkost ehabk...@raisama.net --- client/tests/kvm/kvm_utils.py | 85 + 1 files

[KVM-AUTOTEST PATCH 2/4] KVM test: use kvm_utils.Env wherever appropriate

2010-12-28 Thread Michael Goldish
The new Env object is backward compatible with the regular env dict, so all the kvm_utils.env_*() functions should work as usual. Signed-off-by: Eduardo Habkost ehabk...@raisama.net --- client/tests/kvm/kvm.py | 10 +- client/tests/kvm/kvm_scheduler.py |4 ++-- 2 files

[KVM-AUTOTEST PATCH 3/4] KVM test: use the new Env methods instead of the old env_* functions

2010-12-28 Thread Michael Goldish
Signed-off-by: Eduardo Habkost ehabk...@raisama.net --- client/tests/kvm/kvm.py |2 +- client/tests/kvm/kvm_preprocessing.py| 12 ++-- client/tests/kvm/kvm_test_utils.py |4 ++-- client/tests/kvm/tests/ksm_overcommit.py |4 ++--

[KVM-AUTOTEST PATCH 02/28] KVM test: kvm_utils.py: add a convenience function to run functions in parallel

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index 5d79112..57c9951 100644 --- a/client/tests/kvm

[KVM-AUTOTEST PATCH 03/28] KVM test: corrections to migration_with_reboot

2010-12-27 Thread Michael Goldish
- Use wait_for() to try remote_login() multiple times before giving up. - Take VM parameters from vm.params, not params. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/migration_with_reboot.py | 26 +++--- 1 files changed, 13 insertions(+), 13

[KVM-AUTOTEST PATCH 05/28] KVM test: vmstop: use kvm_utils.Thread

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/vmstop.py | 61 ++--- 1 files changed, 30 insertions(+), 31 deletions(-) diff --git a/client/tests/kvm/tests/vmstop.py b/client/tests/kvm/tests/vmstop.py index 703c881..876c3ef 100644

[KVM-AUTOTEST PATCH 04/28] KVM test: migration_with_reboot: use kvm_utils.Thread

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/migration_with_reboot.py | 19 +++ 1 files changed, 7 insertions(+), 12 deletions(-) diff --git a/client/tests/kvm/tests/migration_with_reboot.py b/client/tests/kvm/tests/migration_with_reboot.py

[KVM-AUTOTEST PATCH 06/28] KVM test: migration_with_file_transfer: use kvm_utils.Thread

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- .../kvm/tests/migration_with_file_transfer.py | 42 +++- 1 files changed, 15 insertions(+), 27 deletions(-) diff --git a/client/tests/kvm/tests/migration_with_file_transfer.py b/client/tests/kvm/tests

[KVM-AUTOTEST PATCH 09/28] KVM test: remove kvm_test_utils.BackgroundTest

2010-12-27 Thread Michael Goldish
kvm_utils.Thread is used instead. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 47 1 files changed, 0 insertions(+), 47 deletions(-) diff --git a/client/tests/kvm/kvm_test_utils.py b/client/tests/kvm

[KVM-AUTOTEST PATCH 15/28] KVM test: kvm_subprocess.py: increase default timeout from 30 to 60 secs

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/client/tests/kvm/kvm_subprocess.py b/client/tests/kvm/kvm_subprocess.py index a60eaf6..c3e2dd7 100755

[KVM-AUTOTEST PATCH 17/28] KVM test: whql_submission: make the HDD tests run on a non-system drive

2010-12-27 Thread Michael Goldish
One of the tests refuses to run on a system drive, so: - Add a 2nd disk to the qemu command line and create a 4G image for it - Partition the 2nd disk and assign D: to it before running the tests - Tell the tests to run on a non-system drive Signed-off-by: Michael Goldish mgold...@redhat.com

[KVM-AUTOTEST PATCH 16/28] KVM test: whql_submission: run a user specified shell command before the test

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_submission.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/tests/whql_submission.py b/client/tests/kvm/tests/whql_submission.py index b1b7f25..8dd48b8 100644

[KVM-AUTOTEST PATCH 18/28] KVM test: whql: rename the whql_submission variant to whql.submission

2010-12-27 Thread Michael Goldish
Rename whql_submission to whql.submission and whql_client_install to whql.client_install. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests_base.cfg.sample | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/client/tests

[KVM-AUTOTEST PATCH 07/28] KVM test: migration_with_file_transfer: use unique host filename

2010-12-27 Thread Michael Goldish
If the same constant filename is used every time, multiple instances of the test cannot run concurrently. Signed-off-by: Michael Goldish mgold...@redhat.com --- .../kvm/tests/migration_with_file_transfer.py | 12 +++- client/tests/kvm/tests_base.cfg.sample |2 +- 2

[KVM-AUTOTEST PATCH 08/28] KVM test: migration_with_file_transfer: verify transfer correctness

2010-12-27 Thread Michael Goldish
After the transfer, copy the file back from the guest to the host and make sure the returned file is identical to the one sent to the guest. Signed-off-by: Michael Goldish mgold...@redhat.com --- .../kvm/tests/migration_with_file_transfer.py | 34 +--- 1 files changed, 29

[KVM-AUTOTEST PATCH 13/28] KVM test: don't print the contents of env before and after tests

2010-12-27 Thread Michael Goldish
It produces a lot of output and normally isn't useful. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index 4dec182..dc00edd 100644

[KVM-AUTOTEST PATCH 20/28] KVM test: whql.submission: add unclassified USB tablet tests

2010-12-27 Thread Michael Goldish
Group all device tests under a 'device' variant and create a new 'unclassified' variant that currently contains only the tablet tests. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests_base.cfg.sample | 134 ++-- 1 files changed, 77

[KVM-AUTOTEST PATCH 21/28] KVM test: refactor whql_submission_15.cs and whql_submission.py

2010-12-27 Thread Michael Goldish
' to 'yes' in tests_base.cfg.sample to force a restart of the VMs before each test. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/whql_submission_15.cs | 662 +++--- client/tests/kvm/deps/whql_submission_15.exe | Bin 10240 - 12288 bytes client

[KVM-AUTOTEST PATCH 22/28] KVM test: whql: add a network submission

2010-12-27 Thread Michael Goldish
of whql.client_install.support_vm. - Add whql.submission.device.net, which defines the network submission. - Append '-supportvm' to image_name of the 2nd VM of whql.submission.device.net for all guests. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests_base.cfg.sample | 108

[KVM-AUTOTEST PATCH 25/28] KVM test: whql.submission: don't use any cdroms

2010-12-27 Thread Michael Goldish
whql.submission doesn't require any cdroms so get rid of them. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests_base.cfg.sample |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm

[KVM-AUTOTEST PATCH 28/28] KVM test: whql_submission.py: log in using all NICs before running tests

2010-12-27 Thread Michael Goldish
This will make sure all NICs are up before beginning testing. Useful for network tests. For other tests it should be harmless as they only use a single NIC. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_submission.py | 14 ++ 1 files changed

[KVM-AUTOTEST PATCH 27/28] KVM test: whql.submission: reorder DeviceData

2010-12-27 Thread Michael Goldish
The DeviceData order should now match the order in the XMLs produced by the DTM studio, which should make it easier to look at diffs (for debugging) between the XMLs produced by the automation program and the those produced by the DTM studio Signed-off-by: Michael Goldish mgold...@redhat.com

[KVM-AUTOTEST PATCH 23/28] KVM test: whql.submission: use a different submission name for each submission category

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_submission.py | 10 +- client/tests/kvm/tests_base.cfg.sample|4 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/tests/whql_submission.py b/client/tests/kvm

[KVM-AUTOTEST PATCH 11/28] KVM test: make_qemu_command(): catch IndexError when accessing self.netdev_id

2010-12-27 Thread Michael Goldish
make_qemu_command() is sometimes called to see if a VM needs to be restarted using a different qemu command line. When it's called with more NICs than the VM currently has, accessing self.netdev_id can raise an IndexError. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm

[KVM-AUTOTEST PATCH 10/28] KVM test: avoid printing address cache messages too often

2010-12-27 Thread Michael Goldish
MAC address was printed more than 5 seconds ago. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py

[KVM-AUTOTEST PATCH v2] KVM test: migration_with_file_transfer: verify transfer correctness

2010-12-27 Thread Michael Goldish
) to copy_files_from(). Signed-off-by: Michael Goldish mgold...@redhat.com --- .../kvm/tests/migration_with_file_transfer.py | 37 +--- 1 files changed, 32 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/tests/migration_with_file_transfer.py b/client/tests/kvm/tests

[KVM-AUTOTEST PATCH 1/4] KVM test: introduce Params, a dict-like object containing test parameters

2010-12-27 Thread Michael Goldish
This object should replace get_sub_dict_names() and get_sub_dict(). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b

[KVM-AUTOTEST PATCH 2/4] KVM test: kvm.py: convert the params dict to a kvm_utils.Params object

2010-12-27 Thread Michael Goldish
Also bump the env version so old env files will not be used. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index dc00edd..ceee88f 100644

[KVM-AUTOTEST PATCH 4/4] KVM test: remove get_sub_dict_names() and get_sub_dict()

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 35 --- 1 files changed, 0 insertions(+), 35 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index 1e32e30..2e4ba92 100644 --- a/client

[KVM-AUTOTEST PATCH 3/4] KVM test: use the new Params methods instead of get_sub_dict_.*()

2010-12-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 14 ++--- client/tests/kvm/kvm_vm.py | 58 ++-- client/tests/kvm/tests/pci_hotplug.py |4 +- client/tests/kvm/tests

Re: [PATCH 1/3] KVM Test: Introduce a helper class to run a test in the background

2010-12-01 Thread Michael Goldish
On 11/27/2010 01:16 AM, Lucas Meneghel Rodrigues wrote: On Fri, 2010-11-26 at 21:01 -0200, Lucas Meneghel Rodrigues wrote: Sometimes, we need to run a test when doing operations on a running VM (such as migrate the vm during its rebooting ). So this patch introduces a simple warpper

Re: [PATCH 0/3] Launch other test during migration

2010-11-03 Thread Michael Goldish
On 11/03/2010 04:53 AM, Jason Wang wrote: Michael Goldish writes: On 11/02/2010 07:34 AM, Jason Wang wrote: Michael Goldish writes: On 09/25/2010 11:36 AM, Jason Wang wrote: We could give a further test of migration by launch test during migartion. So the following

Re: [PATCH 0/3] Launch other test during migration

2010-11-02 Thread Michael Goldish
On 11/02/2010 07:34 AM, Jason Wang wrote: Michael Goldish writes: On 09/25/2010 11:36 AM, Jason Wang wrote: We could give a further test of migration by launch test during migartion. So the following series implements: - A simple class to run a specified test

Re: [PATCH 0/3] Launch other test during migration

2010-11-01 Thread Michael Goldish
On 09/25/2010 11:36 AM, Jason Wang wrote: We could give a further test of migration by launch test during migartion. So the following series implements: - A simple class to run a specified test in the background which could be used to launch other test during migartion. Its design is rather

Re: [PATCH 3/3] KVM test: Test the file transfer during migartion

2010-11-01 Thread Michael Goldish
On 09/25/2010 11:36 AM, Jason Wang wrote: This test just do the file transfer from host to guest during migartion in order to check whether the nic/block state could be saved and loaded correctly. Signed-off-by: Jason Wang jasow...@redhat.com ---

Re: [KVM-AUTOTEST PATCH 4/5] KVM test: kvm_subprocess: rename get_command_status_output() and friends

2010-10-27 Thread Michael Goldish
On 10/27/2010 07:59 AM, Feng Yang wrote: - Michael Goldish mgold...@redhat.com wrote: From: Michael Goldish mgold...@redhat.com To: autot...@test.kernel.org, kvm@vger.kernel.org Cc: Michael Goldish mgold...@redhat.com Sent: Wednesday, October 27, 2010 12:49:43 AM GMT +08:00 Beijing

[KVM-AUTOTEST PATCH] KVM test: kvm_vm.py: style corrections in add_nic() and add_net()

2010-10-27 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 25 +++-- 1 files changed, 11 insertions(+), 14 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index bb24c6a..02d7dff 100755 --- a/client/tests/kvm

[KVM-AUTOTEST PATCH] KVM test: VM.create(): fix netdev_id generation

2010-10-27 Thread Michael Goldish
Clear the list of netdev IDs before generating new ones. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 02d7dff..a65e2e9

[KVM-AUTOTEST PATCH] KVM test: kvm_subprocess: add aliases for cmd_* functions for backward compatibility

2010-10-27 Thread Michael Goldish
Add aliases to maintain compatibility with tests that use the long names. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_subprocess.py

[KVM-AUTOTEST PATCH 4/5] KVM test: kvm_subprocess: rename get_command_status_output() and friends

2010-10-26 Thread Michael Goldish
get_command_status_output() - cmd_status_output() get_command_output() - cmd_output() get_command_status() - cmd_status() Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 27 +-- client/tests/kvm/kvm_test_utils.py

[KVM-AUTOTEST PATCH 2/5] KVM test: kvm_monitor.py: store attributes in QMPCmdError

2010-10-26 Thread Michael Goldish
For consistency with the exceptions in kvm_subprocess. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_monitor.py | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm_monitor.py b/client/tests/kvm/kvm_monitor.py index

[KVM-AUTOTEST PATCH 3/5] KVM test: add utility functions start_windows_service() and stop_windows_service()

2010-10-26 Thread Michael Goldish
These utilities use sc to stop and start windows services. They're used by whql_submission and whql_client_install to stop or restart wttsvc on the client machine. Resending because this seems never to have been committed. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests

[KVM-AUTOTEST PATCH 5/5] [RFC] KVM test: kvm_subprocess: rename kvm_shell_session and friends

2010-10-26 Thread Michael Goldish
-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py |2 +- client/tests/kvm/kvm_scheduler.py |2 +- client/tests/kvm/kvm_subprocess.py| 60 client/tests/kvm/kvm_utils.py | 15 client/tests/kvm

[KVM-AUTOTEST PATCH 1/7] KVM test: simplify MAC address management

2010-10-24 Thread Michael Goldish
() with VM.free_mac_address() - Use _open_mac_pool() and _close_mac_pool() to save code - Merge _generate_mac_address_prefix() with generate_mac_address_prefix() - Concentrate all functions that access the MAC address pool in the same module (kvm_utils.py) - Minor style changes Signed-off-by: Michael Goldish mgold

[KVM-AUTOTEST PATCH 2/7] KVM test: VM.get_address(): fix handling of multiple NICs

2010-10-24 Thread Michael Goldish
Use VM.get_mac_address() instead of kvm_utils.get_mac_ip_pair_from_dict(). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index

[KVM-AUTOTEST PATCH 4/7] KVM test: get_ifname(): use self.instance instead of self.vnc_port

2010-10-24 Thread Michael Goldish
string can't be used because it exceeds 15 characters.) Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 2db916f..a5c110c

[KVM-AUTOTEST PATCH 3/7] [RFC] KVM test: remove all code related to the old MAC address pool method

2010-10-24 Thread Michael Goldish
This patch removes all code related to the old manual method (address_pools.cfg). Note that now running in TAP mode requires an external DHCP server that accepts *any* MAC address, because MAC addresses are randomly generated and cannot be manually configured. Signed-off-by: Michael Goldish

[KVM-AUTOTEST PATCH 5/7] KVM test: kvm_monitor.py: replace MonitorSendError with MonitorSocketError

2010-10-24 Thread Michael Goldish
- Replace MonitorSendError with MonitorSocketError. - Embed socket.error messages in MonitorSocketError messages. - Catch exceptions raised while receiving data (in addition to those raised while sending data). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm

[KVM-AUTOTEST PATCH 6/7] KVM test: refactor migration code

2010-10-24 Thread Michael Goldish
'migration_mode' and 'migration_exec_cmd' - Remove unix socket files in VM.destroy() because they are created by VM.create() (as opposed to gzipped state files which are created in kvm_test_utils.migrate()) Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 10

[KVM-AUTOTEST PATCH 7/7] [RFC] KVM test: migrate_cancel: allow for alternative spellings of 'cancelled'

2010-10-24 Thread Michael Goldish
Is there any chance someone will decide to switch over to the American spelling? Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm_test_utils.py b/client

Re: [PATCH] KVM Test: add -w parameter in nc command in kvm_utils.py

2010-10-21 Thread Michael Goldish
On 10/21/2010 03:57 AM, Feng Yang wrote: - Michael Goldish mgold...@redhat.com wrote: From: Michael Goldish mgold...@redhat.com To: Feng Yang fy...@redhat.com Cc: autot...@test.kernel.org, kvm@vger.kernel.org Sent: Wednesday, October 20, 2010 6:48:42 PM GMT +08:00 Beijing / Chongqing

Re: [PATCH] KVM Test: Set bootstatuspolicy to ignoreallfailures for Win2008 and r2 in autounattend.xml

2010-10-20 Thread Michael Goldish
On 10/20/2010 07:53 AM, Feng Yang wrote: Windows 2008 image is easy to go to startup repair screen, which make many of our cases fail. This patch will disable startup repair screen in win2008 which caused by shutdown failures. Signed-off-by: Feng Yang fy...@redhat.com Shouldn't it be easier

Re: [PATCH] KVM Test: add -w parameter in nc command in kvm_utils.py

2010-10-20 Thread Michael Goldish
On 10/20/2010 08:55 AM, Feng Yang wrote: If a connection and stdin are idle for more than timeout seconds, then the connection is silently closed. withou this paramter, nc will listen forever for a connection. This may cause our test hang. redmine issue:

Re: [PATCH] KVM Test: Set bootstatuspolicy to ignoreallfailures for Win2008 and r2 in autounattend.xml

2010-10-20 Thread Michael Goldish
On 10/20/2010 11:47 AM, Feng Yang wrote: - Michael Goldish mgold...@redhat.com wrote: From: Michael Goldish mgold...@redhat.com To: Feng Yang fy...@redhat.com Cc: autot...@test.kernel.org, kvm@vger.kernel.org Sent: Wednesday, October 20, 2010 4:49:29 PM GMT +08:00 Beijing / Chongqing

Re: [PATCH] KVM Test: add -w parameter in nc command in kvm_utils.py

2010-10-20 Thread Michael Goldish
On 10/20/2010 12:18 PM, Feng Yang wrote: - Michael Goldish mgold...@redhat.com wrote: From: Michael Goldish mgold...@redhat.com To: Feng Yang fy...@redhat.com Cc: autot...@test.kernel.org, kvm@vger.kernel.org Sent: Wednesday, October 20, 2010 5:11:32 PM GMT +08:00 Beijing / Chongqing

[KVM-AUTOTEST PATCH] KVM test: kvm_monitor.py: use select whenever possible

2010-10-20 Thread Michael Goldish
As suggested by Luiz Capitulino, use select() whenever possible to minimize delays. (_data_available() is a wrapper for select().) Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_monitor.py | 73 +-- 1 files changed, 39

[KVM-AUTOTEST PATCH] KVM test: kvm_monitor.py: fix cmd_qmp()'s docstring

2010-10-20 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_monitor.py |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_monitor.py b/client/tests/kvm/kvm_monitor.py index 5ad80d8..7047850 100644 --- a/client/tests/kvm/kvm_monitor.py

Re: [Autotest] [KVM-AUTOTEST PATCH] [RFC] KVM test: kvm_monitor.py: refactor _get_command_output()

2010-10-19 Thread Michael Goldish
On 10/18/2010 08:45 PM, Luiz Capitulino wrote: On Mon, 18 Oct 2010 15:13:39 +0200 Michael Goldish mgold...@redhat.com wrote: Instead of _get_command_output() and friends, introduce the following methods: * QMP: - _send(): send raw data without waiting for a response - _get_response

[KVM-AUTOTEST PATCH] KVM test: kvm_subprocess.py: reset _thread_kill_requested in kill_tail_threads()

2010-10-18 Thread Michael Goldish
Reset the flag only after all relevant child threads have been joined. Resetting the flag in one of the child threads causes a race condition, where the other child threads will not detect that the flag was set and will therefore not terminate. Signed-off-by: Michael Goldish mgold...@redhat.com

[KVM-AUTOTEST PATCH] KVM test: whql_client_install: fix retrieval of server_dns_suffix

2010-10-18 Thread Michael Goldish
Currently REG_SZ is incorrectly used if no dns suffix is set. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_client_install.py |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/tests/whql_client_install.py b

[KVM-AUTOTEST PATCH] [RFC] KVM test: kvm_monitor.py: refactor _get_command_output()

2010-10-18 Thread Michael Goldish
data without waiting for a response - cmd(): send a command, return response Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_monitor.py | 235 ++ 1 files changed, 136 insertions(+), 99 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH] KVM test: kvm_monitor.py: add __str__() method to QMPCmdError exception

2010-10-18 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_monitor.py | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/client/tests/kvm/kvm_monitor.py b/client/tests/kvm/kvm_monitor.py index b887060..40be77d 100644 --- a/client/tests/kvm

Re: [Autotest] [KVM-AUTOTEST PATCH v2 3/5] [RFC] KVM test: add whql_submission test

2010-08-05 Thread Michael Goldish
On 08/05/2010 03:49 AM, Amos Kong wrote: On Thu, Jul 22, 2010 at 01:14:17PM +0300, Michael Goldish wrote: whql_submission runs a submission on a given device. It requires a functioning external DTM server which runs rss.exe like regular Windows VMs, preferably with administrator permissions

Re: [KVM-AUTOTEST PATCH 6/9] [RFC] KVM test: add utility functions start_windows_service() and stop_windows_service()

2010-08-05 Thread Michael Goldish
On 08/05/2010 03:38 AM, Amos Kong wrote: On Thu, Jul 15, 2010 at 06:57:35PM +0300, Michael Goldish wrote: These utilities use sc to stop and start windows services. They're used by whql_submission and whql_client_install to stop or restart wttsvc on the client machine. Signed-off

[KVM-AUTOTEST PATCH v3] [RFC] KVM test: add whql_client_install test

2010-07-29 Thread Michael Goldish
(...) if s != 0: ... with if session.get_command_status(...) != 0: ... Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_client_install.py | 116 + 1 files changed, 116 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm

Re: [Qemu-devel] [RFC PATCH 02/14] KVM Test: Add a function get_interface_name() to kvm_net_utils.py

2010-07-28 Thread Michael Goldish
On 07/27/2010 05:08 AM, Lucas Meneghel Rodrigues wrote: On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: The function get_interface_name is used to get the interface name of linux guest through the macaddress of specified macaddress. I wonder if it wouldn't be overkill to have separate

Re: [Qemu-devel] [RFC PATCH 03/14] KVM Test: Add a common ping module for network related tests

2010-07-28 Thread Michael Goldish
On 07/27/2010 04:01 PM, Lucas Meneghel Rodrigues wrote: On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: The kvm_net_utils.py is a just a place that wraps common network related commands which is used to do the network-related tests. Use -1 as the packet ratio for loss analysis. Use quiet

[KVM-AUTOTEST PATCH v2 1/5] [RFC] KVM test: DTM automation program for WHQL tests

2010-07-22 Thread Michael Goldish
device and failing immediately if it isn't found, allow up to 2 minutes for it to show up. - Add the job ID of each job to the result list printed to stdout. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/whql_submission_15.cs | 289

[KVM-AUTOTEST PATCH v2 3/5] [RFC] KVM test: add whql_submission test

2010-07-22 Thread Michael Goldish
', 'InProgress'). - Kill the client VM if the tests don't complete on time. - In the final results summary display the job ID of each job. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_submission.py | 188 + 1 files changed, 188

[KVM-AUTOTEST PATCH v2 4/5] [RFC] KVM test: add whql_client_install test

2010-07-22 Thread Michael Goldish
whql_client_install installs the DTM client on a guest. It requires a functioning external DTM server which runs rss.exe like regular Windows VMs. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_client_install.py | 110 + 1 files

[KVM-AUTOTEST PATCH v2 5/5] [RFC] KVM test: add WHQL test definitions to tests_base.cfg.sample

2010-07-22 Thread Michael Goldish
can't be done routinely as part of our regression testing. - Change test_device regex to qemu harddisk in whql_submission.hdd. - Update timeouts - Enable WHQL tests for Win2003 Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests.cfg.sample |8 + client/tests/kvm

Re: [Qemu-devel] [PATCH] Monitor: Convert do_sendkey() to QObject, QError

2010-07-21 Thread Michael Goldish
On 07/21/2010 09:44 PM, Luiz Capitulino wrote: On Sun, 18 Jul 2010 15:43:55 +0300 Michael Goldish mgold...@redhat.com wrote: Signed-off-by: Michael Goldish mgold...@redhat.com Do you need this for 0.13? I think the development window is already closed. No, it's not urgent

Re: [Qemu-devel] [RFC PATCH 01/14] KVM-test: Add a new macaddress pool algorithm

2010-07-20 Thread Michael Goldish
On 07/20/2010 04:34 AM, Amos Kong wrote: Old method uses the mac address in the configuration files which could lead serious problem when multiple tests running in different hosts. This patch adds a new macaddress pool algorithm, it generates the mac prefix based on mac address of the host

Re: [Qemu-devel] [RFC PATCH 01/14] KVM-test: Add a new macaddress pool algorithm

2010-07-20 Thread Michael Goldish
On 07/20/2010 04:44 PM, Amos Kong wrote: On Tue, Jul 20, 2010 at 01:19:39PM +0300, Michael Goldish wrote: Michael, Thanks for your comments. Let's simplify this method together. On 07/20/2010 04:34 AM, Amos Kong wrote: Old method uses the mac address in the configuration files which

[PATCH] Monitor: Convert do_sendkey() to QObject, QError

2010-07-18 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- monitor.c | 15 --- qemu-monitor.hx | 22 +- qerror.c| 12 qerror.h|9 + 4 files changed, 50 insertions(+), 8 deletions(-) diff --git a/monitor.c b

[KVM-AUTOTEST PATCH 1/9] KVM test: kvm_vm.py: make -drive index optional for both images and cdrom ISOs

2010-07-15 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 6cd0688..248aeca 100755 --- a/client/tests/kvm/kvm_vm.py +++ b

[KVM-AUTOTEST PATCH 2/9] KVM test: allow definition of multiple cdroms

2010-07-15 Thread Michael Goldish
.* ?= ... to cdrom(_.*)? ?= ... It won't hurt to do the same for image_name. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 19 +++ client/tests/kvm/tests.cfg.sample |4 ++-- client/tests/kvm/tests_base.cfg.sample | 10 -- 3

[KVM-AUTOTEST PATCH 3/9] KVM test: rss_file_transfer.py: add convenience functions upload() and download()

2010-07-15 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/rss_file_transfer.py | 32 ++-- 1 files changed, 26 insertions(+), 6 deletions(-) diff --git a/client/tests/kvm/rss_file_transfer.py b/client/tests/kvm/rss_file_transfer.py index c584397

[KVM-AUTOTEST PATCH 4/9] [RFC] KVM test: DTM automation program for WHQL tests

2010-07-15 Thread Michael Goldish
This C# program should run on a DTM/WHQL server. It's used by the whql_submission test to schedule and monitor device submission jobs. Note: the binary is copied to the server at run time, so it doesn't need to be packaged in winutils.iso. Signed-off-by: Michael Goldish mgold...@redhat.com

[KVM-AUTOTEST PATCH 5/9] [RFC] KVM test: DTM machine deletion tool for WHQL tests

2010-07-15 Thread Michael Goldish
). Note: the binary is copied to the server at run time, so it doesn't need to be packaged in winutils.iso. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/whql_delete_machine_15.cs | 82 ++ client/tests/kvm/deps/whql_delete_machine_15.exe

[KVM-AUTOTEST PATCH 6/9] [RFC] KVM test: add utility functions start_windows_service() and stop_windows_service()

2010-07-15 Thread Michael Goldish
These utilities use sc to stop and start windows services. They're used by whql_submission and whql_client_install to stop or restart wttsvc on the client machine. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 46

[KVM-AUTOTEST PATCH 7/9] [RFC] KVM test: add whql_submission test

2010-07-15 Thread Michael Goldish
-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_submission.py | 176 + 1 files changed, 176 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm/tests/whql_submission.py diff --git a/client/tests/kvm/tests/whql_submission.py b/client

[KVM-AUTOTEST PATCH 8/9] [RFC] KVM test: add whql_client_install test

2010-07-15 Thread Michael Goldish
whql_client_install installs the DTM client on a guest. It requires a functioning external DTM server which runs rss.exe like regular Windows VMs. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/whql_client_install.py | 110 + 1 files

[KVM-AUTOTEST PATCH 9/9] [RFC] KVM test: add WHQL test definitions to tests_base.cfg.sample

2010-07-15 Thread Michael Goldish
and WinVista.64sp2 to WinVista.64.sp2. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests.cfg.sample |8 + client/tests/kvm/tests_base.cfg.sample | 230 2 files changed, 184 insertions(+), 54 deletions(-) diff --git a/client/tests

Re: [Autotest] [PATCH 1/2] KVM Test: Update cmd() help function in kvm_monitor.py to support parameters.

2010-07-12 Thread Michael Goldish
On 07/12/2010 10:57 PM, Lucas Meneghel Rodrigues wrote: On Mon, 2010-06-28 at 05:43 -0400, Feng Yang wrote: - Michael Goldish mgold...@redhat.com wrote: Why not add a wrapper for the command you're interested in? If we do it your way, a test that uses cmd() with parameters will have

[KVM-AUTOTEST PATCH] KVM test: setuprss.bat: add yet another way of disabling the firewall

2010-07-12 Thread Michael Goldish
-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/setuprss.bat |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/deps/setuprss.bat b/client/tests/kvm/deps/setuprss.bat index 97298cd..42b1709 100644 --- a/client/tests/kvm/deps/setuprss.bat +++ b

Re: [Autotest] [KVM-AUTOTEST PATCH] KVM test: rss.cpp: minimize window by default so it doesn't bother step files

2010-07-08 Thread Michael Goldish
On 07/08/2010 04:43 AM, Chen Cao wrote: Michael, Can rss provide some log (files)? Cao, Chen Not right now, but I'll post a patch that will enable logging. On Wed, Jul 07, 2010 at 01:32:17PM +0300, Michael Goldish wrote: Signed-off-by: Michael Goldish mgold...@redhat.com --- client

[KVM-AUTOTEST PATCH] KVM test: fail if qemu complains about KVM module trouble

2010-07-08 Thread Michael Goldish
If qemu is tested without KVM intentionally (e.g. with -no-kvm) it won't complain and the KVM test won't complain either. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/client

[KVM-AUTOTEST PATCH 1/2] KVM test: rss.cpp: use critical section instead of mutex for text buffer access

2010-07-08 Thread Michael Goldish
A critical section should be faster. The difference for this application may or may not be noticeable (with a large number of files). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/rss.cpp | 15 --- 1 files changed, 8 insertions(+), 7 deletions

[KVM-AUTOTEST PATCH 2/2] KVM test: rss.cpp: write all user messages to a log file

2010-07-08 Thread Michael Goldish
The log file will be placed in the current directory. For example, when rss.exe is run at startup as administrator under WinXP, the current directory will be C:\Documents and Settings\Administrator. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/rss.cpp | 21

[KVM-AUTOTEST PATCH] KVM test: kvm_vm.py: do not check nic_mode when adding -tftp option

2010-07-07 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 603576f..e631a3a 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm

[KVM-AUTOTEST PATCH] KVM test: rss.cpp: minimize window by default so it doesn't bother step files

2010-07-07 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/rss.cpp |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/deps/rss.cpp b/client/tests/kvm/deps/rss.cpp index 26c5ed6..8df70e4 100644 --- a/client/tests/kvm/deps/rss.cpp +++ b

[KVM-AUTOTEST PATCH] KVM test: deal with incompatible env files gracefully (using version numbers)

2010-07-07 Thread Michael Goldish
. This will prevent exceptions being raised due to newly added VM attributes that are missing from old env files. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |3 ++- client/tests/kvm/kvm_utils.py | 16 +++- 2 files changed, 13 insertions

[KVM-AUTOTEST PATCH] KVM test: when available, use new syntax instead of -tftp, -bootp and -redir

2010-07-05 Thread Michael Goldish
In new qemu versions the tftp, bootp and redir options may be given as part of the -net user option. If the output of 'qemu -help' indicates that this syntax is acceptable, use it instead of the old one. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py

[KVM-AUTOTEST PATCH v4] [RFC] KVM test: rss.cpp: add file transfer support

2010-07-04 Thread Michael Goldish
appropriate. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/rss.cpp | 1449 - 1 files changed, 990 insertions(+), 459 deletions(-) diff --git a/client/tests/kvm/deps/rss.cpp b/client/tests/kvm/deps/rss.cpp index 66d9a5b..26c5ed6

[KVM-AUTOTEST PATCH v4] [RFC] KVM test: add python client for rss file transfer services

2010-07-04 Thread Michael Goldish
/dirs are transferred (due to a bad path or wildcard pattern) - Make all connection related errors in the base class raise FileTransferConnectError Changes from v1: - Use glob() instead of iglob() (Python 2.4 doesn't like iglob()) - Change a few comments Signed-off-by: Michael Goldish mgold

<    1   2   3   4   5   6   7   >