[KVM-AUTOTEST PATCH] Use new function VM.get_name() to get the VM's name, instead of VM.name

2009-05-24 Thread Michael Goldish
kvm_vm.py: add function VM.get_name(). kvm_preprocessing.py: use VM.get_name() instead of directly accessing the .name attribute. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm_runtest_2/kvm_preprocessing.py |6 +++--- client/tests/kvm_runtest_2/kvm_vm.py

[KVM-AUTOTEST PATCH] kvm_vm.py: choose a monitor filename in the constructor instead of VM.create()

2009-05-24 Thread Michael Goldish
This will reduce the number of monitor files left in /tmp, because the constructor is called fewer times than VM.create(). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm_runtest_2/kvm_vm.py | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff

[KVM-AUTOTEST PATCH] VM.create(): always destroy() the VM before attempting to start it

2009-05-24 Thread Michael Goldish
Also, don't do it in kvm_preprocessing.py since it's now done in kvm_vm.py. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm_runtest_2/kvm_preprocessing.py |1 - client/tests/kvm_runtest_2/kvm_vm.py|2 ++ 2 files changed, 2 insertions(+), 1 deletions

[KVM-AUTOTEST PATCH] kvm_vm.py: add new function VM.clone() which returns a clone of the VM

2009-05-24 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm_runtest_2/kvm_vm.py | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm_runtest_2/kvm_vm.py b/client/tests/kvm_runtest_2/kvm_vm.py index af06693..9571a3b 100644

[KVM-AUTOTEST PATCH] kvm_vm.py: make sure the bulk of VM.create() is not executed in parallel

2009-05-24 Thread Michael Goldish
VM.create() does a few things (such as finding free ports) which are not safe to execute in parallel. Use a lock file to make sure this doesn't happen. The lock is released only after the VM is started or fails to start. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests

[KVM-AUTOTEST PATCH] kvm_utils.py: remote_login(): improve regular expression matching

2009-05-24 Thread Michael Goldish
1. Make the 'login:' regular expression stricter so it doesn't match 'Last login: ...' messages. 2. Make the 'password:' regular expression stricter. 3. Handle 'Connection refused' messages. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm_runtest_2/kvm_utils.py | 13

[KVM-AUTOTEST PATCH] kvm_runtest_2.py: use environment filename specified by the 'env' parameter

2009-05-24 Thread Michael Goldish
Do not use hardcoded environment filename 'env'. Instead use the value specified by the 'env' parameter. If unspecified, use 'env' as the filename. This is important for parallel execution; it may be necessary to use a separate environment file for each process. Signed-off-by: Michael Goldish

[KVM-AUTOTEST PATCH] kvm_vm.py: add new VM parameter 'x11_display' that controls $DISPLAY

2009-05-24 Thread Michael Goldish
If x11_display is specified, the DISPLAY environment variable is set to this value for the QEMU process. This may be useful for SDL rendering. Also add some comments. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm_runtest_2/kvm_vm.py | 12 +++- 1 files changed

[KVM-AUTOTEST PATCH] kvm_runtest_2.py: use pickle instead of shelve when loading/saving env

2009-05-24 Thread Michael Goldish
once per test (such a class will be introduced in a future patch). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm_runtest_2/kvm_runtest_2.py | 29 -- 1 files changed, 22 insertions(+), 7 deletions(-) diff --git a/client/tests/kvm_runtest_2

Re: [PATCH] [KVM_Autotest] Added functionality to the preprocessor to run scripts

2009-05-22 Thread Michael Goldish
Looks good to me. See some comments below. - David Huff dh...@redhat.com wrote: This patch will run pre and post scripts defined in config file with the parameter pre_command and post_command post_command. Also exports all the prameters in preprocess for passing arguments to the

Re: [RFC] KVM-Autotest: basic parallel test execution

2009-05-20 Thread Michael Goldish
- Mike Burns mbu...@redhat.com wrote: Avi Kivity wrote: Michael Goldish wrote: Drawbacks: - requires some initial work to be done by the user -- the user has to define exactly where each test should run For me, this is a major drawback. I'd really like a fire-and-forget

Re: [PATCH][KVM-AUTOTEST] Add ability to install custom kernel modules

2009-05-20 Thread Michael Goldish
- Mike Burns mbu...@redhat.com wrote: See comments and example in control file for details. Signed-off-by: Mike Burns mbu...@redhat.com --- client/tests/kvm_runtest_2/control|6 ++ client/tests/kvm_runtest_2/kvm_install.py |7 +++ 2 files changed, 13

KVM-Autotest: server problem

2009-05-18 Thread Michael Goldish
Hi Lucas, Since I consider you our Autotest reference I direct the following question to you. Currently our Autotest servers run tests in client mode using the same control file on all hosts. We want to move on to dispatching tests from the server, using a server control file, so that each

[RFC] KVM-Autotest: basic parallel test execution

2009-05-17 Thread Michael Goldish
Hi all, We've recently implemented a very simple form of parallel test execution into KVM-Autotest and we'd like some feedback on it. This suggestion allows the user to manually assign tests to hosts/queues. It also takes care of assigning different MAC address ranges to hosts/queues. By

Re: kvm-autotest: The automation plans?

2009-05-14 Thread Michael Goldish
- jason wang jasow...@redhat.com wrote: sudhir kumar 写道: Hi Uri/Lucas, Do you have any plans for enhancing kvm-autotest? I was looking mainly on the following 2 aspects: (1). we have standalone migration only. Is there any plans of enhancing kvm-autotest so that we can

Re: [PATCH][KVM-AUTOTEST] TAP network support in kvm-autotest

2009-05-14 Thread Michael Goldish
Hi Jason, We already have patches that implement similar functionality here in TLV, as mentioned in the to-do list (item #4 under 'Framework'). They're not yet committed upstream because they're still quite fresh. Still, your patch looks good and is quite similar to mine. The main difference is

Re: kvm-autotest: The automation plans?

2009-05-14 Thread Michael Goldish
- sudhir kumar smalik...@gmail.com wrote: On Thu, May 14, 2009 at 12:22 PM, jason wang jasow...@redhat.com wrote: sudhir kumar 写道: Hi Uri/Lucas, Do you have any plans for enhancing kvm-autotest? I was looking mainly on the following 2 aspects: (1). we have standalone

Re: kvm-autotest: The automation plans?

2009-05-14 Thread Michael Goldish
- sudhir kumar smalik...@gmail.com wrote: On Wed, May 13, 2009 at 11:30 PM, Michael Goldish mgold...@redhat.com wrote: - sudhir kumar smalik...@gmail.com wrote: Hi Uri/Lucas, Do you have any plans for enhancing kvm-autotest? I was looking mainly on the following 2 aspects

Re: [RFC + PATCHES] Work to get KVM autotest upstream

2009-05-13 Thread Michael Goldish
The patches look good, but I haven't tested them yet to make sure they leave everything at a functional state (will test them and let you know). I have a somewhat related question: how is KVM-Autotest development going to proceed after the upstream merge? Currently I have comfortable access to

Re: kvm-autotest: The automation plans?

2009-05-13 Thread Michael Goldish
- sudhir kumar smalik...@gmail.com wrote: Hi Uri/Lucas, Do you have any plans for enhancing kvm-autotest? I was looking mainly on the following 2 aspects: (1). we have standalone migration only. Is there any plans of enhancing kvm-autotest so that we can trigger migration while a

Re: [RFC + PATCHES] Work to get KVM autotest upstream

2009-05-13 Thread Michael Goldish
- Lucas Meneghel Rodrigues mrodr...@redhat.com wrote: On Wed, 2009-05-13 at 12:23 -0400, Michael Goldish wrote: The patches look good, but I haven't tested them yet to make sure they leave everything at a functional state (will test them and let you know). Thanks Michael! I

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Michael Goldish
- Mike Burns mbu...@redhat.com wrote: Eduardo Habkost wrote: Hi, Excerpts from Michael Burns's message of Fri May 08 15:55:30 -0300 2009: --- a/client/tests/kvm_runtest_2/kvm_install.py +++ b/client/tests/kvm_runtest_2/kvm_install.py @@ -77,6 +77,17 @@ def

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Michael Goldish
- Eduardo Habkost ehabk...@redhat.com wrote: On Mon, May 11, 2009 at 01:36:26PM -0400, Michael Goldish wrote: - Mike Burns mbu...@redhat.com wrote: Eduardo Habkost wrote: snip Maybe something like (untested): for k in params.keys(): os.putenv

Re: [KVM-AUTOTEST] [PATCH] support for remote migration

2009-05-04 Thread Michael Goldish
Thanks for the new patch. I'll comment on it later because I want to take some more time to review it. The login prompt problem is my fault -- please see my comment below. - yogi anant...@linux.vnet.ibm.com wrote: Hello everyone, I like to resubmit patch to add support for remote

Re: [KVM-AUTOTEST] [PATCH] Iterate over reboot

2009-05-01 Thread Michael Goldish
- supriya kannery supri...@in.ibm.com wrote: Uri Lublin wrote: supriya kannery wrote: A patch for iterating over VM reboot I think adding iterations capability belongs to the infrastructure, not the test itself. Implement it once in the infrastructure, instead of once per

Re: [KVM-AUTOTEST] [PATCH] support for remote migration

2009-04-30 Thread Michael Goldish
- yogi anant...@linux.vnet.ibm.com wrote: Hello everyone, I like to submit patch to add support for remote migration in kvm-autotest. Sounds like a good idea. Also, the patch isn't too big, which I personally appreciate very much (makes it easier to read). To use this patch the

Re: [PATCH] kvm-autotest: add object addressing in sample cfg

2009-04-03 Thread Michael Goldish
- Ryan Harper ry...@us.ibm.com wrote: The wiki documents[1] object addressing quite well, but we should include it in the example config file as well. 1. http://www.linux-kvm.org/page/KVM-Autotest/Parameters#Addressing_objects_.28VMs.2C_images.2C_NICs_etc.29 -- Ryan Harper

Re: kvm-autotest: weird memory error during stepmaker test

2009-04-03 Thread Michael Goldish
- Eduardo Habkost ehabk...@raisama.net wrote: Excerpts from Ryan Harper's message of Qua Abr 01 12:55:58 -0300 2009: Wondering if anyone else using kvm-autotest stepmaker has ever seen this error: Traceback (most recent call last): File

Re: kvm-autotest -- introducing kvm_runtest_2

2009-03-11 Thread Michael Goldish
- Ryan Harper ry...@us.ibm.com wrote: * Michael Goldish mgold...@redhat.com [2009-03-10 20:55]: - Ryan Harper ry...@us.ibm.com wrote: - guest install wizard using md5sum region matching ... ouch. This is quite fickle. I've seen different kvms generate different

Re: kvm-autotest -- introducing kvm_runtest_2

2009-03-10 Thread Michael Goldish
- Ryan Harper ry...@us.ibm.com wrote: - guest install wizard using md5sum region matching ... ouch. This is quite fickle. I've seen different kvms generate different md5sum for the same region a couple of times. I know distributing screenshots of certain OSes is a grey area,

<    2   3   4   5   6   7