TCM_Loop virtual SAS Ports + megasas HBA emulation into Linux Guests

2010-04-15 Thread Nicholas A. Bellinger
Greetings Hannes, Christoph and Co, So after some additional discussions on and off the linux-scsi list wrt to KVM + megasas emulation, I got motivated and decided to try it out for myself using the QEMU code from Gerd's tree at: http://repo.or.cz/w/qemu/kraxel.git branch: scsi.v9. As expected

[PATCH] QEMU-KVM scsi-bus: Add LBA+Transfer Length to outgoing SBC CDBs in scsi_req_setup() for SG_IO

2010-05-01 Thread Nicholas A. Bellinger
Greetings Hannes, Gerd and co, So after doing more digging into the work for a SGL capable QEMU SCSI HBA emulation interface with the megasas driver on Linux/KVM Hosts, I realized that the SG_IO breakage we originally encountered is due to the fact that CDBs containing SBC LBA+block_count where

[QEMU-KVM]: Megasas + TCM_Loop + SG_IO into Windows XP guests

2010-05-13 Thread Nicholas A. Bellinger
Greetings Hannes and co, I have been spending a bit of time trying Megasas HBA emulation + TCM_Loop + SG_IO with a Windows XP SP2 KVM guests.. So far, I noticed that hw/scsi-generic.c:execute_command_run() using bdev_aio_ioctl() appears to be broken for XP guests, which causes the first 36-byte

Re: [QEMU-KVM]: Megasas + TCM_Loop + SG_IO into Windows XP guests

2010-05-14 Thread Nicholas A. Bellinger
On Fri, 2010-05-14 at 09:22 +0200, Hannes Reinecke wrote: Nicholas A. Bellinger wrote: Greetings Hannes and co, SNIP So, I ended up needing requiring the following quick hack for hw/scsi-generic.c:execute_command_run() to make SG_IO function synchronously using bdrv_ioctl(), which

[PATCH 0/2] Fix scsi-generic breakage in upstream qemu-kvm.git

2010-05-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings Kevin and hch, After pulling from upstream qemu-kvm.git/master into the megasas qemu-kvm.git tree, I ran into some breakage with scsi-generic devices returning an -ESPIPE exception in bdrv_open() - find_image_format() - bdrv_read

[PATCH 1/2] [block]: Fix scsi-generic breakage in find_image_format()

2010-05-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a special BlockDriverState-sg check in block.c:find_image_format() after bdrv_file_open() - block/raw-posix.c:hdev_open() has been called to determine if we are dealing with a Linux host scsi-generic device or not. The patch

[PATCH 2/2] [block]: Skip refresh_total_sectors() for scsi-generic devices

2010-05-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a BlockDriverState-sg check in block.c:bdrv_common_open() to skip the new refresh_total_sectors() call once we know we are working with a scsi-generic device. We go ahead and skip this call for scsi-generic devices because block/raw

Re: [PATCH 1/2] [block]: Fix scsi-generic breakage in find_image_format()

2010-05-16 Thread Nicholas A. Bellinger
On Sun, 2010-05-16 at 15:29 +0200, Christoph Hellwig wrote: On Sat, May 15, 2010 at 06:30:52AM -0700, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a special BlockDriverState-sg check in block.c:find_image_format() after bdrv_file_open

Re: [PATCH 2/2] [block]: Skip refresh_total_sectors() for scsi-generic devices

2010-05-16 Thread Nicholas A. Bellinger
On Sun, 2010-05-16 at 15:30 +0200, Christoph Hellwig wrote: On Sat, May 15, 2010 at 06:30:59AM -0700, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a BlockDriverState-sg check in block.c:bdrv_common_open() to skip the new refresh_total_sectors

[PATCH 0/2] Fix scsi-generic breakage in upstream qemu-kvm.git

2010-05-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings, Attached are the updated patches following hch's comments to fix scsi-generic device breakage with find_image_format() and refresh_total_sectors(). These are being resent as the last attachments where in MBOX format from git-format-patch

[PATCH 2/2] [block]: Add SG_IO device check in refresh_total_sectors()

2010-05-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a special case check for scsi-generic devices in refresh_total_sectors() to skip the subsequent BlockDriver-bdrv_getlength() that will be returning -ESPIPE from block/raw-posic.c:raw_getlength() for BlockDriverState-sg=1 devices

[PATCH 1/2] [block]: Make find_image_format() return 'raw' BlockDriver for SG_IO devices

2010-05-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a special BlockDriverState-sg check in block.c:find_image_format() after bdrv_file_open() - block/raw-posix.c:hdev_open() has been called to determine if we are dealing with a Linux host scsi-generic device. The patch then returns

Re: [QEMU-KVM]: Megasas + TCM_Loop + SG_IO into Windows XP guests

2010-05-17 Thread Nicholas A. Bellinger
On Fri, 2010-05-14 at 02:42 -0700, Nicholas A. Bellinger wrote: On Fri, 2010-05-14 at 09:22 +0200, Hannes Reinecke wrote: Nicholas A. Bellinger wrote: Greetings Hannes and co, SNIP Let's see if I can find some time working on the megasas emulation. Maybe I find something. Last

Re: [QEMU-KVM]: Megasas + TCM_Loop + SG_IO into Windows XP guests

2010-05-18 Thread Nicholas A. Bellinger
On Tue, 2010-05-18 at 11:43 +0200, Hannes Reinecke wrote: Nicholas A. Bellinger wrote: On Fri, 2010-05-14 at 02:42 -0700, Nicholas A. Bellinger wrote: On Fri, 2010-05-14 at 09:22 +0200, Hannes Reinecke wrote: Nicholas A. Bellinger wrote: Greetings Hannes and co, SNIP Let's see if I

Re: [Qemu-devel] [PATCH 0/2] Fix scsi-generic breakage in upstream qemu-kvm.git

2010-05-27 Thread Nicholas A. Bellinger
On Thu, 2010-05-20 at 15:18 +0200, Kevin Wolf wrote: Am 17.05.2010 18:45, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org Greetings, Attached are the updated patches following hch's comments to fix scsi-generic device breakage with find_image_format

Re: [QEMU-KVM]: Megasas + TCM_Loop + SG_IO into Windows XP guests

2010-05-29 Thread Nicholas A. Bellinger
On Tue, 2010-05-18 at 04:18 -0700, Nicholas A. Bellinger wrote: On Tue, 2010-05-18 at 11:43 +0200, Hannes Reinecke wrote: Nicholas A. Bellinger wrote: On Fri, 2010-05-14 at 02:42 -0700, Nicholas A. Bellinger wrote: Greetings Hannes, So I spent some more time with XP guests

[PATCH 0/2] Setup scsi-bus xfer and xfer_mode for PR IN/OUT and Maintenance IN/OUT

2010-05-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings Gerd, Kevin and Co, Attached are two patches to add the necesary CDB parsing to determine SCSIRequest-cmd.xfer (length) and SCSIRequest-cmd.mode (direction) for Persistent Reservation IN/OUT CDBs and for Maintenance IN/OUT CDBs used

[PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-05-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and PERSISTENT_RESERVE_IN case in scsi_req_length() to extra the incoming buffer length into SCSIRequest-cmd.xfer, and adds a second PERSISTENT_RESERVE_OUT case in scsi_req_xfer_mode

[PATCH 2/2] [scsi-bus]: Add MAINTENANCE_IN and MAINTENANCE_OUT case for SCSIRequest xfer and xfer_mode setup

2010-05-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add MAINTENANCE_IN and MAINTENANCE_OUT case in scsi_req_length() to extra the incoming buffer length into SCSIRequest-cmd.xfer, and adds a second MAINTENANCE_OUT case in scsi_req_xfer_mode() in order to properly

Re: [PATCH] megasas: Update to version 1.01

2010-06-09 Thread Nicholas A. Bellinger
On Wed, 2010-06-09 at 03:14 -0700, Nicholas A. Bellinger wrote: On Tue, 2010-06-08 at 16:15 +0200, Hannes Reinecke wrote: This patch updates the megasas HBA emulation to version 1.01. It fixes the following issues: - Remove hand-crafted inquiry command - Remove bounce-buffer for direct

Re: [PATCH] megasas: Update to version 1.01

2010-06-09 Thread Nicholas A. Bellinger
On Wed, 2010-06-09 at 12:32 +0200, Hannes Reinecke wrote: Nicholas A. Bellinger wrote: Hi Hannes, I applied your changes and everything looks good with the exception of the new MEGASAS_DEFAULT_SGE=80 setting.. diff --git a/hw/megasas.c b/hw/megasas.c index 250c3fb..19569a8 100644

Re: [PATCH] [BSG]: Add support for struct sg_io_v4-d[out,in]_iovec_count

2010-06-14 Thread Nicholas A. Bellinger
On Mon, 2010-06-14 at 15:22 +0900, FUJITA Tomonori wrote: On Sun, 13 Jun 2010 23:11:29 -0700 Nicholas A. Bellinger n...@linux-iscsi.org wrote: From: Nicholas Bellinger n...@linux-iscsi.org Greetings Jens and co, This patch adds the missing support to block/bsg.c:bsg_map_hdr

[PATCH 0/5] *** SUBJECT HERE ***

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings Gerd, Hannes and co, This series adds initial support for a hw/scsi-bsg.c backstore for scsi-bus compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG driver. This code is available from the scsi-bsg branch in the megasas

[PATCH 1/5] [block]: Add top level BSG support

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds top level BSG support to QEMU-KVM block and adds the BDS_* prefixed defines for SG_IO and BSG. It adds the BDS_SCSI_GENERIC and BDS_BSG assignments in block/raw-posix.c:hdev_open() using S_ISCHR() and major(st.st_rdev) in order

[PATCH 2/5] [block]: Add BSG qemu_open() in block/raw.c:raw_open()

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a BSG specific qemu_open() call in block/raw.c:raw_open() that saves the opened file descriptor for BSG AIO into BlockDriverState-fd. It also adds the reverse close() call to block/raw.c:raw_close() Signed-off-by: Nicholas

[PATCH 3/5] [block]: Add paio_submit_len() non sector sized AIO

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds posix-aio-compat.c:paio_submit_len(), which is a identical to paio_submit() expect that in expected nb_len instead of nb_sectors (* 512) so that it can be used by BSG AIO for write()/read() of struct sg_io_v4. Signed-off-by: Nicholas

[PATCH 4/5] [scsi]: Add BSG support for scsi-bus and scsi-disk

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c:scsi_bus_legacy_add_drive() to check for the scsi-bsg backstore. It also updates hw/scsi-disk.c:scsi_disk_initfn() to check for when bdrv_is_bsg() is present and we need to fail for the fileio backed scsi-disk code

[PATCH 5/5] [scsi-bsg]: Add initial support for BSG based SCSIDeviceInfo

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds initial support for using the Linux BSG interface with write/read vectored AIO as a QEMU backstore (SCSIDeviceInfo) with hw/scsi-bus.c compatible HBA emulation. So far it has been tested with x86_64 host and guest using hw/megasas.c

[PATCH 0/5] [QEMU-KVM]: Add BSG backstore using struct sg_io_v4

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Quick resend with project subject for cover letter.. Greetings Gerd, Hannes and co, This series adds initial support for a hw/scsi-bsg.c backstore for scsi-bus compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG driver. This code

Re: [PATCH 3/5] [block]: Add paio_submit_len() non sector sized AIO

2010-06-14 Thread Nicholas A. Bellinger
On Mon, 2010-06-14 at 07:42 -0400, Christoph Hellwig wrote: On Mon, Jun 14, 2010 at 02:44:31AM -0700, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds posix-aio-compat.c:paio_submit_len(), which is a identical to paio_submit() expect

Re: [Qemu-devel] [PATCH 5/5] [scsi-bsg]: Add initial support for BSG based SCSIDeviceInfo

2010-06-14 Thread Nicholas A. Bellinger
On Mon, 2010-06-14 at 18:11 +, Blue Swirl wrote: On Mon, Jun 14, 2010 at 9:44 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds initial support for using the Linux BSG interface with write/read vectored AIO

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Nicholas A. Bellinger
On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add PERSISTENT_RESERVE_OUT and PERSISTENT_RESERVE_IN

Re: [Qemu-devel] Re: [PATCH 1/2] [scsi-bus]: Add PR-OUT and PR-IN case for SCSIRequest xfer and xfer_mode setup

2010-06-16 Thread Nicholas A. Bellinger
On Wed, 2010-06-16 at 06:03 -0700, Nicholas A. Bellinger wrote: On Wed, 2010-06-16 at 14:13 +0200, Kevin Wolf wrote: Am 04.06.2010 16:06, schrieb Kevin Wolf: Am 31.05.2010 03:43, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi

[PATCH 0/2] [scsi-bus]: Changes for PERSISTENT_RESERVE_OUT and MAINTENANCE CDBs v2

2010-06-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings, Attached is v2 for a series containing a handful of changes required for scsi-bus in order to get PERSISTENT_RESERVE_OUT and MAINTENANCE CDBs working as expected. Thanks to Kevin Wolf for pointing out the unnecessary SCSIRequest

[PATCH 1/2] [scsi-bus]: Add PERSISTENT_RESERVE_OUT SCSIRequest-cmd.mode setup

2010-06-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add the PERSISTENT_RESERVE_OUT cdb case in scsi_req_xfer_mode() to set SCSI_XFER_TO_DEV for outgoing WRITE data. Signed-off-by: Nicholas A. Bellinger n...@linux-iscsi.org --- hw/scsi-bus.c |1 + 1 files

[PATCH 2/2] [scsi-bus]: Add MAINTENANCE_IN and MAINTENANCE_OUT SCSIRequest xfer and mode assignments

2010-06-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates hw/scsi-bus.c to add MAINTENANCE_IN and MAINTENANCE_OUT case in scsi_req_length() for TYPE_ROM with MMC commands. It also adds the MAINTENANCE_OUT case in scsi_req_xfer_mode() to set SCSI_XFER_TO_DEV for outgoing write data

MegaSAS 8708EM2 qemu-kvm.git tree updated to v0.12.5

2010-08-15 Thread Nicholas A. Bellinger
Greetings Hannes, hch and Co, The lastest code from upstream qemu-kvm.git v0.12.5 has been merged into the megasas HBA emulation friendly qemu-kvm.git/master and scsi-bsg branches at: http://git.kernel.org/?p=virt/kvm/nab/qemu-kvm.git;a=summary The merge commitdiffs for master and scsi-bsg can

[PATCH] block: Make BSG detection more sane in hdev_open()

2010-08-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings hch, tomo and Co, This patch changes the Linux BSG backstore detect logic in hdev_open() in order to determine when to actually set 'bs-sg = BDS_BSG;' by obtaining the BSG major from a SysFS attribute in /sys/class/bsg/$H:C:T:L/dev, instead

Re: [PATCH] block: Make BSG detection more sane in hdev_open()

2010-08-21 Thread Nicholas A. Bellinger
On Sat, 2010-08-21 at 16:01 -0700, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Greetings hch, tomo and Co, This patch changes the Linux BSG backstore detect logic in hdev_open() in order to determine when to actually set 'bs-sg = BDS_BSG;' by obtaining

[PATCH] lsi53c895a: Fix breakage v0.12.5 merge for SGL passthrough qemu-kvm.git tree

2010-08-22 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings hch, Paul and other lsi53c895a folks, This patch merges the remaining changes from upstream v0.12.5 for hw/lsi53c895a.c to function with the existing SGL passthrough code. This includes the following: *) conversion of lsi_request

Re: [PATCH] block: Make BSG detection more sane in hdev_open()

2010-08-22 Thread Nicholas A. Bellinger
On Sun, 2010-08-22 at 10:31 +0200, Christoph Hellwig wrote: On Sat, Aug 21, 2010 at 04:01:15PM -0700, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Greetings hch, tomo and Co, What tree is this against? I can't see any specificc BSG support in qemu

[PATCH] lsi53c895a: Add missing registers and workaround for OS/2 Warp SYM8XX.ADD driver

2010-09-29 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for using lsi53c895a HBA with SYM8XXX.ADD driver v4.10. This includes adding the missing SOCL and STIME1 registers from lsi_reg_readb(), and missing SOCL and a workaround for bogus SDID WRITE that is requred to function

[PATCH] lsi53c895a: Add support for OS/2 Warp SYM8XX.ADD driver

2010-09-29 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings Paul, Jan, Kevin and co, This series is against my v0.12.5 qemu-kvm.git that contains QEMU SCSI layer SGL passthrough from Gerd Hoffman, 8708EM2 MegaSas emulation from Dr. Hannes Reinecke, and well as my own hw/scsi-bsg.c support

[PATCH] scsi-generic: Add reset handler

2010-09-29 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds NOP scsi_generic_reset() caller to fix an OOPs which is expected to be set by hw/lsi53895a.c code for both scsi-disk and scsi-generic operation. Signed-off-by: Nicholas A. Bellinger n...@linux-iscsi.org --- hw/scsi-generic.c |6

Re: [PATCH] lsi53c895a: Add missing registers and workaround for OS/2 Warp SYM8XX.ADD driver

2010-09-30 Thread Nicholas A. Bellinger
On Thu, 2010-09-30 at 10:07 +0200, Paolo Bonzini wrote: On 09/30/2010 07:07 AM, Nicholas A. Bellinger wrote: case 0x06: /* SDID */ -if ((val 0xf) != (s-ssid 0xf)) -BADF(Destination ID does not match SSID\n); +/* + * This workaround is required

Re: [PATCH] lsi53c895a: Add support for OS/2 Warp SYM8XX.ADD driver

2010-09-30 Thread Nicholas A. Bellinger
On Thu, 2010-09-30 at 15:23 +0200, Hannes Reinecke wrote: Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Greetings Paul, Jan, Kevin and co, This series is against my v0.12.5 qemu-kvm.git that contains QEMU SCSI layer SGL passthrough from Gerd Hoffman

Re: [PATCH -next] tcm_vhost: remove unused variable in vhost_scsi_allocate_cmd()

2012-11-08 Thread Nicholas A. Bellinger
active struct tcm_vhost_nexus\n); return ERR_PTR(-EIO); } - se_sess = tv_nexus-tvn_se_sess; tv_cmd = kzalloc(sizeof(struct tcm_vhost_cmd), GFP_ATOMIC); if (!tv_cmd) { -- Looks fine to me. Reviewed-by + Acked-by: Nicholas Bellinger n...@linux-iscsi.org

[RFC-v2 0/6] vhost-scsi: Add support for host virtualized target

2012-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Paolo, Stefan, QEMU folks, The following is the second RFC series for vhost-scsi patches against mainline QEMU v1.1.0. The series is available from the following working branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost

[RFC-v2 2/6] vhost: Pass device path to vhost_dev_init()

2012-08-13 Thread Nicholas A. Bellinger
: Paolo Bonzini pbonz...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- hw/vhost.c |5 +++-- hw/vhost.h |3 ++- hw/vhost_net.c |2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/vhost.c b/hw

[RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This is required to get past the following assert with: commit 1523ed9e1d46b0b54540049d491475ccac7e6421 Author: Jan Kiszka jan.kis...@siemens.com Date: Thu May 17 10:32:39 2012 -0300 virtio/vhost: Add support for KVM in-kernel MSI injection

[RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-13 Thread Nicholas A. Bellinger
: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- configure| 10 +++ hw/Makefile.objs |1 + hw/qdev-properties.c

[RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI-cmd_vqs[0] definition

2012-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes bug in the definition of VirtIOSCSI-cmd_vqs[0], where the return of virtio_add_queue() in virtio_scsi_init() ends up overwriting past the end of -cmd_vqs[0]. Since virtio_scsi currently assumes a single vqs for data, this patch

[RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-08-13 Thread Nicholas A. Bellinger
: Michael S. Tsirkin m...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- hw/virtio-pci.c |1 + hw/virtio-scsi.c | 48 hw/virtio-scsi.h |1 + 3 files changed, 50 insertions(+), 0

[RFC-v2 5/6] virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This QEMU patch sets VirtIOSCSIConfig-max_target=0 for vhost-scsi operation to restrict virtio-scsi LLD guest scanning to max_id=0 (a single target ID instance) when connected to individual tcm_vhost endpoints. This ensures that virtio-scsi LLD only

Re: [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-14 Thread Nicholas A. Bellinger
On Mon, 2012-08-13 at 21:17 +0300, Michael S. Tsirkin wrote: On Mon, Aug 13, 2012 at 08:06:17PM +0200, Jan Kiszka wrote: On 2012-08-13 20:03, Michael S. Tsirkin wrote: On Mon, Aug 13, 2012 at 02:06:10PM +0200, Jan Kiszka wrote: On 2012-08-13 10:35, Nicholas A. Bellinger wrote: From

Re: [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI-cmd_vqs[0] definition

2012-08-14 Thread Nicholas A. Bellinger
On Mon, 2012-08-13 at 12:02 +0300, Michael S. Tsirkin wrote: On Mon, Aug 13, 2012 at 08:35:17AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes bug in the definition of VirtIOSCSI-cmd_vqs[0], where the return of virtio_add_queue

Re: [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-14 Thread Nicholas A. Bellinger
On Mon, 2012-08-13 at 11:53 +0300, Michael S. Tsirkin wrote: On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch adds a new type of host device that drives the vhost_scsi device. The syntax to add vhost-scsi

Re: [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-14 Thread Nicholas A. Bellinger
On Mon, 2012-08-13 at 11:59 +0300, Michael S. Tsirkin wrote: On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch adds a new type of host device that drives the vhost_scsi device. The syntax to add vhost-scsi

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-14 Thread Nicholas A. Bellinger
On Mon, 2012-08-13 at 19:47 +, Blue Swirl wrote: On Mon, Aug 13, 2012 at 8:35 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch adds a new type of host device that drives the vhost_scsi device. The syntax to add vhost

Re: [PATCH] kvm tools: Add initial virtio-scsi support

2012-08-14 Thread Nicholas A. Bellinger
On Tue, 2012-08-14 at 07:45 +0100, Stefan Hajnoczi wrote: On Tue, Aug 14, 2012 at 09:52:55AM +0800, Asias He wrote: On Mon, Aug 13, 2012 at 3:24 PM, Pekka Enberg penb...@kernel.org wrote: On Thu, Aug 9, 2012 at 3:51 AM, Asias He asias.he...@gmail.com wrote: SNIP --- diff --git

Re: [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI-cmd_vqs[0] definition

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 20:52 +0200, Paolo Bonzini wrote: Il 14/08/2012 22:20, Nicholas A. Bellinger ha scritto: Since virtio_scsi currently assumes a single vqs for data, this patch simply changes -cmd_vqs[1] to handle the single VirtQueue. Wrong, multiqueue works just fine. :) It's

Re: [GIT PULL] tcm_vhost: Initial merge of vhost level target fabric driver

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 23:04 +0300, Michael S. Tsirkin wrote: Hi Nicholas, I just noticed this problem in the interface: +#include linux/vhost.h + +/* + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. + * + * ABI Rev 0: July 2012 version starting point for v3.6-rc merge

Re: [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 22:10 +0300, Michael S. Tsirkin wrote: On Tue, Aug 14, 2012 at 02:12:29PM -0700, Nicholas A. Bellinger wrote: On Mon, 2012-08-13 at 11:59 +0300, Michael S. Tsirkin wrote: On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: SNIP +if (ret

Re: [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 22:12 +0300, Michael S. Tsirkin wrote: On Tue, Aug 14, 2012 at 01:31:14PM -0700, Nicholas A. Bellinger wrote: On Mon, 2012-08-13 at 11:53 +0300, Michael S. Tsirkin wrote: On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: From: Stefan Hajnoczi

Re: [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-20 Thread Nicholas A. Bellinger
On Sun, 2012-08-19 at 11:44 +0300, Michael S. Tsirkin wrote: On Sat, Aug 18, 2012 at 05:36:26PM -0700, Nicholas A. Bellinger wrote: On Sat, 2012-08-18 at 22:12 +0300, Michael S. Tsirkin wrote: On Tue, Aug 14, 2012 at 01:31:14PM -0700, Nicholas A. Bellinger wrote: On Mon, 2012-08-13 at 11

[RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-08-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, This is the third RFC for vhost-scsi patches against mainline QEMU v1.1 to support the upstream tcm_vhost host virtualized target driver now available in v3.6-rc kernel code. This series is based upon last week's commit 346fe0c4c0b

[RFC-v3 1/5] monitor: Rename+move net_handle_fd_param - monitor_handle_fd_param

2012-08-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch renames+moves the net_handle_fd_param() caller used to obtain a file descriptor from either qemu_parse_fd() (the normal case) or from monitor_get_fd() (migration case) into a generically prefixed monitor_handle_fd_param() to be used

[RFC-v3 2/5] vhost: Pass device path to vhost_dev_init()

2012-08-21 Thread Nicholas A. Bellinger
: Paolo Bonzini pbonz...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- hw/vhost.c |5 +++-- hw/vhost.h |3 ++- hw/vhost_net.c |2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/vhost.c b/hw

[RFC-v3 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-08-21 Thread Nicholas A. Bellinger
by paolo) - Only register QEMU SCSI bus is vhost-scsi is not active (reported by paolo) Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Nicholas Bellinger n

[RFC-v3 3/5] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-21 Thread Nicholas A. Bellinger
: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- configure| 10 +++ hw/Makefile.objs |1 + hw/qdev-properties.c

[RFC-v3 5/5] virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-08-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This QEMU patch sets VirtIOSCSIConfig-max_target=0 for vhost-scsi operation to restrict virtio-scsi LLD guest scanning to max_id=0 (a single target ID instance) when connected to individual tcm_vhost endpoints. This ensures that virtio-scsi LLD only

Re: [PATCH V2] kvm tools: Add initial virtio-scsi support

2012-08-21 Thread Nicholas A. Bellinger
the GET_ABI_VERSION to return 'int': #define VHOST_SCSI_GET_ABI_VERSION _IOW(VHOST_VIRTIO, 0x42, int) Aside from this minor bit, I think the patch looks good wrt to upstream tcm_vhost kernel code. Feel free to add my: Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org Nice work Asias

Re: [PATCH 5/5] virtio-scsi: introduce multiqueue support

2012-09-03 Thread Nicholas A. Bellinger
On Tue, 2012-08-28 at 13:54 +0200, Paolo Bonzini wrote: This patch adds queue steering to virtio-scsi. When a target is sent multiple requests, we always drive them to the same queue so that FIFO processing order is kept. However, if a target was idle, we can choose a queue arbitrarily. In

Re: [PATCH 5/5] virtio-scsi: introduce multiqueue support

2012-09-04 Thread Nicholas A. Bellinger
On Tue, 2012-09-04 at 08:46 +0200, Paolo Bonzini wrote: Il 04/09/2012 04:21, Nicholas A. Bellinger ha scritto: @@ -112,6 +118,9 @@ static void virtscsi_complete_cmd(struct virtio_scsi *vscsi, void *buf) struct virtio_scsi_cmd *cmd = buf; struct scsi_cmnd *sc = cmd-sc; struct

[PATCH 0/5] vhost-scsi: Add support for host virtualized target

2012-09-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git

[PATCH 1/5] monitor: Rename+move net_handle_fd_param - monitor_handle_fd_param

2012-09-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch renames+moves the net_handle_fd_param() caller used to obtain a file descriptor from either qemu_parse_fd() (the normal case) or from monitor_get_fd() (migration case) into a generically prefixed monitor_handle_fd_param() to be used

[PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-07 Thread Nicholas A. Bellinger
by paolo) - Only register QEMU SCSI bus is vhost-scsi is not active (reported by paolo) Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Nicholas Bellinger n

[PATCH 5/5] virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-09-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This QEMU patch sets VirtIOSCSIConfig-max_target=0 for vhost-scsi operation to restrict virtio-scsi LLD guest scanning to max_id=0 (a single target ID instance) when connected to individual tcm_vhost endpoints. This ensures that virtio-scsi LLD only

[PATCH 2/5] vhost: Pass device path to vhost_dev_init()

2012-09-07 Thread Nicholas A. Bellinger
: Paolo Bonzini pbonz...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- hw/vhost.c |5 +++-- hw/vhost.h |3 ++- hw/vhost_net.c |2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/vhost.c b/hw

[PATCH 3/5] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-09-07 Thread Nicholas A. Bellinger
: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- configure| 10 +++ hw/Makefile.objs |1 + hw/qdev-properties.c

Re: [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-07 Thread Nicholas A. Bellinger
On Fri, 2012-09-07 at 09:37 +0300, Michael S. Tsirkin wrote: On Fri, Sep 07, 2012 at 09:32:37AM +0300, Michael S. Tsirkin wrote: On Fri, Sep 07, 2012 at 09:23:22AM +0300, Michael S. Tsirkin wrote: On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: From: Nicholas

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-07 Thread Nicholas A. Bellinger
On Fri, 2012-09-07 at 18:00 +0200, Paolo Bonzini wrote: Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off

Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2012-09-13 Thread Nicholas A. Bellinger
On Tue, 2012-09-11 at 12:36 +0800, Asias He wrote: Hello Nicholas, Hello Asias! On 09/07/2012 02:48 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-13 Thread Nicholas A. Bellinger
On Tue, 2012-09-11 at 18:07 +0300, Michael S. Tsirkin wrote: On Tue, Sep 11, 2012 at 08:46:34AM -0500, Anthony Liguori wrote: On 09/10/2012 01:24 AM, Michael S. Tsirkin wrote: On Mon, Sep 10, 2012 at 08:16:54AM +0200, Paolo Bonzini wrote: Il 09/09/2012 00:40, Michael S. Tsirkin ha scritto:

Re: [PATCH v3 3/6] vbus: add a vbus-proxy bus model for vbus_driver objects

2009-08-19 Thread Nicholas A. Bellinger
On Wed, 2009-08-19 at 14:39 -0400, Gregory Haskins wrote: Hi Nicholas Nicholas A. Bellinger wrote: On Wed, 2009-08-19 at 10:11 +0300, Avi Kivity wrote: On 08/19/2009 09:28 AM, Gregory Haskins wrote: Avi Kivity wrote: SNIP Basically, what it comes down to is both vbus and vhost

Re: configfs/sysfs

2009-08-19 Thread Nicholas A. Bellinger
On Wed, 2009-08-19 at 15:16 -0700, Joel Becker wrote: On Wed, Aug 19, 2009 at 11:12:43PM +0300, Avi Kivity wrote: On 08/19/2009 09:23 PM, Nicholas A. Bellinger wrote: Anyways, I was wondering if you might be interesting in sharing your concerns wrt to configfs (conigfs maintainer CC'ed

KVM x86_64 with SR-IOV..?

2009-04-30 Thread Nicholas A. Bellinger
Greetings KVM folks, I wondering if any information exists for doing SR-IOV on the new VT-d capable chipsets with KVM..? From what I understand the patches for doing this with KVM are floating around, but I have been unable to find any user-level docs for actually making it all go against a

Re: [Qemu-devel] Re: [PATCH] virtio-blk: add SGI_IO passthru support

2009-04-30 Thread Nicholas A. Bellinger
On Thu, 2009-04-30 at 22:13 +0200, Christoph Hellwig wrote: On Wed, Apr 29, 2009 at 12:37:20PM +0100, Paul Brook wrote: How exactly does it introduce additional latency? A scsi command block is hardly large or complicated. Are you suggesting that a 16/32byte scsi command takes

Re: KVM x86_64 with SR-IOV..?

2009-05-03 Thread Nicholas A. Bellinger
On Sat, 2009-05-02 at 18:22 +0800, Sheng Yang wrote: On Thu, Apr 30, 2009 at 01:22:54PM -0700, Nicholas A. Bellinger wrote: Greetings KVM folks, I wondering if any information exists for doing SR-IOV on the new VT-d capable chipsets with KVM..? From what I understand the patches

Re: KVM x86_64 with SR-IOV..?

2009-05-03 Thread Nicholas A. Bellinger
On Mon, 2009-05-04 at 10:09 +0800, Sheng Yang wrote: On Monday 04 May 2009 08:53:07 Nicholas A. Bellinger wrote: On Sat, 2009-05-02 at 18:22 +0800, Sheng Yang wrote: On Thu, Apr 30, 2009 at 01:22:54PM -0700, Nicholas A. Bellinger wrote: Greetings KVM folks, I wondering if any

Re: KVM x86_64 with SR-IOV..?

2009-05-03 Thread Nicholas A. Bellinger
On Sun, 2009-05-03 at 21:36 -0700, Nicholas A. Bellinger wrote: On Mon, 2009-05-04 at 10:09 +0800, Sheng Yang wrote: On Monday 04 May 2009 08:53:07 Nicholas A. Bellinger wrote: On Sat, 2009-05-02 at 18:22 +0800, Sheng Yang wrote: On Thu, Apr 30, 2009 at 01:22:54PM -0700, Nicholas

Re: KVM x86_64 with SR-IOV..?

2009-05-03 Thread Nicholas A. Bellinger
On Sun, 2009-05-03 at 22:28 -0700, Nicholas A. Bellinger wrote: On Sun, 2009-05-03 at 21:36 -0700, Nicholas A. Bellinger wrote: On Mon, 2009-05-04 at 10:09 +0800, Sheng Yang wrote: On Monday 04 May 2009 08:53:07 Nicholas A. Bellinger wrote: On Sat, 2009-05-02 at 18:22 +0800, Sheng Yang

Re: KVM x86_64 with SR-IOV..?

2009-05-04 Thread Nicholas A. Bellinger
On Sun, 2009-05-03 at 22:28 -0700, Nicholas A. Bellinger wrote: On Mon, 2009-05-04 at 10:09 +0800, Sheng Yang wrote: Greetings Sheng, So, I have been trying the latest kvm-85 release on a v2.6.30-rc3 checkout from linux-2.6.git on a CentOS 5u3 x86_64 install on Intel IOH-5520

Re: KVM x86_64 with SR-IOV..?

2009-05-04 Thread Nicholas A. Bellinger
On Mon, 2009-05-04 at 17:49 +0800, Sheng Yang wrote: On Monday 04 May 2009 17:11:59 Nicholas A. Bellinger wrote: On Mon, 2009-05-04 at 16:20 +0800, Sheng Yang wrote: On Monday 04 May 2009 12:36:04 Nicholas A. Bellinger wrote: On Mon, 2009-05-04 at 10:09 +0800, Sheng Yang wrote

Re: KVM x86_64 with SR-IOV..? (device passthrough with LIO-Target v3.0)

2009-05-05 Thread Nicholas A. Bellinger
On Tue, 2009-05-05 at 03:43 -0700, Nicholas A. Bellinger wrote: On Tue, 2009-05-05 at 09:42 +0800, Yu Zhao wrote: Hi, The VF also works in the host if the VF driver is programed properly. So it would be easier to develop the VF driver in the host and then verify the VF driver

Re: KVM x86_64 with SR-IOV..? (device passthrough with LIO-Target v3.0)

2009-05-05 Thread Nicholas A. Bellinger
On Tue, 2009-05-05 at 04:28 -0700, Nicholas A. Bellinger wrote: On Tue, 2009-05-05 at 03:43 -0700, Nicholas A. Bellinger wrote: On Tue, 2009-05-05 at 09:42 +0800, Yu Zhao wrote: Hi, The VF also works in the host if the VF driver is programed properly. So it would be easier

Re: KVM x86_64 with SR-IOV..? (device passthrough with LIO-Target v3.0)

2009-05-06 Thread Nicholas A. Bellinger
On Wed, 2009-05-06 at 11:51 +0800, Sheng Yang wrote: On Wednesday 06 May 2009 01:45:47 Nicholas A. Bellinger wrote: On Tue, 2009-05-05 at 04:28 -0700, Nicholas A. Bellinger wrote: On Tue, 2009-05-05 at 03:43 -0700, Nicholas A. Bellinger wrote: On Tue, 2009-05-05 at 09:42 +0800, Yu Zhao

KVM 10/Gb Ethernet PCIe passthrough with Linux/iSCSI and large block sizes

2009-05-14 Thread Nicholas A. Bellinger
Greetings all, The first test results for Linux/iSCSI Initiators and targets for large block sizes using 10 Gb/sec Ethernet + PCIe device-passthrough into Linux/KVM guests have been posted at: http://linux-iscsi.org/index.php/KVM-LIO-Target So far, the results have been quite impressive using

[ANNOUNCE] lio-utils.git v3.0 configfs HOWTO for v2.6.30 released

2009-06-16 Thread Nicholas A. Bellinger
Grettings all, The Linux-iSCSI.org Target v3.0 HOWTO using the new configfs enabled generic target subsystem python CLI has been released and is up and running on v2.6.30 of the Linux Kernel in x86_64 KVM (Debian), x86_64 bare-metal (SLES) and PPC64 (Fedora PS3) hosts! The HOWTO entry can be

[PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-03 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, This series contains patches required to update tcm_vhost - virtio-scsi connected hosts - guests to run on v3.5-rc2 mainline code. This series is available on top of target-pending/auto-next here: git://git.kernel.org/pub/scm/linux

  1   2   3   4   >