:26: error: expected ‘:’ or ‘)’ before string constant
"orl $0x200, (%%"R"sp)\n\t"
Fix it by putting a space between macro R and a string literal.
(We already do that somewhere.)
Signed-off-by: Radim Krčmář
---
I think it would be better to replace
"[...]"
2015-03-14 18:00-0600, James Sullivan:
> * DM=1, RH=0 : Logical destination mode without redirection. Interrupt
> is delivered to all LAPICs in the logical group
> specified by the IRQ's destination map and delivery
> mode.
Your previou
2015-03-16 11:16-0500, Joel Schopp:
> On 03/12/2015 04:20 PM, Radim Krčmář wrote:
> > 2015-03-12 15:17-0500, Joel Schopp:
> >> There isn't really a valid reason for kvm to intercept cr* reads
> >> on svm hardware. The current kvm code just ends up returning
> &
2015-03-16 11:28-0600, James Sullivan:
> Changes Since v1:
> * Reworked patches into two commits:
> 1) [Patch v2 1/2] Extended struct kvm_lapic_irq with bool
> msi_redir_hint
> * Initialize msi_redir_hint = true in kvm_set_msi_irq when RH=1
> * Initia
nested_vmx_vmexit+0x96e/0xb00 [kvm_intel] ()
Prevent this scenario by masking SECONDARY_EXEC_UNRESTRICTED_GUEST when
the host doesn't have it enabled.
Fixes: 78051e3b7e35 ("KVM: nVMX: Disable unrestricted mode if ept=0")
Cc: sta...@vger.kernel.org
Tested-By: Kashyap Chamarthy
Sign
Initialized the value
> of msi_redir_hint to true when RH=1 in kvm_set_msi_irq(), and initialized
> to false in all other cases.
>
> Added value of msi_redir_hint to a debug message dump of an IRQ in
> apic_send_ipi().
>
> Signed-off-by: James Sullivan
> ---
Reviewed-by: Rad
edir_hint.
>
> Moved kvm_is_dm_lowest_prio() into lapic.h and renamed to
> kvm_lowest_prio_delivery().
>
> Changed a check in kvm_irq_delivery_to_apic_fast() from
> irq->delivery_mode == APIC_DM_LOWPRI to kvm_is_dm_lowest_prio().
>
> Signed-off-by: James Sullivan
> -
kvm_ioapic_update_eoi() wasn't called if directed EOI was enabled.
We need to do that for irq notifiers. (Like with edge interrupts.)
Fix it by skipping EOI broadcast only.
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=82211
Signed-off-by: Radim Krčmář
---
arch/x86/kvm/ioapic.
2015-03-18 15:37-0400, Bandan Das:
> Radim Krčmář writes:
> > kvm_ioapic_update_eoi() wasn't called if directed EOI was enabled.
> > We need to do that for irq notifiers. (Like with edge interrupts.)
>
> Wow! It's interesting that this path is only hit with X
2015-03-18 22:09-0300, Marcelo Tosatti:
> > > See native_compose_msi_msg:
> > > ((apic->irq_dest_mode == 0) ?
> > > MSI_ADDR_DEST_MODE_PHYSICAL :
> > > MSI_ADDR_DEST_MODE_LOGICAL) |
> > > ((apic->irq_delivery_mode != de
2015-03-19 18:24+0100, Paolo Bonzini:
> > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> > @@ -833,8 +833,7 @@ int kvm_apic_compare_prio(struct kvm_vcpu *vcpu1,
> > struct kvm_vcpu *vcpu2)
> > - if (!(kvm_apic_get_reg(apic, APIC_SPIV) & APIC_SPIV_DIRECTED_EOI) &&
> > - kvm_ioap
An overhead from function call is not appropriate for its size and
frequency of execution.
Suggested-by: Paolo Bonzini
Signed-off-by: Radim Krčmář
---
I'm not very fond of that smp_rmb(): there is no real synchronization
against update_handled_vectors(), so the only point I see is to
2015-03-19 18:44-0300, Marcelo Tosatti:
> On Wed, Mar 18, 2015 at 07:38:22PM +0100, Radim Krčmář wrote:
> > kvm_ioapic_update_eoi() wasn't called if directed EOI was enabled.
> > We need to do that for irq notifiers. (Like with edge interrupts.)
> >
> > Fix i
2015-03-19 16:51-0600, James Sullivan:
> I played around with native_compose_msi_msg and discovered the following:
>
> * dm=0, rh=0 => Physical Destination Mode
> * dm=0, rh=1 => Failed delivery
> * dm=1, rh=0 => Logical Destination Mode, No Redirection
> * dm=1, rh=1 => Logical Destination Mode,
2015-03-20 11:50-0600, James Sullivan:
> On 03/20/2015 09:22 AM, James Sullivan wrote:
> > On 03/20/2015 09:15 AM, Radim Krčmář wrote:
> >> 2015-03-19 16:51-0600, James Sullivan:
> >>> I played around with native_compose_msi_msg and discovered the following:
> &
2015-03-23 16:46-0600, James Sullivan:
> On 03/23/2015 03:13 PM, Radim Krčmář wrote:
> > I meant if the delivery mode from data register isn't ignored with RH=1,
> > and the message delivered as if lowest-priority was set there.
> > (Decided by having something else tha
2015-03-23 20:21-0300, Marcelo Tosatti:
> The following point:
>
> 2. per-CPU pvclock time info is updated if the
>underlying CPU changes.
>
> Is not true anymore since "KVM: x86: update pvclock area conditionally,
> on cpu migration".
I think that the revert doesn't fix point 2.: "
2015-03-24 15:33-0700, Andy Lutomirski:
> On Tue, Mar 24, 2015 at 8:34 AM, Radim Krčmář wrote:
> > What is the problem?
>
> The kvmclock spec says that the host will increment a version field to
> an odd number, then update stuff, then increment it to an even number.
>
2015-03-24 19:59-0300, Marcelo Tosatti:
> On Tue, Mar 24, 2015 at 04:34:12PM +0100, Radim Krčmář wrote:
> > 2015-03-23 20:21-0300, Marcelo Tosatti:
> > > The following point:
> > >
> > > 2. per-CPU pvclock time info is updated if the
> > >
2015-03-25 12:08+0100, Radim Krčmář:
> Reverting the patch protects us from any migration, but I don't think we
> need to care about changing VCPUs as long as we read a consistent data
> from kvmclock. (VCPU can change outside of this loop too, so it doesn't
> matter if we
we are reverting and is completely unrelated to
the bug we are fixing now, (reverted patch just was just wrong)
Reviewed-by: Radim Krčmář
> diff --git a/arch/x86/vdso/vclock_gettime.c b/arch/x86/vdso/vclock_gettime.c
> @@ -82,18 +82,15 @@ static notrace cycle_t vread_pvclock(int *mode)
>
2015-03-25 20:05-0400, Kevin O'Connor:
> On Thu, Mar 26, 2015 at 02:35:58AM +0300, Andrey Korolyov wrote:
> > Thanks, strangely the reboot is always failing now and always reaching
> > seabios greeting. May be prints straightened up a race (e.g. it is not
> > int19 problem really).
> >
> > object
501 - 522 of 522 matches
Mail list logo
