[RFC v9 04/27] virtio-blk: Map vring

2012-07-18 Thread Stefan Hajnoczi
Map the vring to host memory so it can be accessed without the overhead of the QEMU memory functions. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c | 44 1 file changed, 44 insertions(+) diff --git a/hw/virtio-blk.c

[RFC v9 01/27] virtio-blk: Remove virtqueue request handling code

2012-07-18 Thread Stefan Hajnoczi
Start with a clean slate, a virtio-blk device that supports virtio lifecycle operations and configuration but doesn't do any actual I/O. The I/O is going to happen in a separate optimized data plane thread. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c | 496

[RFC v9 08/27] virtio-blk: Read requests from the vring

2012-07-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/dataplane/vring.h |8 +-- hw/virtio-blk.c | 62 ++ 2 files changed, 59 insertions(+), 11 deletions(-) diff --git a/hw/dataplane/vring.h b/hw/dataplane/vring.h index

[RFC v9 09/27] virtio-blk: Add Linux AIO queue

2012-07-18 Thread Stefan Hajnoczi
Requests read from the vring will be placed in a queue where they can be merged as necessary. Once all requests have been read from the vring, the queue can be submitted. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/dataplane/ioq.h | 104

[RFC v9 12/27] virtio-blk: Add workaround for BUG_ON() dependency in virtio_ring.h

2012-07-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/dataplane/vring.h |5 + 1 file changed, 5 insertions(+) diff --git a/hw/dataplane/vring.h b/hw/dataplane/vring.h index 3eab4b4..44ef4a9 100644 --- a/hw/dataplane/vring.h +++ b/hw/dataplane/vring.h @@ -1,6 +1,11 @@ #ifndef

[RFC v9 11/27] virtio-blk: Indirect vring and flush support

2012-07-18 Thread Stefan Hajnoczi
does not support Linux AIO fdsync. Work around this by performing fdatasync() synchronously for now. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/dataplane/ioq.h | 18 - hw/dataplane/vring.h | 103 +++--- hw/virtio

[RFC v9 16/27] virtio-blk: Kick data plane thread using event notifier set

2012-07-18 Thread Stefan Hajnoczi
--- hw/virtio-blk.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 1616be5..d75c187 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -339,8 +339,7 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)

[RFC v9 06/27] virtio-blk: Take PCI memory range into account

2012-07-18 Thread Stefan Hajnoczi
Support 4 GB physical memory accesses. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index abd9386..99654f1 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -64,6

[RFC v9 15/27] notifier: Add a function to set the notifier

2012-07-18 Thread Stefan Hajnoczi
Although past users only needed to test and clear event notifiers, it is useful to be able to set them too. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- event_notifier.c |7 +++ event_notifier.h |1 + 2 files changed, 8 insertions(+) diff --git a/event_notifier.c b

[RFC v9 23/27] virtio-blk: Stub out SCSI commands

2012-07-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 51807b5..8734029 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -215,14

[RFC v9 13/27] virtio-blk: Increase max requests for indirect vring

2012-07-18 Thread Stefan Hajnoczi
With indirect vring descriptors, one can no longer assume that the maximum number of requests is VRING_MAX / 2 (outhdr and inhdr). Now a single indirect descriptor can contain the outhdr and inhdr so max requests becomes VRING_MAX. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

[RFC v9 20/27] virtio-blk: Add ioscheduler to detect mergable requests

2012-07-18 Thread Stefan Hajnoczi
--- hw/dataplane/iosched.h | 78 hw/virtio-blk.c|5 2 files changed, 83 insertions(+) create mode 100644 hw/dataplane/iosched.h diff --git a/hw/dataplane/iosched.h b/hw/dataplane/iosched.h new file mode 100644 index

[RFC v9 25/27] msix: fix irqchip breakage in msix_try_notify_from_thread()

2012-07-18 Thread Stefan Hajnoczi
is not defined. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/msix.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 3308604..0ed1013 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -511,12 +511,10 @@ bool msix_try_notify_from_thread(PCIDevice *dev

[RFC v9 27/27] virtio-blk: add EVENT_IDX support to dataplane

2012-07-18 Thread Stefan Hajnoczi
This patch adds support for the VIRTIO_RING_F_EVENT_IDX feature for interrupt mitigation. virtio-blk doesn't do anything fancy with it so we may not see a performance improvement. This patch will allow newer guest kernels to run successfully. Signed-off-by: Stefan Hajnoczi stefa

[RFC v9 24/27] virtio-blk: fix incorrect length

2012-07-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 8734029..cff2298 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -131,7 +131,7 @@ static void

[RFC v9 26/27] msix: use upstream kvm_irqchip_set_irq()

2012-07-18 Thread Stefan Hajnoczi
Commit 9507e305ec54062fccc88fcf6fccf1898a7e7141 changed the kvm_set_irq() function to kvm_irqchip_set_irq(). Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/msix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/msix.c b/hw/msix.c index 0ed1013

[RFC v9 21/27] virtio-blk: Add basic request merging

2012-07-18 Thread Stefan Hajnoczi
This commit adds an I/O scheduler that sorts requests and merges adjacent requests if they have the same operation type (read/write). The code is ugly and not very well factored but it does merge successfully. --- hw/dataplane/ioq.h |3 +- hw/dataplane/iosched.h | 51

[RFC v9 22/27] virtio-blk: Fix request merging

2012-07-18 Thread Stefan Hajnoczi
Khoa Huynh k...@us.ibm.com discovered that request merging is broken. The merged iocb is not updated to reflect the total number of iovecs and the offset is also outdated. This patch fixes request merging. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c | 10

[RFC v9 19/27] virtio-blk: Disable guest-host notifies while processing vring

2012-07-18 Thread Stefan Hajnoczi
--- hw/dataplane/vring.h | 28 +++- hw/virtio-blk.c | 47 +++ 2 files changed, 58 insertions(+), 17 deletions(-) diff --git a/hw/dataplane/vring.h b/hw/dataplane/vring.h index 44ef4a9..cdd4d4a 100644 ---

[RFC v9 18/27] virtio-blk: Call ioctl() directly instead of irqfd

2012-07-18 Thread Stefan Hajnoczi
Optimize for the MSI-X enabled and vector unmasked case where it is possible to issue the KVM ioctl() directly instead of using irqfd. This patch introduces a new virtio binding function which tries to notify in a thread-safe way. If this is not possible, the function returns false. Virtio

[RFC v9 10/27] virtio-blk: Stop data plane thread cleanly

2012-07-18 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/dataplane/event-poll.h | 79 --- hw/dataplane/ioq.h| 65 +-- hw/dataplane/vring.h |6 +- hw/virtio-blk.c | 154 +++-- 4

[RFC v9 14/27] virtio-blk: Use pthreads instead of qemu-thread

2012-07-18 Thread Stefan Hajnoczi
Using qemu-thread.h seemed like a nice idea but it has two limitations: 1. QEMU needs to be built with --enable-io-thread 2. qemu-kvm doesn't build with --enable-io-thread For now just copy the pthread_create() code straight into virtio-blk.c. Signed-off-by: Stefan Hajnoczi stefa

Re: [Qemu-devel] [RFC v9 18/27] virtio-blk: Call ioctl() directly instead of irqfd

2012-07-19 Thread Stefan Hajnoczi
On Wed, Jul 18, 2012 at 4:40 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 18, 2012 at 04:07:45PM +0100, Stefan Hajnoczi wrote: Optimize for the MSI-X enabled and vector unmasked case where it is possible to issue the KVM ioctl() directly instead of using irqfd. Why? Is an ioctl

Re: [Qemu-devel] [RFC v9 06/27] virtio-blk: Take PCI memory range into account

2012-07-19 Thread Stefan Hajnoczi
On Wed, Jul 18, 2012 at 7:29 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 18, 2012 at 04:07:33PM +0100, Stefan Hajnoczi wrote: Support 4 GB physical memory accesses. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Need some sane APIs, this is just too scary. Yes

Re: [Qemu-devel] [RFC v9 06/27] virtio-blk: Take PCI memory range into account

2012-07-19 Thread Stefan Hajnoczi
On Thu, Jul 19, 2012 at 10:14 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jul 18, 2012 at 7:29 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 18, 2012 at 04:07:33PM +0100, Stefan Hajnoczi wrote: Support 4 GB physical memory accesses. Signed-off-by: Stefan Hajnoczi stefa

Re: [Qemu-devel] [RFC v9 00/27] virtio: virtio-blk data plane

2012-07-19 Thread Stefan Hajnoczi
On Wed, Jul 18, 2012 at 4:49 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 18, 2012 at 04:07:27PM +0100, Stefan Hajnoczi wrote: This series implements a dedicated thread for virtio-blk processing using Linux AIO for raw image files only. It is based on qemu-kvm.git a0bc8c3

Re: [PATCH RESEND 5/5] vhost-blk: Add vhost-blk support

2012-07-20 Thread Stefan Hajnoczi
On Thu, Jul 19, 2012 at 2:09 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 19, 2012 at 08:05:42AM -0500, Anthony Liguori wrote: Of course, the million dollar question is why would using AIO in the kernel be faster than using AIO in userspace? Actually for me a more important

Re: [PATCH RESEND] Recognize PCID feature

2012-07-21 Thread Stefan Hajnoczi
On Fri, Jul 20, 2012 at 07:08:21AM +, Mao, Junjie wrote: This patch makes Qemu recognize the PCID feature specified from configuration or command line options. Signed-off-by: Junjie Mao junjie@intel.com --- target-i386/cpu.c |2 +- 1 files changed, 1 insertions(+), 1

Re: vhost-scsi port to v1.1.0 + MSI-X performance regression

2012-07-24 Thread Stefan Hajnoczi
nicely reviewable patches that apply against the current qemu.git/master: Nicholas Bellinger (1): virtio-scsi: Set max_target=0 during vhost-scsi operation Stefan Hajnoczi (8): notifier: add validity check and notify function virtio-pci: support host notifiers in TCG mode virtio

Re: [PATCH 4/5] qom: delay DeviceState's reclaim to main-loop

2012-07-25 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 4:31 AM, Liu Ping Fan qemul...@gmail.com wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com iohandler/bh/timer may use DeviceState when its refcnt=0, postpone the reclaimer till they have done with it. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com ---

Re: [PATCH 5/5] e1000: using new interface--unmap to unplug

2012-07-25 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 4:31 AM, Liu Ping Fan qemul...@gmail.com wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/e1000.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/e1000.c

Re: [PATCH 2/5] exec.c: use refcnt to protect device during dispatching

2012-07-25 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 4:31 AM, Liu Ping Fan qemul...@gmail.com wrote: @@ -3396,13 +3420,25 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, uint32_t val; target_phys_addr_t page; MemoryRegionSection *section; +Object *bk; while (len 0) {

Re: [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION

2012-07-25 Thread Stefan Hajnoczi
if you have any concerns here. Thanks! Reported-by: Anthony Liguori aligu...@us.ibm.com Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off

Re: [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION

2012-07-25 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 02:14:50PM -0700, Nicholas A. Bellinger wrote: On Wed, 2012-07-25 at 12:55 +0100, Stefan Hajnoczi wrote: On Tue, Jul 24, 2012 at 01:45:24PM -0700, Nicholas A. Bellinger wrote: On Mon, 2012-07-23 at 18:56 -0700, Greg Kroah-Hartman wrote: On Tue, Jul 24, 2012 at 01

Re: [Qemu-devel] [PATCH] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-07-31 Thread Stefan Hajnoczi
On Mon, Jul 30, 2012 at 7:22 PM, riegama...@gmail.com wrote: From: Dunrong Huang riegama...@gmail.com Add a helper function for fetching max cpus supported by kvm. Make QEMU exit with an error message if smp_cpus exceeds limit of VCPU count retrieved by invoking this helper function.

Re: [regression] virtio net locks up

2012-07-31 Thread Stefan Hajnoczi
On Mon, Jul 30, 2012 at 7:08 PM, Bernd Schubert bernd.schub...@itwm.fraunhofer.de wrote: On 07/30/2012 07:33 PM, Bernd Schubert wrote: Hello Stefan, Stefan Hajnoczi stefanha at gmail.com writes: On Wed, Jan 11, 2012 at 4:18 PM, Bernd Schubert bernd.schubert at itwm.fraunhofer.de wrote

Re: KVM call agenda for Tuesday, July 31

2012-07-31 Thread Stefan Hajnoczi
On Mon, Jul 30, 2012 at 8:34 AM, Juan Quintela quint...@redhat.com wrote: Please send in any agenda items you are interested in covering. QEMU 1.2 Test Day * Let's find -rc bugs and ensure the release is stable * We've done this in the past and have a wiki template but can discuss suggestions

Re: [regression] virtio net locks up

2012-08-02 Thread Stefan Hajnoczi
On Wed, Aug 1, 2012 at 6:05 PM, Bernd Schubert bernd.schub...@itwm.fraunhofer.de wrote: On 07/31/2012 12:23 PM, Stefan Hajnoczi wrote: On Mon, Jul 30, 2012 at 7:08 PM, Bernd Schubert I took a quick glance where skb_recv_done is registered at all and traced it back to vp_find_vqs

Re: qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-08-06 Thread Stefan Hajnoczi
On Thu, Jun 28, 2012 at 2:05 PM, Peter Lieven p...@dlhnet.de wrote: i debugged my initial problem further and found out that the problem happens to be that the main thread is stuck in pause_all_vcpus() on reset or quit commands in the monitor if one cpu is stuck in the do-while loop

Re: [PATCH 4/6] virtio-blk: implement -make_request

2011-12-22 Thread Stefan Hajnoczi
On Wed, Dec 21, 2011 at 1:00 AM, Minchan Kim minc...@kernel.org wrote: +static void virtblk_add_buf_wait(struct virtio_blk *vblk, +       struct virtblk_req *vbr, unsigned long out, unsigned long in) +{ +       DEFINE_WAIT(wait); +       bool retry, notify; + +       for (;;) { +          

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-22 Thread Stefan Hajnoczi
On Wed, Dec 21, 2011 at 1:00 AM, Minchan Kim minc...@kernel.org wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote from hch This patchset allows the virtio-blk driver to support much

Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

2012-01-01 Thread Stefan Hajnoczi
On Sun, Jan 1, 2012 at 9:43 AM, Orit Wasserman owass...@redhat.com wrote: On 12/30/2011 12:39 AM, Anthony Liguori wrote: On 12/28/2011 07:25 PM, Isaku Yamahata wrote: Intro = This patch series implements postcopy live migration.[1] As discussed at KVM forum 2011, dedicated character

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2012-01-01 Thread Stefan Hajnoczi
On Thu, Dec 22, 2011 at 11:41 PM, Minchan Kim minc...@kernel.org wrote: On Thu, Dec 22, 2011 at 12:57:40PM +, Stefan Hajnoczi wrote: On Wed, Dec 21, 2011 at 1:00 AM, Minchan Kim minc...@kernel.org wrote: If you're stumped by the performance perhaps compare blktraces of the request approach

Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

2012-01-02 Thread Stefan Hajnoczi
On Mon, Jan 2, 2012 at 9:28 AM, Dor Laor dl...@redhat.com wrote: At the end of the day, it's performance testing using various scenarios that can educate us whether post-copy worth the extra complexity over slowing down the guest on the source. True. It's certainly an interesting patch series

Re: KVM call agenda for Tuesday 3

2012-01-03 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 01:09:40PM +0100, Juan Quintela wrote: Please send in any agenda items you are interested in covering. Status of virtio drivers for Windows: * Unsupported in community today * Bugs languish on bug tracker/mailing list * Risking a reputation of not supporting Windows

Re: KVM call agenda for Tuesday 3

2012-01-03 Thread Stefan Hajnoczi
On Tue, Jan 3, 2012 at 12:15 PM, Dor Laor dl...@redhat.com wrote: On 01/03/2012 10:33 AM, Stefan Hajnoczi wrote: On Mon, Jan 02, 2012 at 01:09:40PM +0100, Juan Quintela wrote: Please send in any agenda items you are interested in covering. Status of virtio drivers for Windows

Re: [Qemu-devel] KVM call agenda for Tuesday 3

2012-01-04 Thread Stefan Hajnoczi
On Wed, Jan 4, 2012 at 2:47 AM, Cao,Bing Bu m...@linux.vnet.ibm.com wrote: On 01/03/2012 09:12 PM, Stefan Hajnoczi wrote: On Tue, Jan 3, 2012 at 12:15 PM, Dor Laordl...@redhat.com  wrote: On 01/03/2012 10:33 AM, Stefan Hajnoczi wrote: On Mon, Jan 02, 2012 at 01:09:40PM +0100, Juan Quintela

[RFC] KVM: x86: emulate movdqa

2012-01-07 Thread Stefan Hajnoczi
this guest userspace SSE instruction in the first place? This host machine lacks EPT but can't we service the page fault and then retry execution inside the guest? Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- arch/x86/kvm/emulate.c |9 - 1 files changed, 8 insertions

x86_decode_insn succeeds with GroupMask flags when it should fail

2012-01-07 Thread Stefan Hajnoczi
The unimplemented movdqa (66 0f 7f 07) instruction triggers a bug in the x86 emulator. The emulator should fail since the instruction is unimplemented. However the emulator thinks it is succeeding but we keep re-executing the same instruction over and over. top shows 100% CPU utilization and

Re: [RFC] KVM: x86: emulate movdqa

2012-01-08 Thread Stefan Hajnoczi
On Sun, Jan 8, 2012 at 10:32 AM, Avi Kivity a...@redhat.com wrote: On 01/07/2012 12:26 PM, Stefan Hajnoczi wrote: movdqa %xmm0,(%rdi) This patch adds movdqa to the emulator but does not implement #GP when the memory operand is unaligned to 16 bytes.  I'm not sure whether alignment checking

[PATCH] emulator: add movdqa tests

2012-01-09 Thread Stefan Hajnoczi
#GP. The emulator will therefore never meet unaligned movdqa instructions. Also change read/write to store/load to make it obvious whether the test transfers to or from memory. Previous usage of read and write was misleading. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

Re: [regression] virtio net locks up

2012-01-11 Thread Stefan Hajnoczi
On Wed, Jan 11, 2012 at 3:24 PM, Bernd Schubert bernd.schub...@itwm.fraunhofer.de wrote: Any idea what is going on or how to debug it? Here are a couple of ideas that would yield more information: Since the console still works I suggest checking dmesg output inside the guest. Are there any

Re: [regression] virtio net locks up

2012-01-11 Thread Stefan Hajnoczi
On Wed, Jan 11, 2012 at 4:18 PM, Bernd Schubert bernd.schub...@itwm.fraunhofer.de wrote: On 01/11/2012 05:04 PM, Stefan Hajnoczi wrote: Try pinging the host's IP address from inside the guest.  Run tcpdump on the guest's tap interface from the host and observe whether or not you see any

Re: Could anybody give some description about the implement of hyercall in kvm?

2012-01-12 Thread Stefan Hajnoczi
On Thu, Jan 12, 2012 at 4:38 AM, Liu ping fan kernelf...@gmail.com wrote: Could anybody give some description about the implement of hyercall in kvm? Or give some links about it? Try git grep hypercall arch/x86/kvm. Take a look at arch/x86/kvm/x86.c kvm_set_msr_common() and

Re: Could anybody give some description about the implement of hyercall in kvm?

2012-01-13 Thread Stefan Hajnoczi
On Fri, Jan 13, 2012 at 7:45 AM, Liu ping fan kernelf...@gmail.com wrote: On Thu, Jan 12, 2012 at 5:21 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jan 12, 2012 at 4:38 AM, Liu ping fan kernelf...@gmail.com wrote: Could anybody give some description about the implement of hyercall

Re: [PATCH 3/3] KVM: perf: kvm events analysis tool

2012-01-16 Thread Stefan Hajnoczi
On Mon, Jan 16, 2012 at 9:32 AM, Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: +DESCRIPTION +--- +You can analyze some crucial events and statistics with this +'perf kvm-events' command. This line is very general and does not explain which events/statistics can be collected

Re: [PATCH] emulator: add movdqa tests

2012-02-06 Thread Stefan Hajnoczi
2012/2/1 Avi Kivity a...@redhat.com: On 02/01/2012 11:08 AM, Takuya Yoshikawa wrote: What is the status of Stefan's work? Stefan's on vacation. Back now. I will try to get back to movdqa soon. Stefan -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

QEMU applying for Google Summer of Code 2012

2012-02-10 Thread Stefan Hajnoczi
This year's Google Summer of Code has been announced: http://www.google-melange.com/gsoc/events/google/gsoc2012 For those who haven't heard of GSoC before, it funds university students to work on open source projects during the summer. Organizations, such as QEMU, can participate to attract

Re: [PATCH v5 0/3] virtio-scsi driver

2012-02-10 Thread Stefan Hajnoczi
is starting to look like wishful thinking, but the possibility of regressions is obviously zero so I'm still dreaming. Otherwise, that would be 3.4. Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message

Re: [libvirt] QEMU applying for Google Summer of Code 2012

2012-02-10 Thread Stefan Hajnoczi
On Fri, Feb 10, 2012 at 10:59 AM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Feb 10, 2012 at 10:30:24AM +, Stefan Hajnoczi wrote: This year's Google Summer of Code has been announced: http://www.google-melange.com/gsoc/events/google/gsoc2012 For those who haven't heard of GSoC

Re: virtio-blk performance regression and qemu-kvm

2012-02-13 Thread Stefan Hajnoczi
On Fri, Feb 10, 2012 at 2:36 PM, Dongsu Park dongsu.p...@profitbricks.com wrote:  Now I'm running benchmarks with both qemu-kvm 0.14.1 and 1.0.  - Sequential read (Running inside guest)   # fio -name iops -rw=read -size=1G -iodepth 1 \    -filename /dev/vdb -ioengine libaio -direct=1 -bs=4096

Re: kvm + raid1 showstopper bug

2012-02-17 Thread Stefan Hajnoczi
On Fri, Feb 17, 2012 at 4:57 AM, Pete Ashdown pashd...@xmission.com wrote: I've been waiting for some response from the Ubuntu team regarding a bug on launchpad, but it appears that it isn't being taken seriously: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/745785 This looks

Re: kvm + raid1 showstopper bug

2012-02-18 Thread Stefan Hajnoczi
On Fri, Feb 17, 2012 at 3:31 PM, Pete Ashdown pashd...@xmission.com wrote: On 02/17/2012 04:30 AM, Stefan Hajnoczi wrote: On Fri, Feb 17, 2012 at 4:57 AM, Pete Ashdown pashd...@xmission.com wrote: I've been waiting for some response from the Ubuntu team regarding a bug on launchpad

Re: how two vms on the same physical machine communicate with each other?

2012-02-20 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 5:42 AM, 夏业添 summer...@gmail.com wrote:    I want to know if there is other way besides network to make two guests on a same host to communicate with each other.    And when there is an inter-vm communication by virtual network, are these network packages passing the

Re: virtio-blk performance regression and qemu-kvm

2012-02-21 Thread Stefan Hajnoczi
On Tue, Feb 21, 2012 at 3:57 PM, Dongsu Park dongsu.p...@profitbricks.com wrote: On 13.02.2012 11:57, Stefan Hajnoczi wrote: On Fri, Feb 10, 2012 at 2:36 PM, Dongsu Park dongsu.p...@profitbricks.com wrote:  Now I'm running benchmarks with both qemu-kvm 0.14.1 and 1.0.  - Sequential read

Re: virtio-blk performance regression and qemu-kvm

2012-02-22 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 4:48 PM, Dongsu Park dongsu.p...@profitbricks.com wrote: Try turning ioeventfd off for the virtio-blk device: -device virtio-blk-pci,ioeventfd=off,... You might see better performance since ramdisk I/O should be very low-latency.  The overhead of using ioeventfd might

Re: linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven p...@dlh.net wrote: However, in a virtual machine I have not observed the above slow down to that extend while the benefit of zero after free in a virtualisation environment is obvious: 1) zero pages can easily be merged by ksm or other

Re: linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 7:08 PM, peter.lie...@gmail.com p...@dlh.net wrote: Stefan Hajnoczi stefa...@gmail.com schrieb: On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven p...@dlh.net wrote: However, in a virtual machine I have not observed the above slow down to that extend while the benefit

Re: linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Feb 23, 2012 at 7:08 PM, peter.lie...@gmail.com p...@dlh.net wrote: Stefan Hajnoczi stefa...@gmail.com schrieb: On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven p...@dlh.net wrote: However, in a virtual machine

Re: linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Fri, Feb 24, 2012 at 6:53 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Feb 23, 2012 at 7:08 PM, peter.lie...@gmail.com p...@dlh.net wrote: Stefan Hajnoczi stefa...@gmail.com schrieb: On Thu, Feb 23, 2012

Add GSoC project ideas to the wiki!

2012-02-24 Thread Stefan Hajnoczi
This is a reminder that QEMU will apply for Google Summer of Code 2012 and we need project ideas and mentors. Libvirt and kvm.ko projects are also welcome! http://wiki.qemu.org/Google_Summer_of_Code_2012 Please add yourself to the wiki now if you want to mentor a project this summer. I will

Re: [libvirt] Add GSoC project ideas to the wiki!

2012-02-24 Thread Stefan Hajnoczi
On Fri, Feb 24, 2012 at 10:38 AM, Michal Privoznik mpriv...@redhat.com wrote: On 24.02.2012 10:19, Stefan Hajnoczi wrote: Thank you for the opportunity. I was personally thinking about something libvirt-snmp related. Nowdays, it is difficult to add new elements to MIB, as some parts of code

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 11:46 AM, Peter Lieven p...@dlh.net wrote: On 24.02.2012 08:23, Stefan Hajnoczi wrote: On Fri, Feb 24, 2012 at 6:53 AM, Stefan Hajnoczistefa...@gmail.com  wrote: On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczistefa...@gmail.com  wrote: On Thu, Feb 23, 2012 at 7:08

Re: Hosts crashed

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 11:50 AM, Germain Maurice gmaur...@linkfluence.net wrote: I don't know if someone has already seen my request… If you're not getting responses it could be because you are using Proxmox VE, so the kernel and qemu-kvm might have patches. Have you asked the Proxmox

Re: [Qemu-devel] KVM call agenda for Tuesday 28th

2012-02-28 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 10:06 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 02/27/2012 03:58 PM, Paolo Bonzini wrote: Il 27/02/2012 18:21, Eric Blake ha scritto: Please send in any agenda items you are interested in covering. Given all the threads on snapshot/mirror/migrate/reopen in

Re: [Qemu-devel] KVM call agenda for Tuesday 28th

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 2:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 28/02/2012 15:39, Stefan Hajnoczi ha scritto: I'm not a fan of transactions or freeze/thaw (if used to atomically perform other commands). We should not export low-level block device operations so that external

Re: virtio-blk performance regression and qemu-kvm

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 4:39 PM, Martin Mailand mar...@tuxadero.com wrote: I could reproduce it and I bisected it down to this commit. 12d4536f7d911b6d87a766ad7300482ea663cea2 is the first bad commit commit 12d4536f7d911b6d87a766ad7300482ea663cea2 Author: Anthony Liguori aligu...@us.ibm.com

Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream

2011-09-21 Thread Stefan Hajnoczi
-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Perhaps qemu_eventfd() can be used in the future instead of an explicit pipe. Then Linux will do eventfd while other OSes will fall back to pipes. Stefan -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord

Re: [PATCH 2/5] virtio: support unlocked queue kick

2011-10-06 Thread Stefan Hajnoczi
On Wed, Oct 05, 2011 at 03:54:05PM -0400, Christoph Hellwig wrote: Split virtqueue_kick to be able to do the actual notification outside the lock protecting the virtqueue. This patch was originally done by Stefan Hajnoczi, but I can't find the original one anymore and had to recreated it from

Re: virtio localdisk performance

2011-10-13 Thread Stefan Hajnoczi
On Wed, Oct 12, 2011 at 1:21 PM, benoit ROUSSELLE brousse...@gmail.com wrote: I am doing some disk io performance testing on the following environment: Dell AMD R515 with: - debian6 (2.6.32) on host and guests. - raid1 mirror on a perc h700 - lvm used to create virtual disks volumes - virtio

Re: virtio localdisk performance

2011-10-14 Thread Stefan Hajnoczi
On Thu, Oct 13, 2011 at 05:03:53PM +0200, benoit ROUSSELLE wrote: On Thu, Oct 13, 2011 at 4:27 PM, Stefan Hajnoczi stefa...@gmail.com wrote: dd performs buffered I/O by default.  That means it just writes to the page cache and the kernel decides when to write out dirty pages. So your host

Re: [Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm

2011-10-17 Thread Stefan Hajnoczi
On Mon, Oct 17, 2011 at 11:26 AM, Kevin Wolf kw...@redhat.com wrote: Am 26.09.2011 09:24, schrieb Zhi Yong Wu: On Sat, Sep 24, 2011 at 12:19 AM, Kevin Wolf kw...@redhat.com wrote: Am 08.09.2011 12:11, schrieb Zhi Yong Wu: Note:      1.) When bps/iops limits are specified to a small value such

Re: Convert one .img disk created with sparse=true to no sparse

2011-10-20 Thread Stefan Hajnoczi
On Thu, Oct 20, 2011 at 4:21 AM, Gonzalo Marcote Peña gonzalomarc...@gmail.com wrote: Hi. I have one guest that I created with virt-install comand option 'sparse=true'. As i want to use now this guest for I/O tasks (DDBB) and i want to improve performance, I want to convert the disk.img from

Re: [Qemu-devel] [RFC v2 PATCH 4/4] virtio-net: notify guest to annouce itself

2011-10-26 Thread Stefan Hajnoczi
On Fri, Oct 21, 2011 at 10:39 PM, Jason Wang jasow...@redhat.com wrote: diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 8c2f460..7f844e7 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -95,6 +95,10 @@ static void virtio_net_set_config(VirtIODevice *vdev, const uint8_t *config)  

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote: On 10/26/2011 01:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it

Re: 1.0 Hard Freeze Logistics

2011-10-31 Thread Stefan Hajnoczi
On Mon, Oct 31, 2011 at 1:28 PM, Anthony Liguori aligu...@us.ibm.com wrote: To make the Test Day more successful, please sign up to test a specific area on the Test[3] wiki page. [...] [3] http://wiki.qemu.org/Planning/1.0/Testing I just signed up for several block and tracing tests and

Re: [PATCH 3 of 5] virtio: support unlocked queue kick

2011-11-04 Thread Stefan Hajnoczi
On Thu, Nov 3, 2011 at 7:52 AM, Christoph Hellwig h...@infradead.org wrote: On Thu, Nov 03, 2011 at 06:12:51PM +1030, Rusty Russell wrote: Based on patch by Christoph for virtio_blk speedup: Please credit it to Stefan - he also sent a pointer to his original version in reply to the previous

Re: .git/config corruption using 9p virtio in guest

2011-11-07 Thread Stefan Hajnoczi
On Sat, Nov 5, 2011 at 12:52 AM, Darren Hart dvh...@linux.intel.com wrote: I have a 32b Fedora 15 guest mounting a filesystem from an Ubuntu 11.10 64b host using virtio and 9p. I'm using the mapping security mode (tried squash as well). While I can create, edit, and delete files, when I try to

Re: Secure KVM

2011-11-07 Thread Stefan Hajnoczi
On Mon, Nov 7, 2011 at 10:17 AM, Sasha Levin levinsasha...@gmail.com wrote: Hi Avi, Thank you for your comments! Just one question below: On Mon, Nov 7, 2011 at 11:26 AM, Avi Kivity a...@redhat.com wrote: Crashing the guest is fine (not 100% - you can have unprivileged code managing a

Re: Secure KVM

2011-11-07 Thread Stefan Hajnoczi
On Mon, Nov 7, 2011 at 12:51 PM, Avi Kivity a...@redhat.com wrote: On 11/07/2011 02:40 PM, Sasha Levin wrote: Where does the VNC server, the image formats, etc go?  It would be nice to confine them too. Regarding image formats, just wondering - was there ever any plan to merge (at least

Re: buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2011-11-09 Thread Stefan Hajnoczi
On Wed, Nov 9, 2011 at 2:06 AM, qemu-...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder default_x86_64_debian_5_0 while building qemu-kvm. Full details are available at:  http://buildbot.b1-systems.de/qemu-kvm/builders/default_x86_64_debian_5_0/builds/1019

Re: [RFC/GIT PULL] Linux KVM tool for v3.2

2011-11-10 Thread Stefan Hajnoczi
On Thu, Nov 10, 2011 at 2:47 PM, Markus Armbruster arm...@redhat.com wrote: Pekka Enberg penb...@kernel.org writes: Hi Anthony, On Thu, Nov 10, 2011 at 3:43 PM, Anthony Liguori anth...@codemonkey.ws wrote: It's not just the qcow2 implementation or even the block layer.  This pull requests

Re: [Qemu-devel] KVM call agenda for Novemeber 22

2011-11-22 Thread Stefan Hajnoczi
On Tue, Nov 22, 2011 at 2:39 PM, Juan Quintela quint...@redhat.com wrote: Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda items you are interested in covering. As there is no topic for today, and Anthony just give us reading we would cancel today call. Happy hacking

Re: [Qemu-devel] KVM call agenda for Novemeber 22

2011-11-22 Thread Stefan Hajnoczi
On Tue, Nov 22, 2011 at 3:00 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Nov 22, 2011 at 2:39 PM, Juan Quintela quint...@redhat.com wrote: Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda items you are interested in covering. As there is no topic for today

Re: Improving RAID5 write performance in a KVM VM

2011-11-29 Thread Stefan Hajnoczi
On Fri, Nov 25, 2011 at 10:34 AM, Simon Wilson si...@simonandkate.net wrote: I have done a fair bit of analysis with dstat and using dd copies, and file writes onto the VM's RAID5 slice sit between 35 and 40MBps consistently. If you want to drill down on the disk I/O performance than removing

Re: [net-next RFC PATCH 2/5] tuntap: simple flow director support

2011-12-05 Thread Stefan Hajnoczi
On Mon, Dec 5, 2011 at 8:58 AM, Jason Wang jasow...@redhat.com wrote: This patch adds a simple flow director to tun/tap device. It is just a page that contains the hash to queue mapping which could be changed by user-space. The backend (tap/macvtap) would query this table to get the desired

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-05 Thread Stefan Hajnoczi
On Mon, Dec 5, 2011 at 8:59 AM, Jason Wang jasow...@redhat.com wrote: +static int virtnet_set_fd(struct net_device *dev, u32 pfn) +{ +       struct virtnet_info *vi = netdev_priv(dev); +       struct virtio_device *vdev = vi-vdev; + +       if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_FD))

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Stefan Hajnoczi
On Tue, Dec 6, 2011 at 6:33 AM, Jason Wang jasow...@redhat.com wrote: On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote: On Mon, Dec 5, 2011 at 8:59 AM, Jason Wangjasow...@redhat.com  wrote: +static int virtnet_set_fd(struct net_device *dev, u32 pfn) +{ +       struct virtnet_info *vi

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Stefan Hajnoczi
On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang jasow...@redhat.com wrote: On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 6:33 AM, Jason Wangjasow...@redhat.com  wrote: On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote: On Mon, Dec 5, 2011 at 8:59 AM, Jason Wangjasow

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 3:03 AM, Jason Wang jasow...@redhat.com wrote: On 12/06/2011 09:15 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 10:21 AM, Jason Wangjasow...@redhat.com  wrote: On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 6:33 AM, Jason Wangjasow

<    1   2   3   4   5   6   7   8   9   >