[PATCH] KVM: x86: Fix invalid secondary exec controls in vmx_cpuid_update()

2012-11-09 Thread Takashi Iwai
] sys_ioctl+0x91/0xb0 [815a942d] system_call_fastpath+0x1a/0x1f This patch adds a check for the availability of secondary exec control to avoid these warnings. Cc: sta...@vger.kernel.org [v3.6+] Signed-off-by: Takashi Iwai ti...@suse.de --- arch/x86/kvm/vmx.c | 11 +++ 1 file

Re: Wierd hack to sound/pci/intel8x0.c

2011-11-06 Thread Takashi Iwai
At Sun, 6 Nov 2011 20:15:01 +0400, Denis V. Lunev wrote: On 11/6/11 6:51 PM, Avi Kivity wrote: The recently merged 228cf79376f1 (ALSA: intel8x0: Improve performance in virtual environment) is hacky and somewhat wrong. First, the detection code + if (inside_vm 0) { +

Re: Wierd hack to sound/pci/intel8x0.c

2011-11-06 Thread Takashi Iwai
At Sun, 06 Nov 2011 18:31:42 +0200, Avi Kivity wrote: On 11/06/2011 06:15 PM, Denis V. Lunev wrote: On 11/6/11 6:51 PM, Avi Kivity wrote: The recently merged 228cf79376f1 (ALSA: intel8x0: Improve performance in virtual environment) is hacky and somewhat wrong. First, the detection

Re: Wierd hack to sound/pci/intel8x0.c

2011-11-07 Thread Takashi Iwai
At Mon, 07 Nov 2011 10:25:24 +0100, Gerd Hoffmann wrote: Hi, Agreed. If we can know the virtual device for KVM in a better way (e.g. any specific PCI SSID or such), we can narrow the condition more safely. PCI Subsystem ID 1af4:1100 is qemu/kvm (not only Intel HDA, most other

Re: Wierd hack to sound/pci/intel8x0.c

2011-11-07 Thread Takashi Iwai
At Mon, 07 Nov 2011 11:35:49 +0100, Gerd Hoffmann wrote: Hi, We discuss Intel ICH/AC'97 (snd-intel8x0) here, but I hope that PCI SSID is same. Hmm, it's not, the ac97 emulation doesn't use the default qemu subsystem id for some reason. Here is the entry: [root@fedora ~]# lspci

Re: [PATCH 3/3] ALSA: intel8x0: Check return value before assigning

2013-01-28 Thread Takashi Iwai
At Sun, 27 Jan 2013 17:40:02 +0100, Emil Goode wrote: The first patch in this series changes the return type of function kvm_para_available to bool. In the function snd_intel8x0_inside_vm we now need to check it's return value before assigning a value to the result variable.

suspicious rcu_dereference_check() usage warning with 3.18-rc2

2014-10-30 Thread Takashi Iwai
Hi, I've got a warning with the latest Linus tree like below: [ INFO: suspicious RCU usage. ] 3.18.0-rc2-test2+ #70 Not tainted --- include/linux/kvm_host.h:474 suspicious rcu_dereference_check() usage! other info that might help us debug this: rcu_scheduler_active