subtype.
Kill trailing whitespace in the renamed tests/check-qobject-json.c
to keep checkpatch.pl happy.
Signed-off-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Paolo Bonzini <pbonz...@redhat.com>
---
v2: retitle, enhance commit message, rebase to master
---
We have two different JSON visitors in the tree; and having both
named 'qjson.h' can cause include confusion. Rename the qapi
version.
Kill trailing whitespace in the renamed tests/check-qobject-json.c
to keep checkpatch.pl happy.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
MAINT
ts" -type f | xargs sed -i "s/pc-dimm/dimm/g"
>
> It prepares the work which abstracts dimm device type for both pc-dimm and
> nvdimm
>
> Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com>
> ---
Reviewed-by: Eric Blake <ebl...@redhat.com>
> qapi-sch
25,7 @@
> #
> # Since: 2.1
> ##
> -{ 'union': 'MemoryDeviceInfo', 'data': {'dimm': 'PCDIMMDeviceInfo'} }
> +{ 'union': 'MemoryDeviceInfo', 'data': {'dimm': 'DIMMDeviceInfo'} }
Struct names are not ABI, so this change is safe.
I have not reviewed the rest of the patch, but I don't see any problems
from the qapi perspective.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
to be ported to both Unixy and windows
systems, you are better off rolling your own alternative to basename (or
better, using something else that has already rolled a portable version
for you - while I know gnulib does that, we aren't using gnulib; but I
assume glib has something along those lines even tho
);
atoi() is lousy; it cannot properly detect user input errors. This
should probably be converted to use the appropriate qemu_strtol variant
instead.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
uch harder time migrating that guest.
It's okay to have a new machine type turn on a feature by default, and
to have knobs so that the feature can be turned on even for older
machine types, but experience has shown that any new feature MUST come
with knobs and a way to learn if the feature can be turned
hat either
s/pseude/pseudo/
> directly provides this hypercall to the guest or is able to
> enable the in-kernel hypercall if available. The in-kernel
> hypercall can be enabled with the use-kvm property, e.g.:
>
> qemu-system-ppc64 -device spapr-rng,use-kvm=true
>
--
Eric Blake
. But it's
annoying to have to probe for whether the parameter is understood by
exploiting that particular error message from older qemu.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
)
Maybe mention that these two fields are for filtering results.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
) of this cpu models accelerator
s/models/model's/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
, so it may be a moot question).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ioctl to resolve userfaults is UFFDIO_COPY. That
+atomically copies a page into the userfault registered range and wakes
+up the blocked userfaults (unless uffdio_copy.mode
+UFFDIO_COPY_MODE_DONTWAKE is set). Other ioctl works similarly to
+UFFDIO_COPY.
--
Eric Blake eblake redhat com
: #optional cpu model offered per accelerator (since 2.3.0)
+#
Must the field be optional, or will we always provide it? Since this is
an output-only field, it is okay for back-compat to make the new field
unconditional.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
the implementation.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
insertions(+), 7 deletions(-)
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
system, like NFS or gluster, install your software
on the shared file system, and then make each guest mount the shared
file system in order to use the software. The same as you would on bare
metal.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
with this (and all the pending comments), I will send
it later unless a better idea is exposed.
Thanks.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
If that is your plan for the final series, then that is the same plan
you should be using for reviews. You want the reviewers to see your
proposed final product, not your intermediate state of how you got there.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
;
+
+errno = 0;
+tmp = strtoul(val_str, endptr, 0);
+if ((errno == ERANGE tmp == ULONG_MAX) || (errno != 0 tmp == 0)) {
+return -1;
+}
and again
+if (endptr == val_str || endptr[0] != '\0') {
+return -1;
+}
+*val = tmp;
+return 0;
+}
--
Eric
to
use
s/make/makes/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
);
+if (errp) {
+error_free(errp);
fprintf(stderr, cannot parse shm size\n);
It would be nicer to print the contents of errp, instead of discarding
what is likely to be a more specific error message.
--
Eric Blake eblake redhat com+1-919-301-3266
correct in the first
place? I think you are better off squashing in a lot of the cleanup
patches into patch 1.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
the guest
# to speed up convergence of RAM migration. (since 1.6)
#
+# @colo: The migration will never end, and the VM will instead be
continuously
+#checkpointed. The feature is disabled by default. (since 2.1)
You missed 2.1. This has to be since 2.2.
--
Eric Blake
unless configured --disable-colo. Are there
any pre-req libraries required for it to work? That would be the only
reason to make the default of on or off conditional, rather than
defaulting to on.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
migration-colo.c
create mode 100644 stubs/migration-colo.c
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
been panicked as a result of guest OS panic
+#
+# @colo: guest is paused to save/restore VM state under colo checkpoint
Missing a '(since 2.2)' designation.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
) + COLO_BUFFER_BASE_SIZE;
+
+colo_buffer.size += len;
+if (colo_buffer.size COLO_BUFFER_MAX_SIZE) {
+error_report(colo_buffer overflow!\n);
No trailing \n in error_report().
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
those rights to others). But you're not the only file in the qemu code
base with this questionable mix.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
, or to implement notifications
+between host and guests.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
@@ -680,10 +680,11 @@ static X86CPUDefinition builtin_x86_defs[] = {
.family = 16,
.model = 2,
.stepping = 3,
+/* MIssing: CPUID_HT */
s/MIssing/Missing/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
forever, name it
x-allow-emulation; we've already documented that anything with x- prefix
is fair game for subsequent removal.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
have a distinct preference, but it's
probably better to leave the style unchanged if checkpatch.pl doesn't
complain about either way.
As that's minor,
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
to C99. Again, will this compile on non-gcc? Unnamed ...
coupled with __VA_ARGS__ is the only fully portable way to do var-args.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
: 2827-ga2, type: 2827, ga: 2 }
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
, libvirt DOES have some notion of what architecture a qemu
executable will be targetting, and could modify the command line based
on what architecture it guesses the binary will support, if only for the
purpose of minimizing qemu invocations for its probe of supported cpus.
--
Eric Blake eblake
.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
| grep -q $i || echo $i; done) \
| uid_name_filter
echo
echo who has not yet uploaded a signature by $my_id on their key:
for i in $(echo $keys); do
gpg --list-sig $i | grep -qi $my_id || gpg --list-key $i
done | uid_name_filter
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
to hit wraparound)
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
, and the whole stack complies without having to worry about
policy. IMO, this is a case where fewer knobs is better.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
return in its 'cpu-max' field during the
'query-machines' command? Should we be modifying QMP to return both
values, so that libvirt can also expose the logic to the end user of
allowing a recommended vs. larger development max?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
, now that the qemu-kvm tree has been
merged upstream and is no longer actively maintained.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 04/23/2013 10:06 AM, Eric Blake wrote:
we can change drive_mirror to use a new command to see if there
are the new features.
drive-mirror changed in 1.4 to add optional buf-size parameter; right
now, libvirt is forced to limit itself to 1.3 interface (no buf-size or
granularity
to get it right.
Not on the phone call, but a recent mail that is related to the topic -
feature detection of whether dump-guest-memory supports paging:
https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg04613.html
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization
introspection of QMP commands?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 03/01/2013 12:36 AM, Hu Tao wrote:
On Thu, Feb 28, 2013 at 02:12:37PM -0700, Eric Blake wrote:
On 02/28/2013 05:13 AM, Hu Tao wrote:
This patch enables preservation of cpu runstate during save/load vm.
So when a vm is restored from snapshot, the cpu runstate is restored,
too.
What
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
remembers that it was running, management wants to start it paused.
Here, it is important that there must not be a window of time where the
guest can run, otherwise, the results are not reproducible.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
and NetClientState were not 1:1 in multiqueue. The following patches
would refactor this function to support multiqueue nic.
Signed-off-by: Jason Wang jasow...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
/disabe/disable/
TUNSETQUEUE.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 01/31/2013 12:00 AM, Jason Wang wrote:
On 01/31/2013 02:29 AM, Eric Blake wrote:
On 01/30/2013 04:12 AM, Jason Wang wrote:
With this changes, user could start a multiqueue virtio-net device through
./qemu -netdev tap,id=hn0,queues=2,vhost=on -device
virtio-net-pci,netdev=hn0
that
I know more about how -netdev works to begin with.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
to the kernel syscall.
Meanwhile, your patch is fixing the third argument from 'int' to a wider
type, which is necessary for passing that value through varargs when the
receiving end will retrieve the same argument via a void* variable.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
architecture. I didn't do that, but I am
sure we should pass an unsigned long instead, if that's the type
expected by the kernel.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 01/18/2013 09:40 AM, Eduardo Habkost wrote:
On Fri, Jan 18, 2013 at 09:11:42AM -0700, Eric Blake wrote:
On 01/18/2013 07:20 AM, Eduardo Habkost wrote:
Could you suggest a text for me to add please?
The argument passed to KVM_CREATE_VCPU now has 'unsigned long' type
instead of 'int
more extensible.
{ 'command': 'query-migrate-parameters',
'returns': [['MigrationParameters']]}
One layer too many of [], but yes, this also seems reasonable.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
-capabilities rather than adding a new field to 'migrate'.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
the
new behavior, instead of 'nobg' with a default of false and causing
double-negative logic.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
the documentation), or do we need a new monitor command similar
to migrate-set-capabilities or migrate-set-cache-size?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
undocumented option, and one which might be better named
'move-background'. Also another candidate for migrate-set-capabilities.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
to attach it to 'migrate' instead of a
new command or enhancement to 'migrate-set-capabilities'.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
(true for success, false for still pending) or
an enum, instead of a free-form string? Likewise, isn't 'request' going
to be exactly one of two values (plug or unplug)?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
naming conventions ('-' vs. '_'); we have 'show
migrate_capabilities' but 'show block-jobs'. Oh well, that's life.
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
are enabled, that
might explain part of the problem.
Other than that, if you can profile the slowdowns, I'm sure people would
be interested in the results.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
cannot be used outside of QEMU in a GPLv3
project. That's fine and that's a decision for the submitter to make.
This policy means that we are locked in with GPLv2.
I'm afraid we're already locked at GPLv2 (and not GPLv2+), for good or
for bad.
--
Eric Blake ebl...@redhat.com+1-919-301
been made and
refuted in earlier versions of this patch series, which is WHY this
series is still applicable.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
.
+
+- Dimm: Dimm name (json-str)
+- request: type of hot request: hot-add or hot-remove (json-str)
+- result: result of the hotplug request for this Dimm success or failure
(json-str)
This may need tweaks (such as s/Dimm/dimm/) based on resolution of above
comments.
--
Eric Blake ebl
into one command.
+#
+# Returns total memory in bytes, including hotplugged dimms
+#
+# Returns: a l
truncated
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 07/09/2012 06:10 AM, Alexander Graf wrote:
This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which
hicks up on QEMU's non-existent CPU models.
s/hicks up/hiccups/
v2 - v3:
- fix typo in commit message
but not all of them :)
--
Eric Blake ebl...@redhat.com
On 07/09/2012 07:48 AM, Alexander Graf wrote:
On 09.07.2012, at 15:47, Eric Blake wrote:
On 07/09/2012 06:10 AM, Alexander Graf wrote:
This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which
hicks up on QEMU's non-existent CPU models.
s/hicks up/hiccups/
v2 - v3
management of fd passing?
Which commands need to reopen a file with different access, and do we
bite the bullet to special case all of those commands to allow fd
passing or can we make qemu_open() coupled with high-level fd passing
generic enough to satisfy all of our reopen needs?
--
Eric Blake
this and the macros you're using are available on
POSIX and mingw32? vl.c is a pretty central file.
POSIX, yes. mingw32, no. Use of preprocessor conditionals is probably
in order.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
a recent kenrel) to a kernel
s/kenrel/kernel/
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
to RUN_STATE_PANICED.
s/PANICED/PANICKED/ throughout your series, for the correct spelling of
the past tense of panic.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
wrapping makes it look like we are adding two lines, one line
ending in 'section-offset_within_region', and the next line starting
with 'delta;', which is a syntax error.
But without line wrapping, we are adding just one line with
'offset_within_region + delta;' at the end of that line.
--
Eric Blake
is 'reopen', then 'file' is the name of the file to be opened to
replace the current file tied to the blockdev, with type given by
'format'. 'reuse', 'mirror', and 'mirror-format' must not be given.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
On 02/27/2012 05:22 AM, Juan Quintela wrote:
Hi
Please send in any agenda items you are interested in covering.
Given all the threads on snapshot/mirror/migrate/reopen in the blockdev
layer, that sounds like a worthwhile topic to discuss on a phone call.
--
Eric Blake ebl...@redhat.com
$TMPDIR instead of $TMP
when referring to the preferred temporary directory location.
http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
--
To unsubscribe from
80 matches
Mail list logo
