Re: [PATCH] blk-mq: Avoid race condition with uninitialized requests

notes wasn't such a horrible and unusable hack, so we had a chance to annotate commits without having to rewrite history... -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: blk-mq crash under KVM in multiqueue block code (with virtio-blk and ext4)

(set-driver_data, tags-rqs[i], hctx_idx, i, Another way would be to ensure that the timeout handler doesn't touch hw_ctx or tag_sets that aren't fully initialized yet. But I think this is safer/cleaner. -- Jens Axboe -- To unsubscribe from

Re: blk-mq crash under KVM in multiqueue block code (with virtio-blk and ext4)

out (and it is the saner way to do things). So yes, I'd greatly applaud that. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: virtio-rng only returns zeros with CONFIG_HW_RANDOM=m

On Thu, May 30 2013, Rusty Russell wrote: Jens Axboe ax...@kernel.dk writes: On Wed, Feb 27 2013, Rusty Russell wrote: Aurelien Jarno aurel...@aurel32.net writes: Hi, I have noticed that virtio-rng only returns zero for kernels = 2.6.33 built with CONFIG_HW_RANDOM=m. This is a bit

Re: virtio-rng only returns zeros with CONFIG_HW_RANDOM=m

, offset_in_page(buf)); } Looks good to me, in lieu of being able to return an error. Want me to queue it up? -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [RFC PATCH 0/8] virtio: new API for addition of buffers, scatterlist changes

think I've come across this requirement before, since it was introduced (6 years ago, from a cursory look at the git logs!). -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC PATCH 5/8] scatterlist: introduce sg_unmark_end

On Thu, Feb 07 2013, Paolo Bonzini wrote: This is useful in places that recycle the same scatterlist multiple times, and do not want to incur the cost of sg_init_table every time in hot paths. Looks fine to me. Acked-by: Jens Axboe ax...@kernel.dk -- Jens Axboe -- To unsubscribe from

Re: [PATCH V5 0/4] Improve virtio-blk performance

for getting that done! -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC 1/2] block: Add blk_bio_map_sg() helper

bugs in the past. Asias, this should be trivial to do, except that blk_rq_map_sg() potentially maps across bio's as well. The tracking of the prev bio_vec does not care about cross bio boundaries. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message

Re: [PATCH] virtio-blk: Call revalidate_disk() upon online disk resize

() which should take care of it. I tested growing disk size of already open disk and it works for me. Thanks, obviously right. Applied. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] virtio_blk: add helper function to support mass of disks naming

, and where to put it). -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFT PATCH] blkio: alloc per cpu data from worker thread context( Re: kvm deadlock)

. That's not going to happen, having that lock in there was a disaster for small IO on fast devices. It's essentially the limiting factor on benchmark runs on the RHEL kernels that have it included and enabled... -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm

Re: kvm deadlock

can't allocate it dynamically off the IO path. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: kvm deadlock

alloc all of these when the non-root groups are setup. Why isn't it done that way right now? -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv4] virtio-blk: use ida to allocate disk index

merge this for 3.2? That is, unless Rusty complains shortly ... Yep, tentatively added. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index

is unfortunate. How about we apply this as is and look at cleanups as a next step? Rusty, any opinion on merging this for 3.2? I expect merge window will open right after the summit, I can toss it into for-3.2/drivers, if there's consensus to do that now. -- Jens Axboe -- To unsubscribe from

Re: [PATCH 5/5] virtio-blk: implement -make_request

is just doing things rather suboptimally in some places, and that it would be possible to claim most of that speedup there too. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH resend] compat_ioctl: fix warning caused by qemu

. Thanks Johannes. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] virtio_blk: Use blk-iopoll for host-guest notify

as well, I have been hoping for some more adoption of this. I have mptsas and mpt2sas patches pending as well. I have not done enough and fully exhaustive weight analysis, so note me down for wanting such an analysis on virtio_blk as well. -- Jens Axboe -- To unsubscribe from this list: send

Re: [PATCH] virtio-spec: document block CMD and FLUSH

the flush approach is really workable. Even just strict ordering of requests could only be supported on SCSI, and even there the kernel still lacks proper guarantees on error handling to prevent reordering there. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH] Add serial number support for virtio_blk, V4a

the driver (except for structure size) makes no interpretation of the data. The structure data is copied wholesale to userspace via a HDIO_GET_IDENTITY ioctl command (eg: hdparm -i dev). Added! -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message

Re: [PATCH 2/2] Add serial number support for virtio_blk, V4

, + VIRTIO_BLK_ID_BYTES); -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe]

to do that _before_ putting the queue reference :-) -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html