Re: [PATCH 0/1] Defer skb allocation for both mergeable buffers and big packets in virtio_net

2009-11-23 Thread Mark McLoughlin
On Mon, 2009-11-23 at 11:23 +1030, Rusty Russell wrote: > I'd like to drop big packet support from our driver, but I don't know > how many kvm hosts will not offer mergable rx bufs yet. Anthony? Mergeable rx bufs were first added in kvm-80 and qemu-0.10.0 So e.g., it's in Fedora since Fedora 11

Re: [PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...]

2009-11-02 Thread Mark McLoughlin
On Fri, 2009-10-30 at 16:15 -0500, Dustin Kirkland wrote: > On Thu, Oct 29, 2009 at 10:34 AM, Dustin Kirkland > wrote: > > whitelist host virtio networking features > > > > This patch is a followup to 8eca6b1bc770982595db2f7207c65051572436cb, > > fixing crashes when guests with 2.6.25 virtio drive

Re: [PULL REQUEST] merge latest upstream qemu networking bits

2009-11-02 Thread Mark McLoughlin
On Mon, 2009-11-02 at 12:36 +0200, Avi Kivity wrote: > On 10/28/2009 04:19 PM, Mark McLoughlin wrote: > > The most notable thing here is that all our networking changes are now > > upstream - i.e. there are no longer qemu-kvm specific changes to > > net.[ch], net-queue.

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 10:13 -0500, Dustin Kirkland wrote: > On Thu, 2009-10-29 at 15:01 +0000, Mark McLoughlin wrote: > > Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct > > Brilliant! > > Works like a champ. I'll send a patch in a subsequent email. Would

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote: > On Thu, 2009-10-29 at 14:48 +0000, Mark McLoughlin wrote: > > Ah, it all makes sense now. > > > > I was getting confused between HOST_* and GUEST_* > > > > this should have been: > > >

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:46 -0500, Dustin Kirkland wrote: > On Thu, 2009-10-29 at 09:34 -0500, Dustin Kirkland wrote: > > In the mean time, Hardy's kernel is in git here: > > > > http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary > > I'll save you a few clicks... > > http://kernel.

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:39 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: > > > >> Mark McLoughlin wrote: > >> > >>>> tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn:

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > > >>tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) > >> being called and get an mtu of 1500 on virbr0 using his birdge.sh script. > >> > >> virtio_net_recei

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 20:00 +0800, Scott Tsai wrote: > Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009: > > Assuming this is something like the virtio-net in 2.6.26, there was no > > receivable buffers support so (as Scott points out) it must be that > > we've read a packe

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
Hi Dustin, On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote: > I believe that we have identified a regression in qemu-kvm-0.11.0. Regression versus which previous version of qemu-kvm? > The kvm process crashes for older guests with virtio networking, when > the guest's incoming network c

[PULL REQUEST] merge latest upstream qemu networking bits

2009-10-28 Thread Mark McLoughlin
save() to QObject monitor: Convert do_migrate() to QObject monitor: Convert do_migrate_set_speed() to QObject monitor: Convert do_migrate_cancel() to QObject monitor: Convert do_pci_device_hot_remove() to QObject monitor: Convert do_eject() to QObject monitor: Conv

Re: [Qemu-devel] net packet storms with multiple NICs

2009-10-23 Thread Mark McLoughlin
On Fri, 2009-10-23 at 20:25 +0400, Michael Tokarev wrote: > I've two questions: > > o what's the intended usage of all-vlan-equal case, when kvm (or qemu) >reflects packets from one interface to another? It's what bridge >in linux is for, I think. I don't think it's necessarily an intend

Re: [PATCH] kvm: fix MSR_COUNT for kvm_arch_save_regs()

2009-10-16 Thread Mark McLoughlin
On Wed, 2009-10-14 at 15:02 -0300, Eduardo Habkost wrote: > A new register was added to the load/save list on commit > d283d5a65a2bdcc570065267be21848bd6fe3d78, but MSR_COUNT was not updated, > leading > to potential stack corruption on kvm_arch_save_regs(). > > The following registers are saved

Re: Add qemu_send_raw() to vlan.

2009-10-15 Thread Mark McLoughlin
On Thu, 2009-10-15 at 09:33 +0200, Gleb Natapov wrote: > On Thu, Oct 15, 2009 at 08:04:45AM +0100, Mark McLoughlin wrote: > > Hi Gleb, > > > > On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote: > > > It gets packet without virtio header and adds it if needed.

Re: Add qemu_send_raw() to vlan.

2009-10-15 Thread Mark McLoughlin
Hi Gleb, On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote: > It gets packet without virtio header and adds it if needed. Allows to > inject packets to vlan from outside. To send gracious arp for instance. ... > diff --git a/net.h b/net.h > index 931133b..3d0b6f2 100644 > --- a/net.h > +++ b/

Re: Raw vs. tap (was: Re: [Qemu-devel] Re: Release plan for 0.12.0)

2009-10-14 Thread Mark McLoughlin
On Wed, 2009-10-14 at 17:53 -0500, Anthony Liguori wrote: > So at this point, I think it's a mistake to include raw socket support. > If the goal is to improve networking usability such that it just works > as a root user, let's incorporate a default network script that creates > a bridge or s

Re: QemuOpts changes breaks multiple nic options

2009-10-13 Thread Mark McLoughlin
Hi Tom, On Mon, 2009-10-12 at 17:05 -0500, Tom Lendacky wrote: > The recent change to QemuOpts for the -net nic option breaks specifying -net > nic,... more than once. The net_init_nic function's return value in net.c is > a table index, which is non-zero after the first time it is called. The

Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices

2009-10-09 Thread Mark McLoughlin
On Thu, 2009-10-08 at 15:31 -0700, Sridhar Samudrala wrote: > On Thu, 2009-10-08 at 11:07 +0100, Mark McLoughlin wrote: > > On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote: > > > linux 2.6.32 includes UDP fragmentation offload support in software. > > > So we

Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices

2009-10-08 Thread Mark McLoughlin
On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote: > linux 2.6.32 includes UDP fragmentation offload support in software. > So we can enable UFO on the host tap device if supported and allow setting > UFO on virtio-net in the guest. Hmm, we really need to detect whether the host has tunt

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-10-01 Thread Mark McLoughlin
On Thu, 2009-10-01 at 18:49 +0200, Avi Kivity wrote: > On 09/30/2009 03:59 PM, Mark McLoughlin wrote: > > I think we should keep the vlan stuff, just de-emphasise it. > > > > Maybe we should do what X.org does, break it silently and remove it some > time later when

Re: [Qemu-devel] Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-10-01 Thread Mark McLoughlin
On Wed, 2009-09-30 at 21:15 +0200, Gerd Hoffmann wrote: > On 09/30/09 15:59, Mark McLoughlin wrote: > > I'm planning on adding -hostnet and -nic arguments, which would not use > > vlans by default but rather connect the nic directly to the host side. > > No new -nic a

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 15:55 +0200, Avi Kivity wrote: > On 09/30/2009 03:51 PM, Christoph Hellwig wrote: > > I might sound like a broken record, but why isn't the full GSO support > > for virtio-net upstream in qemu? > > > > IIRC the current hacks are not upstream quality. > > The problem (aga

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 08:24 -0300, Glauber Costa wrote: > On Wed, Sep 30, 2009 at 08:24:18AM +0200, Avi Kivity wrote: > > On 09/29/2009 10:45 PM, Mark McLoughlin wrote: > >> On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: > >> > >>&

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-29 Thread Mark McLoughlin
On Tue, 2009-09-29 at 21:45 +0100, Mark McLoughlin wrote: > On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: > > This commit: > > > >commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 > >Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) >

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-29 Thread Mark McLoughlin
On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: > This commit: > >commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 >Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) > > Removed some GSO code from upstream qemu.git, but it needs to > be re-ins

Re: [PATCH] qemu-kvm: fix error handling in msix vector add

2009-09-07 Thread Mark McLoughlin
On Sat, 2009-07-25 at 12:30 -0300, Marcelo Tosatti wrote: > On Thu, Jul 23, 2009 at 04:34:13PM +0300, Michael S. Tsirkin wrote: > > When adding a vector fails, the used counter should > > not be incremented, otherwise on vector change we will > > try to update the routing entry. > > > > Signed-off

Re: [PATCH] qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back to non-accelerated mode

2009-09-04 Thread Mark McLoughlin
On Thu, 2009-09-03 at 19:18 -0300, Glauber Costa wrote: > On Thu, Sep 3, 2009 at 6:48 PM, Dustin Kirkland wrote: > > On Thu, Sep 3, 2009 at 3:01 PM, Mark McLoughlin wrote: > >> On Thu, 2009-09-03 at 12:31 -0500, Dustin Kirkland wrote: > >>> qemu-kvm: fix segfault whe

Re: [PATCH] qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back to non-accelerated mode

2009-09-03 Thread Mark McLoughlin
On Thu, 2009-09-03 at 12:31 -0500, Dustin Kirkland wrote: > qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back > to non-accelerated mode > > We're seeing segfaults on systems without access to /dev/kvm. It > looks like the global kvm_allowed is being set just a little too late

Re: [PATCHv3 3/4] qemu-kvm: vhost-net implementation

2009-08-20 Thread Mark McLoughlin
Hi Michael, Some random high-level comments: - I had expected this to be available as: -net raw,ifname=eth2 -net nic,model=virtio I'd prefer it this way, because it means you can use this mode even without vhost and it's ties in better with the way all other qemu networkin

Re: [PATCH]: Always use KVM_VERSION to build version number

2009-08-10 Thread Mark McLoughlin
On Mon, 2009-08-10 at 12:46 +0300, Avi Kivity wrote: > On 08/10/2009 12:19 PM, Mark McLoughlin wrote: > > > > Or we could drop this kvm snapshot numbering system and just use qemu > > VERSION numbering - i.e. qemu-kvm-devel-88 could have been published as > > qemu-kv

[PATCH] configure: make default KVM_VERSION qemu-kvm-devel

2009-08-10 Thread Mark McLoughlin
, 87 etc.) and just uses the 'qemu-kvm-' string to detect that this is the kvm fork of qemu. The actual kvm snapshot number is no longer important, it's the qemu version number which is important. Signed-off-by: Mark McLoughlin --- configure |2 +- 1 files changed, 1 i

Re: [PATCH]: Always use KVM_VERSION to build version number

2009-08-10 Thread Mark McLoughlin
On Sun, 2009-08-09 at 12:58 +0300, Avi Kivity wrote: > On 08/07/2009 03:31 PM, Chris Lalancette wrote: > > Avi, > > Trying to use libvirt with development snapshots of qemu-kvm is a bit > > problematic. The trouble is that for all development snapshots, the value > > that > > gets placed in

Re: [PATCH 1/1] net: fix vnet_hdr bustage with slirp

2009-08-07 Thread Mark McLoughlin
On Fri, 2009-08-07 at 13:51 +0200, Arnd Bergmann wrote: > On Friday 07 August 2009, Mark McLoughlin wrote: > > slirp has started using VLANClientState::opaque and this has caused the > > kvm specific tap_has_vnet_hdr() hack to break because we blindly use > > this opaque poin

[PATCH 1/1] net: fix vnet_hdr bustage with slirp

2009-08-07 Thread Mark McLoughlin
table-0.11 too] Signed-off-by: Mark McLoughlin --- net.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index c7702f8..2428f63 100644 --- a/net.c +++ b/net.c @@ -1521,6 +1521,9 @@ int tap_has_vnet_hdr(void *opaque) VLANClientState *vc = o

Re: Fix migration issue when the destination is loaded

2009-07-16 Thread Mark McLoughlin
On Thu, 2009-07-16 at 15:00 +0300, Dor Laor wrote: > On 07/16/2009 12:39 PM, Mark McLoughlin wrote: > > Hi Dor, > > > > On Wed, 2009-07-15 at 18:03 +0300, Dor Laor wrote: > >> If the migration socket is full, we get EAGAIN for the write. > >> The set_fd_hand

Re: Fix migration issue when the destination is loaded

2009-07-16 Thread Mark McLoughlin
Hi Dor, On Wed, 2009-07-15 at 18:03 +0300, Dor Laor wrote: > If the migration socket is full, we get EAGAIN for the write. > The set_fd_handler2 defers the write for later on. The function > tries to wake up the iothread by qemu_kvm_notify_work. > Since this happens in a loop, multiple times, the

Re: [Qemu-devel] Planning for the 0.11.0 release

2009-07-09 Thread Mark McLoughlin
Hi Anthony, On Mon, 2009-06-22 at 18:57 -0500, Anthony Liguori wrote: > Hi, > > It's getting to be about the time to start thinking about the 0.11.0 > release. 0.10.0 was released on March 2nd so following with the 6 month > release cycle, that would put 0.11.0 at September 2nd. > > Based on

[PATCH] net: re-instate some lost vnet_hdr code

2009-07-08 Thread Mark McLoughlin
/?func=detail&atid=893831&aid=2817367&group_id=180599 Network doesn't work anymore switching from kvm-86 to kvm-87 Signed-off-by: Mark McLoughlin --- net.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/net.c b/net.c index ac06ea1..19e

Re: slow guest performance with build load, looking for ideas

2009-07-03 Thread Mark McLoughlin
On Thu, 2009-07-02 at 12:41 +0300, Avi Kivity wrote: > On 07/02/2009 08:48 AM, Avi Kivity wrote: > >> HOST time (make -j12&& make -j12 modules) with no guest running > >> > >> real6m50.936s > >> user29m12.051s > >> sys5m

[PATCH] Fix pcspk build with kvm disabled

2009-06-29 Thread Mark McLoughlin
function ‘kvm_get_pit_ch2’ hw/pcspk.c:185: error: too many arguments to function ‘kvm_set_pit_ch2’ hw/pcspk.c:171: warning: unused variable ‘inkernel_state’ Signed-off-by: Mark McLoughlin Cc: Jan Kiszka --- hw/pcspk.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a

Re: a few words about drive/pci add/remove

2009-06-17 Thread Mark McLoughlin
On Wed, 2009-06-17 at 17:44 +0400, Michael Tokarev wrote: > WARNING: at drivers/base/core.c:122 device_release+0x5f/0x70() > Device 'virtio8' does not have a release() function, it is broken and > must be fixed. This should be fixed in 2.6.29 Cheers, Mark. -- To unsubscribe from this list: send

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-17 Thread Mark McLoughlin
On Wed, 2009-06-17 at 12:03 +0300, Avi Kivity wrote: > On 06/17/2009 11:33 AM, Mark McLoughlin wrote: > >> I particularly don't like the idea of arcane machine-dependent slot > >> allocation knowledge living in libvirt, because it needs to be in Qemu > >> anyway

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-17 Thread Mark McLoughlin
On Tue, 2009-06-16 at 19:44 +0100, Jamie Lokier wrote: > Mark McLoughlin wrote: > > > Worst case we hardcode those numbers (gasp, faint). > > > > Maybe we can just add the open slots to the -help output. That'd be nice > > and clean. I was being sarcastic

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-16 Thread Mark McLoughlin
On Tue, 2009-06-16 at 15:28 +0300, Avi Kivity wrote: > On 06/16/2009 03:14 PM, Mark McLoughlin wrote: > > On Mon, 2009-06-15 at 13:12 -0500, Anthony Liguori wrote: > > > >> Mark McLoughlin wrote: > >> > >>> So long as the restrictions would

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-16 Thread Mark McLoughlin
On Mon, 2009-06-15 at 13:12 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > So long as the restrictions would be known to the management app via > > some "what slots are available" mechanism in qemu, that sounds fine. > > > > I'm not sure a

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Mon, 2009-06-15 at 18:05 +0300, Avi Kivity wrote: > On 06/15/2009 05:24 PM, Anthony Liguori wrote: > > Dor Laor wrote: > >> Libvirt does not support r2d. I hope it won't start to support it. > > > > It supports mips, sparc, and ppc machines now. I don't see why it > > wouldn't support r2d. Fo

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Mon, 2009-06-15 at 18:12 +0300, Dor Laor wrote: > > It doesn't want to. As Mark said, libvirt just wants to be able to ensure > > a stable guest ABI, of which stable PCI addresses is one aspect. This does > > not imply libvirt wants to allocate the PCI addresses, just that it wants > > a way to

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Mon, 2009-06-15 at 07:48 -0500, Anthony Liguori wrote: > Avi Kivity wrote: > > On 06/15/2009 12:09 PM, Mark McLoughlin wrote: > >>>>> I think the point is that you don't need version numbers if you > >>>>> have a > >>>>> prope

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Sun, 2009-06-14 at 10:58 +0300, Avi Kivity wrote: > Mark McLoughlin wrote: > > > > >> I think the point is that you don't need version numbers if you have a > >> proper device tree. > >> > > > > How do you add a new attribute

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Sun, 2009-06-14 at 12:50 +0300, Michael S. Tsirkin wrote: > On Fri, Jun 12, 2009 at 05:48:23PM +0100, Mark McLoughlin wrote: > > However, in order to retain compat for that SCSI device (e.g. ensuring > > the PCI address doesn't change as other devices are added an removed

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Sun, 2009-06-14 at 12:34 +0300, Michael S. Tsirkin wrote: > On Fri, Jun 12, 2009 at 04:53:27PM +0100, Mark McLoughlin wrote: > > The other obvious piece to add to it would be PCI addresses, so that > > even if you remove a device, the addresses assigned to existing devices &

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 20:44 +0300, Blue Swirl wrote: > If the device has different behavior or different properties from > guest perspective compared to the old device, it should get a new > device type so that you could specify in the device tree either the > old device or the new one. Yes, that

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 12:00 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > So, when libvirt creates a guest for the first time, it makes a copy of > > the device tree and continues to use that even if qemu is upgraded. > > That's enough to ensure compat is

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 11:12 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Fri, 2009-06-12 at 09:55 -0500, Anthony Liguori wrote: > > > >> Mark McLoughlin wrote: > >> > >>> On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokie

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 11:11 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Fri, 2009-06-12 at 09:51 -0500, Anthony Liguori wrote: > > > >> Mark McLoughlin wrote: > >> > >>> On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokier wrote: &g

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 09:55 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokier wrote: > > > > = Solution - Separate configuration from compat hints = > > > > As I suggested before: > > > >

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 09:51 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokier wrote: > > > >> Michael S. Tsirkin wrote: > >> > >>>> I think the right long term answer to all this

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 16:59 +0300, Michael S. Tsirkin wrote: > On Fri, Jun 12, 2009 at 09:43:29AM +0100, Mark McLoughlin wrote: > > = Solution - Separate configuration from compat hints = > > > > As I suggested before: > > > > - Allow the VM manager to du

Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokier wrote: > Michael S. Tsirkin wrote: > > > I think the right long term answer to all this is a way to get QEMU to > > > dump it's current machine configuration in glorious detail as a file > > > which can be reloaded as a machine configuration. > > > >

[GIT PULL] Merge latest qemu.git

2009-06-11 Thread Mark McLoughlin
nitor: Remove unused variable monitor: Introduce get_command_name() Fix "defined but not used" warning Mark McLoughlin (22): Revert "Fix output of uninitialized strings" net: fix error reporting for some net parameter checks net: factor tap_read_packet()

Re: Network throughput limits for local VM <-> VM communication

2009-06-09 Thread Mark McLoughlin
On Tue, 2009-06-09 at 11:06 +, Fischer, Anna wrote: > I am testing network throughput between two guests residing on the > same physical machine. I use a bridge to pass packets between those > guests and the virtio NIC model. I am wondering why the throughput > only goes up to about 970Mbps. S

Re: [KVM PATCH v4 3/3] kvm: add iosignalfd support

2009-06-04 Thread Mark McLoughlin
Hi Greg, On Wed, 2009-06-03 at 18:04 -0400, Gregory Haskins wrote: > Hi Mark, > So with the v5 release of iosignalfd, we now have the notion of a > "trigger", the API of which is as follows: > > --- > /*! > * \brief Assign an eventfd to an IO port (PIO or MMIO) > * > * As

Re: KVM-86 not exposing 64 bits CPU anymore, NICE

2009-06-04 Thread Mark McLoughlin
On Thu, 2009-06-04 at 09:20 +0200, Gilles PIETRI wrote: > I'm quite pissed off. I just upgraded to kvm-86 on a host that has > worked nicely on kvm-78 for quite some time. But since I was fearing the > qcow2 corruption issues, I wanted to upgrade kvm-86. After testing the > performance, I decid

Re: [KVM PATCH v4 3/3] kvm: add iosignalfd support

2009-05-28 Thread Mark McLoughlin
On Wed, 2009-05-27 at 16:45 -0400, Gregory Haskins wrote: > Mark McLoughlin wrote: > > The virtio ABI is fixed, so we couldn't e.g. have the guest use a cookie > > to identify a queue - it's just going to continue using a per-device > > queue number. > > Act

Re: [KVM PATCH v4 3/3] kvm: add iosignalfd support

2009-05-27 Thread Mark McLoughlin
On Wed, 2009-05-27 at 13:40 -0400, Gregory Haskins wrote: > Mark McLoughlin wrote: > > On Wed, 2009-05-27 at 15:11 +0300, Avi Kivity wrote: > > > > > >> Multiple cookies on the same address are required by virtio. You can't > >> mux since the da

Re: [KVM PATCH v4 3/3] kvm: add iosignalfd support

2009-05-27 Thread Mark McLoughlin
On Wed, 2009-05-27 at 15:11 +0300, Avi Kivity wrote: > Multiple cookies on the same address are required by virtio. You can't > mux since the data doesn't go anywhere. > > Virtio can survive by checking all rings on a notify, and we can later > add a mechanism that has a distinct address for e

Re: Add qemu_send_raw() to vlan.

2009-05-26 Thread Mark McLoughlin
On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote: > It gets packet without virtio header and adds it if needed. Allows to > inject packets to vlan from outside. To send gracious arp for instance. Acked-by: Mark McLoughlin This isn't ideal, but neither is the current VNET_HDR s

Re: Add qemu_send_raw() to vlan.

2009-05-26 Thread Mark McLoughlin
On Tue, 2009-05-26 at 13:11 +0300, Avi Kivity wrote: > Gleb Natapov wrote: > > On Tue, May 26, 2009 at 01:05:35PM +0300, Avi Kivity wrote: > > > >> Gleb Natapov wrote: > >> > >>> It gets packet without virtio header and adds it if needed. Allows to > >>> inject packets to vlan from outside

Re: 64bit guest thinks it is 32bit in kvm-86 - Intel only

2009-05-25 Thread Mark McLoughlin
On Sun, 2009-05-24 at 19:45 -0700, Josh Wilsdon wrote: > the kernel refuses to boot with the error message: > > "This kernel requires an x86-64 CPU, but only detected an i686 CPU. > Unable to boot - please use a kernel appropriate for your CPU." This should fix it: http://git.kernel.

Re: Guest OS cannot detect keystrokes/mouse clicks after system_reset

2009-05-20 Thread Mark McLoughlin
On Wed, 2009-05-20 at 15:25 +0530, Sachin Sant wrote: > > I used system_reset command from QEMU prompt with a SLES 11 > Guest. After a reset the guest came up fine with the exception > that neither key strokes nor mouse click worked. > > Host OS Info : > CPU Model : Intel(R) Xeon(R) CPU

Re: [PATCH 11/17] net: drop packet from tap device if all NICs are down

2009-05-19 Thread Mark McLoughlin
On Sun, 2009-05-17 at 10:43 -0500, Anthony Liguori wrote: > From: Mark McLoughlin > > If you do e.g. "set_link virtio.0 down" and there are packets > pending on the tap interface, we currently buffer a packet > and constantly try and send it until the link is up again. &

Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-14 Thread Mark McLoughlin
On Wed, 2009-05-13 at 21:57 +, Arnd Bergmann wrote: > On Wednesday 13 May 2009 08:32:21 Mark McLoughlin wrote: > > Currently we only include $(KERNELDIR)/include in CFLAGS, > > but we also have $(KERNELDIR)/arch/$(arch)/include or else > > we'll get mis-matched heade

Re: [ANNOUNCE] qemu-kvm-0.10.4

2009-05-13 Thread Mark McLoughlin
On Tue, 2009-05-12 at 22:30 +0200, Farkas Levente wrote: > Avi Kivity wrote: > > qemu-kvm-0.10.4 is now available. This is the first release of the 0.10 > > stable branch of qemu-kvm. The qemu-kvm 0.10.4 includes all of the > > features and fixes of qemu-0.10.4, plus adaptations for improved kvm

[PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-13 Thread Mark McLoughlin
Currently we only include $(KERNELDIR)/include in CFLAGS, but we also have $(KERNELDIR)/arch/$(arch)/include or else we'll get mis-matched headers. Signed-off-by: Mark McLoughlin --- kvm/user/config-i386.mak |1 - kvm/user/config-ia64.mak |1 + kvm/user/config-powerp

Re: [Qemu-devel] [PATCH 4/4] kvm: Trim cpu features not supported by kvm

2009-05-12 Thread Mark McLoughlin
On Sun, 2009-05-03 at 17:04 +0300, Avi Kivity wrote: > Remove cpu features that are not supported by kvm from the cpuid features > reported to the guest. > > Signed-off-by: Avi Kivity > @@ -1699,5 +1714,20 @@ CPUX86State *cpu_x86_init(const char *cpu_model) > > qemu_init_vcpu(env); >

[PATCH] Work around supported cpuid ioctl() brokenness

2009-05-12 Thread Mark McLoughlin
KVM_GET_SUPPORTED_CPUID has been known to fail to return -E2BIG when it runs out of entries. Detect this by always trying again with a bigger table if the ioctl() fills the table. Signed-off-by: Mark McLoughlin --- kvm/libkvm/libkvm-x86.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

[PATCH] KVM: fix cpuid E2BIG handling for extended request types

2009-05-12 Thread Mark McLoughlin
If we run out of cpuid entries for extended request types we should return -E2BIG, just like we do for the standard request types. Signed-off-by: Mark McLoughlin --- arch/x86/kvm/x86.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm

Re: [kvm] virtio-net not working with the latest qemu-kvm git

2009-05-05 Thread Mark McLoughlin
orking when i put the device in promiscuos mode by running > > tcpdump in background on the guest. > > > > After browsing through the recent patches, i found that the following commit > > is causing the regression. > > > > Remove stray GSO code from virtio_ne

[PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-05-05 Thread Mark McLoughlin
This commit: commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) Removed some GSO code from upstream qemu.git, but it needs to be re-instated in qemu-kvm.git. Reported-by: Sridhar Samudrala Signed-off-by: Mark McLoughlin

Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Mark McLoughlin
On Mon, 2009-05-04 at 12:08 +0300, Avi Kivity wrote: > In general a distro provides kernel headers matched to the running > kernel. For example F10 provides > kernel-headers-2.6.27.21-170.2.56.fc10.x86_64 to go along with > kernel-2.6.27.21-170.2.56.fc10.x86_64. So a user running a distro > k

Re: [PATCH] kvm: qemu: net: unbreak tap networking

2009-04-28 Thread Mark McLoughlin
On Tue, 2009-04-28 at 11:58 +0300, Avi Kivity wrote: > Mark McLoughlin wrote: > > A recent merge broke tap networking because qemu_send_packet() > > now always returns -EAGAIN causing tap to try and resend the > > same packet forever. > > > > Fix by having qemu_sen

[PATCH] kvm: qemu: net: unbreak tap networking

2009-04-28 Thread Mark McLoughlin
have been queued up during the delivery of the original packet. Signed-off-by: Mark McLoughlin --- net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net.c b/net.c index 16f6e48..b5ebcea 100644 --- a/net.c +++ b/net.c @@ -445,9 +445,9 @@ int qemu_send_packet

Re: [ANNOUNCE] kvm-85 release

2009-04-27 Thread Mark McLoughlin
On Mon, 2009-04-27 at 10:50 -0400, Christoph Hellwig wrote: > On Mon, Apr 27, 2009 at 04:45:23PM +0200, Alexander Graf wrote: > >> - Disabled pwritev() support until glibc stops writing random junk. > >>See https://bugzilla.redhat.com/497429 > > > > Wouldn't it be useful to have it disabled up

Re: [ANNOUNCE] kvm-85 release

2009-04-27 Thread Mark McLoughlin
Hi Avi, On Tue, 2009-04-21 at 12:32 +0300, Avi Kivity wrote: > Again a long delayed release; I'll try to reduce the lag between > releases. > > kvm-85 comes in two flavors: the traditional kernel+qemu package > (kvm-85.tar.gz), as well as separate qemu (qemu-kvm-devel-85.tar.gz) I packaged th

[PATCH] kvm: qemu: framebuffer: build fix for target-arm

2009-04-27 Thread Mark McLoughlin
/hw/framebuffer.c:54: warning: implicit declaration of function 'kvm_physical_sync_dirty_bitmap' Signed-off-by: Mark McLoughlin --- hw/framebuffer.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/framebuffer.c b/hw/framebuffer.c index 1086ba9..e2d7604 100644 -

kvm: qemu: net: drop packet from tap device if all NICs are down

2009-04-22 Thread Mark McLoughlin
er because we buffer packets from the tap interface. Reported-by: Yan Vugenfirer Signed-off-by: Mark McLoughlin --- qemu/net.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/qemu/net.c b/qemu/net.c index 9c199d6..201d282 100644 --- a/qemu/net.c +++ b/qemu/net.c

Re: virtio net regression

2009-04-20 Thread Mark McLoughlin
On Sun, 2009-04-19 at 14:48 +0300, Avi Kivity wrote: > Antoine Martin wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA512 > > > > Wireshark was showing a huge amount of invalid packets (wrong checksum) > > - - that was the cause of the slowdown. > > Simply rebooting the host into 2.6.28.

Re: kvm-84 + virtio Ubuntu Hardy guests

2009-04-06 Thread Mark McLoughlin
On Mon, 2009-04-06 at 09:55 -0700, Dustin Kirkland wrote: > On Tue, Mar 31, 2009 at 5:28 PM, Dustin Kirkland > wrote: > > I'm receiving a heavy volume of Ubuntu Jaunty Beta users reporting > > that Jaunty hosts running kvm-84 (userspace and kernel) are not able > > to boot previously-working Hard

[PATCH 2/4] kvm: configure: run kernel configure even with --with-patched-kernel

2009-03-27 Thread Mark McLoughlin
We still run header-sync in this case, which requires configure to have been run. Signed-off-by: Mark McLoughlin --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index a2aad59..49c4419 100755 --- a/configure +++ b/configure @@ -117,7

[PATCH 1/4] kvm: configure: remove unused depmod_version

2009-03-27 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin --- configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure b/configure index b9419c0..a2aad59 100755 --- a/configure +++ b/configure @@ -16,7 +16,6 @@ arch=`uname -m` target_exec= # don't use uname if kerneldir i

[PATCH 4/4] kvm: configure: --with-patched-kernel doesn't need kernelversion

2009-03-27 Thread Mark McLoughlin
DEPMOD_VERSION is only used for kvm.ko, not for e.g. header-sync. Signed-off-by: Mark McLoughlin --- kernel/configure |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/configure b/kernel/configure index 3fd0c94..7a222e4 100755 --- a/kernel/configure +++ b/kernel

[PATCH 3/4] kvm: configure: pass --with-patched-kernel to kernel/configure

2009-03-27 Thread Mark McLoughlin
We need to know this so that we can avoid doing things that are specific to building kvm.ko - e.g. when we are only doing header-sync. Signed-off-by: Mark McLoughlin --- configure|1 + kernel/configure |4 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a

[PATCH 0/4] fix header-sync using --with-patched-kernel

2009-03-27 Thread Mark McLoughlin
Hi Avi, Here are a few fairly trivial build patches - they fix building kvm.git using --with-patched-kernel alongside an unconfigured kvm.git tree. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More ma

Re: Fedora 11 Alpha on KVM-84

2009-02-23 Thread Mark McLoughlin
On Sun, 2009-02-22 at 16:35 -0300, Marcelo Tosatti wrote: > On Sat, Feb 21, 2009 at 08:59:49PM +0100, Fabian Deutsch wrote: > > Hey, > > > > Am Samstag, den 21.02.2009, 14:53 -0500 schrieb Mark Bidewell: > > > I tried installing Fedora 11 Alpha in KVM-84 however Anaconda hard > > > crashes when in

Re: KVM PCI device assignment issues

2009-02-13 Thread Mark McLoughlin
On Fri, 2009-02-13 at 08:56 -0800, Greg KH wrote: > On Fri, Feb 13, 2009 at 04:32:47PM +0000, Mark McLoughlin wrote: > > Driver Unbinding > > > > > > Before a device is assigned to a guest, we should make sure that no host > > device driver

KVM PCI device assignment issues

2009-02-13 Thread Mark McLoughlin
Hi, KVM has support for PCI device assignment using VT-d and AMD IOMMU, but there are a number of inter-related issues that need some further discussion: - Unbinding devices from any existing device driver before assignment - Resetting devices before and after assignment - Helping users f

Re: [PATCH 5/6] kvm: qemu: deassign device from guest

2009-02-13 Thread Mark McLoughlin
On Fri, 2009-02-13 at 14:58 +0800, Han, Weidong wrote: > +static void deassign_device(AssignedDevInfo *adev) > +{ > +struct kvm_assigned_pci_dev assigned_dev_data; > +AssignedDevice *dev = adev->assigned_dev; > +int r; > + > +memset(&assigned_dev_data, 0, sizeof(assigned_dev_data));

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-12 Thread Mark McLoughlin
On Thu, 2009-02-12 at 12:02 +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > > On Wed, Feb 11, 2009 at 08:08:23PM +0000, Mark McLoughlin wrote: > > > >> On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote: > >> > >>> Marcelo Tosa

Re: [PATCH 0/4] qemu: TAP filtering support

2009-02-11 Thread Mark McLoughlin
On Wed, 2009-02-11 at 12:51 -0700, Alex Williamson wrote: > > - What do we need rxfilter=on|off on the command line for? > > Primarily because the current tun driver in Linux has a bug that it can > drop unicast packets requested to be included in the filter if it > overflows the exact match tab

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-11 Thread Mark McLoughlin
On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > > This is better. > > > > Currently, this code path is posing us big troubles, > > and we won't have a decent patch in time. So, temporarily > > disable it. > > > > > > Applied to master and kvm-updates/2.6.29, th

  1   2   3   4   >