[PATCH] KVM: VMX: Support Unrestricted Guest feature

2009-06-08 Thread Nitin A Kamble
feature at the boot time. Signed-off-by: Nitin A Kamble nitin.a.kam...@intel.com Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/include/asm/kvm_host.h | 12 --- arch/x86/include/asm/vmx.h |1 + arch/x86/kvm/vmx.c | 60 +++ 3

[PATCH] QEMU KVM: i386: Fix the cpu reset state

2009-06-04 Thread Nitin A Kamble
As per the IA32 processor manual, the accessed bit is set to 1 in the processor state after reset. qemu pc cpu_reset code was missing this accessed bit setting. Signed-off-by: Nitin A Kamble nitin.a.kam...@intel.com --- target-i386/helper.c | 18 -- 1 files changed, 12

[PATCH KVM VMX 1/2] KVM: VMX: Rename rmode.active to rmode.vm86_active

2009-06-04 Thread Nitin A Kamble
That way the interpretation of rmode.active becomes more clear with unrestricted guest code. Signed-off-by: Nitin A Kamble nitin.a.kam...@intel.com --- arch/x86/include/asm/kvm_host.h |2 +- arch/x86/kvm/vmx.c | 28 ++-- 2 files changed, 15 insertions

[PATCH KVM VMX 0/2] Enable Unrestricted Guest

2009-06-04 Thread Nitin A Kamble
. Thanks Regards, Nitin Nitin A Kamble (2): KVM: VMX: Rename rmode.active to rmode.vm86_active KVM: VMX: Support Unrestricted Guest feature arch/x86/include/asm/kvm_host.h | 14 --- arch/x86/include/asm/vmx.h |1 + arch/x86/kvm/vmx.c | 77

Re: [patch] VMX Unrestricted mode support

2009-06-03 Thread Nitin A Kamble
Hi Avi, I find that the qemu processor reset state is not per the IA32 processor specifications. (Sections 8.1.1 of http://www.intel.com/Assets/PDF/manual/253668.pdf) In qemu-kvm.git in file target-i386/helper.c in function cpu_reset the segment registers are initialized as follows:

Re: [patch] VMX Unrestricted mode support

2009-06-01 Thread Nitin A Kamble
On Mon, 2009-06-01 at 11:06 -0700, Nitin A Kamble wrote: On Sun, 2009-05-31 at 01:39 -0700, Avi Kivity wrote: Instead of changing all the checks like this, you can make rmode.active be false when unrestricted guest is enabled. We can interpret rmode.active as emulating real mode via

[patch] VMX Unrestricted mode support

2009-05-28 Thread Nitin A Kamble
on the processor. It also adds a new kernel/module parameter to disable the unrestricted guest feature at the boot time. Signed-Off-By: Nitin A Kamble nitin.a.kam...@intel.com Thanks Regards, Nitin diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index d2b082d

Re: [patch] VMX Unrestricted guest mode support

2009-05-28 Thread Nitin A Kamble
Unrestricted guest features is introduced in Westmere processor. Westmere is next to nehalem. And all the following processors will support it. Westmere would be the 1st processor being built on the 32nm process. Thanks, Nitin On Thu, 2009-05-28 at 16:39 -0700, Alexey Eremenko wrote: VMX

kvm building issue

2009-05-19 Thread Nitin A Kamble
Hi Avi, I am trying to build the kvm with changed repositories. I was trying to follow the instructions from here: http://www.linux-kvm.org/page/Code. Especially this section: building an external module with older kernels from that page. I find the kernel directory is missing in the

Re: [kernel patch] exposing host cpuids to guest

2009-01-30 Thread Nitin A Kamble
On Fri, 2009-01-30 at 03:25 -0800, Amit Shah wrote: Please add a Signed-Off-By and a git-style description for patches sent for inclusion. Will do. Also, it'll be better to reply to the patch if you include in the message instead of attaching them (git send-email). -#define

Re: [userspace patch] exposing host cpuids to guest

2009-01-30 Thread Nitin A Kamble
On Fri, 2009-01-30 at 02:57 -0800, Amit Shah wrote: Please split them into multiple patches; they do a lot of things here. It's easier to review once all the logical changes are separated out. Also, split out the qemu-specific (qemu/target-i386/*) and kvm-specific parts so that the

[userspace patch] exposing host cpuids to guest

2009-01-29 Thread Nitin A Kamble
, 2009-01-29 at 17:12 -0800, Nitin A Kamble wrote: Avi, I reworked the earlier patch for exposing the host cpuid bits to guests. Attached is the patch for your kvm.git tree. With this new code in the kernel both the old and new qemu binaries are working. There are also changes for the kvm

Re: [Patch 3] thread/core siblings info for guests

2008-11-17 Thread Nitin A Kamble
On Sun, 2008-11-16 at 05:26 -0800, Avi Kivity wrote: Kamble, Nitin A wrote: The capability itself can return the count; for example case KVM_CAP_NR_CPUID_LEAVES: return KVM_MAX_CPUID_ENTRIES; which is simpler to use and shorter. Avi, Yes, it is simpler and shorter

Re: Cross vendor migration ideas

2008-11-14 Thread Nitin A Kamble
- The mind is like a parachute; it works much better when it's open commit 70e4e65bc591eb9cf25c1cbc0d16b2cbdb089a6f Author: Nitin A Kamble [EMAIL PROTECTED] Date: Wed Nov 5 16:17:46 2008 -0800 Change the ioctl KVM_GET_SUPPORTED_CPUID, such that it will return

[Patch 1] thread/core siblings info for guests

2008-11-05 Thread Nitin A Kamble
Hi Avi, Attached is the patch for the bugfix1, as we discussed in the earlier email. For cpuid leaf 0xb the bits 8-15 in ECX register define the end of counting leaf. The previous code was using bits 0-7 for this purpose, which is a bug. Signed-off-by: Nitin A Kamble [EMAIL PROTECTED

[patch 2] thread/core siblings info for guests

2008-11-05 Thread Nitin A Kamble
find a valid entry. 2. Also the stop condition in the for loop while looking for the next unflaged entry is broken. It needs to stop when it find one matching entry; and in the case of count of 1, it will be the same entry found in this iteration. Signed-Off-By: Nitin A Kamble [EMAIL

[Patch 3] thread/core siblings info for guests

2008-11-05 Thread Nitin A Kamble
, KVM_CAP_CPUID_SIZER to determine if the running kernel supports the above changed ABI. Signed-Off-By: Nitin A Kamble [EMAIL PROTECTED] Please Apply. Thanks Regards, Nitin commit 70e4e65bc591eb9cf25c1cbc0d16b2cbdb089a6f Author: Nitin A Kamble [EMAIL PROTECTED] Date: Wed Nov 5 16:17:46 2008 -0800

Re: thread/core siblings info for guests

2008-11-04 Thread Nitin A Kamble
Hi Avi, Thanks for the comments on the patches. please see bellow for my response to your comments. Thanks Regards, Nitin On Tue, 2008-11-04 at 07:59 -0700, Avi Kivity wrote: You need changelog entries that describe the patches. Also, one patch per email. sounds right. I will cut my

Re: thread/core siblings info for guests

2008-10-31 Thread Nitin A Kamble
. the kvm_kernel_patch is for the kvm.git tree. And the kvm_userspace_patch is for the kvm-userspace.git tree. Signed-Off-By: Nitin A Kamble [EMAIL PROTECTED] -- Thanks Regards, Nitin Open Source Technology Center, Intel Corporation - The mind

Re: thread/core siblings info for guests

2008-10-20 Thread Nitin A Kamble
Hi Avi, I do find that ioctl in the kvm kernel module code. and the qemu code can do the ioctl to get the cpuinfo bits. But seems like nobody is using this ioctl yet. What was the purpose of this code? On Sun, 2008-10-19 at 02:29 -0700, Avi Kivity wrote: There is already a kernel function for

Re: thread/core siblings info for guests

2008-10-17 Thread Nitin A Kamble
-By: Nitin A Kamble [EMAIL PROTECTED] Next things: * Default mode: I am not planning to do anything for this. I see the current situation is good enough for the default mode. * Managed mode: For this, I am thinking few things. 1. Either an option can be added to qemu to take (almost) all