Re: buggy emulate_int_real

2011-04-13 Thread Serge E. Hallyn
Quoting Jan Kiszka (jan.kis...@web.de): Looks consistent to me. It's working for me, so if there are no further comments I'll improve the changelog and send to lkml. thanks, -serge -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: buggy emulate_int_real

2011-04-13 Thread Serge E. Hallyn
Quoting Avi Kivity (a...@redhat.com): On 04/13/2011 04:24 PM, Serge E. Hallyn wrote: Quoting Jan Kiszka (jan.kis...@web.de): Looks consistent to me. It's working for me, so if there are no further comments Looks good to me too. I'll improve the changelog and send to lkml. kvm

[PATCH] kvm: fix push of wrong eip when doing softint

2011-04-13 Thread Serge E. Hallyn
When doing a soft int, we need to bump eip before pushing it to the stack. Otherwise we'll do the int a second time. [a...@canonical.com: merged eip update as per Jan's recommendation.] Signed-off-by: Serge E. Hallyn serge.hal...@ubuntu.com Signed-off-by: Andy Whitcroft a...@canonical.com

Re: buggy emulate_int_real

2011-04-12 Thread Serge E. Hallyn
Quoting Avi Kivity (a...@redhat.com): On 04/09/2011 12:09 AM, Serge E. Hallyn wrote: Hi, at https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/747090, it was found that emulate_int_real() sometimes pushes the wrong eip when doing a int. Whereas with non-kvm qemu we push the next

Re: buggy emulate_int_real

2011-04-12 Thread Serge E. Hallyn
Quoting Avi Kivity (a...@redhat.com): On 04/12/2011 10:53 AM, Serge E. Hallyn wrote: Quoting Avi Kivity (a...@redhat.com): On 04/09/2011 12:09 AM, Serge E. Hallyn wrote: Hi, at https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/747090, it was found that emulate_int_real

Re: buggy emulate_int_real

2011-04-12 Thread Serge E. Hallyn
Quoting Avi Kivity (a...@redhat.com): On 04/12/2011 10:53 AM, Serge E. Hallyn wrote: Quoting Avi Kivity (a...@redhat.com): On 04/09/2011 12:09 AM, Serge E. Hallyn wrote: Hi, at https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/747090, it was found that emulate_int_real

Re: buggy emulate_int_real

2011-04-12 Thread Serge E. Hallyn
Quoting Jan Kiszka (jan.kis...@siemens.com): On 2011-04-12 16:16, Avi Kivity wrote: On 04/12/2011 05:12 PM, Serge E. Hallyn wrote: Quoting Avi Kivity (a...@redhat.com): On 04/12/2011 10:53 AM, Serge E. Hallyn wrote: Quoting Avi Kivity (a...@redhat.com): On 04/09/2011 12:09 AM

Re: buggy emulate_int_real

2011-04-12 Thread Serge E. Hallyn
processing them (e.g. a page fault while accessing the IDT). Jan Ok, thanks guys. I'm currently trying a compile of the following. From a3c4d5b67eb6d91ef772bc0e04adcd7d9711275f Mon Sep 17 00:00:00 2001 From: Serge E. Hallyn serge.hal...@canonical.com Date: Tue, 12 Apr 2011 22:18:40 +0100 Subject

Re: buggy emulate_int_real

2011-04-12 Thread Serge E. Hallyn
Quoting Serge E. Hallyn (se...@hallyn.com): Quoting Jan Kiszka (jan.kis...@web.de): From a brief refresh-reading, I would say if (interrupt.soft || kvm_exception_is_soft(nr)) increment_eip_by_inst_len but only for those interrupts/exceptions which were raised by the triggering

buggy emulate_int_real

2011-04-08 Thread Serge E. Hallyn
Hi, at https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/747090, it was found that emulate_int_real() sometimes pushes the wrong eip when doing a int. Whereas with non-kvm qemu we push the next instruction after the int, with kvm we push the addr of the instruction itself. I thought it'd

Re: FIXED: Re: [Qemu-devel] possible regression in qemu-kvm 0.13.0 (memtest)

2011-01-06 Thread Serge E. Hallyn
Thanks, Stefan. That patch actually doesn't compile for me, because it leaves references in hw/pckbd.c to both ioport92_write and ioport92_read, which it deletes from there. Should ioport92_read just be renamed to outport_read instead of delted, and the remaining references changed to

Re: FIXED: Re: [Qemu-devel] possible regression in qemu-kvm 0.13.0 (memtest)

2011-01-05 Thread Serge E. Hallyn
Hi, I don't see this patch in the git tree, nor a revert of the buggy commit. Was any decision made on this? thanks, -serge -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at