Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Zhang Yanfei
description in first patch in this patchset. ;-) Yeah, not only in this patchset, I saw Joonsoo trying to unify all kinds of things in the MM. This is great for newbies, IMO. -- Thanks. Zhang Yanfei -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message

Re: [PATCH v2 01/10] DMA, CMA: clean-up log message

2014-06-12 Thread Zhang Yanfei
add one more debug log on cma_activate_area(). Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Reviewed-by: Zhang Yanfei zhangyan...@cn.fujitsu.com diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index 83969f8..bd0bb81 100644 --- a/drivers/base/dma

Re: [PATCH v2 02/10] DMA, CMA: fix possible memory leak

2014-06-12 Thread Zhang Yanfei
this patchset. Yeah, I also like the idea. After all, this patchset aims to a general CMA management, we could improve more after this patchset. So Acked-by: Zhang Yanfei zhangyan...@cn.fujitsu.com -- Thanks. Zhang Yanfei -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Zhang Yanfei
granularity for following generalization. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Zhang Yanfei zhangyan...@cn.fujitsu.com diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index bc4c171..9bc9340 100644 --- a/drivers/base/dma-contiguous.c +++ b/drivers

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

2014-06-12 Thread Zhang Yanfei
-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Zhang Yanfei zhangyan...@cn.fujitsu.com diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index 00e13ce..4eac559 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -283,16

Re: [PATCH v2 08/10] mm, cma: clean-up cma allocation error path

2014-06-12 Thread Zhang Yanfei
On 06/12/2014 11:21 AM, Joonsoo Kim wrote: We can remove one call sites for clear_cma_bitmap() if we first call it before checking error number. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Reviewed-by: Zhang Yanfei zhangyan...@cn.fujitsu.com diff --git a/mm/cma.c b/mm/cma.c index

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Zhang Yanfei
description in first patch in this patchset. ;-) Yeah, not only in this patchset, I saw Joonsoo trying to unify all kinds of things in the MM. This is great for newbies, IMO. -- Thanks. Zhang Yanfei -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message

Re: [PATCH v2 01/10] DMA, CMA: clean-up log message

2014-06-12 Thread Zhang Yanfei
add one more debug log on cma_activate_area(). Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Reviewed-by: Zhang Yanfei zhangyan...@cn.fujitsu.com diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index 83969f8..bd0bb81 100644 --- a/drivers/base/dma

Re: [PATCH v2 02/10] DMA, CMA: fix possible memory leak

2014-06-12 Thread Zhang Yanfei
this patchset. Yeah, I also like the idea. After all, this patchset aims to a general CMA management, we could improve more after this patchset. So Acked-by: Zhang Yanfei zhangyan...@cn.fujitsu.com -- Thanks. Zhang Yanfei -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Zhang Yanfei
granularity for following generalization. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Zhang Yanfei zhangyan...@cn.fujitsu.com diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index bc4c171..9bc9340 100644 --- a/drivers/base/dma-contiguous.c +++ b/drivers

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

2014-06-12 Thread Zhang Yanfei
-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Zhang Yanfei zhangyan...@cn.fujitsu.com diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index 00e13ce..4eac559 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -283,16

Re: [PATCH v2 08/10] mm, cma: clean-up cma allocation error path

2014-06-12 Thread Zhang Yanfei
On 06/12/2014 11:21 AM, Joonsoo Kim wrote: We can remove one call sites for clear_cma_bitmap() if we first call it before checking error number. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Reviewed-by: Zhang Yanfei zhangyan...@cn.fujitsu.com diff --git a/mm/cma.c b/mm/cma.c index

Re: [PATCH] x86/kexec: crash_vmclear_local_vmcss needs __rcu

2012-12-11 Thread Zhang Yanfei
于 2012年12月11日 04:30, Marcelo Tosatti 写道: On Fri, Dec 07, 2012 at 01:40:56PM +0800, Zhang Yanfei wrote: This removes the sparse warning: arch/x86/kernel/crash.c:49:32: sparse: incompatible types in comparison expression (different address spaces) Reported-by: kbuild test robot fengguang

Re: [PATCH] x86/kexec: crash_vmclear_local_vmcss needs __rcu

2012-12-11 Thread Zhang Yanfei
于 2012年12月11日 16:10, Gleb Natapov 写道: On Tue, Dec 11, 2012 at 04:04:55PM +0800, Zhang Yanfei wrote: 于 2012年12月11日 04:30, Marcelo Tosatti 写道: On Fri, Dec 07, 2012 at 01:40:56PM +0800, Zhang Yanfei wrote: This removes the sparse warning: arch/x86/kernel/crash.c:49:32: sparse: incompatible types

[PATCH] [RESEND] x86/kexec: crash_vmclear_local_vmcss needs __rcu

2012-12-11 Thread Zhang Yanfei
This removes the sparse warning: arch/x86/kernel/crash.c:49:32: sparse: incompatible types in comparison expression (different address spaces) Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- arch/x86/include/asm/kexec.h |3

[PATCH v11 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary

2012-12-06 Thread Zhang Yanfei
unnecessary conditions in function cpu_emergency_clear_loaded_vmcss as Marcelo suggested. Changelog from v1 to v2: 1. remove the sysctl and clear VMCSs unconditionally. Zhang Yanfei (2): x86/kexec: VMCLEAR VMCSs loaded on all cpus if necessary KVM-INTEL: provide the vmclear function

[PATCH v11 1/2] x86/kexec: VMCLEAR VMCSs loaded on all cpus if necessary

2012-12-06 Thread Zhang Yanfei
From: Zhang Yanfei zhangyan...@cn.fujitsu.com This patch provides a way to VMCLEAR VMCSs related to guests on all cpus before executing the VMXOFF when doing kdump. This is used to ensure the VMCSs in the vmcore updated and non-corrupted. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com

Re: [PATCH v11 2/2] KVM-INTEL: provide the vmclear function and a bitmap to support VMCLEAR in kdump

2012-12-06 Thread Zhang Yanfei
From: Zhang Yanfei zhangyan...@cn.fujitsu.com The vmclear function will be assigned to the callback function pointer when loading kvm-intel module. And the bitmap indicates whether we should do VMCLEAR operation in kdump. The bits in the bitmap are set/unset according to different conditions

[PATCH] x86/kexec: crash_vmclear_local_vmcss needs __rcu

2012-12-06 Thread Zhang Yanfei
This removes the sparse warning: arch/x86/kernel/crash.c:49:32: sparse: incompatible types in comparison expression (different address spaces) Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- arch/x86/include/asm/kexec.h |4

[PATCH v10 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary

2012-12-05 Thread Zhang Yanfei
and clear VMCSs unconditionally. Zhang Yanfei (2): x86/kexec: VMCLEAR VMCSs loaded on all cpus if necessary KVM-INTEL: provide the vmclear function and a bitmap to support VMCLEAR in kdump arch/x86/include/asm/kexec.h |2 + arch/x86/kernel/crash.c | 32

[PATCH v10 1/2] x86/kexec: VMCLEAR VMCSs loaded on all cpus if necessary

2012-12-05 Thread Zhang Yanfei
This patch provides a way to VMCLEAR VMCSs related to guests on all cpus before executing the VMXOFF when doing kdump. This is used to ensure the VMCSs in the vmcore updated and non-corrupted. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- arch/x86/include/asm/kexec.h |2 ++ arch

Re: [PATCH v10 2/2] KVM-INTEL: provide the vmclear function and a bitmap to support VMCLEAR in kdump

2012-12-05 Thread Zhang Yanfei
The vmclear function will be assigned to the callback function pointer when loading kvm-intel module. And the bitmap indicates whether we should do VMCLEAR operation in kdump. The bits in the bitmap are set/unset according to different conditions. Signed-off-by: Zhang Yanfei zhangyan

Re: [PATCH v9 1/2] x86/kexec: VMCLEAR VMCSs loaded on all cpus if necessary

2012-12-04 Thread Zhang Yanfei
于 2012年12月05日 04:14, Eric W. Biederman 写道: Zhang Yanfei zhangyan...@cn.fujitsu.com writes: This patch provides a way to VMCLEAR VMCSs related to guests on all cpus before executing the VMXOFF when doing kdump. This is used to ensure the VMCSs in the vmcore updated and non-corrupted

Re: [PATCH v8 1/2] x86/kexec: add a new atomic notifier list for kdump

2012-11-26 Thread Zhang Yanfei
于 2012年11月27日 02:18, Eric W. Biederman 写道: Gleb Natapov g...@redhat.com writes: On Mon, Nov 26, 2012 at 11:43:10AM -0600, Eric W. Biederman wrote: Gleb Natapov g...@redhat.com writes: On Mon, Nov 26, 2012 at 09:08:54AM -0600, Eric W. Biederman wrote: Zhang Yanfei zhangyan...@cn.fujitsu.com

Re: [PATCH v8 1/2] x86/kexec: add a new atomic notifier list for kdump

2012-11-26 Thread Zhang Yanfei
于 2012年11月27日 09:49, Eric W. Biederman 写道: Zhang Yanfei zhangyan...@cn.fujitsu.com writes: So in summary, 1. a specific callback function instead of a notifier? Yes. 2. Instead of calling vmclear_local_loaded_vmcss, the vmclear operation will just call the vmclear on every vmcss

[PATCH v9 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary

2012-11-26 Thread Zhang Yanfei
vmclear_skipped to skip vmclear in kdump in some conditions. Changelog from v2 to v3: 1. remove unnecessary conditions in function cpu_emergency_clear_loaded_vmcss as Marcelo suggested. Changelog from v1 to v2: 1. remove the sysctl and clear VMCSs unconditionally. Zhang Yanfei (2): x86/kexec

[PATCH v9 1/2] x86/kexec: VMCLEAR VMCSs loaded on all cpus if necessary

2012-11-26 Thread Zhang Yanfei
This patch provides a way to VMCLEAR VMCSs related to guests on all cpus before executing the VMXOFF when doing kdump. This is used to ensure the VMCSs in the vmcore updated and non-corrupted. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- arch/x86/include/asm/kexec.h |2 ++ arch

[PATCH v9 2/2] KVM-INTEL: provide the vmclear function and a bitmap to support VMCLEAR in kdump

2012-11-26 Thread Zhang Yanfei
The vmclear function will be assigned to the callback function pointer when loading kvm-intel module. And the bitmap indicates whether we should do VMCLEAR operation in kdump. The bits in the bitmap are set/unset according to different conditions. Signed-off-by: Zhang Yanfei zhangyan

Re: [PATCH v8 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary

2012-11-25 Thread Zhang Yanfei
于 2012年11月25日 22:26, Gleb Natapov 写道: On Thu, Nov 22, 2012 at 04:22:26PM +0800, Zhang Yanfei wrote: Currently, kdump just makes all the logical processors leave VMX operation by executing VMXOFF instruction, so any VMCSs active on the logical processors may be corrupted. But, sometimes, we

Re: [PATCH v8 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary

2012-11-25 Thread Zhang Yanfei
Hello Eric Would you help review the patch, and give some comments, please ? Thanks Zhang 于 2012年11月22日 16:22, Zhang Yanfei 写道: Currently, kdump just makes all the logical processors leave VMX operation by executing VMXOFF instruction, so any VMCSs active on the logical processors may

[PATCH v6 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary

2012-11-21 Thread Zhang Yanfei
and clear VMCSs unconditionally. Zhang Yanfei (2): x86/kexec: VMCLEAR vmcss on all cpus if necessary KVM-INTEL: add a notifier and a bitmap to support VMCLEAR in kdump arch/x86/include/asm/kexec.h |2 + arch/x86/kernel/crash.c | 25 + arch/x86/kvm/vmx.c | 77

[PATCH v6 1/2] x86/kexec: VMCLEAR vmcss on all cpus if necessary

2012-11-21 Thread Zhang Yanfei
This patch adds an atomic notifier list named vmclear_notifier_list. When loading kvm-intel module, a notifier will be registered in the list to enable vmcss loaded on all cpus to be VMCLEAR'd if needed. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- arch/x86/include/asm/kexec.h

[PATCH v6 2/2] KVM-INTEL: add a notifier and a bitmap to support VMCLEAR in kdump

2012-11-21 Thread Zhang Yanfei
The notifier will be registered in vmclear_notifier_list when loading kvm-intel module. And the bitmap indicates whether we should do VMCLEAR operation in kdump. The bits in the bitmap are set/unset according to different conditions. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com

[PATCH v5 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary

2012-11-20 Thread Zhang Yanfei
cpu_emergency_clear_loaded_vmcss as Marcelo suggested. Changelog from v1 to v2: 1. remove the sysctl and clear VMCSs unconditionally. Zhang Yanfei (2): x86/kexec: VMCLEAR vmcss on all cpus if necessary KVM-INTEL: add a notifier and a bitmap to support VMCLEAR in kdump arch/x86/include/asm/kexec.h |2 + arch/x86/kernel

[PATCH v5 1/2] x86/kexec: VMCLEAR vmcss on all cpus if necessary

2012-11-20 Thread Zhang Yanfei
This patch adds an atomic notifier list named crash_notifier_list. When loading kvm-intel module, a notifier will be registered in the list to enable vmcss loaded on all cpus to be VMCLEAR'd if needed. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- arch/x86/include/asm/kexec.h |2

[PATCH v5 2/2] KVM-INTEL: add a notifier and a bitmap to support VMCLEAR in kdump

2012-11-20 Thread Zhang Yanfei
The notifier will be registered in crash_notifier_list when loading kvm-intel module. And the bitmap indicates whether we should do VMCLEAR operation in kdump. The bits in the bitmap are set/unset according to different conditions. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- arch

Re: [PATCH 0/3] x86: clear vmcss on all cpus when doing kdump if necessary

2012-10-18 Thread Zhang Yanfei
于 2012年10月18日 18:55, Avi Kivity 写道: On 10/18/2012 03:12 AM, Zhang Yanfei wrote: 于 2012年10月17日 18:16, Avi Kivity 写道: On 10/17/2012 04:28 AM, Zhang Yanfei wrote: 于 2012年10月15日 23:43, Avi Kivity 写道: On 10/12/2012 08:40 AM, Zhang Yanfei wrote: Currently, kdump just makes all the logical

[PATCH v2 0/2] x86: clear vmcss on all cpus when doing kdump if necessary

2012-10-18 Thread Zhang Yanfei
Currently, kdump just makes all the logical processors leave VMX operation by executing VMXOFF instruction, so any VMCSs active on the logical processors may be corrupted. But, sometimes, we need the VMCSs to debug guest images contained in the host vmcore. To prevent the corruption, we should

[PATCH 1/2] x86/kexec: VMCLEAR vmcss on all cpus if necessary

2012-10-18 Thread Zhang Yanfei
This patch provides a way to VMCLEAR vmcss related to guests on all cpus before executing the VMXOFF when doing kdump. This is used to ensure the VMCSs in the vmcore updated and non-corrupted. Signed-off-by: zhangyanfei zhangyan...@cn.fujitsu.com --- arch/x86/include/asm/kexec.h |2 ++

[PATCH 2/2] KVM: make crash_clear_loaded_vmcss valid when loading kvm_intel module

2012-10-18 Thread Zhang Yanfei
Signed-off-by: zhangyanfei zhangyan...@cn.fujitsu.com --- arch/x86/kvm/vmx.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 4ff0ab9..f6a16b2 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -41,6 +41,7 @@

Re: [PATCH 0/3] x86: clear vmcss on all cpus when doing kdump if necessary

2012-10-17 Thread Zhang Yanfei
于 2012年10月17日 18:16, Avi Kivity 写道: On 10/17/2012 04:28 AM, Zhang Yanfei wrote: 于 2012年10月15日 23:43, Avi Kivity 写道: On 10/12/2012 08:40 AM, Zhang Yanfei wrote: Currently, kdump just makes all the logical processors leave VMX operation by executing VMXOFF instruction, so any VMCSs active

[PATCH 0/3] x86: clear vmcss on all cpus when doing kdump if necessary

2012-10-12 Thread Zhang Yanfei
Currently, kdump just makes all the logical processors leave VMX operation by executing VMXOFF instruction, so any VMCSs active on the logical processors may be corrupted. But, sometimes, we need the VMCSs to debug guest images contained in the host vmcore. To prevent the corruption, we should

[PATCH 1/3] x86/kexec: clear vmcss on all cpus if necessary

2012-10-12 Thread Zhang Yanfei
This patch provides an alternative way to clear vmcss related to guests on all cpus when doing kdump. Signed-off-by: zhangyanfei zhangyan...@cn.fujitsu.com --- arch/x86/include/asm/kexec.h |3 +++ arch/x86/kernel/crash.c | 23 +++ 2 files changed, 26 insertions(+),

[PATCH 2/3] KVM: make crash_clear_loaded_vmcss valid when kvm_intel is loaded

2012-10-12 Thread Zhang Yanfei
Signed-off-by: zhangyanfei zhangyan...@cn.fujitsu.com --- arch/x86/kvm/vmx.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 4ff0ab9..f6a16b2 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -41,6 +41,7 @@

[PATCH 3/3] sysctl: introduce a new interface to control kdump-vmcs-clear behaviour

2012-10-12 Thread Zhang Yanfei
This patch exports the variable clear_loaded_vmcs_enabled to userspace. Signed-off-by: zhangyanfei zhangyan...@cn.fujitsu.com --- Documentation/sysctl/kernel.txt |8 kernel/sysctl.c | 10 ++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git

Export offsets of VMCS fields as note information for kdump

2012-08-27 Thread Zhang Yanfei
Hello Avi, About this VMCSINFO patch, we really need this functionality in our development. And YOSHIDA Masanori(masanori.yoshida...@hitachi.com), the developer from Hitachi, has said they need this too. So could you please tell us why the patch is unacceptable? You dislike the whole

Re: KVM-INTEL: Add new module vmcsinfo-intel to fill VMCSINFO

2012-08-02 Thread Zhang Yanfei
://git.kernel.org/pub/scm/virt/kvm/kvm.git Thanks Zhang Yanfei -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 0/3] Export offsets of VMCS fields as note information for kdump

2012-07-29 Thread Zhang Yanfei
Hello Avi, Do you have any comments about this version of the patch set? 于 2012年07月12日 17:54, Zhang Yanfei 写道: This patch set exports offsets of VMCS fields as note information for kdump. We call it VMCSINFO. The purpose of VMCSINFO is to retrieve runtime state of guest machine image

[PATCH v5 0/3] Export offsets of VMCS fields as note information for kdump

2012-07-12 Thread Zhang Yanfei
This patch set exports offsets of VMCS fields as note information for kdump. We call it VMCSINFO. The purpose of VMCSINFO is to retrieve runtime state of guest machine image, such as registers, in host machine's crash dump as VMCS format. The problem is that VMCS internal is hidden by Intel in its

[PATCH v5 1/3] KVM: Export symbols for module vmcsinfo-intel

2012-07-12 Thread Zhang Yanfei
A new module named vmcsinfo-intel is used to fill VMCSINFO. And this module depends on kvm-intel and kvm module. So we should export some symbols of kvm-intel and kvm module that are needed by vmcsinfo-intel. Signed-off-by: zhangyanfei zhangyan...@cn.fujitsu.com --- arch/x86/include/asm/vmx.h |

[PATCH v5 2/3] KVM-INTEL: Add new module vmcsinfo-intel to fill VMCSINFO

2012-07-12 Thread Zhang Yanfei
of VMCS fields for guest debugging. + * + * Copyright (C) 2012 Fujitsu, Inc. + * + * Authors: + * Zhang Yanfei zhangyan...@cn.fujitsu.com + * + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + * + */ + +#include linux

[PATCH v5 3/3] Documentation: Add ABI entry for vmcs sysfs interface

2012-07-12 Thread Zhang Yanfei
2012 +Contact: Zhang Yanfei zhangyan...@cn.fujitsu.com +Description: + A collection of vmcs fields' offsets for Intel cpu. + Also including vmcs revision identifier. + + Individual offsets are contained in subfiles named by + the filed's