Re: [patch] vfio: make an array larger

2015-11-04 Thread walter harms
Am 04.11.2015 14:26, schrieb Dan Carpenter: > Smatch complains about a possible out of bounds error: > > drivers/vfio/pci/vfio_pci_config.c:1241 vfio_cap_init() > error: buffer overflow 'pci_cap_length' 20 <= 20 > > Fix this by making the array larger. > > Signed-off-by: Dan

Re: [patch] vhost: NULL vs ERR_PTR bug

2015-07-15 Thread walter harms
Am 15.07.2015 13:28, schrieb Michael S. Tsirkin: On Wed, Jul 15, 2015 at 02:16:59PM +0300, Dan Carpenter wrote: There is only one caller for vhost_kvzalloc() and it expects NULL on allocation failure. Most people would probably expect that so let's change ERR_PTR(-ENOMEM) to NULL. Fixes:

Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()

2015-06-20 Thread walter harms
Acked-by: walter harms wha...@bfs.de Am 17.06.2015 02:35, schrieb Andy Lutomirski: This is only used if BAYCOM_DEBUG is defined. Cc: walter harms wha...@bfs.de Cc: Ralf Baechle r...@linux-mips.org Cc: Thomas Sailer t.sai...@alumni.ethz.ch Cc: linux-h...@vger.kernel.org Signed-off-by: Andy

Re: [patch RFC] kvm, cpuid: silence a buffer overflow warning

2014-02-20 Thread walter harms
Am 20.02.2014 14:07, schrieb Paolo Bonzini: Il 20/02/2014 13:34, Dan Carpenter ha scritto: This seems like a harmless off by one overflow if i is the last element in the vcpu-arch.cpuid_entries[] array. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Not tested. I always wonder

Re: [patch] KVM: return an error code in kvm_vm_ioctl_register_coalesced_mmio()

2014-01-29 Thread walter harms
Am 29.01.2014 14:16, schrieb Dan Carpenter: If kvm_io_bus_register_dev() fails then it returns success but it should return an error code. I also did a little cleanup like removing an impossible NULL test. Fixes: 2b3c246a682c ('KVM: Make coalesced mmio use a device per zone')

Re: [PATCH 1/1] kvm/mmu: Resolve compile warning

2009-10-12 Thread walter harms
javier martinez canillas schrieb: I got this compile warning with today linux-next: arch/x86/kvm/mmu.c: In function ‘kvm_set_pte_rmapp’: arch/x86/kvm/mmu.c:770: warning: cast to pointer from integer of different size arch/x86/kvm/mmu.c: In function ‘kvm_set_spte_hva’: