Re: [PATCH] Adding a userspace application crash handling system to autotest

I do have one major concern; other than that, it looks pretty good to me. I think Michael's suggestions are generally reasonable (although I'm fine with the code as it is as well). But if you do use his suggested get_results_dir_list please use pid in pid_dir_dict and not

[PATCH] Adding a userspace application crash handling system to autotest

This patch adds a system to watch user space segmentation faults, writing core dumps and some degree of core dump analysis report. We believe that such a system will be beneficial for autotest as a whole, since the ability to get core dumps and dump analysis for each app crashing during an

Re: [Autotest] [PATCH] Adding a userspace application crash handling system to autotest

On Mon, Sep 14, 2009 at 7:23 AM, Michael Goldish mgold...@redhat.com wrote: I think this is a very useful feature to have. Please see some very minor comments below. - Lucas Meneghel Rodrigues l...@redhat.com wrote: This patch adds a system to watch user space segmentation faults,

Re: [PATCH] Adding a userspace application crash handling system to autotest

I think this is a very useful feature to have. Please see some very minor comments below. - Lucas Meneghel Rodrigues l...@redhat.com wrote: This patch adds a system to watch user space segmentation faults, writing core dumps and some degree of core dump analysis report. We believe that

Re: [Autotest] [PATCH] Adding a userspace application crash handling system to autotest

Sorry, I haven't had time to take a look yet. Been busy. :( I'll try and get in a review some time today. -- John On Sun, Sep 13, 2009 at 9:40 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: Hi John, do you think the code looks good enough for inclusion? On Tue, Sep 8, 2009 at 10:53 AM,

Re: [Autotest] [PATCH] Adding a userspace application crash handling system to autotest

Hi John, do you think the code looks good enough for inclusion? On Tue, Sep 8, 2009 at 10:53 AM, Lucas Meneghel Rodrigues l...@redhat.com wrote: This patch adds a system to watch user space segmentation faults, writing core dumps and some degree of core dump analysis report. We believe that

[PATCH] Adding a userspace application crash handling system to autotest

This patch adds a system to watch user space segmentation faults, writing core dumps and some degree of core dump analysis report. We believe that such a system will be beneficial for autotest as a whole, since the ability to get core dumps and dump analysis for each app crashing during an

[PATCH] Adding a userspace application crash handling system to autotest

This patch adds a system to watch user space segmentation faults, writing core dumps and some degree of core dump analysis report. We believe that such a system will be beneficial for autotest as a whole, since the ability to get core dumps and dump analysis for each app crashing during an

Re: [PATCH] Adding a userspace application crash handling system to autotest

On 08/13/2009 05:04 AM, Lucas Meneghel Rodrigues wrote: This patch adds a system to watch user space segmentation faults, writing core dumps and some degree of core dump analysis report. We believe that such a system will be beneficial for autotest as a whole, since the ability to get core dumps

[PATCH] Adding a userspace application crash handling system to autotest

This patch adds a system to watch user space segmentation faults, writing core dumps and some degree of core dump analysis report. We believe that such a system will be beneficial for autotest as a whole, since the ability to get core dumps and dump analysis for each app crashing during an