Re: [PATCH] cleanup acpi table creation

2009-06-08 Thread Avi Kivity
Gleb Natapov wrote: Current code is a mess. And addition of acpi tables is broken. Sorry, this patch is impossible to review. Please send the shortest possible fix, even if it remains hacky. We'll switch to seabios as soon as possible, so I don't think it makes sense to clean this up.

Re: [PATCH] cleanup acpi table creation

2009-06-08 Thread Gleb Natapov
On Mon, Jun 08, 2009 at 02:29:16PM +0300, Avi Kivity wrote: Gleb Natapov wrote: Current code is a mess. And addition of acpi tables is broken. Sorry, this patch is impossible to review. Please send the shortest possible fix, even if it remains hacky. We'll switch to seabios as soon

[PATCH] cleanup acpi table creation

2009-06-04 Thread Gleb Natapov
Current code is a mess. And addition of acpi tables is broken. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/kvm/bios/rombios32.c b/kvm/bios/rombios32.c index 369cbef..fda4894 100755 --- a/kvm/bios/rombios32.c +++ b/kvm/bios/rombios32.c @@ -1293,15 +1293,13 @@ struct rsdp_descriptor