Re: [PATCH] kvm: Make init_rmode_tss() return 0 on success.

2014-09-22 Thread Paolo Bonzini
Il 20/09/2014 01:44, Radim Krčmář ha scritto: This patch removes the redundant variable, by making init_rmode_tss() return 0 on success, -errno on failure. Which is going to propagate all the way to userpace through ioctl ... is this change of A[PB]I acceptable? Otherwise, -EFAULT seems

Re: [PATCH] kvm: Make init_rmode_tss() return 0 on success.

2014-09-19 Thread Radim Krčmář
2014-09-16 13:38+0200, Paolo Bonzini: In init_rmode_tss(), there two variables indicating the return value, r and ret, and it return 0 on error, 1 on success. The function is only called by vmx_set_tss_addr(), and r is redundant. This patch removes the redundant variable, by making

[PATCH] kvm: Make init_rmode_tss() return 0 on success.

2014-09-16 Thread Paolo Bonzini
In init_rmode_tss(), there two variables indicating the return value, r and ret, and it return 0 on error, 1 on success. The function is only called by vmx_set_tss_addr(), and r is redundant. This patch removes the redundant variable, by making init_rmode_tss() return 0 on success, -errno on