Re: [PATCH] kvm-userspace: fix module build with --kerneldir

2008-12-10 Thread Avi Kivity
Joerg Roedel wrote: Hey Avi, do you plan to apply this patch? Or, if not, can you give a comment why not? sorry, accidentally dropped, not applied. Thanks for the remainder. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line

Re: [PATCH] kvm-userspace: fix module build with --kerneldir

2008-12-01 Thread Maik Hentsche
Please find my reworked patch attached. Support for pre-f1d28fb04 kernels was tested with 2.6.16.1. I CC-ed everyone who contributed to this thread, thanks for your help. I hope the bureaucracy is correct. I'm not a kernel developer and thus only know about the contribution process what I found in

Re: [PATCH] kvm-userspace: fix module build with --kerneldir

2008-11-27 Thread Eduardo Habkost
Excerpts from Avi Kivity's message of Qua Nov 26 14:00:42 -0200 2008: Jan Kiszka wrote: Avi Kivity wrote: snip If the user specified $kerneldir, it should be in the form /lib/modules/$version/build, no? This is not sufficiently generic. KVM should to accept arbitrary paths to

Re: [PATCH] kvm-userspace: fix module build with --kerneldir

2008-11-26 Thread Maik Hentsche
Avi Kivity [EMAIL PROTECTED] wrote: Can't the version be determined directly from kernedir itself? e.g. kerneldir is /lib/modules/$version/build? How do you get $version if you are crosscompiling? In this case the usual way of asking uname doesn't work. Instead you somehow need to get the

Re: [PATCH] kvm-userspace: fix module build with --kerneldir

2008-11-26 Thread Avi Kivity
Maik Hentsche wrote: If the user specified $kerneldir, it should be in the form /lib/modules/$version/build, no? Ah sorry, I did not know of this requirement. My kerneldir is /tmp/linux (I build inside chroot). I took it from the depmod manpage, but if you're building from