Re: [PATCH] kvm tools: Add 'kvm nmi' command

2011-12-07 Thread Ingo Molnar
* Sasha Levin levinsasha...@gmail.com wrote: This patch adds a 'kvm nmi' command which can be used to trigger NMIs in guests. Mostly useful for debugging purposes. Could we make this something like 'kvm debug nmi'? We already have some debug functionality, right? Those should be

Re: [PATCH] kvm tools: Add 'kvm nmi' command

2011-12-07 Thread Gleb Natapov
On Tue, Dec 06, 2011 at 10:42:55PM +0200, Sasha Levin wrote: +static void handle_nmi(int fd, u32 type, u32 len, u8 *msg) +{ + u32 vcpu = *(u32 *)msg; + + ioctl(kvm_cpus[vcpu]-vcpu_fd, KVM_NMI); You need to check that vcpu apic's LINT1 is configured to receive NMI (and not masked

Re: [PATCH] kvm tools: Add 'kvm nmi' command

2011-12-07 Thread Cyrill Gorcunov
On Wed, Dec 07, 2011 at 12:21:52PM +0200, Gleb Natapov wrote: On Tue, Dec 06, 2011 at 10:42:55PM +0200, Sasha Levin wrote: +static void handle_nmi(int fd, u32 type, u32 len, u8 *msg) +{ + u32 vcpu = *(u32 *)msg; + + ioctl(kvm_cpus[vcpu]-vcpu_fd, KVM_NMI); You need to check that

Re: [PATCH] kvm tools: Add 'kvm nmi' command

2011-12-07 Thread Gleb Natapov
On Wed, Dec 07, 2011 at 02:31:11PM +0400, Cyrill Gorcunov wrote: On Wed, Dec 07, 2011 at 12:21:52PM +0200, Gleb Natapov wrote: On Tue, Dec 06, 2011 at 10:42:55PM +0200, Sasha Levin wrote: +static void handle_nmi(int fd, u32 type, u32 len, u8 *msg) +{ + u32 vcpu = *(u32 *)msg; + +

Re: [PATCH] kvm tools: Add 'kvm nmi' command

2011-12-07 Thread Cyrill Gorcunov
On Wed, Dec 07, 2011 at 12:33:05PM +0200, Gleb Natapov wrote: On Wed, Dec 07, 2011 at 02:31:11PM +0400, Cyrill Gorcunov wrote: On Wed, Dec 07, 2011 at 12:21:52PM +0200, Gleb Natapov wrote: On Tue, Dec 06, 2011 at 10:42:55PM +0200, Sasha Levin wrote: +static void handle_nmi(int fd, u32

Re: [PATCH] kvm tools: Add 'kvm nmi' command

2011-12-07 Thread Gleb Natapov
On Wed, Dec 07, 2011 at 02:37:25PM +0400, Cyrill Gorcunov wrote: On Wed, Dec 07, 2011 at 12:33:05PM +0200, Gleb Natapov wrote: On Wed, Dec 07, 2011 at 02:31:11PM +0400, Cyrill Gorcunov wrote: On Wed, Dec 07, 2011 at 12:21:52PM +0200, Gleb Natapov wrote: On Tue, Dec 06, 2011 at 10:42:55PM

Re: [PATCH] kvm tools: Add 'kvm nmi' command

2011-12-07 Thread Cyrill Gorcunov
On Wed, Dec 07, 2011 at 12:41:50PM +0200, Gleb Natapov wrote: Yup, but while we support linux kernels only it should be fine. Still of course on long term we need a check. Tomorrow someone will send a patch to change how Linux behaves and slightly older kvmtool will not be able to run

Re: [PATCH] kvm tools: Add 'kvm nmi' command

2011-12-07 Thread Pekka Enberg
On Wed, 2011-12-07 at 09:16 +0100, Ingo Molnar wrote: * Sasha Levin levinsasha...@gmail.com wrote: This patch adds a 'kvm nmi' command which can be used to trigger NMIs in guests. Mostly useful for debugging purposes. Could we make this something like 'kvm debug nmi'? We already

Re: [PATCH] kvm tools: Add 'kvm nmi' command

2011-12-07 Thread Sasha Levin
On Wed, 2011-12-07 at 19:13 +0200, Pekka Enberg wrote: On Wed, 2011-12-07 at 09:16 +0100, Ingo Molnar wrote: * Sasha Levin levinsasha...@gmail.com wrote: This patch adds a 'kvm nmi' command which can be used to trigger NMIs in guests. Mostly useful for debugging purposes.

[PATCH] kvm tools: Add 'kvm nmi' command

2011-12-06 Thread Sasha Levin
This patch adds a 'kvm nmi' command which can be used to trigger NMIs in guests. Mostly useful for debugging purposes. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/Documentation/kvm-nmi.txt | 16 +++ tools/kvm/Makefile |3 +-