Re: [PATCH 0/2] remove kvm vmap usage

2008-12-29 Thread Avi Kivity

Izik Eidus wrote:

Remove the vmap usage from kvm, this is needed both for ksm and
get_user_pages != write.
  


applied, thanks.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/2] remove kvm vmap usage

2008-12-28 Thread Izik Eidus
Remove the vmap usage from kvm, this is needed both for ksm and
get_user_pages != write.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] remove kvm vmap usage

2008-12-28 Thread Izik Eidus

Izik Eidus wrote:

Remove the vmap usage from kvm, this is needed both for ksm and
get_user_pages != write.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Ok so for ksm things are now all right, actully i could live without 
this vmap as well,
beacuse ksm check the page _count and every call to gva_to_page should 
increase it.


anyway before i continue with the kmap removing (again ksm doesnt need 
it, only get_user_pages != write)

does we really want to go that way?

even for the get_user_pages case we can live with the write = 0, if 
before each kmap_atomic we will call
get_user_pages (write = 1), so the page inside apic_page and time_page 
and what so ever would be safe
(when ksm will come to merge that page it will skip it with the page 
count check)

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html