Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2012-01-02 Thread Paolo Bonzini
On 01/01/2012 05:45 PM, Stefan Hajnoczi wrote: By the way, drivers for solid-state devices can set QUEUE_FLAG_NONROT to hint that seek time optimizations may be sub-optimal. NBD and other virtual/pseudo device drivers set this flag. Should virtio-blk set it and how does it affect performance?

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2012-01-02 Thread Christoph Hellwig
On Mon, Jan 02, 2012 at 05:12:00PM +0100, Paolo Bonzini wrote: On 01/01/2012 05:45 PM, Stefan Hajnoczi wrote: By the way, drivers for solid-state devices can set QUEUE_FLAG_NONROT to hint that seek time optimizations may be sub-optimal. NBD and other virtual/pseudo device drivers set this

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2012-01-02 Thread Christoph Hellwig
On Sun, Jan 01, 2012 at 04:45:42PM +, Stefan Hajnoczi wrote: win. The fact that you added batching suggests there is some benefit to what the request-based code path does. So find out what's good about the request-based code path and how to get the best of both worlds. Batching pretty

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2012-01-02 Thread Paolo Bonzini
On 01/02/2012 05:15 PM, Christoph Hellwig wrote: When QEMU uses O_DIRECT, the guest should not use QUEUE_FLAG_NONROT unless it is active for the host disk as well. (In doubt, as is the case for remote hosts accessed over NFS, I would also avoid NONROT and allow more coalescing). Do we

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2012-01-02 Thread Avi Kivity
On 01/02/2012 06:18 PM, Christoph Hellwig wrote: On Sun, Jan 01, 2012 at 04:45:42PM +, Stefan Hajnoczi wrote: win. The fact that you added batching suggests there is some benefit to what the request-based code path does. So find out what's good about the request-based code path and

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2012-01-02 Thread Christoph Hellwig
On Mon, Jan 02, 2012 at 05:18:13PM +0100, Paolo Bonzini wrote: I tried a few times, and the only constant measureable thing was that it regressed performance when used for rotating devices in a few benchmarks. Were you trying with cache=none or writeback? For cache=none, that's exactly

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2012-01-01 Thread Stefan Hajnoczi
On Thu, Dec 22, 2011 at 11:41 PM, Minchan Kim minc...@kernel.org wrote: On Thu, Dec 22, 2011 at 12:57:40PM +, Stefan Hajnoczi wrote: On Wed, Dec 21, 2011 at 1:00 AM, Minchan Kim minc...@kernel.org wrote: If you're stumped by the performance perhaps compare blktraces of the request approach

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2012-01-01 Thread Dor Laor
On 01/01/2012 06:45 PM, Stefan Hajnoczi wrote: On Thu, Dec 22, 2011 at 11:41 PM, Minchan Kimminc...@kernel.org wrote: On Thu, Dec 22, 2011 at 12:57:40PM +, Stefan Hajnoczi wrote: On Wed, Dec 21, 2011 at 1:00 AM, Minchan Kimminc...@kernel.org wrote: If you're stumped by the performance

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-22 Thread Stefan Hajnoczi
On Wed, Dec 21, 2011 at 1:00 AM, Minchan Kim minc...@kernel.org wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote from hch This patchset allows the virtio-blk driver to support much

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-22 Thread Vivek Goyal
On Thu, Dec 22, 2011 at 10:05:38AM +0900, Minchan Kim wrote: [..] May be using deadline or noop in guest is better to benchmark against PCI-E based flash. Good suggestion. I tested it by deadline on guest side. The result is not good. Although gap is within noise, Batch BIO's random

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-22 Thread Minchan Kim
On Thu, Dec 22, 2011 at 10:45:06AM -0500, Vivek Goyal wrote: On Thu, Dec 22, 2011 at 10:05:38AM +0900, Minchan Kim wrote: [..] May be using deadline or noop in guest is better to benchmark against PCI-E based flash. Good suggestion. I tested it by deadline on guest side. The

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-22 Thread Minchan Kim
On Thu, Dec 22, 2011 at 12:57:40PM +, Stefan Hajnoczi wrote: On Wed, Dec 21, 2011 at 1:00 AM, Minchan Kim minc...@kernel.org wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-21 Thread Minchan Kim
Hi Sasha! On Wed, Dec 21, 2011 at 10:28:52AM +0200, Sasha Levin wrote: On Wed, 2011-12-21 at 10:00 +0900, Minchan Kim wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote from

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-21 Thread Vivek Goyal
On Wed, Dec 21, 2011 at 10:00:48AM +0900, Minchan Kim wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote from hch This patchset allows the virtio-blk driver to support much higher

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-21 Thread Minchan Kim
Hi Vivek, On Wed, Dec 21, 2011 at 02:11:17PM -0500, Vivek Goyal wrote: On Wed, Dec 21, 2011 at 10:00:48AM +0900, Minchan Kim wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote

[PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-20 Thread Minchan Kim
This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote from hch This patchset allows the virtio-blk driver to support much higher IOP rates which can be driven out of modern PCI-e flash devices. At

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-20 Thread Rusty Russell
On Wed, 21 Dec 2011 10:00:48 +0900, Minchan Kim minc...@kernel.org wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote from hch This patchset allows the virtio-blk driver to support

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-20 Thread Minchan Kim
Hi Rusty, On Wed, Dec 21, 2011 at 03:38:03PM +1030, Rusty Russell wrote: On Wed, 21 Dec 2011 10:00:48 +0900, Minchan Kim minc...@kernel.org wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk].

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

2011-12-20 Thread Sasha Levin
On Wed, 2011-12-21 at 10:00 +0900, Minchan Kim wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote from hch This patchset allows the virtio-blk driver to support much higher IOP