Re: [PATCH 05/15] KVM: MTRR: clean up mtrr default type

2015-06-08 Thread David Matlack
On Sat, May 30, 2015 at 3:59 AM, Xiao Guangrong guangrong.x...@linux.intel.com wrote: Use union definition to avoid the decode/code workload and drop all the hard code Thank you for doing this cleanup. The new code is much clearer! Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com

Re: [PATCH 05/15] KVM: MTRR: clean up mtrr default type

2015-06-02 Thread Xiao Guangrong
Thanks for your review, Paolo! On 06/01/2015 05:11 PM, Paolo Bonzini wrote: struct kvm_vcpu_arch { diff --git a/arch/x86/kvm/mtrr.c b/arch/x86/kvm/mtrr.c index 562341b..6de49dd 100644 --- a/arch/x86/kvm/mtrr.c +++ b/arch/x86/kvm/mtrr.c @@ -105,7 +105,6 @@ EXPORT_SYMBOL_GPL(kvm_mtrr_valid);

Re: [PATCH 05/15] KVM: MTRR: clean up mtrr default type

2015-06-01 Thread Paolo Bonzini
On 30/05/2015 12:59, Xiao Guangrong wrote: Use union definition to avoid the decode/code workload and drop all the hard code Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- arch/x86/include/asm/kvm_host.h | 12 ++-- arch/x86/kvm/mtrr.c | 19

[PATCH 05/15] KVM: MTRR: clean up mtrr default type

2015-05-30 Thread Xiao Guangrong
Use union definition to avoid the decode/code workload and drop all the hard code Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- arch/x86/include/asm/kvm_host.h | 12 ++-- arch/x86/kvm/mtrr.c | 19 --- 2 files changed, 18 insertions(+), 13