Re: [Qemu-devel] Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-10-01 Thread Mark McLoughlin
On Wed, 2009-09-30 at 21:15 +0200, Gerd Hoffmann wrote: On 09/30/09 15:59, Mark McLoughlin wrote: I'm planning on adding -hostnet and -nic arguments, which would not use vlans by default but rather connect the nic directly to the host side. No new -nic argument please. We should just

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-10-01 Thread Avi Kivity
On 09/30/2009 03:59 PM, Mark McLoughlin wrote: I think we should keep the vlan stuff, just de-emphasise it. Maybe we should do what X.org does, break it silently and remove it some time later when no one complains. -- Do not meddle in the internals of kernels, for they are subtle and

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-10-01 Thread Mark McLoughlin
On Thu, 2009-10-01 at 18:49 +0200, Avi Kivity wrote: On 09/30/2009 03:59 PM, Mark McLoughlin wrote: I think we should keep the vlan stuff, just de-emphasise it. Maybe we should do what X.org does, break it silently and remove it some time later when no one complains. Well, the

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Avi Kivity
On 09/29/2009 10:45 PM, Mark McLoughlin wrote: On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: This commit: commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) Removed some GSO code from upstream qemu.git, but

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Glauber Costa
On Wed, Sep 30, 2009 at 08:24:18AM +0200, Avi Kivity wrote: On 09/29/2009 10:45 PM, Mark McLoughlin wrote: On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: This commit: commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 Subject: Remove stray GSO code from virtio_net (Mark

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 08:24 -0300, Glauber Costa wrote: On Wed, Sep 30, 2009 at 08:24:18AM +0200, Avi Kivity wrote: On 09/29/2009 10:45 PM, Mark McLoughlin wrote: On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: This commit: commit

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Anthony Liguori
Avi Kivity wrote: Anthony/Glauber, is 0.10.7 in the works? If not, we'll release it as 0.10.6.1. Yes. I can release it very soon. -- Regards, Anthony Liguori -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Christoph Hellwig
I might sound like a broken record, but why isn't the full GSO support for virtio-net upstream in qemu? -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Avi Kivity
On 09/30/2009 03:51 PM, Christoph Hellwig wrote: I might sound like a broken record, but why isn't the full GSO support for virtio-net upstream in qemu? IIRC the current hacks are not upstream quality. The problem (again IIRC) is that the guest and host negotiate a protocol, but the qemu

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 15:55 +0200, Avi Kivity wrote: On 09/30/2009 03:51 PM, Christoph Hellwig wrote: I might sound like a broken record, but why isn't the full GSO support for virtio-net upstream in qemu? IIRC the current hacks are not upstream quality. The problem (again IIRC)

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Gerd Hoffmann
On 09/30/09 15:59, Mark McLoughlin wrote: I'm planning on adding -hostnet and -nic arguments, which would not use vlans by default but rather connect the nic directly to the host side. No new -nic argument please. We should just finalize the qdev-ifycation of the nic drivers, then you'll do

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-29 Thread Mark McLoughlin
On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: This commit: commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) Removed some GSO code from upstream qemu.git, but it needs to be re-instated in qemu-kvm.git.

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-29 Thread Mark McLoughlin
On Tue, 2009-09-29 at 21:45 +0100, Mark McLoughlin wrote: On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: This commit: commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) Removed some GSO code from upstream

[PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-05-05 Thread Mark McLoughlin
This commit: commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) Removed some GSO code from upstream qemu.git, but it needs to be re-instated in qemu-kvm.git. Reported-by: Sridhar Samudrala s...@us.ibm.com Signed-off-by: Mark