Re: [PATCH 1/2] KVM: take kvm_lock for hardware_disable() during cpu hotplug

2010-11-18 Thread Takuya Yoshikawa
(2010/11/18 14:45), Zachary Amsden wrote: No, I believe your patch is correct and the lock should be there. Did you test with spinlock debugging just to be sure? Sorry but no. I have no experience with cpu hotplug. So I thought it would take too much time to do real test by myself and

Re: [PATCH 1/2] KVM: take kvm_lock for hardware_disable() during cpu hotplug

2010-11-17 Thread Zachary Amsden
On 11/15/2010 10:35 PM, Takuya Yoshikawa wrote: In kvm_cpu_hotplug(), only CPU_STARTING case is protected by kvm_lock. This patch adds missing protection for CPU_DYING case. Signed-off-by: Takuya Yoshikawayoshikawa.tak...@oss.ntt.co.jp --- virt/kvm/kvm_main.c |2 ++ 1 files changed, 2

Re: [PATCH 1/2] KVM: take kvm_lock for hardware_disable() during cpu hotplug

2010-11-17 Thread Takuya Yoshikawa
(2010/11/18 10:59), Zachary Amsden wrote: On 11/15/2010 10:35 PM, Takuya Yoshikawa wrote: In kvm_cpu_hotplug(), only CPU_STARTING case is protected by kvm_lock. This patch adds missing protection for CPU_DYING case. Signed-off-by: Takuya Yoshikawayoshikawa.tak...@oss.ntt.co.jp ---

Re: [PATCH 1/2] KVM: take kvm_lock for hardware_disable() during cpu hotplug

2010-11-17 Thread Zachary Amsden
On 11/17/2010 04:04 PM, Takuya Yoshikawa wrote: (2010/11/18 10:59), Zachary Amsden wrote: On 11/15/2010 10:35 PM, Takuya Yoshikawa wrote: In kvm_cpu_hotplug(), only CPU_STARTING case is protected by kvm_lock. This patch adds missing protection for CPU_DYING case. Signed-off-by: Takuya

Re: [PATCH 1/2] KVM: take kvm_lock for hardware_disable() during cpu hotplug

2010-11-17 Thread Takuya Yoshikawa
(2010/11/18 11:33), Zachary Amsden wrote: On 11/17/2010 04:04 PM, Takuya Yoshikawa wrote: (2010/11/18 10:59), Zachary Amsden wrote: On 11/15/2010 10:35 PM, Takuya Yoshikawa wrote: In kvm_cpu_hotplug(), only CPU_STARTING case is protected by kvm_lock. This patch adds missing protection for

Re: [PATCH 1/2] KVM: take kvm_lock for hardware_disable() during cpu hotplug

2010-11-17 Thread Zachary Amsden
On 11/17/2010 04:41 PM, Takuya Yoshikawa wrote: (2010/11/18 11:33), Zachary Amsden wrote: On 11/17/2010 04:04 PM, Takuya Yoshikawa wrote: (2010/11/18 10:59), Zachary Amsden wrote: On 11/15/2010 10:35 PM, Takuya Yoshikawa wrote: In kvm_cpu_hotplug(), only CPU_STARTING case is protected by

[PATCH 1/2] KVM: take kvm_lock for hardware_disable() during cpu hotplug

2010-11-16 Thread Takuya Yoshikawa
In kvm_cpu_hotplug(), only CPU_STARTING case is protected by kvm_lock. This patch adds missing protection for CPU_DYING case. Signed-off-by: Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp --- virt/kvm/kvm_main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git