Re: [PATCH 17/21] Remove #define __user in usb-linux.c
Anthony Liguori wrote: This has been consistently nacked in upstream QEMU. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- usb-linux.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 26643bd..70d7a1c 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -34,10 +34,6 @@ #include qemu-timer.h #include monitor.h -#if defined(__linux__) -#define __user -#endif - This will introduce a regression into qemu-kvm.git. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 17/21] Remove #define __user in usb-linux.c
Avi Kivity wrote: Anthony Liguori wrote: This has been consistently nacked in upstream QEMU. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- usb-linux.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 26643bd..70d7a1c 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -34,10 +34,6 @@ #include qemu-timer.h #include monitor.h -#if defined(__linux__) -#define __user -#endif - This will introduce a regression into qemu-kvm.git. It won't because -D__user is in CFLAGS. -- Regards, Anthony Liguori -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 17/21] Remove #define __user in usb-linux.c
Anthony Liguori wrote: Avi Kivity wrote: Anthony Liguori wrote: This has been consistently nacked in upstream QEMU. -#if defined(__linux__) -#define __user -#endif - This will introduce a regression into qemu-kvm.git. It won't because -D__user is in CFLAGS. Ah, ok, will apply. But that's not in upstream either. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 17/21] Remove #define __user in usb-linux.c
Avi Kivity wrote: Ah, ok, will apply. But that's not in upstream either. Nope, but one step at a time. -- Regards, Anthony Liguori -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 17/21] Remove #define __user in usb-linux.c
This has been consistently nacked in upstream QEMU. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- usb-linux.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 26643bd..70d7a1c 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -34,10 +34,6 @@ #include qemu-timer.h #include monitor.h -#if defined(__linux__) -#define __user -#endif - #include dirent.h #include sys/ioctl.h #include signal.h -- 1.6.0.6 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
