Re: [PATCH 19/24] KVM: x86 emulator: fix in/out emulation.

2010-03-10 Thread Avi Kivity
On 03/09/2010 08:09 PM, Gleb Natapov wrote: We don't want to enter the emulator for non-string in/out. Leftover test code? No, unfortunately this is not leftover. I just don't see a way how we can bypass emulator and still have emulator be able to emulate in/out (for big real mode for

Re: [PATCH 19/24] KVM: x86 emulator: fix in/out emulation.

2010-03-10 Thread Gleb Natapov
On Wed, Mar 10, 2010 at 11:12:34AM +0200, Avi Kivity wrote: On 03/09/2010 08:09 PM, Gleb Natapov wrote: We don't want to enter the emulator for non-string in/out. Leftover test code? No, unfortunately this is not leftover. I just don't see a way how we can bypass emulator and still have

[PATCH 19/24] KVM: x86 emulator: fix in/out emulation.

2010-03-09 Thread Gleb Natapov
in/out emulation is broken now. The breakage is different depending on where IO device resides. If it is in userspace emulator reports emulation failure since it incorrectly interprets kvm_emulate_pio() return value. If IO device is in the kernel emulation of 'in' will do nothing since

Re: [PATCH 19/24] KVM: x86 emulator: fix in/out emulation.

2010-03-09 Thread Avi Kivity
On 03/09/2010 04:09 PM, Gleb Natapov wrote: in/out emulation is broken now. The breakage is different depending on where IO device resides. If it is in userspace emulator reports emulation failure since it incorrectly interprets kvm_emulate_pio() return value. If IO device is in the kernel

Re: [PATCH 19/24] KVM: x86 emulator: fix in/out emulation.

2010-03-09 Thread Gleb Natapov
On Tue, Mar 09, 2010 at 04:47:24PM +0200, Avi Kivity wrote: On 03/09/2010 04:09 PM, Gleb Natapov wrote: in/out emulation is broken now. The breakage is different depending on where IO device resides. If it is in userspace emulator reports emulation failure since it incorrectly interprets