Re: [PATCH 2/2] Add serial number support for virtio_blk, V4

2009-06-03 Thread Jens Axboe
On Mon, Jun 01 2009, Rusty Russell wrote: On Fri, 29 May 2009 01:45:27 pm john cooper wrote: virtio_blk-serial-4.patch Hate to ask dumb questions, but is there a scsi equivalent of this? It'd be nice if we could avoid being ATA-specific in the long run... SCSI has mode pages, where ATA

Re: [PATCH 2/2] Add serial number support for virtio_blk, V4

2009-06-03 Thread john cooper
Jens Axboe wrote: On Mon, Jun 01 2009, Rusty Russell wrote: On Fri, 29 May 2009 01:45:27 pm john cooper wrote: virtio_blk-serial-4.patch Hate to ask dumb questions, but is there a scsi equivalent of this? It'd be nice if we could avoid being ATA-specific in the long run... SCSI has mode

Re: [PATCH 2/2] Add serial number support for virtio_blk, V4

2009-06-01 Thread Rusty Russell
On Fri, 29 May 2009 01:45:27 pm john cooper wrote: virtio_blk-serial-4.patch Hate to ask dumb questions, but is there a scsi equivalent of this? It'd be nice if we could avoid being ATA-specific in the long run... Also, why u16? Thanks, Rusty. +/* return ATA identify data + */ +static

Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V4

2009-05-31 Thread Christoph Hellwig
On Fri, May 29, 2009 at 12:15:27AM -0400, john cooper wrote: virtio_blk-serial-4.patch The patch looks good to me, but to get it applied to the kernel tree the patch needs a good description and we also need your Signed-off-by line (See Documentation/SubmittingPatches in the kernel source

[PATCH 2/2] Add serial number support for virtio_blk, V4

2009-05-28 Thread john cooper
virtio_blk-serial-4.patch drivers/block/virtio_blk.c | 41 ++--- include/linux/virtio_blk.h |7 +++ 2 files changed, 45 insertions(+), 3 deletions(-) = --- a/drivers/block/virtio_blk.c