Re: [PATCH 2/3] virtio: mmio: fix signature checking for BE guests

2013-11-06 Thread Rusty Russell
Pawel Moll pawel.m...@arm.com writes: On Tue, 2013-11-05 at 03:36 +, Rusty Russell wrote: This particular can is empty - all worms already escaped :-) I just thought that if you wait for 1.0, it will always be little-endian, and if the current qemu only supported little-endian your life

Re: [PATCH 2/3] virtio: mmio: fix signature checking for BE guests

2013-11-05 Thread Pawel Moll
On Tue, 2013-11-05 at 03:36 +, Rusty Russell wrote: Rusty Russell ru...@rustcorp.com.au writes: Pawel Moll pawel.m...@arm.com writes: On Fri, 2013-10-11 at 15:36 +0100, Marc Zyngier wrote: As virtio-mmio config registers are specified to be little-endian, using readl() to read the

Re: [PATCH 2/3] virtio: mmio: fix signature checking for BE guests

2013-11-04 Thread Rusty Russell
Rusty Russell ru...@rustcorp.com.au writes: Pawel Moll pawel.m...@arm.com writes: On Fri, 2013-10-11 at 15:36 +0100, Marc Zyngier wrote: As virtio-mmio config registers are specified to be little-endian, using readl() to read the magic value and then memcmp() to check it fails on BE (as

Re: [PATCH 2/3] virtio: mmio: fix signature checking for BE guests

2013-10-14 Thread Pawel Moll
On Fri, 2013-10-11 at 15:36 +0100, Marc Zyngier wrote: As virtio-mmio config registers are specified to be little-endian, using readl() to read the magic value and then memcmp() to check it fails on BE (as readl() has an implicit swab). Fix it by encoding the magic value as an integer

Re: [PATCH 2/3] virtio: mmio: fix signature checking for BE guests

2013-10-14 Thread Rusty Russell
Pawel Moll pawel.m...@arm.com writes: On Fri, 2013-10-11 at 15:36 +0100, Marc Zyngier wrote: As virtio-mmio config registers are specified to be little-endian, using readl() to read the magic value and then memcmp() to check it fails on BE (as readl() has an implicit swab). Fix it by

[PATCH 2/3] virtio: mmio: fix signature checking for BE guests

2013-10-11 Thread Marc Zyngier
As virtio-mmio config registers are specified to be little-endian, using readl() to read the magic value and then memcmp() to check it fails on BE (as readl() has an implicit swab). Fix it by encoding the magic value as an integer instead of a string. Cc: Rusty Russell ru...@rustcorp.com.au Cc: