Re: [PATCH 3/3] Provide control over unmapped pages (v2)

2010-12-23 Thread Balbir Singh
* MinChan Kim minchan@gmail.com [2010-12-14 20:02:45]: +                       if (should_reclaim_unmapped_pages(zone)) +                               wakeup_kswapd(zone, order); I think we can put the logic into zone_watermark_okay. I did some checks and zone_watermark_ok is used

Re: [PATCH 3/3] Provide control over unmapped pages (v2)

2010-12-23 Thread Minchan Kim
On Thu, Dec 23, 2010 at 5:33 PM, Balbir Singh bal...@linux.vnet.ibm.com wrote: * MinChan Kim minchan@gmail.com [2010-12-14 20:02:45]: +                       if (should_reclaim_unmapped_pages(zone)) +                               wakeup_kswapd(zone, order); I think we can put the

Re: [PATCH 3/3] Provide control over unmapped pages (v2)

2010-12-14 Thread Minchan Kim
On Fri, Dec 10, 2010 at 11:32 PM, Balbir Singh bal...@linux.vnet.ibm.com wrote: Changelog v2 1. Use a config option to enable the code (Andrew Morton) 2. Explain the magic tunables in the code or at-least attempt   to explain them (General comment) 3. Hint uses of the boot parameter with

[PATCH 3/3] Provide control over unmapped pages (v2)

2010-12-10 Thread Balbir Singh
Changelog v2 1. Use a config option to enable the code (Andrew Morton) 2. Explain the magic tunables in the code or at-least attempt to explain them (General comment) 3. Hint uses of the boot parameter with unlikely (Andrew Morton) 4. Use better names (balanced is not a good naming convention)