Re: [PATCH 4/6] virtio-blk: implement -make_request

2011-12-22 Thread Stefan Hajnoczi
On Wed, Dec 21, 2011 at 1:00 AM, Minchan Kim minc...@kernel.org wrote: +static void virtblk_add_buf_wait(struct virtio_blk *vblk, +       struct virtblk_req *vbr, unsigned long out, unsigned long in) +{ +       DEFINE_WAIT(wait); +       bool retry, notify; + +       for (;;) { +          

Re: [PATCH 4/6] virtio-blk: implement -make_request

2011-12-22 Thread Christoph Hellwig
On Thu, Dec 22, 2011 at 12:20:01PM +, Stefan Hajnoczi wrote: virtblk_make_request() checks that the queue is not plugged. Do we need to do that here too? biot based drivers don't have a queue that could be plugged. -- To unsubscribe from this list: send the line unsubscribe kvm in the body

[PATCH 4/6] virtio-blk: implement -make_request

2011-12-20 Thread Minchan Kim
Change I/O path from request-based to bio-based for virtio-blk. This is required for high IOPs devices which get slowed down to 1/5th of the native speed by all the locking, memory allocation and other overhead in the request based I/O path. But it still supports request-based IO path for scsi