Re: [PATCH 6/6] target-arm/cpu.h: document why env-spsr exists

2015-03-12 Thread Peter Maydell
On 25 February 2015 at 16:02, Alex Bennée alex.ben...@linaro.org wrote: I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? I've already disagreed with this. I would suggest putting tentative

Re: [Qemu-devel] [PATCH 6/6] target-arm/cpu.h: document why env-spsr exists

2015-03-12 Thread Greg Bellows
On Wed, Feb 25, 2015 at 10:02 AM, Alex Bennée alex.ben...@linaro.org wrote: I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git

[PATCH 6/6] target-arm/cpu.h: document why env-spsr exists

2015-02-25 Thread Alex Bennée
I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 11845a6..d7fd13f 100644 ---