[PATCH 7/7] kvm x86: report 1GB page support to userspace

2009-07-27 Thread Joerg Roedel
If userspace knows that the kernel part supports 1GB pages it can enable the corresponding cpuid bit so that guests actually use GB pages. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/include/asm/kvm_host.h |2 ++ arch/x86/kvm/svm.c |6 ++

Re: [PATCH 7/7] kvm x86: report 1GB page support to userspace

2009-04-28 Thread Avi Kivity
Joerg Roedel wrote: If userspace knows that the kernel part supports 1GB pages it can enable the corresponding cpuid bit so that guests actually use GB pages. Why not do everything via KVM_GET_SUPPORTED_CPUID2 and virtualized cpuid? We can enable it in the kernel unconditionally. -- Do

[PATCH 7/7] kvm x86: report 1GB page support to userspace

2009-04-24 Thread Joerg Roedel
If userspace knows that the kernel part supports 1GB pages it can enable the corresponding cpuid bit so that guests actually use GB pages. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/include/asm/kvm_host.h |2 ++ arch/x86/kvm/svm.c |7 +++

Re: [PATCH 7/7] kvm x86: report 1GB page support to userspace

2009-03-29 Thread Avi Kivity
Joerg Roedel wrote: If userspace knows that the kernel part supports 1GB pages it can enable the corresponding cpuid bit so that guests actually use GB pages. diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index a1df2a3..6593198 100644 ---

Re: [PATCH 7/7] kvm x86: report 1GB page support to userspace

2009-03-29 Thread Joerg Roedel
On Sun, Mar 29, 2009 at 02:54:31PM +0300, Avi Kivity wrote: Joerg Roedel wrote: If userspace knows that the kernel part supports 1GB pages it can enable the corresponding cpuid bit so that guests actually use GB pages. diff --git a/arch/x86/include/asm/kvm_host.h

Re: [PATCH 7/7] kvm x86: report 1GB page support to userspace

2009-03-29 Thread Avi Kivity
Joerg Roedel wrote: int (*set_tss_addr)(struct kvm *kvm, unsigned int addr); int (*get_tdp_level)(void); int (*get_mt_mask_shift)(void); + + bool (*gb_page_enable)(void); }; Should enable unconditionally. Of course we need to find the shadow bug first,

Re: [PATCH 7/7] kvm x86: report 1GB page support to userspace

2009-03-29 Thread Joerg Roedel
On Sun, Mar 29, 2009 at 03:49:11PM +0300, Avi Kivity wrote: Joerg Roedel wrote: int (*set_tss_addr)(struct kvm *kvm, unsigned int addr); int (*get_tdp_level)(void); int (*get_mt_mask_shift)(void); + + bool (*gb_page_enable)(void); }; Should enable unconditionally. Of

Re: [PATCH 7/7] kvm x86: report 1GB page support to userspace

2009-03-29 Thread Avi Kivity
Joerg Roedel wrote: Ok I will change that together with the page_size - page_level chhanges. But I doubt that there will ever be 0.5T pages ;) We're bloating at a rate of 1 bit per 1-2 years, so we have 8-16 years to prepare. -- error compiling committee.c: too many arguments to function

[PATCH 7/7] kvm x86: report 1GB page support to userspace

2009-03-27 Thread Joerg Roedel
If userspace knows that the kernel part supports 1GB pages it can enable the corresponding cpuid bit so that guests actually use GB pages. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/include/asm/kvm_host.h |2 ++ arch/x86/kvm/svm.c |7 +++