[PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program

2009-08-12 Thread Avi Kivity
This is faster since we don't need to fork/exec/wait for an external program each time. Signed-off-by: Avi Kivity a...@redhat.com --- client/tests/kvm/kvm_guest_wizard.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/kvm_guest_wizard.py

Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program

2009-08-12 Thread Michael Goldish
- Avi Kivity a...@redhat.com wrote: This is faster since we don't need to fork/exec/wait for an external program each time. Signed-off-by: Avi Kivity a...@redhat.com --- client/tests/kvm/kvm_guest_wizard.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program

2009-08-12 Thread Lucas Meneghel Rodrigues
On Wed, 2009-08-12 at 12:34 +0300, Avi Kivity wrote: This is faster since we don't need to fork/exec/wait for an external program each time. Signed-off-by: Avi Kivity a...@redhat.com --- client/tests/kvm/kvm_guest_wizard.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program

2009-08-12 Thread Avi Kivity
On 08/12/2009 03:44 PM, Lucas Meneghel Rodrigues wrote: @@ -110,9 +111,8 @@ def barrier_2(vm, words, params, debug_dir, data_scrdump_filename, history_scrdump_filename = os.path.join(history_dir, scrdump-step_%s-%s.jpg % (current_step_num,

Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program

2009-08-12 Thread Lucas Meneghel Rodrigues
On Wed, 2009-08-12 at 16:00 +0300, Avi Kivity wrote: On 08/12/2009 03:44 PM, Lucas Meneghel Rodrigues wrote: @@ -110,9 +111,8 @@ def barrier_2(vm, words, params, debug_dir, data_scrdump_filename, history_scrdump_filename = os.path.join(history_dir,

Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program

2009-08-12 Thread Avi Kivity
On 08/12/2009 04:26 PM, Lucas Meneghel Rodrigues wrote: But I prefer to follow the project policy when possible. The reason why I accepted the original code that Michael wrote to perform the conversion was graceful degradation of functionality (if you don't have ImageMagick installed, the test

Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program

2009-08-12 Thread Lucas Meneghel Rodrigues
On Wed, 2009-08-12 at 16:33 +0300, Avi Kivity wrote: On 08/12/2009 04:26 PM, Lucas Meneghel Rodrigues wrote: But I prefer to follow the project policy when possible. The reason why I accepted the original code that Michael wrote to perform the conversion was graceful degradation of

Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program

2009-08-12 Thread Avi Kivity
On 08/12/2009 06:01 PM, Lucas Meneghel Rodrigues wrote: Ok Avi, I've spotted other places where we are also making unneeded calls to rm and mogrify, so I changed them, combined the patches, changed the exception trap only to catch the exceptions we are waiting for, and send the patch to the