Re: [PATCH RFC 2/2] vhost: support urgent descriptors

2014-09-22 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 11:30:23AM +0800, Jason Wang wrote: On 09/20/2014 06:00 PM, Paolo Bonzini wrote: Il 19/09/2014 09:10, Jason Wang ha scritto: -if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) { +if (vq-urgent || !vhost_has_feature(vq,

Re: [PATCH RFC 2/2] vhost: support urgent descriptors

2014-09-22 Thread Jason Wang
On 09/22/2014 02:55 PM, Michael S. Tsirkin wrote: On Mon, Sep 22, 2014 at 11:30:23AM +0800, Jason Wang wrote: On 09/20/2014 06:00 PM, Paolo Bonzini wrote: Il 19/09/2014 09:10, Jason Wang ha scritto: -if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) { +if (vq-urgent ||

Re: [PATCH RFC 2/2] vhost: support urgent descriptors

2014-09-22 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 05:55:23PM +0800, Jason Wang wrote: On 09/22/2014 02:55 PM, Michael S. Tsirkin wrote: On Mon, Sep 22, 2014 at 11:30:23AM +0800, Jason Wang wrote: On 09/20/2014 06:00 PM, Paolo Bonzini wrote: Il 19/09/2014 09:10, Jason Wang ha scritto: - if

Re: [PATCH RFC 2/2] vhost: support urgent descriptors

2014-09-21 Thread Jason Wang
On 09/20/2014 06:00 PM, Paolo Bonzini wrote: Il 19/09/2014 09:10, Jason Wang ha scritto: - if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) { + if (vq-urgent || !vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) { So the urgent descriptor only work when event index was not enabled?

Re: [PATCH RFC 2/2] vhost: support urgent descriptors

2014-09-20 Thread Paolo Bonzini
Il 19/09/2014 09:10, Jason Wang ha scritto: - if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) { + if (vq-urgent || !vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) { So the urgent descriptor only work when event index was not enabled? This seems suboptimal, we may still want to

Re: [PATCH RFC 2/2] vhost: support urgent descriptors

2014-09-19 Thread Jason Wang
On 07/01/2014 06:49 PM, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/vhost.h | 19 +-- drivers/vhost/net.c | 30 +- drivers/vhost/scsi.c | 23 +++ drivers/vhost/test.c | 5

Re: [PATCH RFC 2/2] vhost: support urgent descriptors

2014-09-19 Thread Jason Wang
On 07/01/2014 06:49 PM, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/vhost.h | 19 +-- drivers/vhost/net.c | 30 +- drivers/vhost/scsi.c | 23 +++ drivers/vhost/test.c | 5

[PATCH RFC 2/2] vhost: support urgent descriptors

2014-07-01 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/vhost.h | 19 +-- drivers/vhost/net.c | 30 +- drivers/vhost/scsi.c | 23 +++ drivers/vhost/test.c | 5 +++-- drivers/vhost/vhost.c | 23 ---