Re: [PATCH v2 4/4] Defer skb allocation -- change allocation & receiving in recv path

2009-12-15 Thread Shirley Ma
On Sun, 2009-12-13 at 13:08 +0200, Michael S. Tsirkin wrote: > Do not cast away void*. > This initialization above looks very strange: in > fact only one of skb, page makes sense. > So I think you should either get rid of both page and > skb variables (routines such as give_pages get page * > so th

Re: [PATCH v2 4/4] Defer skb allocation -- change allocation & receiving in recv path

2009-12-13 Thread Michael S. Tsirkin
On Fri, Dec 11, 2009 at 04:49:53AM -0800, Shirley Ma wrote: > Signed-off-by: Shirley Ma > - Comments about splitting up this patch apply here. > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index dde8060..b919169 100644 > --- a/drivers/net/virtio_net.c > +++ b/

[PATCH v2 4/4] Defer skb allocation -- change allocation & receiving in recv path

2009-12-11 Thread Shirley Ma
Signed-off-by: Shirley Ma - diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index dde8060..b919169 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -270,99 +270,44 @@ static struct sk_buff *receive_mergeable(struct virtnet_info *vi, ret