Re: [Qemu-devel] [PATCH v3 13/39] rtl8139: convert to memory API

2011-08-07 Thread Avi Kivity
On 08/05/2011 05:21 PM, Anthony Liguori wrote: +{ 0, 0x100, 4, .write = rtl8139_ioport_writel, }, +PORTIO_END Hrm, I missed this #define when it was introduced. Elsewhere we use: VMSTATE_END_OF_LIST() DEFINE_PROP_END_OF_LIST() For consistency, we ought to use PORTIO_END_OF_LIST()

Re: [Qemu-devel] [PATCH v3 13/39] rtl8139: convert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: Reviewed-by: Richard Hendersonr...@twiddle.net Signed-off-by: Avi Kivitya...@redhat.com --- hw/rtl8139.c | 72 ++--- 1 files changed, 38 insertions(+), 34 deletions(-) diff --git a/hw/rtl8139.c

[PATCH v3 13/39] rtl8139: convert to memory API

2011-08-04 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/rtl8139.c | 72 ++--- 1 files changed, 38 insertions(+), 34 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 5214b8c..dfbab90 100644