Re: [Qemu-devel] [PATCH v4 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-05-12 Thread Ulrich Obergfell
Hi Zachary, 1. re.: +static void hpet_timer_driftfix_reset(HPETTimer *t) +{ +if (t-state-driftfix timer_is_periodic(t)) { +t-ticks_not_accounted = t-prev_period = t-period; This is rather confusing. Clearly, ticks_not_accounted isn't actually ticks not accounted, it's

Re: [Qemu-devel] [PATCH v4 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-05-11 Thread Zachary Amsden
On 05/09/2011 12:03 AM, Ulrich Obergfell wrote: Loss of periodic timer interrupts caused by delayed callbacks and by interrupt coalescing is compensated by gradually injecting additional interrupts during subsequent timer intervals, starting at a rate of one additional interrupt per interval.