Re: [RFC PATCH v2 00/19] virtual-bus

2009-06-05 Thread Gregory Haskins
Hi Rusty, Rusty Russell wrote: On Fri, 5 Jun 2009 04:19:17 am Gregory Haskins wrote: Avi Kivity wrote: Gregory Haskins wrote: One idea is similar to signalfd() or eventfd() And thus the kvm-eventfd (irqfd/iosignalfd) interface project was born. ;) The lguest patch

Re: [RFC PATCH v2 00/19] virtual-bus

2009-06-05 Thread Avi Kivity
Gregory Haskins wrote: @@ -1,6 +1,6 @@ config LGUEST tristate Linux hypervisor example code - depends on X86_32 EXPERIMENTAL !X86_PAE FUTEX + depends on X86_32 EXPERIMENTAL !X86_PAE EVENTFD Note to self: we probably need a similar line in KVM now.

Re: [RFC PATCH v2 00/19] virtual-bus

2009-06-05 Thread Rusty Russell
On Fri, 5 Jun 2009 09:26:48 pm Gregory Haskins wrote: Hi Rusty, Rusty Russell wrote: On Fri, 5 Jun 2009 04:19:17 am Gregory Haskins wrote: Avi Kivity wrote: Gregory Haskins wrote: One idea is similar to signalfd() or eventfd() And thus the kvm-eventfd (irqfd/iosignalfd) interface

Re: [RFC PATCH v2 00/19] virtual-bus

2009-06-05 Thread Gregory Haskins
Rusty Russell wrote: On Fri, 5 Jun 2009 09:26:48 pm Gregory Haskins wrote: Hi Rusty, Rusty Russell wrote: On Fri, 5 Jun 2009 04:19:17 am Gregory Haskins wrote: Avi Kivity wrote: Gregory Haskins wrote: One idea is similar to signalfd() or eventfd()

Re: [RFC PATCH v2 00/19] virtual-bus

2009-06-05 Thread Rusty Russell
On Fri, 5 Jun 2009 03:00:10 pm Paul E. McKenney wrote: On Fri, Jun 05, 2009 at 02:25:01PM +0930, Rusty Russell wrote: + /* lg-eventfds is RCU-protected */ + preempt_disable(); Suggest changing to rcu_read_lock() to match the synchronize_rcu(). Ah yes, much better. As I was

Re: [RFC PATCH v2 00/19] virtual-bus

2009-06-05 Thread Paul E. McKenney
On Sat, Jun 06, 2009 at 12:25:57AM +0930, Rusty Russell wrote: On Fri, 5 Jun 2009 03:00:10 pm Paul E. McKenney wrote: On Fri, Jun 05, 2009 at 02:25:01PM +0930, Rusty Russell wrote: + /* lg-eventfds is RCU-protected */ + preempt_disable(); Suggest changing to rcu_read_lock() to match

Re: [RFC PATCH v2 00/19] virtual-bus

2009-06-04 Thread Gregory Haskins
Avi Kivity wrote: Gregory Haskins wrote: Avi, Gregory Haskins wrote: Todo: *) Develop some kind of hypercall registration mechanism for KVM so that we can use that as an integration point instead of directly hooking kvm hypercalls What would you like to see here? I now

Re: [RFC PATCH v2 00/19] virtual-bus

2009-06-04 Thread Rusty Russell
On Fri, 5 Jun 2009 04:19:17 am Gregory Haskins wrote: Avi Kivity wrote: Gregory Haskins wrote: One idea is similar to signalfd() or eventfd() And thus the kvm-eventfd (irqfd/iosignalfd) interface project was born. ;) The lguest patch queue already has such an interface :) And I have a

Re: [RFC PATCH v2 00/19] virtual-bus

2009-06-04 Thread Paul E. McKenney
On Fri, Jun 05, 2009 at 02:25:01PM +0930, Rusty Russell wrote: On Fri, 5 Jun 2009 04:19:17 am Gregory Haskins wrote: Avi Kivity wrote: Gregory Haskins wrote: One idea is similar to signalfd() or eventfd() And thus the kvm-eventfd (irqfd/iosignalfd) interface project was born. ;)

Re: [RFC PATCH v2 00/19] virtual-bus

2009-04-11 Thread Avi Kivity
Gregory Haskins wrote: Avi, Gregory Haskins wrote: Todo: *) Develop some kind of hypercall registration mechanism for KVM so that we can use that as an integration point instead of directly hooking kvm hypercalls What would you like to see here? I now remember why I removed

[RFC PATCH v2 00/19] virtual-bus

2009-04-09 Thread Gregory Haskins
This is release v2. Changes since v1: *) Incorporated review feedback from Stephen Hemminger on vbus-enet driver *) Added support for connecting to vbus devices from userspace *) Added support for a virtio-vbus transport to allow virtio drivers to work with vbus (needs testing and backend

Re: [RFC PATCH v2 00/19] virtual-bus

2009-04-09 Thread Gregory Haskins
Avi, Gregory Haskins wrote: Todo: *) Develop some kind of hypercall registration mechanism for KVM so that we can use that as an integration point instead of directly hooking kvm hypercalls What would you like to see here? I now remember why I removed the original patch I had for